{"sha":"1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","node_id":"MDY6Q29tbWl0NDY3MDY5Njg6MWZhMmRkNTFmMTc3MWJiNDY0OGFjNjdiMzQ1YjdmMjFhYzMyYzJmZA==","commit":{"author":{"name":"Gaël Poupard","email":"gael.poupard@orange.com","date":"2019-12-12T16:33:09Z"},"committer":{"name":"Gaël Poupard","email":"gael.poupard@orange.com","date":"2019-12-12T16:33:33Z"},"message":"feat(navbar): use close icon when collapsible menu is open","tree":{"sha":"637f2cfffd49c958cb937e8aaf5bfa46ce9e2614","url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/git/trees/637f2cfffd49c958cb937e8aaf5bfa46ce9e2614"},"url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/git/commits/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","comment_count":0,"verification":{"verified":false,"reason":"unsigned","signature":null,"payload":null}},"url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/commits/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","html_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/commit/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","comments_url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/commits/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd/comments","author":{"login":"ffoodd","id":2890570,"node_id":"MDQ6VXNlcjI4OTA1NzA=","avatar_url":"https://avatars.githubusercontent.com/u/2890570?v=4","gravatar_id":"","url":"https://api.github.com/users/ffoodd","html_url":"https://github.com/ffoodd","followers_url":"https://api.github.com/users/ffoodd/followers","following_url":"https://api.github.com/users/ffoodd/following{/other_user}","gists_url":"https://api.github.com/users/ffoodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ffoodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffoodd/subscriptions","organizations_url":"https://api.github.com/users/ffoodd/orgs","repos_url":"https://api.github.com/users/ffoodd/repos","events_url":"https://api.github.com/users/ffoodd/events{/privacy}","received_events_url":"https://api.github.com/users/ffoodd/received_events","type":"User","site_admin":false},"committer":{"login":"ffoodd","id":2890570,"node_id":"MDQ6VXNlcjI4OTA1NzA=","avatar_url":"https://avatars.githubusercontent.com/u/2890570?v=4","gravatar_id":"","url":"https://api.github.com/users/ffoodd","html_url":"https://github.com/ffoodd","followers_url":"https://api.github.com/users/ffoodd/followers","following_url":"https://api.github.com/users/ffoodd/following{/other_user}","gists_url":"https://api.github.com/users/ffoodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ffoodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffoodd/subscriptions","organizations_url":"https://api.github.com/users/ffoodd/orgs","repos_url":"https://api.github.com/users/ffoodd/repos","events_url":"https://api.github.com/users/ffoodd/events{/privacy}","received_events_url":"https://api.github.com/users/ffoodd/received_events","type":"User","site_admin":false},"parents":[{"sha":"e2f70080f467a5804720fe44947c4c7edf02323c","url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/commits/e2f70080f467a5804720fe44947c4c7edf02323c","html_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/commit/e2f70080f467a5804720fe44947c4c7edf02323c"}],"stats":{"total":73,"additions":37,"deletions":36},"files":[{"sha":"fb1400d09a21dbb48621160b163818f44fa8515a","filename":"scss/_navbar.scss","status":"modified","additions":33,"deletions":32,"changes":65,"blob_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/blob/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd/scss%2F_navbar.scss","raw_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/raw/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd/scss%2F_navbar.scss","contents_url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/contents/scss%2F_navbar.scss?ref=1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","patch":"@@ -163,15 +163,6 @@\n }\n }\n \n- &[role=\"menuitem\"]::before {\n- float: right;\n- margin-right: 1rem;\n- // stylelint-disable-next-line font-family-no-missing-generic-family-keyword\n- font: $font-weight-normal $font-size-base icon-orange;\n- color: $white;\n- content: \"\\e93e\";\n- }\n-\n &:focus {\n outline-offset: -#{$border-width};\n }\n@@ -298,32 +289,30 @@\n @include media-breakpoint-up(sm) {\n margin: map-get($spacers, 1) 0 0;\n }\n- // end mod\n \n @include hover-focus() {\n color: $navbar-dark-color; // Boosted mod\n text-decoration: none;\n- background-color: $navbar-light-color; // Boosted mod\n-\n- // Boosted mod\n- .navbar-toggler-icon {\n- background-image: escape-svg($navbar-dark-toggler-icon-hover-bg);\n- }\n- // end mod\n }\n \n- // Boosted mod\n- &:active {\n- background-color: $orange-2;\n-\n- .navbar-toggler-icon {\n- background-image: escape-svg($navbar-dark-toggler-icon-bg);\n- }\n+ &:hover .navbar-toggler-icon,\n+ &:focus .navbar-toggler-icon,\n+ &:active .navbar-toggler-icon {\n+ background-image: escape-svg($navbar-toggler-icon-hover);\n }\n \n &:focus {\n outline: 0;\n }\n+\n+ // Boosted mod: close icon when opened\n+ .navbar &[aria-expanded=\"true\"] {\n+ &:hover .navbar-toggler-icon,\n+ &:focus .navbar-toggler-icon,\n+ &:active .navbar-toggler-icon {\n+ background-image: escape-svg($close-icon-hover);\n+ }\n+ }\n // end mod\n \n // Opinionated: add \"hand\" cursor to non-disabled .navbar-toggler elements\n@@ -518,17 +507,23 @@\n \n .navbar-toggler {\n color: $navbar-light-color;\n- background-color: $navbar-dark-color;\n border-color: $navbar-light-toggler-border-color;\n+ // Boosted mod: remove background\n \n @include hover-focus() {\n- color: $navbar-dark-color;\n- background-color: $navbar-light-color;\n+ color: $navbar-light-hover-color;\n+ // Boosted mod: remove background\n+ }\n+\n+ // Boosted mod: close icon when opened\n+ &[aria-expanded=\"true\"] .navbar-toggler-icon {\n+ background-image: escape-svg($close-icon);\n }\n+ // end mod\n }\n \n .navbar-toggler-icon {\n- background-image: escape-svg($navbar-light-toggler-icon-bg);\n+ background-image: escape-svg($navbar-light-toggler-icon);\n }\n \n .navbar-text {\n@@ -587,16 +582,22 @@\n .navbar-toggler {\n color: $navbar-dark-color;\n background-color: $navbar-light-color;\n- border-color: $navbar-dark-toggler-border-color;\n+ // Boosted mod: remove background\n \n @include hover-focus() {\n- color: $navbar-light-color;\n- background-color: $navbar-dark-color;\n+ color: $navbar-dark-hover-color;\n+ // Boosted mod: remove background\n }\n+\n+ // Boosted mod: close icon when opened\n+ &[aria-expanded=\"true\"] .navbar-toggler-icon {\n+ background-image: escape-svg($close-icon-dark);\n+ }\n+ // end mod\n }\n \n .navbar-toggler-icon {\n- background-image: escape-svg($navbar-dark-toggler-icon-bg);\n+ background-image: escape-svg($navbar-dark-toggler-icon);\n }\n \n .navbar-text {"},{"sha":"2557556fd541e6c74f9ccf85cec6005990adfa1e","filename":"scss/_variables.scss","status":"modified","additions":4,"deletions":4,"changes":8,"blob_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/blob/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd/scss%2F_variables.scss","raw_url":"https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/raw/1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd/scss%2F_variables.scss","contents_url":"https://api.github.com/repos/Orange-OpenSource/Orange-Boosted-Bootstrap/contents/scss%2F_variables.scss?ref=1fa2dd51f1771bb4648ac67b345b7f21ac32c2fd","patch":"@@ -839,22 +839,22 @@ $navbar-dark-color: $white !default;\n $navbar-dark-hover-color: $orange-2 !default; // Boosted mod\n $navbar-dark-active-color: $navbar-dark-hover-color !default;\n $navbar-dark-disabled-color: $gray-400 !default;\n-$navbar-dark-toggler-icon-bg: url(\"data:image/svg+xml,\") !default;\n-$navbar-dark-toggler-icon-hover-bg: url(\"data:image/svg+xml,\") !default;\n-$navbar-dark-toggler-border-color: null !default;\n+$navbar-dark-toggler-icon: url(\"data:image/svg+xml,\") !default; // Boosted mod\n+// $navbar-dark-toggler-border-color: null !default; // Boosted mod\n \n $navbar-light-color: $black !default;\n $navbar-light-hover-color: $orange !default; // Boosted mod\n $navbar-light-active-color: $navbar-light-hover-color !default; // Boosted mod\n $navbar-light-disabled-color: $gray-500 !default; // Boosted mod\n-$navbar-light-toggler-icon-bg: $navbar-dark-toggler-icon-bg !default;\n+$navbar-light-toggler-icon: url(\"data:image/svg+xml,\") !default; // Boosted mod\n $navbar-light-toggler-border-color: null !default;\n \n $navbar-light-brand-color: $navbar-light-color !default;\n $navbar-light-brand-hover-color: $navbar-light-active-color !default;\n $navbar-dark-brand-color: $navbar-dark-color !default;\n $navbar-dark-brand-hover-color: $navbar-dark-active-color !default;\n \n+$navbar-toggler-icon-hover: url(\"data:image/svg+xml,\") !default; // Boosted mod\n \n // Dropdowns\n //"}]}