The standard assertions library methods such as org.junit.Assert.assertEquals
, and org.junit.Assert.assertSame
expect the
first argument to be the expected value and the second argument to be the actual value. Swap them, and your test will still have the same outcome
(succeed/fail when it should) but the error messages will be confusing.
This rule raises an issue when the second argument to an assertions library method is a hard-coded value and the first argument is not.
Supported frameworks:
org.junit.Assert.assertEquals(runner.exitCode(), 0, "Unexpected exit code"); // Noncompliant; Yields error message like: Expected:<-1>. Actual:<0>.
org.junit.Assert.assertEquals(0, runner.exitCode(), "Unexpected exit code");