[{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772","id":3368609487,"node_id":"PR_kwDOABII587IyObP","html_url":"https://github.com/bitcoin/bitcoin/pull/34772","diff_url":"https://github.com/bitcoin/bitcoin/pull/34772.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34772.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34772","number":34772,"state":"open","locked":false,"title":"test: clean up interface_http and improve idle timeout coverage","user":{"login":"pinheadmz","id":2084648,"node_id":"MDQ6VXNlcjIwODQ2NDg=","avatar_url":"https://avatars.githubusercontent.com/u/2084648?v=4","gravatar_id":"","url":"https://api.github.com/users/pinheadmz","html_url":"https://github.com/pinheadmz","followers_url":"https://api.github.com/users/pinheadmz/followers","following_url":"https://api.github.com/users/pinheadmz/following{/other_user}","gists_url":"https://api.github.com/users/pinheadmz/gists{/gist_id}","starred_url":"https://api.github.com/users/pinheadmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinheadmz/subscriptions","organizations_url":"https://api.github.com/users/pinheadmz/orgs","repos_url":"https://api.github.com/users/pinheadmz/repos","events_url":"https://api.github.com/users/pinheadmz/events{/privacy}","received_events_url":"https://api.github.com/users/pinheadmz/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This is a follow-up to https://github.com/bitcoin/bitcoin/pull/32408 and a new prerequisite for #32061 in response to a review comment about the replacement HTTP server behavior.\r\n\r\nIn https://github.com/bitcoin/bitcoin/pull/32061#discussion_r2872150590 it is pointed out that the idle timeout set by `-rpcservertimeout` could disconnect a client unfairly if it was the server that was taking too long to process a response. That misbehavior was confirmed and #32061 was updated to match current libevent behavior.\r\n\r\nThis PR asserts the current libevent behavior by adding another test using RPC `waitforblock` past the `-rpcservertimeout` value and then verifying that the HTTP connection is still open. The test currently passes on #32061 and I'll rebase when ready.\r\n\r\nAlso since I am extending this test module again I refactored the monolithic test to resemble the current functional test style in the repository, deduplicating HTTP connection code with a helper class and separating individual test cases into functions.\r\n\r\nI'm trying to figure out how to get a clean transcript of both old and new tests from Wireshark, and I'll post that for extra confidence.","created_at":"2026-03-07T23:07:24Z","updated_at":"2026-03-08T00:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08423afec95d3f8080726760850babe30c60bae1","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34772/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b2bfeabf4c61ae8edb9ae39661bcf9d39ea911b1","head":{"label":"pinheadmz:rpctimeout-busy-idle","ref":"rpctimeout-busy-idle","sha":"b2bfeabf4c61ae8edb9ae39661bcf9d39ea911b1","user":{"login":"pinheadmz","id":2084648,"node_id":"MDQ6VXNlcjIwODQ2NDg=","avatar_url":"https://avatars.githubusercontent.com/u/2084648?v=4","gravatar_id":"","url":"https://api.github.com/users/pinheadmz","html_url":"https://github.com/pinheadmz","followers_url":"https://api.github.com/users/pinheadmz/followers","following_url":"https://api.github.com/users/pinheadmz/following{/other_user}","gists_url":"https://api.github.com/users/pinheadmz/gists{/gist_id}","starred_url":"https://api.github.com/users/pinheadmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinheadmz/subscriptions","organizations_url":"https://api.github.com/users/pinheadmz/orgs","repos_url":"https://api.github.com/users/pinheadmz/repos","events_url":"https://api.github.com/users/pinheadmz/events{/privacy}","received_events_url":"https://api.github.com/users/pinheadmz/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":61248407,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0ODQwNw==","name":"bitcoin","full_name":"pinheadmz/bitcoin","private":false,"owner":{"login":"pinheadmz","id":2084648,"node_id":"MDQ6VXNlcjIwODQ2NDg=","avatar_url":"https://avatars.githubusercontent.com/u/2084648?v=4","gravatar_id":"","url":"https://api.github.com/users/pinheadmz","html_url":"https://github.com/pinheadmz","followers_url":"https://api.github.com/users/pinheadmz/followers","following_url":"https://api.github.com/users/pinheadmz/following{/other_user}","gists_url":"https://api.github.com/users/pinheadmz/gists{/gist_id}","starred_url":"https://api.github.com/users/pinheadmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinheadmz/subscriptions","organizations_url":"https://api.github.com/users/pinheadmz/orgs","repos_url":"https://api.github.com/users/pinheadmz/repos","events_url":"https://api.github.com/users/pinheadmz/events{/privacy}","received_events_url":"https://api.github.com/users/pinheadmz/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/pinheadmz/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/pinheadmz/bitcoin","forks_url":"https://api.github.com/repos/pinheadmz/bitcoin/forks","keys_url":"https://api.github.com/repos/pinheadmz/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinheadmz/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinheadmz/bitcoin/teams","hooks_url":"https://api.github.com/repos/pinheadmz/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/pinheadmz/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/pinheadmz/bitcoin/events","assignees_url":"https://api.github.com/repos/pinheadmz/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/pinheadmz/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/pinheadmz/bitcoin/tags","blobs_url":"https://api.github.com/repos/pinheadmz/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinheadmz/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinheadmz/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinheadmz/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinheadmz/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/pinheadmz/bitcoin/languages","stargazers_url":"https://api.github.com/repos/pinheadmz/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/pinheadmz/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/pinheadmz/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/pinheadmz/bitcoin/subscription","commits_url":"https://api.github.com/repos/pinheadmz/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinheadmz/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinheadmz/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinheadmz/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinheadmz/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/pinheadmz/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinheadmz/bitcoin/merges","archive_url":"https://api.github.com/repos/pinheadmz/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinheadmz/bitcoin/downloads","issues_url":"https://api.github.com/repos/pinheadmz/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/pinheadmz/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/pinheadmz/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/pinheadmz/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinheadmz/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/pinheadmz/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/pinheadmz/bitcoin/deployments","created_at":"2016-06-15T23:48:20Z","updated_at":"2025-09-26T10:10:12Z","pushed_at":"2026-03-07T23:22:17Z","git_url":"git://github.com/pinheadmz/bitcoin.git","ssh_url":"git@github.com:pinheadmz/bitcoin.git","clone_url":"https://github.com/pinheadmz/bitcoin.git","svn_url":"https://github.com/pinheadmz/bitcoin","homepage":"https://bitcoin.org/en/download","size":298123,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34772"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34772"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34772/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34772/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b2bfeabf4c61ae8edb9ae39661bcf9d39ea911b1"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770","id":3367385091,"node_id":"PR_kwDOABII587ItjgD","html_url":"https://github.com/bitcoin/bitcoin/pull/34770","diff_url":"https://github.com/bitcoin/bitcoin/pull/34770.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34770.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34770","number":34770,"state":"open","locked":false,"title":"test: support mainnet base58 in address_to_scriptpubkey","user":{"login":"TonyKim525","id":145915267,"node_id":"U_kgDOCLJ9gw","avatar_url":"https://avatars.githubusercontent.com/u/145915267?v=4","gravatar_id":"","url":"https://api.github.com/users/TonyKim525","html_url":"https://github.com/TonyKim525","followers_url":"https://api.github.com/users/TonyKim525/followers","following_url":"https://api.github.com/users/TonyKim525/following{/other_user}","gists_url":"https://api.github.com/users/TonyKim525/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyKim525/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyKim525/subscriptions","organizations_url":"https://api.github.com/users/TonyKim525/orgs","repos_url":"https://api.github.com/users/TonyKim525/repos","events_url":"https://api.github.com/users/TonyKim525/events{/privacy}","received_events_url":"https://api.github.com/users/TonyKim525/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"## Summary\r\n- Extend `test/functional/test_framework/address.py::address_to_scriptpubkey` to support mainnet Base58 version bytes:\r\n  - P2PKH: `0`\r\n  - P2SH: `5`\r\n- Replace assert-based Base58 character validation with explicit `ValueError`.\r\n- Add explicit `ValueError` handling for:\r\n  - empty input\r\n  - unsupported Base58 version bytes\r\n  - invalid payload lengths\r\n\r\n## Motivation\r\n`address_to_scriptpubkey` supported Bech32 and testnet Base58, but not mainnet Base58 (`0`, `5`), despite being a shared helper in functional tests.\r\n\r\nThis change closes that gap and makes failure modes explicit and testable.\r\n\r\n## Tests\r\n- `cd test/functional && python3 -m unittest test_framework.address`\r\n- `test/functional/feature_framework_unit_tests.py`\r\n- `python3 -m ruff check --select=B006,B008,E101,E401,E402,E701,E702,E703,E711,E713,E714,E721,E722,E742,E743,F401,F402,F403,F404,F405,F406,F407,F541,F601,F602,F621,F631,F632,F811,F821,F822,F823,F841,PLE,W191,W291,W292,W293,W605 test/functional/test_framework/address.py`","created_at":"2026-03-07T11:58:52Z","updated_at":"2026-03-07T22:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff18458120cb3342c486ba6587fc24dcf1e0e4f","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34770/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/219daccf3b28bf0805a688e807e1bdbc5319e03a","head":{"label":"TonyKim525:test-address-mainnet-base58-scriptpubkey","ref":"test-address-mainnet-base58-scriptpubkey","sha":"219daccf3b28bf0805a688e807e1bdbc5319e03a","user":{"login":"TonyKim525","id":145915267,"node_id":"U_kgDOCLJ9gw","avatar_url":"https://avatars.githubusercontent.com/u/145915267?v=4","gravatar_id":"","url":"https://api.github.com/users/TonyKim525","html_url":"https://github.com/TonyKim525","followers_url":"https://api.github.com/users/TonyKim525/followers","following_url":"https://api.github.com/users/TonyKim525/following{/other_user}","gists_url":"https://api.github.com/users/TonyKim525/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyKim525/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyKim525/subscriptions","organizations_url":"https://api.github.com/users/TonyKim525/orgs","repos_url":"https://api.github.com/users/TonyKim525/repos","events_url":"https://api.github.com/users/TonyKim525/events{/privacy}","received_events_url":"https://api.github.com/users/TonyKim525/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1174108447,"node_id":"R_kgDORft5Hw","name":"bitcoin","full_name":"TonyKim525/bitcoin","private":false,"owner":{"login":"TonyKim525","id":145915267,"node_id":"U_kgDOCLJ9gw","avatar_url":"https://avatars.githubusercontent.com/u/145915267?v=4","gravatar_id":"","url":"https://api.github.com/users/TonyKim525","html_url":"https://github.com/TonyKim525","followers_url":"https://api.github.com/users/TonyKim525/followers","following_url":"https://api.github.com/users/TonyKim525/following{/other_user}","gists_url":"https://api.github.com/users/TonyKim525/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyKim525/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyKim525/subscriptions","organizations_url":"https://api.github.com/users/TonyKim525/orgs","repos_url":"https://api.github.com/users/TonyKim525/repos","events_url":"https://api.github.com/users/TonyKim525/events{/privacy}","received_events_url":"https://api.github.com/users/TonyKim525/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/TonyKim525/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/TonyKim525/bitcoin","forks_url":"https://api.github.com/repos/TonyKim525/bitcoin/forks","keys_url":"https://api.github.com/repos/TonyKim525/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TonyKim525/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TonyKim525/bitcoin/teams","hooks_url":"https://api.github.com/repos/TonyKim525/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/TonyKim525/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/TonyKim525/bitcoin/events","assignees_url":"https://api.github.com/repos/TonyKim525/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/TonyKim525/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/TonyKim525/bitcoin/tags","blobs_url":"https://api.github.com/repos/TonyKim525/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TonyKim525/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TonyKim525/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TonyKim525/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TonyKim525/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/TonyKim525/bitcoin/languages","stargazers_url":"https://api.github.com/repos/TonyKim525/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/TonyKim525/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/TonyKim525/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/TonyKim525/bitcoin/subscription","commits_url":"https://api.github.com/repos/TonyKim525/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TonyKim525/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TonyKim525/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TonyKim525/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TonyKim525/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/TonyKim525/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TonyKim525/bitcoin/merges","archive_url":"https://api.github.com/repos/TonyKim525/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TonyKim525/bitcoin/downloads","issues_url":"https://api.github.com/repos/TonyKim525/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/TonyKim525/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/TonyKim525/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/TonyKim525/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TonyKim525/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/TonyKim525/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/TonyKim525/bitcoin/deployments","created_at":"2026-03-06T04:33:10Z","updated_at":"2026-03-08T00:31:44Z","pushed_at":"2026-03-08T00:31:36Z","git_url":"git://github.com/TonyKim525/bitcoin.git","ssh_url":"git@github.com:TonyKim525/bitcoin.git","clone_url":"https://github.com/TonyKim525/bitcoin.git","svn_url":"https://github.com/TonyKim525/bitcoin","homepage":"https://bitcoincore.org/en/download","size":262621,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34770"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34770"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34770/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34770/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/219daccf3b28bf0805a688e807e1bdbc5319e03a"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769","id":3367084660,"node_id":"PR_kwDOABII587IsaJ0","html_url":"https://github.com/bitcoin/bitcoin/pull/34769","diff_url":"https://github.com/bitcoin/bitcoin/pull/34769.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34769.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34769","number":34769,"state":"open","locked":false,"title":"doc: update http pool thread names","user":{"login":"rkrux","id":5960750,"node_id":"MDQ6VXNlcjU5NjA3NTA=","avatar_url":"https://avatars.githubusercontent.com/u/5960750?v=4","gravatar_id":"","url":"https://api.github.com/users/rkrux","html_url":"https://github.com/rkrux","followers_url":"https://api.github.com/users/rkrux/followers","following_url":"https://api.github.com/users/rkrux/following{/other_user}","gists_url":"https://api.github.com/users/rkrux/gists{/gist_id}","starred_url":"https://api.github.com/users/rkrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkrux/subscriptions","organizations_url":"https://api.github.com/users/rkrux/orgs","repos_url":"https://api.github.com/users/rkrux/repos","events_url":"https://api.github.com/users/rkrux/events{/privacy}","received_events_url":"https://api.github.com/users/rkrux/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"After using `Threadpool` for HTTp server in PR 33689, the previously documented HTTP worker thread names are outdated. This commit makes the corresponding changes to document new names for the HTTP pool threads. Below is the output from the `thead list` command after attaching `lldb` to `bitcoind`.\r\n\r\n```zsh\r\nthread #3: tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'\r\nthread #4: tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'\r\n```\r\n\r\n<!--\r\n*** Please remove the following help text before submitting: ***\r\n\r\nPull requests without a rationale and clear improvement may be closed\r\nimmediately.\r\n\r\nGUI-related pull requests should be opened against\r\nhttps://github.com/bitcoin-core/gui\r\nfirst. See CONTRIBUTING.md\r\n-->\r\n\r\n<!--\r\nPlease provide clear motivation for your patch and explain how it improves\r\nBitcoin Core user experience or Bitcoin Core developer experience\r\nsignificantly:\r\n\r\n* Any test improvements or new tests that improve coverage are always welcome.\r\n* All other changes should have accompanying unit tests (see `src/test/`) or\r\n  functional tests (see `test/`). Contributors should note which tests cover\r\n  modified code. If no tests exist for a region of modified code, new tests\r\n  should accompany the change.\r\n* Bug fixes are most welcome when they come with steps to reproduce or an\r\n  explanation of the potential issue as well as reasoning for the way the bug\r\n  was fixed.\r\n* Features are welcome, but might be rejected due to design or scope issues.\r\n  If a feature is based on a lot of dependencies, contributors should first\r\n  consider building the system outside of Bitcoin Core, if possible.\r\n* Refactoring changes are only accepted if they are required for a feature or\r\n  bug fix or otherwise improve developer experience significantly. For example,\r\n  most \"code style\" refactoring changes require a thorough explanation why they\r\n  are useful, what downsides they have and why they *significantly* improve\r\n  developer experience or avoid serious programming bugs. Note that code style\r\n  is often a subjective matter. Unless they are explicitly mentioned to be\r\n  preferred in the [developer notes](/doc/developer-notes.md), stylistic code\r\n  changes are usually rejected.\r\n-->\r\n\r\n<!--\r\nBitcoin Core has a thorough review process and even the most trivial change\r\nneeds to pass a lot of eyes and requires non-zero or even substantial time\r\neffort to review. There is a huge lack of active reviewers on the project, so\r\npatches often sit for a long time.\r\n-->\r\n","created_at":"2026-03-07T09:02:29Z","updated_at":"2026-03-07T09:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a910693157d753fb0f56d86b53c15e335eadd72e","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":148216,"node_id":"MDU6TGFiZWwxNDgyMTY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs","name":"Docs","color":"02d7e1","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34769/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f5c75037cc3aa84733d6887b641462f4f614851a","head":{"label":"rkrux:http-threads-doc","ref":"http-threads-doc","sha":"f5c75037cc3aa84733d6887b641462f4f614851a","user":{"login":"rkrux","id":5960750,"node_id":"MDQ6VXNlcjU5NjA3NTA=","avatar_url":"https://avatars.githubusercontent.com/u/5960750?v=4","gravatar_id":"","url":"https://api.github.com/users/rkrux","html_url":"https://github.com/rkrux","followers_url":"https://api.github.com/users/rkrux/followers","following_url":"https://api.github.com/users/rkrux/following{/other_user}","gists_url":"https://api.github.com/users/rkrux/gists{/gist_id}","starred_url":"https://api.github.com/users/rkrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkrux/subscriptions","organizations_url":"https://api.github.com/users/rkrux/orgs","repos_url":"https://api.github.com/users/rkrux/repos","events_url":"https://api.github.com/users/rkrux/events{/privacy}","received_events_url":"https://api.github.com/users/rkrux/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":885267588,"node_id":"R_kgDONMQchA","name":"bitcoin","full_name":"rkrux/bitcoin","private":false,"owner":{"login":"rkrux","id":5960750,"node_id":"MDQ6VXNlcjU5NjA3NTA=","avatar_url":"https://avatars.githubusercontent.com/u/5960750?v=4","gravatar_id":"","url":"https://api.github.com/users/rkrux","html_url":"https://github.com/rkrux","followers_url":"https://api.github.com/users/rkrux/followers","following_url":"https://api.github.com/users/rkrux/following{/other_user}","gists_url":"https://api.github.com/users/rkrux/gists{/gist_id}","starred_url":"https://api.github.com/users/rkrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkrux/subscriptions","organizations_url":"https://api.github.com/users/rkrux/orgs","repos_url":"https://api.github.com/users/rkrux/repos","events_url":"https://api.github.com/users/rkrux/events{/privacy}","received_events_url":"https://api.github.com/users/rkrux/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/rkrux/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/rkrux/bitcoin","forks_url":"https://api.github.com/repos/rkrux/bitcoin/forks","keys_url":"https://api.github.com/repos/rkrux/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkrux/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkrux/bitcoin/teams","hooks_url":"https://api.github.com/repos/rkrux/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/rkrux/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/rkrux/bitcoin/events","assignees_url":"https://api.github.com/repos/rkrux/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/rkrux/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/rkrux/bitcoin/tags","blobs_url":"https://api.github.com/repos/rkrux/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkrux/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkrux/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkrux/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkrux/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/rkrux/bitcoin/languages","stargazers_url":"https://api.github.com/repos/rkrux/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/rkrux/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/rkrux/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/rkrux/bitcoin/subscription","commits_url":"https://api.github.com/repos/rkrux/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkrux/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkrux/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkrux/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkrux/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/rkrux/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkrux/bitcoin/merges","archive_url":"https://api.github.com/repos/rkrux/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkrux/bitcoin/downloads","issues_url":"https://api.github.com/repos/rkrux/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/rkrux/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/rkrux/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/rkrux/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkrux/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/rkrux/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/rkrux/bitcoin/deployments","created_at":"2024-11-08T09:18:33Z","updated_at":"2026-03-07T07:57:37Z","pushed_at":"2026-03-07T09:01:45Z","git_url":"git://github.com/rkrux/bitcoin.git","ssh_url":"git@github.com:rkrux/bitcoin.git","clone_url":"https://github.com/rkrux/bitcoin.git","svn_url":"https://github.com/rkrux/bitcoin","homepage":"https://bitcoincore.org/en/download","size":262675,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34769"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34769"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34769/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34769/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f5c75037cc3aa84733d6887b641462f4f614851a"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767","id":3365975053,"node_id":"PR_kwDOABII587IoLQN","html_url":"https://github.com/bitcoin/bitcoin/pull/34767","diff_url":"https://github.com/bitcoin/bitcoin/pull/34767.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34767.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34767","number":34767,"state":"open","locked":false,"title":"Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig","user":{"login":"luke-jr","id":1095675,"node_id":"MDQ6VXNlcjEwOTU2NzU=","avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=4","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Without this, invalid vbparams just silently exit with no message\r\n","created_at":"2026-03-06T23:43:20Z","updated_at":"2026-03-07T23:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df1eee7b4608ab8a9922a4d0d6ed6a0cb93e39c5","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34767/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/55d37546faa6b928d361e8b7ce9a90b49057d09a","head":{"label":"luke-jr:fix_qt_intro_chain_except","ref":"fix_qt_intro_chain_except","sha":"55d37546faa6b928d361e8b7ce9a90b49057d09a","user":{"login":"luke-jr","id":1095675,"node_id":"MDQ6VXNlcjEwOTU2NzU=","avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=4","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":2514537,"node_id":"MDEwOlJlcG9zaXRvcnkyNTE0NTM3","name":"bitcoin","full_name":"luke-jr/bitcoin","private":false,"owner":{"login":"luke-jr","id":1095675,"node_id":"MDQ6VXNlcjEwOTU2NzU=","avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=4","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/luke-jr/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/luke-jr/bitcoin","forks_url":"https://api.github.com/repos/luke-jr/bitcoin/forks","keys_url":"https://api.github.com/repos/luke-jr/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luke-jr/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luke-jr/bitcoin/teams","hooks_url":"https://api.github.com/repos/luke-jr/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/luke-jr/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/luke-jr/bitcoin/events","assignees_url":"https://api.github.com/repos/luke-jr/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/luke-jr/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/luke-jr/bitcoin/tags","blobs_url":"https://api.github.com/repos/luke-jr/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luke-jr/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luke-jr/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/luke-jr/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luke-jr/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/luke-jr/bitcoin/languages","stargazers_url":"https://api.github.com/repos/luke-jr/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/luke-jr/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/luke-jr/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/luke-jr/bitcoin/subscription","commits_url":"https://api.github.com/repos/luke-jr/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/luke-jr/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/luke-jr/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/luke-jr/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/luke-jr/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/luke-jr/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luke-jr/bitcoin/merges","archive_url":"https://api.github.com/repos/luke-jr/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luke-jr/bitcoin/downloads","issues_url":"https://api.github.com/repos/luke-jr/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/luke-jr/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/luke-jr/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/luke-jr/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luke-jr/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/luke-jr/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/luke-jr/bitcoin/deployments","created_at":"2011-10-04T20:22:23Z","updated_at":"2025-10-24T03:38:01Z","pushed_at":"2026-03-06T23:42:27Z","git_url":"git://github.com/luke-jr/bitcoin.git","ssh_url":"git@github.com:luke-jr/bitcoin.git","clone_url":"https://github.com/luke-jr/bitcoin.git","svn_url":"https://github.com/luke-jr/bitcoin","homepage":"","size":333614,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":10,"open_issues":3,"watchers":29,"default_branch":"readme"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34767"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34767"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34767/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34767/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/55d37546faa6b928d361e8b7ce9a90b49057d09a"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766","id":3365622754,"node_id":"PR_kwDOABII587Im1Pi","html_url":"https://github.com/bitcoin/bitcoin/pull/34766","diff_url":"https://github.com/bitcoin/bitcoin/pull/34766.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34766.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34766","number":34766,"state":"open","locked":false,"title":"Pre-31.x branching updates","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Completes the final steps immediately prior to branching:\r\n\r\n* Bump version to 31.99\r\n* Update bips.md\r\n* Remove release note fragments","created_at":"2026-03-06T21:29:10Z","updated_at":"2026-03-06T21:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4eda895ddb46bb72e9a44c31d6c76a432bd0c8b","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74","html_url":"https://github.com/bitcoin/bitcoin/milestone/74","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74/labels","id":12610874,"node_id":"MI_kwDOABII584AwG06","number":74,"title":"31.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":11,"closed_issues":102,"state":"open","created_at":"2025-03-25T18:44:16Z","updated_at":"2026-03-06T21:29:25Z","due_on":null,"closed_at":null},"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34766/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/48b952cbb67e4a59e1f036375240bbb23ae21648","head":{"label":"achow101:bump-version-31","ref":"bump-version-31","sha":"48b952cbb67e4a59e1f036375240bbb23ae21648","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":45006379,"node_id":"MDEwOlJlcG9zaXRvcnk0NTAwNjM3OQ==","name":"bitcoin","full_name":"achow101/bitcoin","private":false,"owner":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/achow101/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/achow101/bitcoin","forks_url":"https://api.github.com/repos/achow101/bitcoin/forks","keys_url":"https://api.github.com/repos/achow101/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achow101/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achow101/bitcoin/teams","hooks_url":"https://api.github.com/repos/achow101/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/achow101/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/achow101/bitcoin/events","assignees_url":"https://api.github.com/repos/achow101/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/achow101/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/achow101/bitcoin/tags","blobs_url":"https://api.github.com/repos/achow101/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achow101/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achow101/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/achow101/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achow101/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/achow101/bitcoin/languages","stargazers_url":"https://api.github.com/repos/achow101/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/achow101/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/achow101/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/achow101/bitcoin/subscription","commits_url":"https://api.github.com/repos/achow101/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/achow101/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/achow101/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/achow101/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/achow101/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/achow101/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achow101/bitcoin/merges","archive_url":"https://api.github.com/repos/achow101/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achow101/bitcoin/downloads","issues_url":"https://api.github.com/repos/achow101/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/achow101/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/achow101/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/achow101/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achow101/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/achow101/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/achow101/bitcoin/deployments","created_at":"2015-10-27T00:20:28Z","updated_at":"2026-02-22T01:30:10Z","pushed_at":"2026-03-06T21:25:19Z","git_url":"git://github.com/achow101/bitcoin.git","ssh_url":"git@github.com:achow101/bitcoin.git","clone_url":"https://github.com/achow101/bitcoin.git","svn_url":"https://github.com/achow101/bitcoin","homepage":"https://bitcoin.org/en/download","size":322001,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":11,"open_issues":0,"watchers":41,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34766"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34766"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34766/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34766/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/48b952cbb67e4a59e1f036375240bbb23ae21648"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765","id":3365517112,"node_id":"PR_kwDOABII587Imbc4","html_url":"https://github.com/bitcoin/bitcoin/pull/34765","diff_url":"https://github.com/bitcoin/bitcoin/pull/34765.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34765.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34765","number":34765,"state":"open","locked":false,"title":"rpc: detect invalid signatures in analyzepsbt","user":{"login":"overcookedpanda","id":35861207,"node_id":"MDQ6VXNlcjM1ODYxMjA3","avatar_url":"https://avatars.githubusercontent.com/u/35861207?v=4","gravatar_id":"","url":"https://api.github.com/users/overcookedpanda","html_url":"https://github.com/overcookedpanda","followers_url":"https://api.github.com/users/overcookedpanda/followers","following_url":"https://api.github.com/users/overcookedpanda/following{/other_user}","gists_url":"https://api.github.com/users/overcookedpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/overcookedpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcookedpanda/subscriptions","organizations_url":"https://api.github.com/users/overcookedpanda/orgs","repos_url":"https://api.github.com/users/overcookedpanda/repos","events_url":"https://api.github.com/users/overcookedpanda/events{/privacy}","received_events_url":"https://api.github.com/users/overcookedpanda/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"  ## Summary\r\n\r\n  - Detect invalid signatures in `analyzepsbt` by checking for the case where `SignPSBTInput` returns incomplete, no `missing_*` fields are populated, yet signature data exists — meaning the signature is present but cryptographically invalid\r\n  - Report a clear error (`\"PSBT is not valid. Input N has an invalid signature\"`) instead of the confusing `\"next\": \"updater\"` fallback\r\n  - Add functional test covering the exact scenario from #33320 (corrupted taproot key path signature)\r\n\r\n  ## Problem\r\n\r\n  When a PSBT input has an invalid `taproot_key_path_sig` (e.g. a script path sig mistakenly placed in the key path field by external software like HWI), `analyzepsbt` returns `\"next\": \"updater\"` with no error message.\r\n\r\n  This happens because `SignTaproot` in `ProduceSignature` finds the existing signature data and returns `solved = true`, but `VerifyScript` (with the real `MutableTransactionSignatureChecker`) fails the cryptographic check, setting `sigdata.complete = false`. Back in `AnalyzePSBT`, the `missing_*` fields  \r\n  are all empty — taproot signing never populates them — so the code falls through to the `UPDATER` fallback.\r\n\r\n  ## Approach\r\n\r\n  Rather than adding a separate signature verification step, this relies on the verification that already happens inside `ProduceSignature` → `VerifyScript`. When `AnalyzePSBT` calls `SignPSBTInput` with real `PrecomputedTransactionData`, the signature is verified against the actual transaction via\r\n  libsecp256k1. If that fails but nothing is missing, the signature must be invalid.\r\n\r\n  The check also covers `m_tap_script_sigs` and `partial_sigs` for completeness, though the primary motivation is the taproot key path case from #33320.\r\n\r\n  Note: a previous attempt at this fix (#33360) was closed because it used `DUMMY_SIGNATURE_CREATOR`/`DUMMY_CHECKER` which accept any non-empty signature, and its hand-crafted test PSBT was malformed.\r\n\r\n  ## Test plan\r\n\r\n  - [ ] `python3 test/functional/rpc_psbt.py` — includes new test for corrupted taproot key path sig\r\n  - [ ] `build/bin/test_bitcoin -t psbt_wallet_tests` — no regressions in C++ unit tests\r\n\r\n  Fixes #33320\r\n","created_at":"2026-03-06T20:54:46Z","updated_at":"2026-03-07T22:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66ad5ac681d1445455cc44f567f1a253ed0910d7","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34765/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/27af927367a6538a3b570d0ae7911ffe836f828b","head":{"label":"overcookedpanda:fix-analyzepsbt-invalid-sig","ref":"fix-analyzepsbt-invalid-sig","sha":"27af927367a6538a3b570d0ae7911ffe836f828b","user":{"login":"overcookedpanda","id":35861207,"node_id":"MDQ6VXNlcjM1ODYxMjA3","avatar_url":"https://avatars.githubusercontent.com/u/35861207?v=4","gravatar_id":"","url":"https://api.github.com/users/overcookedpanda","html_url":"https://github.com/overcookedpanda","followers_url":"https://api.github.com/users/overcookedpanda/followers","following_url":"https://api.github.com/users/overcookedpanda/following{/other_user}","gists_url":"https://api.github.com/users/overcookedpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/overcookedpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcookedpanda/subscriptions","organizations_url":"https://api.github.com/users/overcookedpanda/orgs","repos_url":"https://api.github.com/users/overcookedpanda/repos","events_url":"https://api.github.com/users/overcookedpanda/events{/privacy}","received_events_url":"https://api.github.com/users/overcookedpanda/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1174759127,"node_id":"R_kgDORgVm1w","name":"bitcoin","full_name":"overcookedpanda/bitcoin","private":false,"owner":{"login":"overcookedpanda","id":35861207,"node_id":"MDQ6VXNlcjM1ODYxMjA3","avatar_url":"https://avatars.githubusercontent.com/u/35861207?v=4","gravatar_id":"","url":"https://api.github.com/users/overcookedpanda","html_url":"https://github.com/overcookedpanda","followers_url":"https://api.github.com/users/overcookedpanda/followers","following_url":"https://api.github.com/users/overcookedpanda/following{/other_user}","gists_url":"https://api.github.com/users/overcookedpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/overcookedpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcookedpanda/subscriptions","organizations_url":"https://api.github.com/users/overcookedpanda/orgs","repos_url":"https://api.github.com/users/overcookedpanda/repos","events_url":"https://api.github.com/users/overcookedpanda/events{/privacy}","received_events_url":"https://api.github.com/users/overcookedpanda/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/overcookedpanda/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/overcookedpanda/bitcoin","forks_url":"https://api.github.com/repos/overcookedpanda/bitcoin/forks","keys_url":"https://api.github.com/repos/overcookedpanda/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overcookedpanda/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overcookedpanda/bitcoin/teams","hooks_url":"https://api.github.com/repos/overcookedpanda/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/overcookedpanda/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/overcookedpanda/bitcoin/events","assignees_url":"https://api.github.com/repos/overcookedpanda/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/overcookedpanda/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/overcookedpanda/bitcoin/tags","blobs_url":"https://api.github.com/repos/overcookedpanda/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overcookedpanda/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overcookedpanda/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/overcookedpanda/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overcookedpanda/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/overcookedpanda/bitcoin/languages","stargazers_url":"https://api.github.com/repos/overcookedpanda/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/overcookedpanda/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/overcookedpanda/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/overcookedpanda/bitcoin/subscription","commits_url":"https://api.github.com/repos/overcookedpanda/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/overcookedpanda/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/overcookedpanda/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/overcookedpanda/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/overcookedpanda/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/overcookedpanda/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overcookedpanda/bitcoin/merges","archive_url":"https://api.github.com/repos/overcookedpanda/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overcookedpanda/bitcoin/downloads","issues_url":"https://api.github.com/repos/overcookedpanda/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/overcookedpanda/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/overcookedpanda/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/overcookedpanda/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overcookedpanda/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/overcookedpanda/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/overcookedpanda/bitcoin/deployments","created_at":"2026-03-06T20:09:12Z","updated_at":"2026-03-06T20:09:12Z","pushed_at":"2026-03-06T20:52:58Z","git_url":"git://github.com/overcookedpanda/bitcoin.git","ssh_url":"git@github.com:overcookedpanda/bitcoin.git","clone_url":"https://github.com/overcookedpanda/bitcoin.git","svn_url":"https://github.com/overcookedpanda/bitcoin","homepage":"https://bitcoincore.org/en/download","size":262625,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34765"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34765"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34765/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34765/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/27af927367a6538a3b570d0ae7911ffe836f828b"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764","id":3365398031,"node_id":"PR_kwDOABII587Il-YP","html_url":"https://github.com/bitcoin/bitcoin/pull/34764","diff_url":"https://github.com/bitcoin/bitcoin/pull/34764.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34764.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34764","number":34764,"state":"open","locked":false,"title":"rpc: replace ELISION references with explicit result fields","user":{"login":"satsfy","id":45462822,"node_id":"MDQ6VXNlcjQ1NDYyODIy","avatar_url":"https://avatars.githubusercontent.com/u/45462822?v=4","gravatar_id":"","url":"https://api.github.com/users/satsfy","html_url":"https://github.com/satsfy","followers_url":"https://api.github.com/users/satsfy/followers","following_url":"https://api.github.com/users/satsfy/following{/other_user}","gists_url":"https://api.github.com/users/satsfy/gists{/gist_id}","starred_url":"https://api.github.com/users/satsfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satsfy/subscriptions","organizations_url":"https://api.github.com/users/satsfy/orgs","repos_url":"https://api.github.com/users/satsfy/repos","events_url":"https://api.github.com/users/satsfy/events{/privacy}","received_events_url":"https://api.github.com/users/satsfy/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Partially addresses #29912. Motivated by #34683, which exports OpenRPC from existing `RPCHelpMan` metadata. [Sample OpenRPC](https://gist.github.com/natobritto/8c4a1da04968d2325082ac4bca7d2408).\r\n\r\nSome RPC help definitions currently rely on `RPCResult::Type::ELISION` entries whose structure is only described in prose. This is concise for human-readable help, but it prevents tools from deriving complete machine-readable result schemas from the metadata.\r\n\r\nThis PR replaces all non-recursive ELISION-based reuses with shared structured definitions, so the result layout is represented directly in `RPCHelpMan` metadata instead of only in text.\r\n\r\nAffected RPCs:\r\n- `decodepsbt`\r\n- `getrawtransaction`\r\n- `getblock`\r\n- `listsinceblock`\r\n\r\nThe patch also replaces `DecodeTxDoc()` with `TxDoc()` plus a `TxDocOptions` struct, so decoded transaction layouts can be reused without positional booleans and selectively extended with `prevout`, `fee`, and `hex` fields.\r\n\r\nAs a consequence, `bitcoin-cli` output for affected RPCs becomes more verbose, since prose summaries like \"Same output as verbosity = 1\" are replaced by the full field definitions. The actual RPC return values are unchanged. I opened this as a draft because I'd like to discuss whether this tradeoff is acceptable, or whether the help renderer should collapse some sub-structures via manual configuration back into short summaries while keeping the underlying metadata explicit.\r\n\r\nThis PR doesn't cover `getaddressinfo.embedded`, which is recursive — runtime output can contain nested embedded objects, and `RPCResult` has no way to express that today. Happy to discuss approaches here if anyone has thoughts.\r\n\r\nThis PR also implements the fee field fix in getblock RPC result (PR https://github.com/bitcoin/bitcoin/pull/34702 also implements), which should be optional but is not marked as such.\r\n\r\nChanges:\r\n- replace `DecodeTxDoc()` with `TxDoc()` and `TxDocOptions`\r\n- replace ELISION-based reuse in `decodepsbt`, `getrawtransaction`, `getblock`, and `listsinceblock`\r\n- factor shared result layouts into `TxDoc()`, `GetBlockFields()`, and `ListSinceBlockTxFields()`\r\n- mark `getblock` transaction `fee` documentation optional where it is conditionally present","created_at":"2026-03-06T20:18:42Z","updated_at":"2026-03-07T23:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0dd49959d3e5d308e718904fea4e712c9a676a1","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false,"description":null}],"milestone":null,"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34764/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b2e56e395715bf3a451452c385f32ef2e3ee319b","head":{"label":"satsfy:fix-rpc-inheritance","ref":"fix-rpc-inheritance","sha":"b2e56e395715bf3a451452c385f32ef2e3ee319b","user":{"login":"satsfy","id":45462822,"node_id":"MDQ6VXNlcjQ1NDYyODIy","avatar_url":"https://avatars.githubusercontent.com/u/45462822?v=4","gravatar_id":"","url":"https://api.github.com/users/satsfy","html_url":"https://github.com/satsfy","followers_url":"https://api.github.com/users/satsfy/followers","following_url":"https://api.github.com/users/satsfy/following{/other_user}","gists_url":"https://api.github.com/users/satsfy/gists{/gist_id}","starred_url":"https://api.github.com/users/satsfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satsfy/subscriptions","organizations_url":"https://api.github.com/users/satsfy/orgs","repos_url":"https://api.github.com/users/satsfy/repos","events_url":"https://api.github.com/users/satsfy/events{/privacy}","received_events_url":"https://api.github.com/users/satsfy/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1140817237,"node_id":"R_kgDOQ_99VQ","name":"bitcoin","full_name":"satsfy/bitcoin","private":false,"owner":{"login":"satsfy","id":45462822,"node_id":"MDQ6VXNlcjQ1NDYyODIy","avatar_url":"https://avatars.githubusercontent.com/u/45462822?v=4","gravatar_id":"","url":"https://api.github.com/users/satsfy","html_url":"https://github.com/satsfy","followers_url":"https://api.github.com/users/satsfy/followers","following_url":"https://api.github.com/users/satsfy/following{/other_user}","gists_url":"https://api.github.com/users/satsfy/gists{/gist_id}","starred_url":"https://api.github.com/users/satsfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satsfy/subscriptions","organizations_url":"https://api.github.com/users/satsfy/orgs","repos_url":"https://api.github.com/users/satsfy/repos","events_url":"https://api.github.com/users/satsfy/events{/privacy}","received_events_url":"https://api.github.com/users/satsfy/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/satsfy/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/satsfy/bitcoin","forks_url":"https://api.github.com/repos/satsfy/bitcoin/forks","keys_url":"https://api.github.com/repos/satsfy/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satsfy/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satsfy/bitcoin/teams","hooks_url":"https://api.github.com/repos/satsfy/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/satsfy/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/satsfy/bitcoin/events","assignees_url":"https://api.github.com/repos/satsfy/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/satsfy/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/satsfy/bitcoin/tags","blobs_url":"https://api.github.com/repos/satsfy/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satsfy/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satsfy/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/satsfy/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satsfy/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/satsfy/bitcoin/languages","stargazers_url":"https://api.github.com/repos/satsfy/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/satsfy/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/satsfy/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/satsfy/bitcoin/subscription","commits_url":"https://api.github.com/repos/satsfy/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/satsfy/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/satsfy/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/satsfy/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/satsfy/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/satsfy/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satsfy/bitcoin/merges","archive_url":"https://api.github.com/repos/satsfy/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satsfy/bitcoin/downloads","issues_url":"https://api.github.com/repos/satsfy/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/satsfy/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/satsfy/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/satsfy/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satsfy/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/satsfy/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/satsfy/bitcoin/deployments","created_at":"2026-01-23T19:53:01Z","updated_at":"2026-02-21T21:41:18Z","pushed_at":"2026-03-07T02:30:11Z","git_url":"git://github.com/satsfy/bitcoin.git","ssh_url":"git@github.com:satsfy/bitcoin.git","clone_url":"https://github.com/satsfy/bitcoin.git","svn_url":"https://github.com/satsfy/bitcoin","homepage":"https://bitcoincore.org/en/download","size":273063,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":3,"watchers":0,"default_branch":"30.x"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34764"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34764"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34764/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34764/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b2e56e395715bf3a451452c385f32ef2e3ee319b"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761","id":3364924056,"node_id":"PR_kwDOABII587IkKqY","html_url":"https://github.com/bitcoin/bitcoin/pull/34761","diff_url":"https://github.com/bitcoin/bitcoin/pull/34761.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34761.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34761","number":34761,"state":"open","locked":false,"title":"scripted-diff: replace bare assert == with assert_equal in functional tests","user":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Replace 83 bare `assert x == y` statements with `assert_equal(x, y)` across 30 functional test files for better failure diagnostics.\n\nOnly mechanical equality comparisons are converted. Lines with `and`, `or`, `for`, inline comments, or assertion messages are excluded to keep the scripted-diff safe and verifiable.\n\nConsolidates the approach from #34752 and #34753 per feedback from @l0rinc.","created_at":"2026-03-06T18:01:47Z","updated_at":"2026-03-07T22:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f855939361791c15c54dd4622306a55808ba4b24","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"node_id":"MDU6TGFiZWwxMzU5NjE=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false,"description":null},{"id":5334691551,"node_id":"LA_kwDOABII588AAAABPfju3w","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/CI%20failed","name":"CI failed","color":"cccccc","default":false,"description":""}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34761/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/9631d4056f303c6b412c123d010e84f2c3e8499b","head":{"label":"Bortlesboat:scripted-diff-bare-asserts","ref":"scripted-diff-bare-asserts","sha":"9631d4056f303c6b412c123d010e84f2c3e8499b","user":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1174157184,"node_id":"R_kgDORfw3gA","name":"bitcoin","full_name":"Bortlesboat/bitcoin","private":false,"owner":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/Bortlesboat/bitcoin","description":"Bitcoin Knots enhanced Bitcoin node/wallet software","fork":true,"url":"https://api.github.com/repos/Bortlesboat/bitcoin","forks_url":"https://api.github.com/repos/Bortlesboat/bitcoin/forks","keys_url":"https://api.github.com/repos/Bortlesboat/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bortlesboat/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bortlesboat/bitcoin/teams","hooks_url":"https://api.github.com/repos/Bortlesboat/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Bortlesboat/bitcoin/events","assignees_url":"https://api.github.com/repos/Bortlesboat/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Bortlesboat/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Bortlesboat/bitcoin/tags","blobs_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bortlesboat/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Bortlesboat/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Bortlesboat/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Bortlesboat/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Bortlesboat/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Bortlesboat/bitcoin/subscription","commits_url":"https://api.github.com/repos/Bortlesboat/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bortlesboat/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bortlesboat/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Bortlesboat/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bortlesboat/bitcoin/merges","archive_url":"https://api.github.com/repos/Bortlesboat/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bortlesboat/bitcoin/downloads","issues_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Bortlesboat/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Bortlesboat/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Bortlesboat/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bortlesboat/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Bortlesboat/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/Bortlesboat/bitcoin/deployments","created_at":"2026-03-06T06:03:18Z","updated_at":"2026-03-06T06:03:18Z","pushed_at":"2026-03-07T22:11:15Z","git_url":"git://github.com/Bortlesboat/bitcoin.git","ssh_url":"git@github.com:Bortlesboat/bitcoin.git","clone_url":"https://github.com/Bortlesboat/bitcoin.git","svn_url":"https://github.com/Bortlesboat/bitcoin","homepage":"","size":334784,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"29.x-knots"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34761"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34761"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34761/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34761/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/9631d4056f303c6b412c123d010e84f2c3e8499b"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760","id":3364914782,"node_id":"PR_kwDOABII587IkIZe","html_url":"https://github.com/bitcoin/bitcoin/pull/34760","diff_url":"https://github.com/bitcoin/bitcoin/pull/34760.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34760.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34760","number":34760,"state":"open","locked":false,"title":"doc: add standardness rules reference to doc/policy","user":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The `doc/policy/` directory documents mempool policy but had no reference\nfor transaction standardness rules. This adds `standardness.md` covering\nthe checks in `IsStandardTx()`, `AreInputsStandard()`, `IsWitnessStandard()`,\nand mempool acceptance, along with a table of configurable relay options.\n\nAlso improves the `-datacarriersize` help text in `init.cpp` to mention\nthe pre-v30.0 default of 83, making it easier for operators to restore\nthe previous OP_RETURN relay behavior.","created_at":"2026-03-06T17:58:54Z","updated_at":"2026-03-08T00:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ab5a0541038eca27df13454240f9d04ac8a258c","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":148216,"node_id":"MDU6TGFiZWwxNDgyMTY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs","name":"Docs","color":"02d7e1","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34760/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/28eb78cfdb67839cb0c12a0b7461f7d7dcac0330","head":{"label":"Bortlesboat:doc-policy-standardness","ref":"doc-policy-standardness","sha":"28eb78cfdb67839cb0c12a0b7461f7d7dcac0330","user":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1174157184,"node_id":"R_kgDORfw3gA","name":"bitcoin","full_name":"Bortlesboat/bitcoin","private":false,"owner":{"login":"Bortlesboat","id":169967362,"node_id":"U_kgDOCiF_Ag","avatar_url":"https://avatars.githubusercontent.com/u/169967362?v=4","gravatar_id":"","url":"https://api.github.com/users/Bortlesboat","html_url":"https://github.com/Bortlesboat","followers_url":"https://api.github.com/users/Bortlesboat/followers","following_url":"https://api.github.com/users/Bortlesboat/following{/other_user}","gists_url":"https://api.github.com/users/Bortlesboat/gists{/gist_id}","starred_url":"https://api.github.com/users/Bortlesboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bortlesboat/subscriptions","organizations_url":"https://api.github.com/users/Bortlesboat/orgs","repos_url":"https://api.github.com/users/Bortlesboat/repos","events_url":"https://api.github.com/users/Bortlesboat/events{/privacy}","received_events_url":"https://api.github.com/users/Bortlesboat/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/Bortlesboat/bitcoin","description":"Bitcoin Knots enhanced Bitcoin node/wallet software","fork":true,"url":"https://api.github.com/repos/Bortlesboat/bitcoin","forks_url":"https://api.github.com/repos/Bortlesboat/bitcoin/forks","keys_url":"https://api.github.com/repos/Bortlesboat/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bortlesboat/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bortlesboat/bitcoin/teams","hooks_url":"https://api.github.com/repos/Bortlesboat/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Bortlesboat/bitcoin/events","assignees_url":"https://api.github.com/repos/Bortlesboat/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Bortlesboat/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Bortlesboat/bitcoin/tags","blobs_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bortlesboat/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Bortlesboat/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Bortlesboat/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Bortlesboat/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Bortlesboat/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Bortlesboat/bitcoin/subscription","commits_url":"https://api.github.com/repos/Bortlesboat/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bortlesboat/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bortlesboat/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bortlesboat/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Bortlesboat/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bortlesboat/bitcoin/merges","archive_url":"https://api.github.com/repos/Bortlesboat/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bortlesboat/bitcoin/downloads","issues_url":"https://api.github.com/repos/Bortlesboat/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Bortlesboat/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Bortlesboat/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Bortlesboat/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bortlesboat/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Bortlesboat/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/Bortlesboat/bitcoin/deployments","created_at":"2026-03-06T06:03:18Z","updated_at":"2026-03-06T06:03:18Z","pushed_at":"2026-03-07T22:11:15Z","git_url":"git://github.com/Bortlesboat/bitcoin.git","ssh_url":"git@github.com:Bortlesboat/bitcoin.git","clone_url":"https://github.com/Bortlesboat/bitcoin.git","svn_url":"https://github.com/Bortlesboat/bitcoin","homepage":"","size":334784,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"29.x-knots"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34760"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34760"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34760/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34760/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/28eb78cfdb67839cb0c12a0b7461f7d7dcac0330"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759","id":3364739786,"node_id":"PR_kwDOABII587IjdrK","html_url":"https://github.com/bitcoin/bitcoin/pull/34759","diff_url":"https://github.com/bitcoin/bitcoin/pull/34759.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34759.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34759","number":34759,"state":"open","locked":false,"title":"walletdb: clear out hash preimage vectors containing secret data","user":{"login":"theStack","id":91535,"node_id":"MDQ6VXNlcjkxNTM1","avatar_url":"https://avatars.githubusercontent.com/u/91535?v=4","gravatar_id":"","url":"https://api.github.com/users/theStack","html_url":"https://github.com/theStack","followers_url":"https://api.github.com/users/theStack/followers","following_url":"https://api.github.com/users/theStack/following{/other_user}","gists_url":"https://api.github.com/users/theStack/gists{/gist_id}","starred_url":"https://api.github.com/users/theStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theStack/subscriptions","organizations_url":"https://api.github.com/users/theStack/orgs","repos_url":"https://api.github.com/users/theStack/repos","events_url":"https://api.github.com/users/theStack/events{/privacy}","received_events_url":"https://api.github.com/users/theStack/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"In several places in the wallet DB module, byte strings containing serialized public keys and secret keys are created in order to be hashed. To avoid sensitive data lingering in memory (and potentially leaking), ensure that these hash preimages are cleared out by using `secure_allocator` for the `std::vector<unsigned char>` instances.\r\n\r\nSee e.g. #31166 and #31774 for similarly themed PRs (Note that in #31166 we used the explicit `memory_cleanse` approach though, as changing the allocator was not possible.)\r\n\r\nThe first commit contains the minimal-diff fix. The second commit is a code deduplication refactor; it could be dropped and picked up in a separate PR if preferred (there may be some bikeshedding about naming and style).","created_at":"2026-03-06T17:05:33Z","updated_at":"2026-03-07T22:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7732c966af2bfde3305a4f435e61d74001455fc4","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34759/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/9fc6ee916e6b9ca9f6876a63ecf6b362af86c741","head":{"label":"theStack:202603-walletdb-clear_out_secret_data","ref":"202603-walletdb-clear_out_secret_data","sha":"9fc6ee916e6b9ca9f6876a63ecf6b362af86c741","user":{"login":"theStack","id":91535,"node_id":"MDQ6VXNlcjkxNTM1","avatar_url":"https://avatars.githubusercontent.com/u/91535?v=4","gravatar_id":"","url":"https://api.github.com/users/theStack","html_url":"https://github.com/theStack","followers_url":"https://api.github.com/users/theStack/followers","following_url":"https://api.github.com/users/theStack/following{/other_user}","gists_url":"https://api.github.com/users/theStack/gists{/gist_id}","starred_url":"https://api.github.com/users/theStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theStack/subscriptions","organizations_url":"https://api.github.com/users/theStack/orgs","repos_url":"https://api.github.com/users/theStack/repos","events_url":"https://api.github.com/users/theStack/events{/privacy}","received_events_url":"https://api.github.com/users/theStack/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":204970720,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ5NzA3MjA=","name":"bitcoin","full_name":"theStack/bitcoin","private":false,"owner":{"login":"theStack","id":91535,"node_id":"MDQ6VXNlcjkxNTM1","avatar_url":"https://avatars.githubusercontent.com/u/91535?v=4","gravatar_id":"","url":"https://api.github.com/users/theStack","html_url":"https://github.com/theStack","followers_url":"https://api.github.com/users/theStack/followers","following_url":"https://api.github.com/users/theStack/following{/other_user}","gists_url":"https://api.github.com/users/theStack/gists{/gist_id}","starred_url":"https://api.github.com/users/theStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theStack/subscriptions","organizations_url":"https://api.github.com/users/theStack/orgs","repos_url":"https://api.github.com/users/theStack/repos","events_url":"https://api.github.com/users/theStack/events{/privacy}","received_events_url":"https://api.github.com/users/theStack/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/theStack/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/theStack/bitcoin","forks_url":"https://api.github.com/repos/theStack/bitcoin/forks","keys_url":"https://api.github.com/repos/theStack/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theStack/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theStack/bitcoin/teams","hooks_url":"https://api.github.com/repos/theStack/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/theStack/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/theStack/bitcoin/events","assignees_url":"https://api.github.com/repos/theStack/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/theStack/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/theStack/bitcoin/tags","blobs_url":"https://api.github.com/repos/theStack/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theStack/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theStack/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/theStack/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theStack/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/theStack/bitcoin/languages","stargazers_url":"https://api.github.com/repos/theStack/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/theStack/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/theStack/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/theStack/bitcoin/subscription","commits_url":"https://api.github.com/repos/theStack/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/theStack/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/theStack/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/theStack/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/theStack/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/theStack/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theStack/bitcoin/merges","archive_url":"https://api.github.com/repos/theStack/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theStack/bitcoin/downloads","issues_url":"https://api.github.com/repos/theStack/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/theStack/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/theStack/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/theStack/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theStack/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/theStack/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/theStack/bitcoin/deployments","created_at":"2019-08-28T15:59:29Z","updated_at":"2025-11-10T07:52:39Z","pushed_at":"2026-03-06T16:39:21Z","git_url":"git://github.com/theStack/bitcoin.git","ssh_url":"git@github.com:theStack/bitcoin.git","clone_url":"https://github.com/theStack/bitcoin.git","svn_url":"https://github.com/theStack/bitcoin","homepage":"https://bitcoincore.org/en/download","size":373875,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"8b70ed6996026de75a2e27e17b65bcbbdd61f6d8","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34759"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34759"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34759/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34759/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/9fc6ee916e6b9ca9f6876a63ecf6b362af86c741"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758","id":3364623493,"node_id":"PR_kwDOABII587IjBSF","html_url":"https://github.com/bitcoin/bitcoin/pull/34758","diff_url":"https://github.com/bitcoin/bitcoin/pull/34758.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34758.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34758","number":34758,"state":"open","locked":false,"title":"[28.x] Finalize 28.4","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"body":null,"created_at":"2026-03-06T16:34:44Z","updated_at":"2026-03-06T16:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9e15b4f4781dc91b31e64aad9288c3162932b79","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390024790,"node_id":"MDU6TGFiZWwzOTAwMjQ3OTA=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Backport","name":"Backport","color":"dd7200","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/82","html_url":"https://github.com/bitcoin/bitcoin/milestone/82","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/82/labels","id":14509510,"node_id":"MI_kwDOABII584A3WXG","number":82,"title":"28.4","description":"","creator":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2026-01-09T16:59:12Z","updated_at":"2026-03-06T16:34:44Z","due_on":null,"closed_at":null},"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34758/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a7748271b36a4c2a8955f41111a2b8c859183924","head":{"label":"achow101:28.4-finalize","ref":"28.4-finalize","sha":"a7748271b36a4c2a8955f41111a2b8c859183924","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":45006379,"node_id":"MDEwOlJlcG9zaXRvcnk0NTAwNjM3OQ==","name":"bitcoin","full_name":"achow101/bitcoin","private":false,"owner":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/achow101/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/achow101/bitcoin","forks_url":"https://api.github.com/repos/achow101/bitcoin/forks","keys_url":"https://api.github.com/repos/achow101/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achow101/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achow101/bitcoin/teams","hooks_url":"https://api.github.com/repos/achow101/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/achow101/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/achow101/bitcoin/events","assignees_url":"https://api.github.com/repos/achow101/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/achow101/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/achow101/bitcoin/tags","blobs_url":"https://api.github.com/repos/achow101/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achow101/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achow101/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/achow101/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achow101/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/achow101/bitcoin/languages","stargazers_url":"https://api.github.com/repos/achow101/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/achow101/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/achow101/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/achow101/bitcoin/subscription","commits_url":"https://api.github.com/repos/achow101/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/achow101/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/achow101/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/achow101/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/achow101/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/achow101/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achow101/bitcoin/merges","archive_url":"https://api.github.com/repos/achow101/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achow101/bitcoin/downloads","issues_url":"https://api.github.com/repos/achow101/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/achow101/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/achow101/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/achow101/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achow101/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/achow101/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/achow101/bitcoin/deployments","created_at":"2015-10-27T00:20:28Z","updated_at":"2026-02-22T01:30:10Z","pushed_at":"2026-03-06T21:25:19Z","git_url":"git://github.com/achow101/bitcoin.git","ssh_url":"git@github.com:achow101/bitcoin.git","clone_url":"https://github.com/achow101/bitcoin.git","svn_url":"https://github.com/achow101/bitcoin","homepage":"https://bitcoin.org/en/download","size":322001,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":11,"open_issues":0,"watchers":41,"default_branch":"master"}},"base":{"label":"bitcoin:28.x","ref":"28.x","sha":"ed80bb21e457bca8c5e67fe27285e7f796984a16","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34758"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34758"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34758/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34758/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a7748271b36a4c2a8955f41111a2b8c859183924"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757","id":3364554727,"node_id":"PR_kwDOABII587Iiwfn","html_url":"https://github.com/bitcoin/bitcoin/pull/34757","diff_url":"https://github.com/bitcoin/bitcoin/pull/34757.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34757.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34757","number":34757,"state":"open","locked":false,"title":"guix: re-enable riscv exported symbol checking","user":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Switching to binutils 2.46.0 seems to fix this (2.45.1 was still broken). Will find the relevant upstream change. No updates on our upstream issue: https://sourceware.org/bugzilla/show_bug.cgi?id=32783.\r\n\r\nBased on #34550.\r\nFixes #28095.","created_at":"2026-03-06T16:15:37Z","updated_at":"2026-03-08T00:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2056e2fc0c3f09aea8a7bfaaaa9834028e52ea14","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":61889416,"node_id":"MDU6TGFiZWw2MTg4OTQxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Build%20system","name":"Build system","color":"5319e7","default":false,"description":null}],"milestone":null,"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34757/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4727e42ca5576f582ab1eb8b7f849ceb07a73106","head":{"label":"fanquake:binutils_2460","ref":"binutils_2460","sha":"4727e42ca5576f582ab1eb8b7f849ceb07a73106","user":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":5910539,"node_id":"MDEwOlJlcG9zaXRvcnk1OTEwNTM5","name":"bitcoin","full_name":"fanquake/bitcoin","private":false,"owner":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/fanquake/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/fanquake/bitcoin","forks_url":"https://api.github.com/repos/fanquake/bitcoin/forks","keys_url":"https://api.github.com/repos/fanquake/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanquake/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanquake/bitcoin/teams","hooks_url":"https://api.github.com/repos/fanquake/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/fanquake/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/fanquake/bitcoin/events","assignees_url":"https://api.github.com/repos/fanquake/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/fanquake/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/fanquake/bitcoin/tags","blobs_url":"https://api.github.com/repos/fanquake/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanquake/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanquake/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanquake/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanquake/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/fanquake/bitcoin/languages","stargazers_url":"https://api.github.com/repos/fanquake/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/fanquake/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/fanquake/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/fanquake/bitcoin/subscription","commits_url":"https://api.github.com/repos/fanquake/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanquake/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanquake/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanquake/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanquake/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/fanquake/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanquake/bitcoin/merges","archive_url":"https://api.github.com/repos/fanquake/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanquake/bitcoin/downloads","issues_url":"https://api.github.com/repos/fanquake/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/fanquake/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/fanquake/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/fanquake/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanquake/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/fanquake/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/fanquake/bitcoin/deployments","created_at":"2012-09-22T05:28:42Z","updated_at":"2026-03-06T16:24:32Z","pushed_at":"2026-03-06T16:40:17Z","git_url":"git://github.com/fanquake/bitcoin.git","ssh_url":"git@github.com:fanquake/bitcoin.git","clone_url":"https://github.com/fanquake/bitcoin.git","svn_url":"https://github.com/fanquake/bitcoin","homepage":"http://www.bitcoincore.org","size":277504,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":true,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":6,"open_issues":1,"watchers":19,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"f6d3201e1416bd8eef93de565dca79629704ffd9","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34757"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34757"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34757/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34757/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4727e42ca5576f582ab1eb8b7f849ceb07a73106"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755","id":3364134342,"node_id":"PR_kwDOABII587IhJ3G","html_url":"https://github.com/bitcoin/bitcoin/pull/34755","diff_url":"https://github.com/bitcoin/bitcoin/pull/34755.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34755.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34755","number":34755,"state":"open","locked":false,"title":"depends: cleanup meta files","user":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"1 followup to #34650, to disable sbom generation.\r\n1 commit to Boost, to cleanup `.natvis` files that end up in share.","created_at":"2026-03-06T14:28:46Z","updated_at":"2026-03-06T14:29:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b504eb7961505fd7d96854ca272969f5322b24f3","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":61889416,"node_id":"MDU6TGFiZWw2MTg4OTQxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Build%20system","name":"Build system","color":"5319e7","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34755/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0ebc6891e2168c3ff1c9ad2250e765446610e75e","head":{"label":"fanquake:qt_no_sbom","ref":"qt_no_sbom","sha":"0ebc6891e2168c3ff1c9ad2250e765446610e75e","user":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":5910539,"node_id":"MDEwOlJlcG9zaXRvcnk1OTEwNTM5","name":"bitcoin","full_name":"fanquake/bitcoin","private":false,"owner":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/fanquake/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/fanquake/bitcoin","forks_url":"https://api.github.com/repos/fanquake/bitcoin/forks","keys_url":"https://api.github.com/repos/fanquake/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanquake/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanquake/bitcoin/teams","hooks_url":"https://api.github.com/repos/fanquake/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/fanquake/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/fanquake/bitcoin/events","assignees_url":"https://api.github.com/repos/fanquake/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/fanquake/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/fanquake/bitcoin/tags","blobs_url":"https://api.github.com/repos/fanquake/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanquake/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanquake/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanquake/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanquake/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/fanquake/bitcoin/languages","stargazers_url":"https://api.github.com/repos/fanquake/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/fanquake/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/fanquake/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/fanquake/bitcoin/subscription","commits_url":"https://api.github.com/repos/fanquake/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanquake/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanquake/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanquake/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanquake/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/fanquake/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanquake/bitcoin/merges","archive_url":"https://api.github.com/repos/fanquake/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanquake/bitcoin/downloads","issues_url":"https://api.github.com/repos/fanquake/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/fanquake/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/fanquake/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/fanquake/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanquake/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/fanquake/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/fanquake/bitcoin/deployments","created_at":"2012-09-22T05:28:42Z","updated_at":"2026-03-06T16:24:32Z","pushed_at":"2026-03-06T16:40:17Z","git_url":"git://github.com/fanquake/bitcoin.git","ssh_url":"git@github.com:fanquake/bitcoin.git","clone_url":"https://github.com/fanquake/bitcoin.git","svn_url":"https://github.com/fanquake/bitcoin","homepage":"http://www.bitcoincore.org","size":277504,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":true,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":6,"open_issues":1,"watchers":19,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"f6d3201e1416bd8eef93de565dca79629704ffd9","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34755"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34755"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34755/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34755/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0ebc6891e2168c3ff1c9ad2250e765446610e75e"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754","id":3363624690,"node_id":"PR_kwDOABII587IfNby","html_url":"https://github.com/bitcoin/bitcoin/pull/34754","diff_url":"https://github.com/bitcoin/bitcoin/pull/34754.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34754.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34754","number":34754,"state":"open","locked":false,"title":"[30.x] Partial backport #34650","user":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This PR backports commits from https://github.com/bitcoin/bitcoin/pull/34650 not related to Qt update. They fix issues when building with GCC 16 and improves Qt detecting.","created_at":"2026-03-06T12:22:09Z","updated_at":"2026-03-07T20:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d956be61e1f9611ef493499ec463b580a35074b0","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":390024790,"node_id":"MDU6TGFiZWwzOTAwMjQ3OTA=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Backport","name":"Backport","color":"dd7200","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/83","html_url":"https://github.com/bitcoin/bitcoin/milestone/83","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/83/labels","id":14543027,"node_id":"MI_kwDOABII584A3eiz","number":83,"title":"30.3","description":"","creator":{"login":"fanquake","id":863730,"node_id":"MDQ6VXNlcjg2MzczMA==","avatar_url":"https://avatars.githubusercontent.com/u/863730?v=4","gravatar_id":"","url":"https://api.github.com/users/fanquake","html_url":"https://github.com/fanquake","followers_url":"https://api.github.com/users/fanquake/followers","following_url":"https://api.github.com/users/fanquake/following{/other_user}","gists_url":"https://api.github.com/users/fanquake/gists{/gist_id}","starred_url":"https://api.github.com/users/fanquake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanquake/subscriptions","organizations_url":"https://api.github.com/users/fanquake/orgs","repos_url":"https://api.github.com/users/fanquake/repos","events_url":"https://api.github.com/users/fanquake/events{/privacy}","received_events_url":"https://api.github.com/users/fanquake/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2026-01-14T13:28:58Z","updated_at":"2026-03-06T12:23:04Z","due_on":null,"closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34754/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fbfc778b68572675a02d094c50f7c801470ab98b","head":{"label":"hebasto:260306-qt6-gcc16","ref":"260306-qt6-gcc16","sha":"fbfc778b68572675a02d094c50f7c801470ab98b","user":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":143212778,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMTI3Nzg=","name":"bitcoin","full_name":"hebasto/bitcoin","private":false,"owner":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/hebasto/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/hebasto/bitcoin","forks_url":"https://api.github.com/repos/hebasto/bitcoin/forks","keys_url":"https://api.github.com/repos/hebasto/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hebasto/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hebasto/bitcoin/teams","hooks_url":"https://api.github.com/repos/hebasto/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/hebasto/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/hebasto/bitcoin/events","assignees_url":"https://api.github.com/repos/hebasto/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/hebasto/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/hebasto/bitcoin/tags","blobs_url":"https://api.github.com/repos/hebasto/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hebasto/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hebasto/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hebasto/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hebasto/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/hebasto/bitcoin/languages","stargazers_url":"https://api.github.com/repos/hebasto/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/hebasto/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/hebasto/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/hebasto/bitcoin/subscription","commits_url":"https://api.github.com/repos/hebasto/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hebasto/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hebasto/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hebasto/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hebasto/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/hebasto/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hebasto/bitcoin/merges","archive_url":"https://api.github.com/repos/hebasto/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hebasto/bitcoin/downloads","issues_url":"https://api.github.com/repos/hebasto/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/hebasto/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/hebasto/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/hebasto/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hebasto/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/hebasto/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/hebasto/bitcoin/deployments","created_at":"2018-08-01T21:59:57Z","updated_at":"2026-03-07T20:03:49Z","pushed_at":"2026-03-07T20:37:44Z","git_url":"git://github.com/hebasto/bitcoin.git","ssh_url":"git@github.com:hebasto/bitcoin.git","clone_url":"https://github.com/hebasto/bitcoin.git","svn_url":"https://github.com/hebasto/bitcoin","homepage":"https://bitcoincore.org/en/download","size":335593,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin-core"],"visibility":"public","forks":6,"open_issues":0,"watchers":25,"default_branch":"master"}},"base":{"label":"bitcoin:30.x","ref":"30.x","sha":"f4f87c9d3bdb385953d63404794235d8dab234c8","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34754"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34754"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34754/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34754/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fbfc778b68572675a02d094c50f7c801470ab98b"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751","id":3362954212,"node_id":"PR_kwDOABII587Icpvk","html_url":"https://github.com/bitcoin/bitcoin/pull/34751","diff_url":"https://github.com/bitcoin/bitcoin/pull/34751.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34751.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34751","number":34751,"state":"open","locked":false,"title":"doc: Update asmap-data repository rule for file inclusion","user":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This updates the decision rule for file inclusion in the asmap-data repository after a collaborative run following discussion in the latest run: https://github.com/bitcoin-core/asmap-data/issues/44\r\n\r\nThe change is small but does a few things:\r\n- No minimum number of participants recommended anymore\r\n- Minimum number of matches set to 5 (which was previously the number of recommended min participants)\r\n- The result that is taken does not need to see a match between the majority of participants, it only needs to have the most matches\r\n- Participants that saw a match should sign for it\r\n\r\nI also thought about adding an explicit tie-breaker if there are two results with the same number of matches but since both results are equally valid I think it won't be needed (?)","created_at":"2026-03-06T09:23:58Z","updated_at":"2026-03-06T15:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0b25d0b3b94a4a0371c5cdaa3df6fd8994fd08b","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":148216,"node_id":"MDU6TGFiZWwxNDgyMTY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs","name":"Docs","color":"02d7e1","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74","html_url":"https://github.com/bitcoin/bitcoin/milestone/74","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74/labels","id":12610874,"node_id":"MI_kwDOABII584AwG06","number":74,"title":"31.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":11,"closed_issues":102,"state":"open","created_at":"2025-03-25T18:44:16Z","updated_at":"2026-03-06T21:29:25Z","due_on":null,"closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34751/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/8bc62ce173dd492ca862a692a88d526d406e0eb3","head":{"label":"fjahr:2026-03-asmap-rule","ref":"2026-03-asmap-rule","sha":"8bc62ce173dd492ca862a692a88d526d406e0eb3","user":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":196253948,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYyNTM5NDg=","name":"bitcoin","full_name":"fjahr/bitcoin","private":false,"owner":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/fjahr/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/fjahr/bitcoin","forks_url":"https://api.github.com/repos/fjahr/bitcoin/forks","keys_url":"https://api.github.com/repos/fjahr/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjahr/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjahr/bitcoin/teams","hooks_url":"https://api.github.com/repos/fjahr/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/fjahr/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/fjahr/bitcoin/events","assignees_url":"https://api.github.com/repos/fjahr/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/fjahr/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/fjahr/bitcoin/tags","blobs_url":"https://api.github.com/repos/fjahr/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjahr/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjahr/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjahr/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjahr/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/fjahr/bitcoin/languages","stargazers_url":"https://api.github.com/repos/fjahr/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/fjahr/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/fjahr/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/fjahr/bitcoin/subscription","commits_url":"https://api.github.com/repos/fjahr/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjahr/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjahr/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjahr/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjahr/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/fjahr/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjahr/bitcoin/merges","archive_url":"https://api.github.com/repos/fjahr/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjahr/bitcoin/downloads","issues_url":"https://api.github.com/repos/fjahr/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/fjahr/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/fjahr/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/fjahr/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjahr/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/fjahr/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/fjahr/bitcoin/deployments","created_at":"2019-07-10T18:11:06Z","updated_at":"2024-07-23T22:14:45Z","pushed_at":"2026-03-06T21:51:27Z","git_url":"git://github.com/fjahr/bitcoin.git","ssh_url":"git@github.com:fjahr/bitcoin.git","clone_url":"https://github.com/fjahr/bitcoin.git","svn_url":"https://github.com/fjahr/bitcoin","homepage":"https://bitcoincore.org/en/download","size":290722,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ca45461ddb2421b4267dad0b7d7bcec88c07eba4","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34751"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34751"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34751/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34751/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/8bc62ce173dd492ca862a692a88d526d406e0eb3"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750","id":3362305112,"node_id":"PR_kwDOABII587IaLRY","html_url":"https://github.com/bitcoin/bitcoin/pull/34750","diff_url":"https://github.com/bitcoin/bitcoin/pull/34750.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34750.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34750","number":34750,"state":"open","locked":false,"title":"test: fix addr relay test silently passing and other improvements","user":{"login":"stratospher","id":44024636,"node_id":"MDQ6VXNlcjQ0MDI0NjM2","avatar_url":"https://avatars.githubusercontent.com/u/44024636?v=4","gravatar_id":"","url":"https://api.github.com/users/stratospher","html_url":"https://github.com/stratospher","followers_url":"https://api.github.com/users/stratospher/followers","following_url":"https://api.github.com/users/stratospher/following{/other_user}","gists_url":"https://api.github.com/users/stratospher/gists{/gist_id}","starred_url":"https://api.github.com/users/stratospher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratospher/subscriptions","organizations_url":"https://api.github.com/users/stratospher/orgs","repos_url":"https://api.github.com/users/stratospher/repos","events_url":"https://api.github.com/users/stratospher/events{/privacy}","received_events_url":"https://api.github.com/users/stratospher/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"couple of improvements in the addr relay test:\r\n  - fixes the silent test pass discovered in https://github.com/bitcoin/bitcoin/pull/34717#issuecomment-3990585763 (will remove this if that PR gets merged - the test doesn't fail even though #34717 changes the behaviour)\r\n  - correct wrong peerinfo index                                                                                         \r\n  - prevent intermittent disconnection warnings like the one shown below by protecting outbound peer from `ConsiderEviction`\r\n  ```\r\n    TestFramework (INFO): Check that we answer getaddr messages only once per connection\r\n    TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:58829 due to [Errno 54] Connection reset by peer\r\n```\r\n  - remove a no longer applicable test comment since we don't need to send initial GETADDR for intial self announcement anymore","created_at":"2026-03-06T05:58:05Z","updated_at":"2026-03-08T01:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd020990cdb01ae326943e9c8962fa78ab33e924","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74","html_url":"https://github.com/bitcoin/bitcoin/milestone/74","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74/labels","id":12610874,"node_id":"MI_kwDOABII584AwG06","number":74,"title":"31.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":11,"closed_issues":102,"state":"open","created_at":"2025-03-25T18:44:16Z","updated_at":"2026-03-06T21:29:25Z","due_on":null,"closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34750/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/57bfa864fe69ea5610399f9db60cf2299930703a","head":{"label":"stratospher:2026_03_tests_addr_relay","ref":"2026_03_tests_addr_relay","sha":"57bfa864fe69ea5610399f9db60cf2299930703a","user":{"login":"stratospher","id":44024636,"node_id":"MDQ6VXNlcjQ0MDI0NjM2","avatar_url":"https://avatars.githubusercontent.com/u/44024636?v=4","gravatar_id":"","url":"https://api.github.com/users/stratospher","html_url":"https://github.com/stratospher","followers_url":"https://api.github.com/users/stratospher/followers","following_url":"https://api.github.com/users/stratospher/following{/other_user}","gists_url":"https://api.github.com/users/stratospher/gists{/gist_id}","starred_url":"https://api.github.com/users/stratospher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratospher/subscriptions","organizations_url":"https://api.github.com/users/stratospher/orgs","repos_url":"https://api.github.com/users/stratospher/repos","events_url":"https://api.github.com/users/stratospher/events{/privacy}","received_events_url":"https://api.github.com/users/stratospher/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":379929443,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk5Mjk0NDM=","name":"bitcoin","full_name":"stratospher/bitcoin","private":false,"owner":{"login":"stratospher","id":44024636,"node_id":"MDQ6VXNlcjQ0MDI0NjM2","avatar_url":"https://avatars.githubusercontent.com/u/44024636?v=4","gravatar_id":"","url":"https://api.github.com/users/stratospher","html_url":"https://github.com/stratospher","followers_url":"https://api.github.com/users/stratospher/followers","following_url":"https://api.github.com/users/stratospher/following{/other_user}","gists_url":"https://api.github.com/users/stratospher/gists{/gist_id}","starred_url":"https://api.github.com/users/stratospher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratospher/subscriptions","organizations_url":"https://api.github.com/users/stratospher/orgs","repos_url":"https://api.github.com/users/stratospher/repos","events_url":"https://api.github.com/users/stratospher/events{/privacy}","received_events_url":"https://api.github.com/users/stratospher/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/stratospher/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/stratospher/bitcoin","forks_url":"https://api.github.com/repos/stratospher/bitcoin/forks","keys_url":"https://api.github.com/repos/stratospher/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratospher/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratospher/bitcoin/teams","hooks_url":"https://api.github.com/repos/stratospher/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/stratospher/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/stratospher/bitcoin/events","assignees_url":"https://api.github.com/repos/stratospher/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/stratospher/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/stratospher/bitcoin/tags","blobs_url":"https://api.github.com/repos/stratospher/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratospher/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratospher/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratospher/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratospher/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/stratospher/bitcoin/languages","stargazers_url":"https://api.github.com/repos/stratospher/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/stratospher/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/stratospher/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/stratospher/bitcoin/subscription","commits_url":"https://api.github.com/repos/stratospher/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratospher/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratospher/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratospher/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratospher/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/stratospher/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratospher/bitcoin/merges","archive_url":"https://api.github.com/repos/stratospher/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratospher/bitcoin/downloads","issues_url":"https://api.github.com/repos/stratospher/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/stratospher/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/stratospher/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/stratospher/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratospher/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/stratospher/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/stratospher/bitcoin/deployments","created_at":"2021-06-24T13:12:06Z","updated_at":"2026-03-06T07:13:34Z","pushed_at":"2026-03-06T07:12:53Z","git_url":"git://github.com/stratospher/bitcoin.git","ssh_url":"git@github.com:stratospher/bitcoin.git","clone_url":"https://github.com/stratospher/bitcoin.git","svn_url":"https://github.com/stratospher/bitcoin","homepage":"https://bitcoincore.org/en/download","size":292932,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ca45461ddb2421b4267dad0b7d7bcec88c07eba4","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34750"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34750"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34750/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34750/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/57bfa864fe69ea5610399f9db60cf2299930703a"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749","id":3360993082,"node_id":"PR_kwDOABII587IVK86","html_url":"https://github.com/bitcoin/bitcoin/pull/34749","diff_url":"https://github.com/bitcoin/bitcoin/pull/34749.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34749.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34749","number":34749,"state":"open","locked":false,"title":"rpc: Refactor gettxspendingprevout to be easier to parse","user":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This refactoring commit was originally part of #34635 but the the change was some-what controversial: https://github.com/bitcoin/bitcoin/pull/34635#discussion_r2833541912 and the discussion was blocking the rest of the uncontroversial changes from moving forward.\r\n\r\nIt looks like #34748 is trying to achieve something similar now, we'll have to see how the different approached converge but at least there seems to be some more conceptual interest than appeared on #34635 originally.\r\n","created_at":"2026-03-05T21:37:50Z","updated_at":"2026-03-06T22:38:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c851119d108d3b406bd7d4ae4c9541b405214e48","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34749/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fb4ad3931813e82837b84d2407345098bc0301c7","head":{"label":"fjahr:2026-02-24539-refactor","ref":"2026-02-24539-refactor","sha":"fb4ad3931813e82837b84d2407345098bc0301c7","user":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":196253948,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYyNTM5NDg=","name":"bitcoin","full_name":"fjahr/bitcoin","private":false,"owner":{"login":"fjahr","id":1322187,"node_id":"MDQ6VXNlcjEzMjIxODc=","avatar_url":"https://avatars.githubusercontent.com/u/1322187?v=4","gravatar_id":"","url":"https://api.github.com/users/fjahr","html_url":"https://github.com/fjahr","followers_url":"https://api.github.com/users/fjahr/followers","following_url":"https://api.github.com/users/fjahr/following{/other_user}","gists_url":"https://api.github.com/users/fjahr/gists{/gist_id}","starred_url":"https://api.github.com/users/fjahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjahr/subscriptions","organizations_url":"https://api.github.com/users/fjahr/orgs","repos_url":"https://api.github.com/users/fjahr/repos","events_url":"https://api.github.com/users/fjahr/events{/privacy}","received_events_url":"https://api.github.com/users/fjahr/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/fjahr/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/fjahr/bitcoin","forks_url":"https://api.github.com/repos/fjahr/bitcoin/forks","keys_url":"https://api.github.com/repos/fjahr/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjahr/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjahr/bitcoin/teams","hooks_url":"https://api.github.com/repos/fjahr/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/fjahr/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/fjahr/bitcoin/events","assignees_url":"https://api.github.com/repos/fjahr/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/fjahr/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/fjahr/bitcoin/tags","blobs_url":"https://api.github.com/repos/fjahr/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjahr/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjahr/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjahr/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjahr/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/fjahr/bitcoin/languages","stargazers_url":"https://api.github.com/repos/fjahr/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/fjahr/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/fjahr/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/fjahr/bitcoin/subscription","commits_url":"https://api.github.com/repos/fjahr/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjahr/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjahr/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjahr/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjahr/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/fjahr/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjahr/bitcoin/merges","archive_url":"https://api.github.com/repos/fjahr/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjahr/bitcoin/downloads","issues_url":"https://api.github.com/repos/fjahr/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/fjahr/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/fjahr/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/fjahr/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjahr/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/fjahr/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/fjahr/bitcoin/deployments","created_at":"2019-07-10T18:11:06Z","updated_at":"2024-07-23T22:14:45Z","pushed_at":"2026-03-06T21:51:27Z","git_url":"git://github.com/fjahr/bitcoin.git","ssh_url":"git@github.com:fjahr/bitcoin.git","clone_url":"https://github.com/fjahr/bitcoin.git","svn_url":"https://github.com/fjahr/bitcoin","homepage":"https://bitcoincore.org/en/download","size":290722,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34749"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34749"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34749/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34749/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fb4ad3931813e82837b84d2407345098bc0301c7"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745","id":3359450078,"node_id":"PR_kwDOABII587IPSPe","html_url":"https://github.com/bitcoin/bitcoin/pull/34745","diff_url":"https://github.com/bitcoin/bitcoin/pull/34745.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34745.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34745","number":34745,"state":"open","locked":false,"title":"refactor: replace `ArgsManager::cs_args RecursiveMutex` with `Mutex`","user":{"login":"w0xlt","id":94266259,"node_id":"U_kgDOBZ5jkw","avatar_url":"https://avatars.githubusercontent.com/u/94266259?v=4","gravatar_id":"","url":"https://api.github.com/users/w0xlt","html_url":"https://github.com/w0xlt","followers_url":"https://api.github.com/users/w0xlt/followers","following_url":"https://api.github.com/users/w0xlt/following{/other_user}","gists_url":"https://api.github.com/users/w0xlt/gists{/gist_id}","starred_url":"https://api.github.com/users/w0xlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0xlt/subscriptions","organizations_url":"https://api.github.com/users/w0xlt/orgs","repos_url":"https://api.github.com/users/w0xlt/repos","events_url":"https://api.github.com/users/w0xlt/events{/privacy}","received_events_url":"https://api.github.com/users/w0xlt/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Part of #19303.\r\n\r\nReplace `ArgsManager::cs_args` from `RecursiveMutex` to `Mutex`.\r\n\r\nThe conversion follows the pattern established in prior `RecursiveMutex` removals (e.g. `CAddrMan` in #19238, `CBlockPolicyEstimator` in #22014): extract private lock-held helpers with trailing underscore naming (`GetSetting_()`, `GetArgFlags_()`, `GetPathArg_()`), then replace recursive calls in methods that already hold `cs_args` with those helpers.","created_at":"2026-03-05T15:26:15Z","updated_at":"2026-03-08T01:43:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e7ac2cb49bde4b5b8392dba29ec0c94edff806c","assignees":[],"requested_reviewers":[{"login":"theuni","id":417043,"node_id":"MDQ6VXNlcjQxNzA0Mw==","avatar_url":"https://avatars.githubusercontent.com/u/417043?v=4","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","user_view_type":"public","site_admin":false},{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false}],"requested_teams":[],"labels":[{"id":135961,"node_id":"MDU6TGFiZWwxMzU5NjE=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34745/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fdc64114dd22d259503a6ac63846e9f4b803854b","head":{"label":"w0xlt:args-mutex-conversion","ref":"args-mutex-conversion","sha":"fdc64114dd22d259503a6ac63846e9f4b803854b","user":{"login":"w0xlt","id":94266259,"node_id":"U_kgDOBZ5jkw","avatar_url":"https://avatars.githubusercontent.com/u/94266259?v=4","gravatar_id":"","url":"https://api.github.com/users/w0xlt","html_url":"https://github.com/w0xlt","followers_url":"https://api.github.com/users/w0xlt/followers","following_url":"https://api.github.com/users/w0xlt/following{/other_user}","gists_url":"https://api.github.com/users/w0xlt/gists{/gist_id}","starred_url":"https://api.github.com/users/w0xlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0xlt/subscriptions","organizations_url":"https://api.github.com/users/w0xlt/orgs","repos_url":"https://api.github.com/users/w0xlt/repos","events_url":"https://api.github.com/users/w0xlt/events{/privacy}","received_events_url":"https://api.github.com/users/w0xlt/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":427811926,"node_id":"R_kgDOGX_kVg","name":"bitcoin","full_name":"w0xlt/bitcoin","private":false,"owner":{"login":"w0xlt","id":94266259,"node_id":"U_kgDOBZ5jkw","avatar_url":"https://avatars.githubusercontent.com/u/94266259?v=4","gravatar_id":"","url":"https://api.github.com/users/w0xlt","html_url":"https://github.com/w0xlt","followers_url":"https://api.github.com/users/w0xlt/followers","following_url":"https://api.github.com/users/w0xlt/following{/other_user}","gists_url":"https://api.github.com/users/w0xlt/gists{/gist_id}","starred_url":"https://api.github.com/users/w0xlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0xlt/subscriptions","organizations_url":"https://api.github.com/users/w0xlt/orgs","repos_url":"https://api.github.com/users/w0xlt/repos","events_url":"https://api.github.com/users/w0xlt/events{/privacy}","received_events_url":"https://api.github.com/users/w0xlt/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/w0xlt/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/w0xlt/bitcoin","forks_url":"https://api.github.com/repos/w0xlt/bitcoin/forks","keys_url":"https://api.github.com/repos/w0xlt/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w0xlt/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w0xlt/bitcoin/teams","hooks_url":"https://api.github.com/repos/w0xlt/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/w0xlt/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/w0xlt/bitcoin/events","assignees_url":"https://api.github.com/repos/w0xlt/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/w0xlt/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/w0xlt/bitcoin/tags","blobs_url":"https://api.github.com/repos/w0xlt/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w0xlt/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w0xlt/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/w0xlt/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w0xlt/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/w0xlt/bitcoin/languages","stargazers_url":"https://api.github.com/repos/w0xlt/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/w0xlt/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/w0xlt/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/w0xlt/bitcoin/subscription","commits_url":"https://api.github.com/repos/w0xlt/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/w0xlt/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/w0xlt/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/w0xlt/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/w0xlt/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/w0xlt/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w0xlt/bitcoin/merges","archive_url":"https://api.github.com/repos/w0xlt/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w0xlt/bitcoin/downloads","issues_url":"https://api.github.com/repos/w0xlt/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/w0xlt/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/w0xlt/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/w0xlt/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w0xlt/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/w0xlt/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/w0xlt/bitcoin/deployments","created_at":"2021-11-14T01:34:01Z","updated_at":"2026-03-05T19:13:43Z","pushed_at":"2026-03-06T21:35:50Z","git_url":"git://github.com/w0xlt/bitcoin.git","ssh_url":"git@github.com:w0xlt/bitcoin.git","clone_url":"https://github.com/w0xlt/bitcoin.git","svn_url":"https://github.com/w0xlt/bitcoin","homepage":"https://bitcoincore.org/en/download","size":297522,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":2,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34745"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34745"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34745/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34745/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fdc64114dd22d259503a6ac63846e9f4b803854b"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743","id":3358813627,"node_id":"PR_kwDOABII587IM227","html_url":"https://github.com/bitcoin/bitcoin/pull/34743","diff_url":"https://github.com/bitcoin/bitcoin/pull/34743.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34743.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34743","number":34743,"state":"open","locked":false,"title":"p2p: protect manual evictions","user":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Closes: #5097\r\n\r\nManual peers (`-addnode`, `-connect` + RPC) currently get disconnected by IBD timeout logic for block stalling, block download timeout and headers sync timeout. This can conflict with explicit user intent to keep these peers connected (especially in privacy-focused -connect setups), and causes unnecessary disconnect/reconnect churn.\r\n\r\nThis PR changes that behavior: manual peers are not disconnected by those timeout paths and we try to re-assign their work to other peers to maintain progress.\r\n\r\n----\r\n\r\nDisconnecting manual peers automatically causes reconnect loops and other behavior that can violate user expectation for manually configured peers.\r\n\r\nSimply “not disconnecting” (for block stalling) is not sufficient by itself: a manual peer can retain in-flight block assignments and delay overall IBD progress.\r\n\r\nI considered taking an approach more like that from #32051, simply protecting peers from some disconnects. However without the reassignment the stalling effects are simply prolonged (which is worse, IMO).\r\n\r\nThis PR uses a different appraoch:\r\n\r\n- For manual peers in block-stalling/download-timeout paths:\r\n    - release all in-flight blocks from that peer,\r\n    - set a one-round recovery flag (`m_stall_recovery`) so scheduler ordering doesn’t immediately reassign those same blocks back to the same peer.\r\n\r\nThis attempts to both preserve manual connections and maintain download progress. It actively reassigns stalled work so IBD can continue, rather than just waiting longer. And, the one-round skip prevents immediate re-capture of freed blocks by the same manual peer due to per-peer send ordering.\r\n\r\nCompared with simpler “don’t disconnect” approaches, this is more robust both in tests, and real-world slow-peer conditions.\r\n\r\nI believe the changes do not increase remote attacker control because it only applies to manual peers (-addnode, -connect, addnode), which are explicitly chosen by the local operator. You were and still are free to add a malicious peer manually.\r\n\r\nA malicious manually-added peer can now remain connected longer, but that peer was already granted privileged trust by operator configuration. And in fact, for block stalling/download timeout this PR reduces potential impact of a slow/malicious manual peer by releasing its in-flight blocks so other peers can fetch them.\r\n\r\nOf course, if an operator relies _only on bad manual peers_, sync can still be delayed.","created_at":"2026-03-05T13:28:47Z","updated_at":"2026-03-08T01:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b98ee0e603f2a4576575183d1516c36a9e75d939","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98298007,"node_id":"MDU6TGFiZWw5ODI5ODAwNw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34743/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7beac82aa119c39cf216556d5fe7675db932e3c3","head":{"label":"willcl-ark:protect-manual-evictions","ref":"protect-manual-evictions","sha":"7beac82aa119c39cf216556d5fe7675db932e3c3","user":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":164122552,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxMjI1NTI=","name":"bitcoin","full_name":"willcl-ark/bitcoin","private":false,"owner":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/willcl-ark/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/willcl-ark/bitcoin","forks_url":"https://api.github.com/repos/willcl-ark/bitcoin/forks","keys_url":"https://api.github.com/repos/willcl-ark/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willcl-ark/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willcl-ark/bitcoin/teams","hooks_url":"https://api.github.com/repos/willcl-ark/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/willcl-ark/bitcoin/events","assignees_url":"https://api.github.com/repos/willcl-ark/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/willcl-ark/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/willcl-ark/bitcoin/tags","blobs_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willcl-ark/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/willcl-ark/bitcoin/languages","stargazers_url":"https://api.github.com/repos/willcl-ark/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/willcl-ark/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/willcl-ark/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/willcl-ark/bitcoin/subscription","commits_url":"https://api.github.com/repos/willcl-ark/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/willcl-ark/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/willcl-ark/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/willcl-ark/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willcl-ark/bitcoin/merges","archive_url":"https://api.github.com/repos/willcl-ark/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willcl-ark/bitcoin/downloads","issues_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/willcl-ark/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/willcl-ark/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/willcl-ark/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willcl-ark/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/willcl-ark/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/willcl-ark/bitcoin/deployments","created_at":"2019-01-04T15:17:29Z","updated_at":"2026-03-07T04:02:35Z","pushed_at":"2026-03-07T04:02:25Z","git_url":"git://github.com/willcl-ark/bitcoin.git","ssh_url":"git@github.com:willcl-ark/bitcoin.git","clone_url":"https://github.com/willcl-ark/bitcoin.git","svn_url":"https://github.com/willcl-ark/bitcoin","homepage":"https://bitcoincore.org/en/download","size":303914,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":2,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c7a3ea2483063cd1b5c119cf44753a9b17e93a89","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34743"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34743"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34743/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34743/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7beac82aa119c39cf216556d5fe7675db932e3c3"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742","id":3358629839,"node_id":"PR_kwDOABII587IMJ_P","html_url":"https://github.com/bitcoin/bitcoin/pull/34742","diff_url":"https://github.com/bitcoin/bitcoin/pull/34742.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34742.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34742","number":34742,"state":"open","locked":false,"title":"fuzz: set whitelist permissions on connman target","user":{"login":"brunoerg","id":19480819,"node_id":"MDQ6VXNlcjE5NDgwODE5","avatar_url":"https://avatars.githubusercontent.com/u/19480819?v=4","gravatar_id":"","url":"https://api.github.com/users/brunoerg","html_url":"https://github.com/brunoerg","followers_url":"https://api.github.com/users/brunoerg/followers","following_url":"https://api.github.com/users/brunoerg/following{/other_user}","gists_url":"https://api.github.com/users/brunoerg/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoerg/subscriptions","organizations_url":"https://api.github.com/users/brunoerg/orgs","repos_url":"https://api.github.com/users/brunoerg/repos","events_url":"https://api.github.com/users/brunoerg/events{/privacy}","received_events_url":"https://api.github.com/users/brunoerg/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"I noticed that `AddWhitelistPermissionFlags` was always being called with an empty `ranges` (whitelist permissions). This function is called when connecting to a node (`ConnectNode`), and if the connection is a manual one, it uses the `vWhitelistedRangeOutgoing` to populate the permissions. However, since we were not setting any whitelist permission on the target, this vector is always empty. This PR improves this target by populating both `vWhitelistedRangeIncoming` and `vWhitelistedRangeOutgoing`.","created_at":"2026-03-05T12:49:10Z","updated_at":"2026-03-05T12:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0741c2eae287cb47f5abf49888fbf4ea2d729469","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":9554944034,"node_id":"LA_kwDOABII588AAAACOYTgIg","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Fuzzing","name":"Fuzzing","color":"0e8a16","default":false,"description":""}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34742/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/32debfa1ed8168bca0b6d2f191d2e3e940f6029b","head":{"label":"brunoerg:2026-03-connman","ref":"2026-03-connman","sha":"32debfa1ed8168bca0b6d2f191d2e3e940f6029b","user":{"login":"brunoerg","id":19480819,"node_id":"MDQ6VXNlcjE5NDgwODE5","avatar_url":"https://avatars.githubusercontent.com/u/19480819?v=4","gravatar_id":"","url":"https://api.github.com/users/brunoerg","html_url":"https://github.com/brunoerg","followers_url":"https://api.github.com/users/brunoerg/followers","following_url":"https://api.github.com/users/brunoerg/following{/other_user}","gists_url":"https://api.github.com/users/brunoerg/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoerg/subscriptions","organizations_url":"https://api.github.com/users/brunoerg/orgs","repos_url":"https://api.github.com/users/brunoerg/repos","events_url":"https://api.github.com/users/brunoerg/events{/privacy}","received_events_url":"https://api.github.com/users/brunoerg/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":267841305,"node_id":"MDEwOlJlcG9zaXRvcnkyNjc4NDEzMDU=","name":"bitcoin","full_name":"brunoerg/bitcoin","private":false,"owner":{"login":"brunoerg","id":19480819,"node_id":"MDQ6VXNlcjE5NDgwODE5","avatar_url":"https://avatars.githubusercontent.com/u/19480819?v=4","gravatar_id":"","url":"https://api.github.com/users/brunoerg","html_url":"https://github.com/brunoerg","followers_url":"https://api.github.com/users/brunoerg/followers","following_url":"https://api.github.com/users/brunoerg/following{/other_user}","gists_url":"https://api.github.com/users/brunoerg/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoerg/subscriptions","organizations_url":"https://api.github.com/users/brunoerg/orgs","repos_url":"https://api.github.com/users/brunoerg/repos","events_url":"https://api.github.com/users/brunoerg/events{/privacy}","received_events_url":"https://api.github.com/users/brunoerg/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/brunoerg/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/brunoerg/bitcoin","forks_url":"https://api.github.com/repos/brunoerg/bitcoin/forks","keys_url":"https://api.github.com/repos/brunoerg/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunoerg/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunoerg/bitcoin/teams","hooks_url":"https://api.github.com/repos/brunoerg/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/brunoerg/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/brunoerg/bitcoin/events","assignees_url":"https://api.github.com/repos/brunoerg/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/brunoerg/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/brunoerg/bitcoin/tags","blobs_url":"https://api.github.com/repos/brunoerg/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunoerg/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunoerg/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunoerg/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunoerg/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/brunoerg/bitcoin/languages","stargazers_url":"https://api.github.com/repos/brunoerg/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/brunoerg/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/brunoerg/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/brunoerg/bitcoin/subscription","commits_url":"https://api.github.com/repos/brunoerg/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunoerg/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunoerg/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunoerg/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunoerg/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/brunoerg/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunoerg/bitcoin/merges","archive_url":"https://api.github.com/repos/brunoerg/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunoerg/bitcoin/downloads","issues_url":"https://api.github.com/repos/brunoerg/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/brunoerg/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/brunoerg/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/brunoerg/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunoerg/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/brunoerg/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/brunoerg/bitcoin/deployments","created_at":"2020-05-29T11:30:10Z","updated_at":"2025-12-22T13:23:26Z","pushed_at":"2026-03-05T12:45:20Z","git_url":"git://github.com/brunoerg/bitcoin.git","ssh_url":"git@github.com:brunoerg/bitcoin.git","clone_url":"https://github.com/brunoerg/bitcoin.git","svn_url":"https://github.com/brunoerg/bitcoin","homepage":"https://bitcoincore.org/en/download","size":287481,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"7e91060ec7736f86e65e77996a2312a8e80d3f09","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34742"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34742"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34742/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34742/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/32debfa1ed8168bca0b6d2f191d2e3e940f6029b"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741","id":3358567354,"node_id":"PR_kwDOABII587IL6u6","html_url":"https://github.com/bitcoin/bitcoin/pull/34741","diff_url":"https://github.com/bitcoin/bitcoin/pull/34741.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34741.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34741","number":34741,"state":"open","locked":false,"title":"refactor: Return std::optional from GetNameProxy/GetProxy","user":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Currently the getters have a mutable reference as inout param and return a bool to indicate success. This is confusing, because the success bool is redundant with the `IsValid()` state on the proxy object.\r\n\r\nSo in theory, the functions could reset the mutable proxy object to an invalid state and return `void`.\r\n\r\nHowever, this would also be confusing, because devs can forget to check `IsValid()`.\r\n\r\nFix all issues by using `std::optional<Proxy>`, where devs no longer have to check `IsValid()` manually, or a separate bool.","created_at":"2026-03-05T12:34:18Z","updated_at":"2026-03-06T06:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4625b0bbd4b07de8af37f534ae279c5b93de89f","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"node_id":"MDU6TGFiZWwxMzU5NjE=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34741/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa66d1ad49d5c10646662f2cdf8aa875a43dcf21","head":{"label":"maflcko:2603-opt-proxy","ref":"2603-opt-proxy","sha":"fa66d1ad49d5c10646662f2cdf8aa875a43dcf21","user":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":40046254,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA0NjI1NA==","name":"bitcoin-core","full_name":"maflcko/bitcoin-core","private":false,"owner":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/maflcko/bitcoin-core","description":null,"fork":true,"url":"https://api.github.com/repos/maflcko/bitcoin-core","forks_url":"https://api.github.com/repos/maflcko/bitcoin-core/forks","keys_url":"https://api.github.com/repos/maflcko/bitcoin-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maflcko/bitcoin-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maflcko/bitcoin-core/teams","hooks_url":"https://api.github.com/repos/maflcko/bitcoin-core/hooks","issue_events_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues/events{/number}","events_url":"https://api.github.com/repos/maflcko/bitcoin-core/events","assignees_url":"https://api.github.com/repos/maflcko/bitcoin-core/assignees{/user}","branches_url":"https://api.github.com/repos/maflcko/bitcoin-core/branches{/branch}","tags_url":"https://api.github.com/repos/maflcko/bitcoin-core/tags","blobs_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maflcko/bitcoin-core/statuses/{sha}","languages_url":"https://api.github.com/repos/maflcko/bitcoin-core/languages","stargazers_url":"https://api.github.com/repos/maflcko/bitcoin-core/stargazers","contributors_url":"https://api.github.com/repos/maflcko/bitcoin-core/contributors","subscribers_url":"https://api.github.com/repos/maflcko/bitcoin-core/subscribers","subscription_url":"https://api.github.com/repos/maflcko/bitcoin-core/subscription","commits_url":"https://api.github.com/repos/maflcko/bitcoin-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/maflcko/bitcoin-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/maflcko/bitcoin-core/contents/{+path}","compare_url":"https://api.github.com/repos/maflcko/bitcoin-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maflcko/bitcoin-core/merges","archive_url":"https://api.github.com/repos/maflcko/bitcoin-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maflcko/bitcoin-core/downloads","issues_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues{/number}","pulls_url":"https://api.github.com/repos/maflcko/bitcoin-core/pulls{/number}","milestones_url":"https://api.github.com/repos/maflcko/bitcoin-core/milestones{/number}","notifications_url":"https://api.github.com/repos/maflcko/bitcoin-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maflcko/bitcoin-core/labels{/name}","releases_url":"https://api.github.com/repos/maflcko/bitcoin-core/releases{/id}","deployments_url":"https://api.github.com/repos/maflcko/bitcoin-core/deployments","created_at":"2015-08-01T12:42:47Z","updated_at":"2026-02-26T13:42:10Z","pushed_at":"2026-03-05T12:28:26Z","git_url":"git://github.com/maflcko/bitcoin-core.git","ssh_url":"git@github.com:maflcko/bitcoin-core.git","clone_url":"https://github.com/maflcko/bitcoin-core.git","svn_url":"https://github.com/maflcko/bitcoin-core","homepage":"","size":271768,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":10,"open_issues":13,"watchers":26,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"7e91060ec7736f86e65e77996a2312a8e80d3f09","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34741"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34741"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34741/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34741/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/fa66d1ad49d5c10646662f2cdf8aa875a43dcf21"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730","id":3353107575,"node_id":"PR_kwDOABII587H3Fx3","html_url":"https://github.com/bitcoin/bitcoin/pull/34730","diff_url":"https://github.com/bitcoin/bitcoin/pull/34730.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34730.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34730","number":34730,"state":"open","locked":false,"title":"util/log: Combine the warning/error log levels into a single alert level","user":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"There's little benefit in having two error levels that the node operator should pay attention to when the only difference between them is that one means the node is about to shut down -- the admin can easily see that just by looking at whether the node did shutdown. So this PR replaces LogWarning and LogError with LogAlert, which hopefully emphasises that the point of using that level is to alert the node operator.\r\n\r\nLeaves LogWarning and LogError available as deprecated aliases to reduce code churn and avoid invalidating PRs.\r\n\r\nLeft as draft pending #34038 as the \"warning\" and \"error\" levels are currently exposed to users via the `-loglevel` config option.","created_at":"2026-03-04T12:03:15Z","updated_at":"2026-03-08T02:28:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e4fc62b4436740684abc57a4b5856b51db41c34","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34730/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4ce720ba8738b480fbd9244776ce1c7b01fc591a","head":{"label":"ajtowns:202603-logalert","ref":"202603-logalert","sha":"4ce720ba8738b480fbd9244776ce1c7b01fc591a","user":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":53941525,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk0MTUyNQ==","name":"bitcoin","full_name":"ajtowns/bitcoin","private":false,"owner":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/ajtowns/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/ajtowns/bitcoin","forks_url":"https://api.github.com/repos/ajtowns/bitcoin/forks","keys_url":"https://api.github.com/repos/ajtowns/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajtowns/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajtowns/bitcoin/teams","hooks_url":"https://api.github.com/repos/ajtowns/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/ajtowns/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/ajtowns/bitcoin/events","assignees_url":"https://api.github.com/repos/ajtowns/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/ajtowns/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/ajtowns/bitcoin/tags","blobs_url":"https://api.github.com/repos/ajtowns/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajtowns/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajtowns/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajtowns/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajtowns/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/ajtowns/bitcoin/languages","stargazers_url":"https://api.github.com/repos/ajtowns/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/ajtowns/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/ajtowns/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/ajtowns/bitcoin/subscription","commits_url":"https://api.github.com/repos/ajtowns/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajtowns/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajtowns/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajtowns/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajtowns/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/ajtowns/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajtowns/bitcoin/merges","archive_url":"https://api.github.com/repos/ajtowns/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajtowns/bitcoin/downloads","issues_url":"https://api.github.com/repos/ajtowns/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/ajtowns/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/ajtowns/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/ajtowns/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajtowns/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/ajtowns/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/ajtowns/bitcoin/deployments","created_at":"2016-03-15T12:11:24Z","updated_at":"2026-01-07T21:24:49Z","pushed_at":"2026-03-06T09:51:01Z","git_url":"git://github.com/ajtowns/bitcoin.git","ssh_url":"git@github.com:ajtowns/bitcoin.git","clone_url":"https://github.com/ajtowns/bitcoin.git","svn_url":"https://github.com/ajtowns/bitcoin","homepage":"https://bitcoin.org/en/download","size":337210,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"2eaf701bc0d5cfbb6bc458f467141451f2175cdf","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34730"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34730"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34730/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34730/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4ce720ba8738b480fbd9244776ce1c7b01fc591a"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729","id":3353080679,"node_id":"PR_kwDOABII587H2_Nn","html_url":"https://github.com/bitcoin/bitcoin/pull/34729","diff_url":"https://github.com/bitcoin/bitcoin/pull/34729.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34729.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34729","number":34729,"state":"open","locked":false,"title":"Reduce log noise","user":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This set of changes reduces some of the exaggerated logging that was introduced in #29236 when \"error()\" logging was upgraded from `LogPrintf` (aka `LogInfo`) to `LogError`. It also introduces `LogWarnThenDebug()` which duplicates the behaviour of #34549 which issues a warning the first time the log line is hit, but downgrades that to categorized debug messages afterwards. This function is used for failures that are likely caused by system configuration problems (so likely degrade the node's functionality and warrant admin attention) but are triggered by remote activity and thus could occur frequently.","created_at":"2026-03-04T11:56:05Z","updated_at":"2026-03-08T02:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4de69d529039b1049e8719c2cdd5d552ce1342f","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34729/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/c665935d02b633032147e58436e3a1c6511d64f3","head":{"label":"ajtowns:202603-logerror","ref":"202603-logerror","sha":"c665935d02b633032147e58436e3a1c6511d64f3","user":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":53941525,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk0MTUyNQ==","name":"bitcoin","full_name":"ajtowns/bitcoin","private":false,"owner":{"login":"ajtowns","id":127186,"node_id":"MDQ6VXNlcjEyNzE4Ng==","avatar_url":"https://avatars.githubusercontent.com/u/127186?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtowns","html_url":"https://github.com/ajtowns","followers_url":"https://api.github.com/users/ajtowns/followers","following_url":"https://api.github.com/users/ajtowns/following{/other_user}","gists_url":"https://api.github.com/users/ajtowns/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtowns/subscriptions","organizations_url":"https://api.github.com/users/ajtowns/orgs","repos_url":"https://api.github.com/users/ajtowns/repos","events_url":"https://api.github.com/users/ajtowns/events{/privacy}","received_events_url":"https://api.github.com/users/ajtowns/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/ajtowns/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/ajtowns/bitcoin","forks_url":"https://api.github.com/repos/ajtowns/bitcoin/forks","keys_url":"https://api.github.com/repos/ajtowns/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajtowns/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajtowns/bitcoin/teams","hooks_url":"https://api.github.com/repos/ajtowns/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/ajtowns/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/ajtowns/bitcoin/events","assignees_url":"https://api.github.com/repos/ajtowns/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/ajtowns/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/ajtowns/bitcoin/tags","blobs_url":"https://api.github.com/repos/ajtowns/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajtowns/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajtowns/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajtowns/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajtowns/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/ajtowns/bitcoin/languages","stargazers_url":"https://api.github.com/repos/ajtowns/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/ajtowns/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/ajtowns/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/ajtowns/bitcoin/subscription","commits_url":"https://api.github.com/repos/ajtowns/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajtowns/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajtowns/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajtowns/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajtowns/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/ajtowns/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajtowns/bitcoin/merges","archive_url":"https://api.github.com/repos/ajtowns/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajtowns/bitcoin/downloads","issues_url":"https://api.github.com/repos/ajtowns/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/ajtowns/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/ajtowns/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/ajtowns/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajtowns/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/ajtowns/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/ajtowns/bitcoin/deployments","created_at":"2016-03-15T12:11:24Z","updated_at":"2026-01-07T21:24:49Z","pushed_at":"2026-03-06T09:51:01Z","git_url":"git://github.com/ajtowns/bitcoin.git","ssh_url":"git@github.com:ajtowns/bitcoin.git","clone_url":"https://github.com/ajtowns/bitcoin.git","svn_url":"https://github.com/ajtowns/bitcoin","homepage":"https://bitcoin.org/en/download","size":337210,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"2eaf701bc0d5cfbb6bc458f467141451f2175cdf","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34729"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34729"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34729/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34729/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/c665935d02b633032147e58436e3a1c6511d64f3"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727","id":3351102387,"node_id":"PR_kwDOABII587HvcOz","html_url":"https://github.com/bitcoin/bitcoin/pull/34727","diff_url":"https://github.com/bitcoin/bitcoin/pull/34727.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34727.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34727","number":34727,"state":"open","locked":false,"title":"test: Add IPC wake-up test and reuse mining context","user":{"login":"enirox001","id":66912335,"node_id":"MDQ6VXNlcjY2OTEyMzM1","avatar_url":"https://avatars.githubusercontent.com/u/66912335?v=4","gravatar_id":"","url":"https://api.github.com/users/enirox001","html_url":"https://github.com/enirox001","followers_url":"https://api.github.com/users/enirox001/followers","following_url":"https://api.github.com/users/enirox001/following{/other_user}","gists_url":"https://api.github.com/users/enirox001/gists{/gist_id}","starred_url":"https://api.github.com/users/enirox001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enirox001/subscriptions","organizations_url":"https://api.github.com/users/enirox001/orgs","repos_url":"https://api.github.com/users/enirox001/repos","events_url":"https://api.github.com/users/enirox001/events{/privacy}","received_events_url":"https://api.github.com/users/enirox001/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"<!--\r\n*** Please remove the following help text before submitting: ***\r\n\r\nPull requests without a rationale and clear improvement may be closed\r\nimmediately.\r\n\r\nGUI-related pull requests should be opened against\r\nhttps://github.com/bitcoin-core/gui\r\nfirst. See CONTRIBUTING.md\r\n-->\r\n\r\n<!--\r\nPlease provide clear motivation for your patch and explain how it improves\r\nBitcoin Core user experience or Bitcoin Core developer experience\r\nsignificantly:\r\n\r\n* Any test improvements or new tests that improve coverage are always welcome.\r\n* All other changes should have accompanying unit tests (see `src/test/`) or\r\n  functional tests (see `test/`). Contributors should note which tests cover\r\n  modified code. If no tests exist for a region of modified code, new tests\r\n  should accompany the change.\r\n* Bug fixes are most welcome when they come with steps to reproduce or an\r\n  explanation of the potential issue as well as reasoning for the way the bug\r\n  was fixed.\r\n* Features are welcome, but might be rejected due to design or scope issues.\r\n  If a feature is based on a lot of dependencies, contributors should first\r\n  consider building the system outside of Bitcoin Core, if possible.\r\n* Refactoring changes are only accepted if they are required for a feature or\r\n  bug fix or otherwise improve developer experience significantly. For example,\r\n  most \"code style\" refactoring changes require a thorough explanation why they\r\n  are useful, what downsides they have and why they *significantly* improve\r\n  developer experience or avoid serious programming bugs. Note that code style\r\n  is often a subjective matter. Unless they are explicitly mentioned to be\r\n  preferred in the [developer notes](/doc/developer-notes.md), stylistic code\r\n  changes are usually rejected.\r\n-->\r\n\r\n<!--\r\nBitcoin Core has a thorough review process and even the most trivial change\r\nneeds to pass a lot of eyes and requires non-zero or even substantial time\r\neffort to review. There is a huge lack of active reviewers on the project, so\r\npatches often sit for a long time.\r\n-->\r\nThis is a follow-up to implement a couple of test improvements discussed in recent IPC PRs.\r\n\r\n- adds a test to interface_ipc_mining.py to verify that createNewBlock wakes up immediately when the tip advances, rather than waiting for the cooldown timer to expire (https://github.com/bitcoin/bitcoin/pull/34184#discussion_r2842239399).\r\n- moves make_mining_ctx into ipc_util.py so it can be reused across the IPC tests instead of duplicating the setup code (https://github.com/bitcoin/bitcoin/pull/34422#discussion_r2852445430).","created_at":"2026-03-03T23:59:07Z","updated_at":"2026-03-04T11:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd792d995ba61a23084dc18b0a36caf608acfb5","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34727/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1329a7d5cc27ee62efb15caac3c6164647df575a","head":{"label":"enirox001:03-26-ipctest-improv","ref":"03-26-ipctest-improv","sha":"1329a7d5cc27ee62efb15caac3c6164647df575a","user":{"login":"enirox001","id":66912335,"node_id":"MDQ6VXNlcjY2OTEyMzM1","avatar_url":"https://avatars.githubusercontent.com/u/66912335?v=4","gravatar_id":"","url":"https://api.github.com/users/enirox001","html_url":"https://github.com/enirox001","followers_url":"https://api.github.com/users/enirox001/followers","following_url":"https://api.github.com/users/enirox001/following{/other_user}","gists_url":"https://api.github.com/users/enirox001/gists{/gist_id}","starred_url":"https://api.github.com/users/enirox001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enirox001/subscriptions","organizations_url":"https://api.github.com/users/enirox001/orgs","repos_url":"https://api.github.com/users/enirox001/repos","events_url":"https://api.github.com/users/enirox001/events{/privacy}","received_events_url":"https://api.github.com/users/enirox001/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":949079120,"node_id":"R_kgDOOJHMUA","name":"bitcoin","full_name":"enirox001/bitcoin","private":false,"owner":{"login":"enirox001","id":66912335,"node_id":"MDQ6VXNlcjY2OTEyMzM1","avatar_url":"https://avatars.githubusercontent.com/u/66912335?v=4","gravatar_id":"","url":"https://api.github.com/users/enirox001","html_url":"https://github.com/enirox001","followers_url":"https://api.github.com/users/enirox001/followers","following_url":"https://api.github.com/users/enirox001/following{/other_user}","gists_url":"https://api.github.com/users/enirox001/gists{/gist_id}","starred_url":"https://api.github.com/users/enirox001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enirox001/subscriptions","organizations_url":"https://api.github.com/users/enirox001/orgs","repos_url":"https://api.github.com/users/enirox001/repos","events_url":"https://api.github.com/users/enirox001/events{/privacy}","received_events_url":"https://api.github.com/users/enirox001/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/enirox001/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/enirox001/bitcoin","forks_url":"https://api.github.com/repos/enirox001/bitcoin/forks","keys_url":"https://api.github.com/repos/enirox001/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enirox001/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enirox001/bitcoin/teams","hooks_url":"https://api.github.com/repos/enirox001/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/enirox001/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/enirox001/bitcoin/events","assignees_url":"https://api.github.com/repos/enirox001/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/enirox001/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/enirox001/bitcoin/tags","blobs_url":"https://api.github.com/repos/enirox001/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enirox001/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enirox001/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/enirox001/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enirox001/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/enirox001/bitcoin/languages","stargazers_url":"https://api.github.com/repos/enirox001/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/enirox001/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/enirox001/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/enirox001/bitcoin/subscription","commits_url":"https://api.github.com/repos/enirox001/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/enirox001/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/enirox001/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/enirox001/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/enirox001/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/enirox001/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enirox001/bitcoin/merges","archive_url":"https://api.github.com/repos/enirox001/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enirox001/bitcoin/downloads","issues_url":"https://api.github.com/repos/enirox001/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/enirox001/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/enirox001/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/enirox001/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enirox001/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/enirox001/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/enirox001/bitcoin/deployments","created_at":"2025-03-15T16:19:26Z","updated_at":"2026-03-03T22:39:10Z","pushed_at":"2026-03-04T10:23:13Z","git_url":"git://github.com/enirox001/bitcoin.git","ssh_url":"git@github.com:enirox001/bitcoin.git","clone_url":"https://github.com/enirox001/bitcoin.git","svn_url":"https://github.com/enirox001/bitcoin","homepage":"https://bitcoincore.org/en/download","size":262540,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"17a04039bc5befd51c2f96daf081e9e4a8ed7bff","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34727"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34727"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34727/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34727/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1329a7d5cc27ee62efb15caac3c6164647df575a"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726","id":3350769984,"node_id":"PR_kwDOABII587HuLFA","html_url":"https://github.com/bitcoin/bitcoin/pull/34726","diff_url":"https://github.com/bitcoin/bitcoin/pull/34726.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34726.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34726","number":34726,"state":"open","locked":false,"title":"[wip] ignore 2603 ci empty","user":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"body":null,"created_at":"2026-03-03T21:54:50Z","updated_at":"2026-03-04T03:21:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34a89eb1675672bbc1f7c156c19bb57384f72e26","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":5334691551,"node_id":"LA_kwDOABII588AAAABPfju3w","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/CI%20failed","name":"CI failed","color":"cccccc","default":false,"description":""}],"milestone":null,"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34726/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/de71c9adfb777d3bbfc7b88e06f2f61db0030bf8","head":{"label":"maflcko:2603-ci-empty","ref":"2603-ci-empty","sha":"de71c9adfb777d3bbfc7b88e06f2f61db0030bf8","user":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":40046254,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA0NjI1NA==","name":"bitcoin-core","full_name":"maflcko/bitcoin-core","private":false,"owner":{"login":"maflcko","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/maflcko","html_url":"https://github.com/maflcko","followers_url":"https://api.github.com/users/maflcko/followers","following_url":"https://api.github.com/users/maflcko/following{/other_user}","gists_url":"https://api.github.com/users/maflcko/gists{/gist_id}","starred_url":"https://api.github.com/users/maflcko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maflcko/subscriptions","organizations_url":"https://api.github.com/users/maflcko/orgs","repos_url":"https://api.github.com/users/maflcko/repos","events_url":"https://api.github.com/users/maflcko/events{/privacy}","received_events_url":"https://api.github.com/users/maflcko/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/maflcko/bitcoin-core","description":null,"fork":true,"url":"https://api.github.com/repos/maflcko/bitcoin-core","forks_url":"https://api.github.com/repos/maflcko/bitcoin-core/forks","keys_url":"https://api.github.com/repos/maflcko/bitcoin-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maflcko/bitcoin-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maflcko/bitcoin-core/teams","hooks_url":"https://api.github.com/repos/maflcko/bitcoin-core/hooks","issue_events_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues/events{/number}","events_url":"https://api.github.com/repos/maflcko/bitcoin-core/events","assignees_url":"https://api.github.com/repos/maflcko/bitcoin-core/assignees{/user}","branches_url":"https://api.github.com/repos/maflcko/bitcoin-core/branches{/branch}","tags_url":"https://api.github.com/repos/maflcko/bitcoin-core/tags","blobs_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maflcko/bitcoin-core/statuses/{sha}","languages_url":"https://api.github.com/repos/maflcko/bitcoin-core/languages","stargazers_url":"https://api.github.com/repos/maflcko/bitcoin-core/stargazers","contributors_url":"https://api.github.com/repos/maflcko/bitcoin-core/contributors","subscribers_url":"https://api.github.com/repos/maflcko/bitcoin-core/subscribers","subscription_url":"https://api.github.com/repos/maflcko/bitcoin-core/subscription","commits_url":"https://api.github.com/repos/maflcko/bitcoin-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/maflcko/bitcoin-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/maflcko/bitcoin-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/maflcko/bitcoin-core/contents/{+path}","compare_url":"https://api.github.com/repos/maflcko/bitcoin-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maflcko/bitcoin-core/merges","archive_url":"https://api.github.com/repos/maflcko/bitcoin-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maflcko/bitcoin-core/downloads","issues_url":"https://api.github.com/repos/maflcko/bitcoin-core/issues{/number}","pulls_url":"https://api.github.com/repos/maflcko/bitcoin-core/pulls{/number}","milestones_url":"https://api.github.com/repos/maflcko/bitcoin-core/milestones{/number}","notifications_url":"https://api.github.com/repos/maflcko/bitcoin-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maflcko/bitcoin-core/labels{/name}","releases_url":"https://api.github.com/repos/maflcko/bitcoin-core/releases{/id}","deployments_url":"https://api.github.com/repos/maflcko/bitcoin-core/deployments","created_at":"2015-08-01T12:42:47Z","updated_at":"2026-02-26T13:42:10Z","pushed_at":"2026-03-05T12:28:26Z","git_url":"git://github.com/maflcko/bitcoin-core.git","ssh_url":"git@github.com:maflcko/bitcoin-core.git","clone_url":"https://github.com/maflcko/bitcoin-core.git","svn_url":"https://github.com/maflcko/bitcoin-core","homepage":"","size":271768,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":10,"open_issues":13,"watchers":26,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"bf9ef4f0433551e850a11c2da8baae0ec6439a99","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34726"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34726"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34726/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34726/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/de71c9adfb777d3bbfc7b88e06f2f61db0030bf8"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722","id":3349920959,"node_id":"PR_kwDOABII587Hq7y_","html_url":"https://github.com/bitcoin/bitcoin/pull/34722","diff_url":"https://github.com/bitcoin/bitcoin/pull/34722.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34722.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34722","number":34722,"state":"open","locked":false,"title":"test: cover requested far-ahead cmpctblock getdata retry","user":{"login":"shuv-amp","id":63120087,"node_id":"MDQ6VXNlcjYzMTIwMDg3","avatar_url":"https://avatars.githubusercontent.com/u/63120087?v=4","gravatar_id":"","url":"https://api.github.com/users/shuv-amp","html_url":"https://github.com/shuv-amp","followers_url":"https://api.github.com/users/shuv-amp/followers","following_url":"https://api.github.com/users/shuv-amp/following{/other_user}","gists_url":"https://api.github.com/users/shuv-amp/gists{/gist_id}","starred_url":"https://api.github.com/users/shuv-amp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuv-amp/subscriptions","organizations_url":"https://api.github.com/users/shuv-amp/orgs","repos_url":"https://api.github.com/users/shuv-amp/repos","events_url":"https://api.github.com/users/shuv-amp/events{/privacy}","received_events_url":"https://api.github.com/users/shuv-amp/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This updates coverage in `test/functional/p2p_compactblocks.py` for the\r\nrequested far-ahead `CMPCTBLOCK` path.\r\n\r\nThe test now targets a discriminating invariant:\r\n\r\n1. Build a 3-block extension from tip.\r\n2. Send `HEADERS` for all 3 blocks so block 3 is already requested from the\r\n   same peer.\r\n3. Send `CMPCTBLOCK` for block 3.\r\n4. Assert the node sends one additional `getdata` for block 3 (retry path).\r\n\r\nThe precondition waits on per-hash `getdata` counters under `p2p_lock`, so it\r\ndoes not depend on all inventory entries arriving in a single `getdata`\r\nmessage.\r\n\r\nThis distinguishes current behavior from the #34618 removal diff:\r\n- current code: pass\r\n- with #34618 removal diff applied to `src/net_processing.cpp`: fail at\r\n  `saw_exactly_one_retry` timeout\r\n\r\nTested:\r\n- `python3 test/functional/p2p_compactblocks.py --configfile=build/test/config.ini` (pass)\r\n- apply local #34618 removal diff in `src/net_processing.cpp`, rebuild, rerun same test (fails at `saw_exactly_one_retry`)\r\n- revert `src/net_processing.cpp`, rebuild\r\n\r\nRef #34618\r\n","created_at":"2026-03-03T17:34:28Z","updated_at":"2026-03-04T23:18:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbffcfb1beef969b2f8d49c1343be23c7ede8bbf","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"node_id":"MDU6TGFiZWw2Mjk2MzUxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34722/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3fdbd8d9dbaf3fca1c79c6ff7f07536c2838325a","head":{"label":"shuv-amp:test-cmpctblock-revert-to-header-processing","ref":"test-cmpctblock-revert-to-header-processing","sha":"3fdbd8d9dbaf3fca1c79c6ff7f07536c2838325a","user":{"login":"shuv-amp","id":63120087,"node_id":"MDQ6VXNlcjYzMTIwMDg3","avatar_url":"https://avatars.githubusercontent.com/u/63120087?v=4","gravatar_id":"","url":"https://api.github.com/users/shuv-amp","html_url":"https://github.com/shuv-amp","followers_url":"https://api.github.com/users/shuv-amp/followers","following_url":"https://api.github.com/users/shuv-amp/following{/other_user}","gists_url":"https://api.github.com/users/shuv-amp/gists{/gist_id}","starred_url":"https://api.github.com/users/shuv-amp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuv-amp/subscriptions","organizations_url":"https://api.github.com/users/shuv-amp/orgs","repos_url":"https://api.github.com/users/shuv-amp/repos","events_url":"https://api.github.com/users/shuv-amp/events{/privacy}","received_events_url":"https://api.github.com/users/shuv-amp/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":1168427283,"node_id":"R_kgDORaTJEw","name":"bitcoin","full_name":"shuv-amp/bitcoin","private":false,"owner":{"login":"shuv-amp","id":63120087,"node_id":"MDQ6VXNlcjYzMTIwMDg3","avatar_url":"https://avatars.githubusercontent.com/u/63120087?v=4","gravatar_id":"","url":"https://api.github.com/users/shuv-amp","html_url":"https://github.com/shuv-amp","followers_url":"https://api.github.com/users/shuv-amp/followers","following_url":"https://api.github.com/users/shuv-amp/following{/other_user}","gists_url":"https://api.github.com/users/shuv-amp/gists{/gist_id}","starred_url":"https://api.github.com/users/shuv-amp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuv-amp/subscriptions","organizations_url":"https://api.github.com/users/shuv-amp/orgs","repos_url":"https://api.github.com/users/shuv-amp/repos","events_url":"https://api.github.com/users/shuv-amp/events{/privacy}","received_events_url":"https://api.github.com/users/shuv-amp/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/shuv-amp/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/shuv-amp/bitcoin","forks_url":"https://api.github.com/repos/shuv-amp/bitcoin/forks","keys_url":"https://api.github.com/repos/shuv-amp/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuv-amp/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuv-amp/bitcoin/teams","hooks_url":"https://api.github.com/repos/shuv-amp/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/shuv-amp/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/shuv-amp/bitcoin/events","assignees_url":"https://api.github.com/repos/shuv-amp/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/shuv-amp/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/shuv-amp/bitcoin/tags","blobs_url":"https://api.github.com/repos/shuv-amp/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuv-amp/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuv-amp/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuv-amp/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuv-amp/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/shuv-amp/bitcoin/languages","stargazers_url":"https://api.github.com/repos/shuv-amp/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/shuv-amp/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/shuv-amp/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/shuv-amp/bitcoin/subscription","commits_url":"https://api.github.com/repos/shuv-amp/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuv-amp/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuv-amp/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuv-amp/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuv-amp/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/shuv-amp/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuv-amp/bitcoin/merges","archive_url":"https://api.github.com/repos/shuv-amp/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuv-amp/bitcoin/downloads","issues_url":"https://api.github.com/repos/shuv-amp/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/shuv-amp/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/shuv-amp/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/shuv-amp/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuv-amp/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/shuv-amp/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/shuv-amp/bitcoin/deployments","created_at":"2026-02-27T11:28:01Z","updated_at":"2026-03-03T17:22:49Z","pushed_at":"2026-03-08T00:51:56Z","git_url":"git://github.com/shuv-amp/bitcoin.git","ssh_url":"git@github.com:shuv-amp/bitcoin.git","clone_url":"https://github.com/shuv-amp/bitcoin.git","svn_url":"https://github.com/shuv-amp/bitcoin","homepage":"https://bitcoincore.org/en/download","size":262688,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"083242aac81d02b6547ca37e0b4e6f37e0e89d87","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34722"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34722"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34722/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34722/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3fdbd8d9dbaf3fca1c79c6ff7f07536c2838325a"}},"author_association":"NONE","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721","id":3349161644,"node_id":"PR_kwDOABII587HoCas","html_url":"https://github.com/bitcoin/bitcoin/pull/34721","diff_url":"https://github.com/bitcoin/bitcoin/pull/34721.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34721.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34721","number":34721,"state":"open","locked":false,"title":"build: install shell completions via cmake","user":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Fixes: #34714\r\n\r\nPackagers currently need to manually copy shell completion scripts from contrib/completions/ into the appropriate system directories.\r\n\r\nInstall bash and fish completions alongside their corresponding binaries as part of install_binary_component(), following the same pattern used for man pages. Completion files are automatically detected per component and installed to the standard locations:\r\n- bash: ${datadir}/bash-completion/completions/\r\n- fish: ${datadir}/fish/vendor_completions.d/\r\n\r\nEnabled by default. Can be disabled with -DINSTALL_COMPLETIONS=OFF. (This matches INSTALL_MAN default)","created_at":"2026-03-03T14:33:24Z","updated_at":"2026-03-04T18:30:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d981456a38dbe7576e6678f3872485af255d5f05","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":61889416,"node_id":"MDU6TGFiZWw2MTg4OTQxNg==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Build%20system","name":"Build system","color":"5319e7","default":false,"description":null}],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34721/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0a2d2cd11655b75b629992acb54dd2a572759fb0","head":{"label":"willcl-ark:cmake-shell-completions","ref":"cmake-shell-completions","sha":"0a2d2cd11655b75b629992acb54dd2a572759fb0","user":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":164122552,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxMjI1NTI=","name":"bitcoin","full_name":"willcl-ark/bitcoin","private":false,"owner":{"login":"willcl-ark","id":6606587,"node_id":"MDQ6VXNlcjY2MDY1ODc=","avatar_url":"https://avatars.githubusercontent.com/u/6606587?v=4","gravatar_id":"","url":"https://api.github.com/users/willcl-ark","html_url":"https://github.com/willcl-ark","followers_url":"https://api.github.com/users/willcl-ark/followers","following_url":"https://api.github.com/users/willcl-ark/following{/other_user}","gists_url":"https://api.github.com/users/willcl-ark/gists{/gist_id}","starred_url":"https://api.github.com/users/willcl-ark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willcl-ark/subscriptions","organizations_url":"https://api.github.com/users/willcl-ark/orgs","repos_url":"https://api.github.com/users/willcl-ark/repos","events_url":"https://api.github.com/users/willcl-ark/events{/privacy}","received_events_url":"https://api.github.com/users/willcl-ark/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/willcl-ark/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/willcl-ark/bitcoin","forks_url":"https://api.github.com/repos/willcl-ark/bitcoin/forks","keys_url":"https://api.github.com/repos/willcl-ark/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willcl-ark/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willcl-ark/bitcoin/teams","hooks_url":"https://api.github.com/repos/willcl-ark/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/willcl-ark/bitcoin/events","assignees_url":"https://api.github.com/repos/willcl-ark/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/willcl-ark/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/willcl-ark/bitcoin/tags","blobs_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willcl-ark/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/willcl-ark/bitcoin/languages","stargazers_url":"https://api.github.com/repos/willcl-ark/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/willcl-ark/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/willcl-ark/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/willcl-ark/bitcoin/subscription","commits_url":"https://api.github.com/repos/willcl-ark/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/willcl-ark/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/willcl-ark/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/willcl-ark/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/willcl-ark/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willcl-ark/bitcoin/merges","archive_url":"https://api.github.com/repos/willcl-ark/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willcl-ark/bitcoin/downloads","issues_url":"https://api.github.com/repos/willcl-ark/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/willcl-ark/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/willcl-ark/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/willcl-ark/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willcl-ark/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/willcl-ark/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/willcl-ark/bitcoin/deployments","created_at":"2019-01-04T15:17:29Z","updated_at":"2026-03-07T04:02:35Z","pushed_at":"2026-03-07T04:02:25Z","git_url":"git://github.com/willcl-ark/bitcoin.git","ssh_url":"git@github.com:willcl-ark/bitcoin.git","clone_url":"https://github.com/willcl-ark/bitcoin.git","svn_url":"https://github.com/willcl-ark/bitcoin","homepage":"https://bitcoincore.org/en/download","size":303914,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":true,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":2,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"2702711c3a54b2ba9ae3781b61c90d28ee951de6","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34721"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34721"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34721/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34721/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0a2d2cd11655b75b629992acb54dd2a572759fb0"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718","id":3348606555,"node_id":"PR_kwDOABII587Hl65b","html_url":"https://github.com/bitcoin/bitcoin/pull/34718","diff_url":"https://github.com/bitcoin/bitcoin/pull/34718.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34718.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34718","number":34718,"state":"open","locked":false,"title":"Release: 31.0 translations update","user":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This PR follows our [Release Process](https://github.com/bitcoin/bitcoin/blob/24699fec8422a4d9219f8c5272370351e7adea7f/doc/release-process.md) and concludes the translation-specific efforts for this release cycle. It follows two previous translation-related PRs, https://github.com/bitcoin/bitcoin/pull/34525 and https://github.com/bitcoin-core/gui/pull/931.\r\n\r\nIt is one of the steps required _before_ branch-off, as scheduled in https://github.com/bitcoin/bitcoin/issues/33607.\r\n\r\nA previous similar PR: https://github.com/bitcoin/bitcoin/pull/33275.\r\n\r\n**A Note for reviewers:**\r\nThe actual translations on Transifex is a moving target. As a result, your diff after running [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) may differ.","created_at":"2026-03-03T12:20:27Z","updated_at":"2026-03-04T11:02:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4716e7f5948de8e5fde538c522b0a8b5ef874729","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135946,"node_id":"MDU6TGFiZWwxMzU5NDY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/GUI","name":"GUI","color":"02d7e1","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74","html_url":"https://github.com/bitcoin/bitcoin/milestone/74","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74/labels","id":12610874,"node_id":"MI_kwDOABII584AwG06","number":74,"title":"31.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":11,"closed_issues":102,"state":"open","created_at":"2025-03-25T18:44:16Z","updated_at":"2026-03-06T21:29:25Z","due_on":null,"closed_at":null},"draft":true,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34718/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0674d9237a20bb89dea418cccd72e90eecef718b","head":{"label":"hebasto:260303-tr","ref":"260303-tr","sha":"0674d9237a20bb89dea418cccd72e90eecef718b","user":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":143212778,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMTI3Nzg=","name":"bitcoin","full_name":"hebasto/bitcoin","private":false,"owner":{"login":"hebasto","id":32963518,"node_id":"MDQ6VXNlcjMyOTYzNTE4","avatar_url":"https://avatars.githubusercontent.com/u/32963518?v=4","gravatar_id":"","url":"https://api.github.com/users/hebasto","html_url":"https://github.com/hebasto","followers_url":"https://api.github.com/users/hebasto/followers","following_url":"https://api.github.com/users/hebasto/following{/other_user}","gists_url":"https://api.github.com/users/hebasto/gists{/gist_id}","starred_url":"https://api.github.com/users/hebasto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebasto/subscriptions","organizations_url":"https://api.github.com/users/hebasto/orgs","repos_url":"https://api.github.com/users/hebasto/repos","events_url":"https://api.github.com/users/hebasto/events{/privacy}","received_events_url":"https://api.github.com/users/hebasto/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/hebasto/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/hebasto/bitcoin","forks_url":"https://api.github.com/repos/hebasto/bitcoin/forks","keys_url":"https://api.github.com/repos/hebasto/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hebasto/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hebasto/bitcoin/teams","hooks_url":"https://api.github.com/repos/hebasto/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/hebasto/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/hebasto/bitcoin/events","assignees_url":"https://api.github.com/repos/hebasto/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/hebasto/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/hebasto/bitcoin/tags","blobs_url":"https://api.github.com/repos/hebasto/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hebasto/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hebasto/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hebasto/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hebasto/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/hebasto/bitcoin/languages","stargazers_url":"https://api.github.com/repos/hebasto/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/hebasto/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/hebasto/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/hebasto/bitcoin/subscription","commits_url":"https://api.github.com/repos/hebasto/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hebasto/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hebasto/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hebasto/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hebasto/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/hebasto/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hebasto/bitcoin/merges","archive_url":"https://api.github.com/repos/hebasto/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hebasto/bitcoin/downloads","issues_url":"https://api.github.com/repos/hebasto/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/hebasto/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/hebasto/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/hebasto/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hebasto/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/hebasto/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/hebasto/bitcoin/deployments","created_at":"2018-08-01T21:59:57Z","updated_at":"2026-03-07T20:03:49Z","pushed_at":"2026-03-07T20:37:44Z","git_url":"git://github.com/hebasto/bitcoin.git","ssh_url":"git@github.com:hebasto/bitcoin.git","clone_url":"https://github.com/hebasto/bitcoin.git","svn_url":"https://github.com/hebasto/bitcoin","homepage":"https://bitcoincore.org/en/download","size":335593,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin-core"],"visibility":"public","forks":6,"open_issues":0,"watchers":25,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"2702711c3a54b2ba9ae3781b61c90d28ee951de6","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34718"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34718"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34718/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34718/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/0674d9237a20bb89dea418cccd72e90eecef718b"}},"author_association":"MEMBER","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717","id":3348549752,"node_id":"PR_kwDOABII587HltB4","html_url":"https://github.com/bitcoin/bitcoin/pull/34717","diff_url":"https://github.com/bitcoin/bitcoin/pull/34717.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34717.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34717","number":34717,"state":"open","locked":false,"title":"p2p: remove m_getaddr_sent","user":{"login":"naiyoma","id":40592031,"node_id":"MDQ6VXNlcjQwNTkyMDMx","avatar_url":"https://avatars.githubusercontent.com/u/40592031?v=4","gravatar_id":"","url":"https://api.github.com/users/naiyoma","html_url":"https://github.com/naiyoma","followers_url":"https://api.github.com/users/naiyoma/followers","following_url":"https://api.github.com/users/naiyoma/following{/other_user}","gists_url":"https://api.github.com/users/naiyoma/gists{/gist_id}","starred_url":"https://api.github.com/users/naiyoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naiyoma/subscriptions","organizations_url":"https://api.github.com/users/naiyoma/orgs","repos_url":"https://api.github.com/users/naiyoma/repos","events_url":"https://api.github.com/users/naiyoma/events{/privacy}","received_events_url":"https://api.github.com/users/naiyoma/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This PR removes `m_getaddr_sent`, as it no longer behaves as originally intended. Initially, this flag was meant to track when a getaddr message was sent to a peer.\r\n\r\nNow that self-announcements are sent separately from getaddr responses, the self-announcement sets `m_getaddr_sent `to `false` even though we are still waiting for the getaddr response (1000 addresses). \r\nWhen the getaddr response does arrive, we rely on the size of the addr message, not the flag, to decide whether it should be relayed. This makes the flag redundant.\r\n\r\nThis is the current behavior:\r\n\r\n- The initial self-announcement is not relayed but it flips m_getaddr_sent to be false\r\n- We use addr.size() to avoid relaying  (1000) getaddr response.(assuming the other two flags are false) \r\n- The first addr message is relayed because the flag is  false(this was not the case before https://github.com/bitcoin/bitcoin/pull/34146).\r\n\r\nRemoving this flag ensures that:\r\n\r\n- The initial self-announcement is relayed.\r\n- The getaddr response is still not relayed, using the existing size-based check.\r\n\r\nI had initially considered an alternative approach https://github.com/naiyoma/bitcoin/pull/14, where the self-announcement would not affect this flag and would therefore retain the initial behaviour, but i decided to reattempt its removal, as this was previously attempted, see https://github.com/bitcoin/bitcoin/pull/19794. Given the changes since then, I believe revisiting it is now more appropriate.\r\n","created_at":"2026-03-03T12:04:38Z","updated_at":"2026-03-06T17:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7839c4094e65409b4a6afd8cfdaa055214cb39e","assignees":[],"requested_reviewers":[{"login":"stratospher","id":44024636,"node_id":"MDQ6VXNlcjQ0MDI0NjM2","avatar_url":"https://avatars.githubusercontent.com/u/44024636?v=4","gravatar_id":"","url":"https://api.github.com/users/stratospher","html_url":"https://github.com/stratospher","followers_url":"https://api.github.com/users/stratospher/followers","following_url":"https://api.github.com/users/stratospher/following{/other_user}","gists_url":"https://api.github.com/users/stratospher/gists{/gist_id}","starred_url":"https://api.github.com/users/stratospher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratospher/subscriptions","organizations_url":"https://api.github.com/users/stratospher/orgs","repos_url":"https://api.github.com/users/stratospher/repos","events_url":"https://api.github.com/users/stratospher/events{/privacy}","received_events_url":"https://api.github.com/users/stratospher/received_events","type":"User","user_view_type":"public","site_admin":false},{"login":"mzumsande","id":48763452,"node_id":"MDQ6VXNlcjQ4NzYzNDUy","avatar_url":"https://avatars.githubusercontent.com/u/48763452?v=4","gravatar_id":"","url":"https://api.github.com/users/mzumsande","html_url":"https://github.com/mzumsande","followers_url":"https://api.github.com/users/mzumsande/followers","following_url":"https://api.github.com/users/mzumsande/following{/other_user}","gists_url":"https://api.github.com/users/mzumsande/gists{/gist_id}","starred_url":"https://api.github.com/users/mzumsande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzumsande/subscriptions","organizations_url":"https://api.github.com/users/mzumsande/orgs","repos_url":"https://api.github.com/users/mzumsande/repos","events_url":"https://api.github.com/users/mzumsande/events{/privacy}","received_events_url":"https://api.github.com/users/mzumsande/received_events","type":"User","user_view_type":"public","site_admin":false}],"requested_teams":[],"labels":[{"id":98298007,"node_id":"MDU6TGFiZWw5ODI5ODAwNw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74","html_url":"https://github.com/bitcoin/bitcoin/milestone/74","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/74/labels","id":12610874,"node_id":"MI_kwDOABII584AwG06","number":74,"title":"31.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":11,"closed_issues":102,"state":"open","created_at":"2025-03-25T18:44:16Z","updated_at":"2026-03-06T21:29:25Z","due_on":null,"closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34717/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b5914990464e581731f8214c0ff1c3cb6b58cb94","head":{"label":"naiyoma:2026_1/m_getaddr_sent","ref":"2026_1/m_getaddr_sent","sha":"b5914990464e581731f8214c0ff1c3cb6b58cb94","user":{"login":"naiyoma","id":40592031,"node_id":"MDQ6VXNlcjQwNTkyMDMx","avatar_url":"https://avatars.githubusercontent.com/u/40592031?v=4","gravatar_id":"","url":"https://api.github.com/users/naiyoma","html_url":"https://github.com/naiyoma","followers_url":"https://api.github.com/users/naiyoma/followers","following_url":"https://api.github.com/users/naiyoma/following{/other_user}","gists_url":"https://api.github.com/users/naiyoma/gists{/gist_id}","starred_url":"https://api.github.com/users/naiyoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naiyoma/subscriptions","organizations_url":"https://api.github.com/users/naiyoma/orgs","repos_url":"https://api.github.com/users/naiyoma/repos","events_url":"https://api.github.com/users/naiyoma/events{/privacy}","received_events_url":"https://api.github.com/users/naiyoma/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":685023327,"node_id":"R_kgDOKNSgXw","name":"bitcoin","full_name":"naiyoma/bitcoin","private":false,"owner":{"login":"naiyoma","id":40592031,"node_id":"MDQ6VXNlcjQwNTkyMDMx","avatar_url":"https://avatars.githubusercontent.com/u/40592031?v=4","gravatar_id":"","url":"https://api.github.com/users/naiyoma","html_url":"https://github.com/naiyoma","followers_url":"https://api.github.com/users/naiyoma/followers","following_url":"https://api.github.com/users/naiyoma/following{/other_user}","gists_url":"https://api.github.com/users/naiyoma/gists{/gist_id}","starred_url":"https://api.github.com/users/naiyoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naiyoma/subscriptions","organizations_url":"https://api.github.com/users/naiyoma/orgs","repos_url":"https://api.github.com/users/naiyoma/repos","events_url":"https://api.github.com/users/naiyoma/events{/privacy}","received_events_url":"https://api.github.com/users/naiyoma/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/naiyoma/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/naiyoma/bitcoin","forks_url":"https://api.github.com/repos/naiyoma/bitcoin/forks","keys_url":"https://api.github.com/repos/naiyoma/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naiyoma/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naiyoma/bitcoin/teams","hooks_url":"https://api.github.com/repos/naiyoma/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/naiyoma/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/naiyoma/bitcoin/events","assignees_url":"https://api.github.com/repos/naiyoma/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/naiyoma/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/naiyoma/bitcoin/tags","blobs_url":"https://api.github.com/repos/naiyoma/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naiyoma/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naiyoma/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/naiyoma/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naiyoma/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/naiyoma/bitcoin/languages","stargazers_url":"https://api.github.com/repos/naiyoma/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/naiyoma/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/naiyoma/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/naiyoma/bitcoin/subscription","commits_url":"https://api.github.com/repos/naiyoma/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/naiyoma/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/naiyoma/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/naiyoma/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/naiyoma/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/naiyoma/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naiyoma/bitcoin/merges","archive_url":"https://api.github.com/repos/naiyoma/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naiyoma/bitcoin/downloads","issues_url":"https://api.github.com/repos/naiyoma/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/naiyoma/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/naiyoma/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/naiyoma/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naiyoma/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/naiyoma/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/naiyoma/bitcoin/deployments","created_at":"2023-08-30T10:54:44Z","updated_at":"2026-02-10T10:28:22Z","pushed_at":"2026-03-06T10:55:00Z","git_url":"git://github.com/naiyoma/bitcoin.git","ssh_url":"git@github.com:naiyoma/bitcoin.git","clone_url":"https://github.com/naiyoma/bitcoin.git","svn_url":"https://github.com/naiyoma/bitcoin","homepage":"https://bitcoincore.org/en/download","size":259932,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c0802e20be2e2b2f4805dae52406401f3ee60d4b","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34717"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34717"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34717/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34717/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/b5914990464e581731f8214c0ff1c3cb6b58cb94"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null},{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708","id":3342587092,"node_id":"PR_kwDOABII587HO9TU","html_url":"https://github.com/bitcoin/bitcoin/pull/34708","diff_url":"https://github.com/bitcoin/bitcoin/pull/34708.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/34708.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34708","number":34708,"state":"open","locked":false,"title":"validation: refactor: remove ConnectTrace","user":{"login":"stickies-v","id":69010457,"node_id":"MDQ6VXNlcjY5MDEwNDU3","avatar_url":"https://avatars.githubusercontent.com/u/69010457?v=4","gravatar_id":"","url":"https://api.github.com/users/stickies-v","html_url":"https://github.com/stickies-v","followers_url":"https://api.github.com/users/stickies-v/followers","following_url":"https://api.github.com/users/stickies-v/following{/other_user}","gists_url":"https://api.github.com/users/stickies-v/gists{/gist_id}","starred_url":"https://api.github.com/users/stickies-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickies-v/subscriptions","organizations_url":"https://api.github.com/users/stickies-v/orgs","repos_url":"https://api.github.com/users/stickies-v/repos","events_url":"https://api.github.com/users/stickies-v/events{/privacy}","received_events_url":"https://api.github.com/users/stickies-v/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The sentinel pattern in `ConnectTrace` has been unnecessary since conflicted transaction tracking was removed in 5613f9842b4000fed088b8cf7b99674c328d15e1. Without that tracking `ConnectTrace` is a trivial wrapper around `std::vector`, so it seems better to just replace it with the vector directly.\r\n\r\nAlso modernize/update naming along the way, renaming `PerBlockConnectTrace` to `ConnectedBlock`\r\n\r\nRefactor, no behaviour change.","created_at":"2026-03-02T05:21:46Z","updated_at":"2026-03-07T04:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5e20200d661f06c1fd992bcf1354944e541bf4e","assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118379652,"node_id":"MDU6TGFiZWwxMTgzNzk2NTI=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa","default":false,"description":null}],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/84","html_url":"https://github.com/bitcoin/bitcoin/milestone/84","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/84/labels","id":14878840,"node_id":"MI_kwDOABII584A4wh4","number":84,"title":"32.0","description":null,"creator":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","user_view_type":"public","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2026-02-20T12:46:51Z","updated_at":"2026-03-05T09:32:16Z","due_on":null,"closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/34708/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2f8f2e900118c98699db91075bd1b72e6460c6b1","head":{"label":"stickies-v:2026-03/connecttrace-rvalue","ref":"2026-03/connecttrace-rvalue","sha":"2f8f2e900118c98699db91075bd1b72e6460c6b1","user":{"login":"stickies-v","id":69010457,"node_id":"MDQ6VXNlcjY5MDEwNDU3","avatar_url":"https://avatars.githubusercontent.com/u/69010457?v=4","gravatar_id":"","url":"https://api.github.com/users/stickies-v","html_url":"https://github.com/stickies-v","followers_url":"https://api.github.com/users/stickies-v/followers","following_url":"https://api.github.com/users/stickies-v/following{/other_user}","gists_url":"https://api.github.com/users/stickies-v/gists{/gist_id}","starred_url":"https://api.github.com/users/stickies-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickies-v/subscriptions","organizations_url":"https://api.github.com/users/stickies-v/orgs","repos_url":"https://api.github.com/users/stickies-v/repos","events_url":"https://api.github.com/users/stickies-v/events{/privacy}","received_events_url":"https://api.github.com/users/stickies-v/received_events","type":"User","user_view_type":"public","site_admin":false},"repo":{"id":431644530,"node_id":"R_kgDOGbpfcg","name":"bitcoin","full_name":"stickies-v/bitcoin","private":false,"owner":{"login":"stickies-v","id":69010457,"node_id":"MDQ6VXNlcjY5MDEwNDU3","avatar_url":"https://avatars.githubusercontent.com/u/69010457?v=4","gravatar_id":"","url":"https://api.github.com/users/stickies-v","html_url":"https://github.com/stickies-v","followers_url":"https://api.github.com/users/stickies-v/followers","following_url":"https://api.github.com/users/stickies-v/following{/other_user}","gists_url":"https://api.github.com/users/stickies-v/gists{/gist_id}","starred_url":"https://api.github.com/users/stickies-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickies-v/subscriptions","organizations_url":"https://api.github.com/users/stickies-v/orgs","repos_url":"https://api.github.com/users/stickies-v/repos","events_url":"https://api.github.com/users/stickies-v/events{/privacy}","received_events_url":"https://api.github.com/users/stickies-v/received_events","type":"User","user_view_type":"public","site_admin":false},"html_url":"https://github.com/stickies-v/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/stickies-v/bitcoin","forks_url":"https://api.github.com/repos/stickies-v/bitcoin/forks","keys_url":"https://api.github.com/repos/stickies-v/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stickies-v/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stickies-v/bitcoin/teams","hooks_url":"https://api.github.com/repos/stickies-v/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/stickies-v/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/stickies-v/bitcoin/events","assignees_url":"https://api.github.com/repos/stickies-v/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/stickies-v/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/stickies-v/bitcoin/tags","blobs_url":"https://api.github.com/repos/stickies-v/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stickies-v/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stickies-v/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/stickies-v/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stickies-v/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/stickies-v/bitcoin/languages","stargazers_url":"https://api.github.com/repos/stickies-v/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/stickies-v/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/stickies-v/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/stickies-v/bitcoin/subscription","commits_url":"https://api.github.com/repos/stickies-v/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/stickies-v/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/stickies-v/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/stickies-v/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/stickies-v/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/stickies-v/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stickies-v/bitcoin/merges","archive_url":"https://api.github.com/repos/stickies-v/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stickies-v/bitcoin/downloads","issues_url":"https://api.github.com/repos/stickies-v/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/stickies-v/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/stickies-v/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/stickies-v/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stickies-v/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/stickies-v/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/stickies-v/bitcoin/deployments","created_at":"2021-11-24T22:26:41Z","updated_at":"2025-10-10T05:07:04Z","pushed_at":"2026-03-05T02:23:58Z","git_url":"git://github.com/stickies-v/bitcoin.git","ssh_url":"git@github.com:stickies-v/bitcoin.git","clone_url":"https://github.com/stickies-v/bitcoin.git","svn_url":"https://github.com/stickies-v/bitcoin","homepage":"https://bitcoincore.org/en/download","size":295203,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":[],"visibility":"public","forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"083242aac81d02b6547ca37e0b4e6f37e0e89d87","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","user_view_type":"public","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2026-03-08T00:47:27Z","pushed_at":"2026-03-06T20:07:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":306389,"stargazers_count":88388,"watchers_count":88388,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":38796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":717,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"has_pull_requests":true,"pull_request_creation_policy":"all","topics":["bitcoin","c-plus-plus","cryptocurrency","cryptography","p2p"],"visibility":"public","forks":38796,"open_issues":717,"watchers":88388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/34708"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34708"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/34708/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/34708/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2f8f2e900118c98699db91075bd1b72e6460c6b1"}},"author_association":"CONTRIBUTOR","auto_merge":null,"assignee":null,"active_lock_reason":null}]