[{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55330","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55330/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55330/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55330/events","html_url":"https://github.com/dart-lang/sdk/issues/55330","id":2214293059,"node_id":"I_kwDOAiEj5s6D-25D","number":55330,"title":"Finalizer is called twice for the same object.","user":{"login":"polina-c","id":12115586,"node_id":"MDQ6VXNlcjEyMTE1NTg2","avatar_url":"https://avatars.githubusercontent.com/u/12115586?v=4","gravatar_id":"","url":"https://api.github.com/users/polina-c","html_url":"https://github.com/polina-c","followers_url":"https://api.github.com/users/polina-c/followers","following_url":"https://api.github.com/users/polina-c/following{/other_user}","gists_url":"https://api.github.com/users/polina-c/gists{/gist_id}","starred_url":"https://api.github.com/users/polina-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polina-c/subscriptions","organizations_url":"https://api.github.com/users/polina-c/orgs","repos_url":"https://api.github.com/users/polina-c/repos","events_url":"https://api.github.com/users/polina-c/events{/privacy}","received_events_url":"https://api.github.com/users/polina-c/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-03-28T22:51:13Z","updated_at":"2024-03-28T23:08:47Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"It can be reproduced in flutter tests:\r\n\r\n1. Enable leak tracking by replacing `if (_isLeakTrackingEnabled())` with `if (true)`.\r\n2. Run test `SemanticsDebugger will schedule a frame`\r\n\r\nSee failure:\r\n```\r\n══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════\r\nThe following _Exception was thrown running a test (but after the test had completed):\r\nException: The object 616336549 GCed twice\r\n\r\nWhen the exception was thrown, this was the stack:\r\n#0 ObjectRecord.setGCed (package:leak_tracker/src/leak_tracking/_object_record.dart:66:31)\r\n#1 ObjectTracker._onObjectGarbageCollected (package:leak_tracker/src/leak_tracking/_object_tracker.dart:84:12)\r\n#9 _FinalizerImpl._runFinalizers (dart:core-patch/finalizer_patch.dart:66:18)\r\n#10 _FinalizerImpl._handleFinalizerMessage (dart:core-patch/finalizer_patch.dart:79:15)\r\n(elided 7 frames from dart:async and package:stack_trace)\r\n════════════════════════════════════════════════════════════════════════════════════════════════════\r\n```\r\n\r\n\r\n```\r\nFlutter 3.21.0-16.0.pre.9 • channel master • git@github.com:flutter/flutter.git\r\nFramework • revision c6f9cdf156 (29 hours ago) • 2024-03-27 14:08:21 -0400\r\nEngine • revision b7dddee939\r\nTools • Dart 3.4.0 (build 3.4.0-275.0.dev) • DevTools 2.34.0-dev.12\r\n```\r\n\r\nSee https://github.com/dart-lang/leak_tracker/pull/224","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55330/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55330/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55329","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55329/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55329/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55329/events","html_url":"https://github.com/dart-lang/sdk/issues/55329","id":2213845730,"node_id":"I_kwDOAiEj5s6D9Jri","number":55329,"title":"Accessing privates through a prefixed import of the current library doesn't work ","user":{"login":"jakemac53","id":984921,"node_id":"MDQ6VXNlcjk4NDkyMQ==","avatar_url":"https://avatars.githubusercontent.com/u/984921?v=4","gravatar_id":"","url":"https://api.github.com/users/jakemac53","html_url":"https://github.com/jakemac53","followers_url":"https://api.github.com/users/jakemac53/followers","following_url":"https://api.github.com/users/jakemac53/following{/other_user}","gists_url":"https://api.github.com/users/jakemac53/gists{/gist_id}","starred_url":"https://api.github.com/users/jakemac53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakemac53/subscriptions","organizations_url":"https://api.github.com/users/jakemac53/orgs","repos_url":"https://api.github.com/users/jakemac53/repos","events_url":"https://api.github.com/users/jakemac53/events{/privacy}","received_events_url":"https://api.github.com/users/jakemac53/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":6120007145,"node_id":"LA_kwDOAiEj5s8AAAABbMfl6Q","url":"https://api.github.com/repos/dart-lang/sdk/labels/feature-macros","name":"feature-macros","color":"bfdadc","default":false,"description":"Implementation of the macros feature"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-28T18:14:44Z","updated_at":"2024-03-28T18:14:45Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"It is possible this is working as intended, so let me know if so. I am not sure exactly what the next course of action would be though in that case.\r\n\r\nCurrently the functional widget example macro adds a reference to the original function, which it requires to be private, using the identifier. This ends up adding an import to the current library with a prefix, full example is like this:\r\n\r\n### main library\r\n\r\n```dart\r\n@FunctionalWidget()\r\nWidget _myApp(BuildContext context) {...}\r\n```\r\n\r\n### augmentation\r\n\r\n```dart\r\nlibrary augment 'package:macros_example/main.dart';\r\n\r\nimport 'package:flutter/src/widgets/framework.dart' as prefix0;\r\nimport 'dart:core' as prefix1;\r\nimport 'package:macros_example/main.dart' as prefix2;\r\n\r\nclass MyApp extends prefix0.StatelessWidget {\r\n const MyApp({super.key,});\r\n @prefix1.override\r\n prefix0.Widget build(prefix0.BuildContext context) => \r\n prefix2._myApp(context, );\r\n}\r\n```\r\n\r\nThis gives an error that `prefix2._myApp` does not exist.\r\n\r\nIf I change the generator to just output the _name_ of the private function, it does work, since it doesn't get prefixed.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55329/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55329/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55328","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55328/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55328/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55328/events","html_url":"https://github.com/dart-lang/sdk/pull/55328","id":2213752154,"node_id":"PR_kwDOAiEj5s5rFRr4","number":55328,"title":"Show a message when DAP is connected to the VM service.","user":{"login":"chingjun","id":1267593,"node_id":"MDQ6VXNlcjEyNjc1OTM=","avatar_url":"https://avatars.githubusercontent.com/u/1267593?v=4","gravatar_id":"","url":"https://api.github.com/users/chingjun","html_url":"https://github.com/chingjun","followers_url":"https://api.github.com/users/chingjun/followers","following_url":"https://api.github.com/users/chingjun/following{/other_user}","gists_url":"https://api.github.com/users/chingjun/gists{/gist_id}","starred_url":"https://api.github.com/users/chingjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingjun/subscriptions","organizations_url":"https://api.github.com/users/chingjun/orgs","repos_url":"https://api.github.com/users/chingjun/repos","events_url":"https://api.github.com/users/chingjun/events{/privacy}","received_events_url":"https://api.github.com/users/chingjun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-03-28T17:23:30Z","updated_at":"2024-03-28T17:26:10Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/dart-lang/sdk/pulls/55328","html_url":"https://github.com/dart-lang/sdk/pull/55328","diff_url":"https://github.com/dart-lang/sdk/pull/55328.diff","patch_url":"https://github.com/dart-lang/sdk/pull/55328.patch","merged_at":null},"body":"Currently the \"connecting\" message is logged to the debug console, but not when it's connected. The user would be confused about why connection took so long.\r\n\r\n---\r\n\r\n- [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.\r\n\r\n\r\n Contribution guidelines:
\r\n\r\n- See our [contributor guide](https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md) for general expectations for PRs.\r\n- Larger or significant changes should be discussed in an issue before creating a PR.\r\n- Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`.\r\n\r\nNote that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.\r\n \r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55328/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55328/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55327","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55327/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55327/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55327/events","html_url":"https://github.com/dart-lang/sdk/issues/55327","id":2213709867,"node_id":"I_kwDOAiEj5s6D8ogr","number":55327,"title":"[CP] Fix DevTools failure to load in VS Code side panel","user":{"login":"elliette","id":21270878,"node_id":"MDQ6VXNlcjIxMjcwODc4","avatar_url":"https://avatars.githubusercontent.com/u/21270878?v=4","gravatar_id":"","url":"https://api.github.com/users/elliette","html_url":"https://github.com/elliette","followers_url":"https://api.github.com/users/elliette/followers","following_url":"https://api.github.com/users/elliette/following{/other_user}","gists_url":"https://api.github.com/users/elliette/gists{/gist_id}","starred_url":"https://api.github.com/users/elliette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliette/subscriptions","organizations_url":"https://api.github.com/users/elliette/orgs","repos_url":"https://api.github.com/users/elliette/repos","events_url":"https://api.github.com/users/elliette/events{/privacy}","received_events_url":"https://api.github.com/users/elliette/received_events","type":"User","site_admin":false},"labels":[{"id":1983719734,"node_id":"MDU6TGFiZWwxOTgzNzE5NzM0","url":"https://api.github.com/repos/dart-lang/sdk/labels/cherry-pick-review","name":"cherry-pick-review","color":"f79d9b","default":false,"description":"Issue that need cherry pick triage to approve"}],"state":"open","locked":false,"assignee":{"login":"vsmenon","id":2119553,"node_id":"MDQ6VXNlcjIxMTk1NTM=","avatar_url":"https://avatars.githubusercontent.com/u/2119553?v=4","gravatar_id":"","url":"https://api.github.com/users/vsmenon","html_url":"https://github.com/vsmenon","followers_url":"https://api.github.com/users/vsmenon/followers","following_url":"https://api.github.com/users/vsmenon/following{/other_user}","gists_url":"https://api.github.com/users/vsmenon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsmenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsmenon/subscriptions","organizations_url":"https://api.github.com/users/vsmenon/orgs","repos_url":"https://api.github.com/users/vsmenon/repos","events_url":"https://api.github.com/users/vsmenon/events{/privacy}","received_events_url":"https://api.github.com/users/vsmenon/received_events","type":"User","site_admin":false},"assignees":[{"login":"vsmenon","id":2119553,"node_id":"MDQ6VXNlcjIxMTk1NTM=","avatar_url":"https://avatars.githubusercontent.com/u/2119553?v=4","gravatar_id":"","url":"https://api.github.com/users/vsmenon","html_url":"https://github.com/vsmenon","followers_url":"https://api.github.com/users/vsmenon/followers","following_url":"https://api.github.com/users/vsmenon/following{/other_user}","gists_url":"https://api.github.com/users/vsmenon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsmenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsmenon/subscriptions","organizations_url":"https://api.github.com/users/vsmenon/orgs","repos_url":"https://api.github.com/users/vsmenon/repos","events_url":"https://api.github.com/users/vsmenon/events{/privacy}","received_events_url":"https://api.github.com/users/vsmenon/received_events","type":"User","site_admin":false},{"login":"whesse","id":4905639,"node_id":"MDQ6VXNlcjQ5MDU2Mzk=","avatar_url":"https://avatars.githubusercontent.com/u/4905639?v=4","gravatar_id":"","url":"https://api.github.com/users/whesse","html_url":"https://github.com/whesse","followers_url":"https://api.github.com/users/whesse/followers","following_url":"https://api.github.com/users/whesse/following{/other_user}","gists_url":"https://api.github.com/users/whesse/gists{/gist_id}","starred_url":"https://api.github.com/users/whesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whesse/subscriptions","organizations_url":"https://api.github.com/users/whesse/orgs","repos_url":"https://api.github.com/users/whesse/repos","events_url":"https://api.github.com/users/whesse/events{/privacy}","received_events_url":"https://api.github.com/users/whesse/received_events","type":"User","site_admin":false},{"login":"itsjustkevin","id":11145366,"node_id":"MDQ6VXNlcjExMTQ1MzY2","avatar_url":"https://avatars.githubusercontent.com/u/11145366?v=4","gravatar_id":"","url":"https://api.github.com/users/itsjustkevin","html_url":"https://github.com/itsjustkevin","followers_url":"https://api.github.com/users/itsjustkevin/followers","following_url":"https://api.github.com/users/itsjustkevin/following{/other_user}","gists_url":"https://api.github.com/users/itsjustkevin/gists{/gist_id}","starred_url":"https://api.github.com/users/itsjustkevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsjustkevin/subscriptions","organizations_url":"https://api.github.com/users/itsjustkevin/orgs","repos_url":"https://api.github.com/users/itsjustkevin/repos","events_url":"https://api.github.com/users/itsjustkevin/events{/privacy}","received_events_url":"https://api.github.com/users/itsjustkevin/received_events","type":"User","site_admin":false},{"login":"mit-mit","id":13644170,"node_id":"MDQ6VXNlcjEzNjQ0MTcw","avatar_url":"https://avatars.githubusercontent.com/u/13644170?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-mit","html_url":"https://github.com/mit-mit","followers_url":"https://api.github.com/users/mit-mit/followers","following_url":"https://api.github.com/users/mit-mit/following{/other_user}","gists_url":"https://api.github.com/users/mit-mit/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-mit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-mit/subscriptions","organizations_url":"https://api.github.com/users/mit-mit/orgs","repos_url":"https://api.github.com/users/mit-mit/repos","events_url":"https://api.github.com/users/mit-mit/events{/privacy}","received_events_url":"https://api.github.com/users/mit-mit/received_events","type":"User","site_admin":false},{"login":"athomas","id":19993735,"node_id":"MDQ6VXNlcjE5OTkzNzM1","avatar_url":"https://avatars.githubusercontent.com/u/19993735?v=4","gravatar_id":"","url":"https://api.github.com/users/athomas","html_url":"https://github.com/athomas","followers_url":"https://api.github.com/users/athomas/followers","following_url":"https://api.github.com/users/athomas/following{/other_user}","gists_url":"https://api.github.com/users/athomas/gists{/gist_id}","starred_url":"https://api.github.com/users/athomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athomas/subscriptions","organizations_url":"https://api.github.com/users/athomas/orgs","repos_url":"https://api.github.com/users/athomas/repos","events_url":"https://api.github.com/users/athomas/events{/privacy}","received_events_url":"https://api.github.com/users/athomas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2024-03-28T16:59:59Z","updated_at":"2024-03-28T21:53:22Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"### Commit(s) to merge\r\n\r\nhttps://dart-review.googlesource.com/c/sdk/+/360281\r\n\r\n### Target\r\n\r\nbeta\r\n\r\n### Prepared changelist for beta/stable\r\n\r\nhttps://dart-review.googlesource.com/c/sdk/+/360301\r\n\r\n### Issue Description\r\n\r\nDevTools switched to compiling with unminified JS. This caused a type error preventing the VS Code DevTools side panel from loading: https://github.com/Dart-Code/Dart-Code/issues/5049\r\n\r\n### What is the fix\r\n\r\nWe reverted to how we normally compile DevTools, with the default minified JS settings. \r\n\r\n### Why cherry-pick\r\n\r\nPrevents Flutter VS Code side panel from loading, affecting all users of the side panel. \r\n\r\n### Risk\r\n\r\nLow\r\n\r\n### Issue link(s)\r\n\r\nhttps://github.com/Dart-Code/Dart-Code/issues/5049\r\n\r\n### Extra Info\r\n\r\n_No response_","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55327/reactions","total_count":2,"+1":2,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55327/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55326","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55326/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55326/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55326/events","html_url":"https://github.com/dart-lang/sdk/issues/55326","id":2213541518,"node_id":"I_kwDOAiEj5s6D7_aO","number":55326,"title":"AddDiagnosticPropertyReference should handle augmentations","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":242423067,"node_id":"MDU6TGFiZWwyNDI0MjMwNjc=","url":"https://api.github.com/repos/dart-lang/sdk/labels/analyzer-quick-fix","name":"analyzer-quick-fix","color":"d4c5f9","default":false,"description":null},{"id":334529267,"node_id":"MDU6TGFiZWwzMzQ1MjkyNjc=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-enhancement","name":"type-enhancement","color":"ededed","default":false,"description":"A request for a change that isn't a bug"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-28T15:38:57Z","updated_at":"2024-03-28T17:15:23Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"The `AddDiagnosticPropertyReference` fix should handle augmented fields by augmenting the `debugFillProperties` method in the same class augmentation as the fields.\r\n\r\nCurrently, the assist/fix is unavailable for fields in augmentations (disabled in https://dart-review.googlesource.com/c/sdk/+/360043 due to the errors noted in https://github.com/dart-lang/sdk/issues/55312).\r\n\r\nThe `debugFillProperties` augmentation should call the augmented `debugFillProperties`.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55326/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55326/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55324","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55324/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55324/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55324/events","html_url":"https://github.com/dart-lang/sdk/issues/55324","id":2213227080,"node_id":"I_kwDOAiEj5s6D6ypI","number":55324,"title":"Import recovery fails for \"import augment\" without a semicolon","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928287,"node_id":"MDU6TGFiZWwyMTk5MjgyODc=","url":"https://api.github.com/repos/dart-lang/sdk/labels/analyzer-recovery","name":"analyzer-recovery","color":"d4c5f9","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"}],"state":"open","locked":false,"assignee":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-28T13:18:21Z","updated_at":"2024-03-28T17:14:49Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"I get an analysis server crash if I miss the semicolon off an `import augment` directive:\r\n\r\n```dart\r\nimport augment 'main_augmentation.dart'\r\n```\r\n\r\n```\r\ntype 'AugmentationImportDirectiveImpl' is not a subtype of type 'ImportDirectiveImpl' in type cast\r\n#0 AstBuilder.handleRecoverImport (package:analyzer/src/fasta/ast_builder.dart:5254:39)\r\n#1 ForwardingListener.handleRecoverImport (package:_fe_analyzer_shared/src/parser/forwarding_listener.dart:1935:15)\r\n#2 Parser.parseImportRecovery (package:_fe_analyzer_shared/src/parser/parser_impl.dart:1025:16)\r\n#3 Parser.parseImport (package:_fe_analyzer_shared/src/…\r\n```","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55324/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55324/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55323","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55323/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55323/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55323/events","html_url":"https://github.com/dart-lang/sdk/issues/55323","id":2212997432,"node_id":"I_kwDOAiEj5s6D56k4","number":55323,"title":"Null checks not narrowing types for instance variables","user":{"login":"alexandradeas","id":12813479,"node_id":"MDQ6VXNlcjEyODEzNDc5","avatar_url":"https://avatars.githubusercontent.com/u/12813479?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandradeas","html_url":"https://github.com/alexandradeas","followers_url":"https://api.github.com/users/alexandradeas/followers","following_url":"https://api.github.com/users/alexandradeas/following{/other_user}","gists_url":"https://api.github.com/users/alexandradeas/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandradeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandradeas/subscriptions","organizations_url":"https://api.github.com/users/alexandradeas/orgs","repos_url":"https://api.github.com/users/alexandradeas/repos","events_url":"https://api.github.com/users/alexandradeas/events{/privacy}","received_events_url":"https://api.github.com/users/alexandradeas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-03-28T11:36:14Z","updated_at":"2024-03-28T13:38:20Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"Null checks appear to not be coercing the type for instance variables. With the following code the expectation is `Foo.doesNotWork` will compile due to the `x != null` check \r\n\r\n```dart\r\nint works({required List xs, String? x}) {\r\n return x != null ? xs.indexOf(x) : 0; // no error\r\n}\r\n\r\nclass Foo {\r\n const Foo({\r\n required this.xs,\r\n this.x,\r\n });\r\n\r\n final List xs;\r\n final String? x;\r\n\r\n int doesNotWork() {\r\n return x != null ? xs.indexOf(x) : 0; // error: 'T?' can't be assigned to type: 'T'\r\n }\r\n \r\n int works() {\r\n final x = this.x;\r\n return x != null ? xs.indexOf(x) : 0; // no error\r\n }\r\n}\r\n```\r\n\r\nTested with Dart v3.3.2 ","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55323/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55323/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55322","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55322/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55322/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55322/events","html_url":"https://github.com/dart-lang/sdk/issues/55322","id":2212647307,"node_id":"I_kwDOAiEj5s6D4lGL","number":55322,"title":"Compiler failed when runing flutter app","user":{"login":"feng4108","id":20110882,"node_id":"MDQ6VXNlcjIwMTEwODgy","avatar_url":"https://avatars.githubusercontent.com/u/20110882?v=4","gravatar_id":"","url":"https://api.github.com/users/feng4108","html_url":"https://github.com/feng4108","followers_url":"https://api.github.com/users/feng4108/followers","following_url":"https://api.github.com/users/feng4108/following{/other_user}","gists_url":"https://api.github.com/users/feng4108/gists{/gist_id}","starred_url":"https://api.github.com/users/feng4108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feng4108/subscriptions","organizations_url":"https://api.github.com/users/feng4108/orgs","repos_url":"https://api.github.com/users/feng4108/repos","events_url":"https://api.github.com/users/feng4108/events{/privacy}","received_events_url":"https://api.github.com/users/feng4108/received_events","type":"User","site_admin":false},"labels":[{"id":524536392,"node_id":"MDU6TGFiZWw1MjQ1MzYzOTI=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-front-end","name":"area-front-end","color":"c5def5","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-28T08:34:46Z","updated_at":"2024-03-28T13:13:35Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"Error logs\r\n```\r\nUnhandled exception:\r\nCrash when compiling file:///D:/source/flutter/flutter_app/lib/main.dart at character offset 20628:\r\nRangeError (index): Invalid value: Not in inclusive range 0..20834: 21043\r\n\r\n#0 _StringBase.[] (dart:core-patch/string_patch.dart:273)\r\n#1 Source.getTextLine (package:kernel/ast.dart:14949)\r\n#2 getSourceLine (package:front_end/src/fasta/messages.dart:28)\r\n#3 format (package:front_end/src/fasta/command_line_reporting.dart:95)\r\n#4 ProcessedOptions.format (package:front_end/src/base/processed_options.dart:214)\r\n#5 ProcessedOptions.report (package:front_end/src/base/processed_options.dart:237)\r\n#6 CompilerContext.report (package:front_end/src/fasta/compiler_context.dart:67)\r\n#7 SourceLoader.addMessage (package:front_end/src/fasta/source/source_loader.dart:748)\r\n#8 SourceLoader.addProblem (package:front_end/src/fasta/source/source_loader.dart:703)\r\n#9 LibraryBuilderImpl.addProblem (package:front_end/src/fasta/builder/library_builder.dart:288)\r\n#10 SourceLibraryBuilder.addProblem (package:front_end/src/fasta/source/source_library_builder.dart:1886)\r\n#11 SourceLoader.tokenize (package:front_end/src/fasta/source/source_loader.dart:949)\r\n\r\n#12 SourceLoader.buildOutline (package:front_end/src/fasta/source/source_loader.dart:1191)\r\n\r\n#13 SourceLoader.buildOutlines (package:front_end/src/fasta/source/source_loader.dart:1016)\r\n\r\n#14 KernelTarget.computeNeededPrecompilations. (package:front_end/src/fasta/kernel/kernel_target.dart:329)\r\n\r\n#15 withCrashReporting (package:front_end/src/fasta/crash.dart:133)\r\n\r\n#16 KernelTarget.computeNeededPrecompilations (package:front_end/src/fasta/kernel/kernel_target.dart:327)\r\n\r\n#17 IncrementalCompiler.computeDelta. (package:front_end/src/fasta/incremental_compiler.dart:341)\r\n\r\n#18 CompilerContext.clear (package:front_end/src/fasta/compiler_context.dart:139)\r\n\r\n#19 IncrementalCompiler.compile (package:vm/incremental_compiler.dart:77)\r\n\r\n#20 FrontendCompiler.compile (package:frontend_server/frontend_server.dart:610)\r\n\r\n#21 listenAndCompile. (package:frontend_server/frontend_server.dart:1303)\r\n\r\nthe Dart compiler exited unexpectedly.\r\nthe Dart compiler exited unexpectedly.\r\n```\r\n\r\n### Flutter doctor output\r\n```\r\nFlutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!\r\nDoctor summary (to see all details, run flutter doctor -v):\r\n[√] Flutter (Channel stable, 3.19.4, on Microsoft Windows [版本 10.0.19045.4046], locale zh-CN)\r\n[√] Windows Version (Installed version of Windows is version 10 or higher)\r\n[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)\r\n[√] Chrome - develop for the web\r\n[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.9.4)\r\n[√] Android Studio (version 2023.2)\r\n[√] Connected device (4 available)\r\n[√] Network resources\r\n\r\n• No issues found!\r\n\r\n```\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55322/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55322/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55321","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55321/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55321/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55321/events","html_url":"https://github.com/dart-lang/sdk/issues/55321","id":2212622218,"node_id":"I_kwDOAiEj5s6D4e-K","number":55321,"title":"List.toList() Type problem","user":{"login":"feduke-nukem","id":72284940,"node_id":"MDQ6VXNlcjcyMjg0OTQw","avatar_url":"https://avatars.githubusercontent.com/u/72284940?v=4","gravatar_id":"","url":"https://api.github.com/users/feduke-nukem","html_url":"https://github.com/feduke-nukem","followers_url":"https://api.github.com/users/feduke-nukem/followers","following_url":"https://api.github.com/users/feduke-nukem/following{/other_user}","gists_url":"https://api.github.com/users/feduke-nukem/gists{/gist_id}","starred_url":"https://api.github.com/users/feduke-nukem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feduke-nukem/subscriptions","organizations_url":"https://api.github.com/users/feduke-nukem/orgs","repos_url":"https://api.github.com/users/feduke-nukem/repos","events_url":"https://api.github.com/users/feduke-nukem/events{/privacy}","received_events_url":"https://api.github.com/users/feduke-nukem/received_events","type":"User","site_admin":false},"labels":[{"id":1102415472,"node_id":"MDU6TGFiZWwxMTAyNDE1NDcy","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-question","name":"type-question","color":"ededed","default":false,"description":"A question about expected behavior or functionality"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2024-03-28T08:19:27Z","updated_at":"2024-03-28T14:27:51Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"This tracker is for issues related to:\r\n\r\n* Dart core libraries (`dart:async`, `dart:io`, etc.)\r\n\r\nSome other pieces of the Dart ecosystem are maintained elsewhere.\r\nPlease file issues in their repository:\r\n\r\n* Dart language: https://github.com/dart-lang/language\r\n\r\nLet's assume I have such code:\r\n\r\n```dart\r\nvoid main() {\r\n final holder = Holder(contents: [Content(data: B())]);\r\n\r\n test(holder);\r\n}\r\n\r\nsealed class A {}\r\n\r\nclass B extends A {}\r\n\r\nclass C extends A {}\r\n\r\nclass Content {\r\n final S data;\r\n\r\n Content({required this.data});\r\n}\r\n\r\nclass Holder {\r\n final List> contents;\r\n\r\n Holder({required this.contents});\r\n}\r\n```\r\n\r\nSo if I use `toList()` I will get `TypeError`:\r\n\r\n```dart\r\nvoid test(Holder holder) {\r\n final contents = holder.contents.toList();\r\n\r\n contents.add(Content(data: B())); // TypeError\r\n}\r\n```\r\nBut `List.of()` doesn't produce that error:\r\n\r\n```dart\r\nvoid test(Holder holder) {\r\n final contents = List.of(holder.contents);\r\n\r\n contents.add(Content(data: B())); // Okay\r\n}\r\n```\r\n\r\nI wonder why? `toList()` under the hood uses `List.of()` but the result is different. `List.from` and `[...contents]` cause no problem, only `toList()` does.\r\n\r\nAlso that will work:\r\n\r\n```dart\r\nvoid test(Holder holder) {\r\n final contents = holder.contents.map((e) => e)).toList();\r\n\r\n contents.add(Content(data: B())); // Okay\r\n}\r\n```\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55321/reactions","total_count":1,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":1,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55321/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55320","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55320/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55320/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55320/events","html_url":"https://github.com/dart-lang/sdk/issues/55320","id":2212502287,"node_id":"I_kwDOAiEj5s6D4BsP","number":55320,"title":"Generic type T itself becomes nullable if a variable of type T? has a null value","user":{"login":"kaboc","id":20254485,"node_id":"MDQ6VXNlcjIwMjU0NDg1","avatar_url":"https://avatars.githubusercontent.com/u/20254485?v=4","gravatar_id":"","url":"https://api.github.com/users/kaboc","html_url":"https://github.com/kaboc","followers_url":"https://api.github.com/users/kaboc/followers","following_url":"https://api.github.com/users/kaboc/following{/other_user}","gists_url":"https://api.github.com/users/kaboc/gists{/gist_id}","starred_url":"https://api.github.com/users/kaboc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaboc/subscriptions","organizations_url":"https://api.github.com/users/kaboc/orgs","repos_url":"https://api.github.com/users/kaboc/repos","events_url":"https://api.github.com/users/kaboc/events{/privacy}","received_events_url":"https://api.github.com/users/kaboc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-28T07:01:27Z","updated_at":"2024-03-28T07:01:27Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"```dart\r\nvoid main() {\r\n final fooA = Foo(value1: 10);\r\n final fooB = Foo(value1: 10, value2: null);\r\n print('${getType(fooA.value1)}'); // int\r\n print('${getType(fooB.value1)}'); // int?\r\n}\r\n\r\nType getType(T value) => T;\r\n\r\nclass Foo {\r\n final T value1;\r\n final T? value2;\r\n\r\n Foo({required this.value1, this.value2});\r\n}\r\n```\r\n\r\n`T` can be nullable, but I want to handle `value1` as non-nullable when its value is not null. On the other hand, `value2` is of type `T?` because it is a property that often has no value, and also because I intend to prevent `T` itself from becoming nullable when `value2` is null but `value1` is not null.\r\n\r\nI've noticed that below works as intended.\r\n\r\n```dart\r\nvoid main() {\r\n final bar = Bar(value1: 10, value2: null);\r\n print('bar.value: ${getType(bar.value1)}');\r\n}\r\n\r\nType getType(T value) => T;\r\n\r\nclass Bar {\r\n final T value1;\r\n final S? value2;\r\n\r\n Bar({required this.value1, this.value2});\r\n}\r\n```\r\n\r\nHowever, it forces users to pass two type arguments when the class needs to be used with the types specified explicitly. It may be a trivial matter, but it makes UX worse. Is it something that could be improved in the Dart language?\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55320/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55320/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55319","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55319/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55319/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55319/events","html_url":"https://github.com/dart-lang/sdk/issues/55319","id":2212279668,"node_id":"I_kwDOAiEj5s6D3LV0","number":55319,"title":"Stale analysis after changing file","user":{"login":"matanlurey","id":168174,"node_id":"MDQ6VXNlcjE2ODE3NA==","avatar_url":"https://avatars.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":1758182142,"node_id":"MDU6TGFiZWwxNzU4MTgyMTQy","url":"https://api.github.com/repos/dart-lang/sdk/labels/analyzer-editing-experience","name":"analyzer-editing-experience","color":"d4c5f9","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-28T03:33:35Z","updated_at":"2024-03-28T17:19:32Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"\r\n\r\nThe field `_leaders` does not exist (I just deleted it), but the analyzer doesn't seem to know.\r\n\r\nIf I close the file and re-open it, everything works as expected.\r\n\r\nAttached: [dart_analyzer_diagnostics_report (1).json](https://github.com/dart-lang/sdk/files/14783575/dart_analyzer_diagnostics_report.1.json).\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55319/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55319/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55318","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55318/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55318/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55318/events","html_url":"https://github.com/dart-lang/sdk/issues/55318","id":2212264152,"node_id":"I_kwDOAiEj5s6D3HjY","number":55318,"title":"`uri_does_not_exist` on right click -> new file in VSCode","user":{"login":"matanlurey","id":168174,"node_id":"MDQ6VXNlcjE2ODE3NA==","avatar_url":"https://avatars.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2024-03-28T03:15:25Z","updated_at":"2024-03-28T17:18:10Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"I have the following file structure in a monorepo:\r\n\r\n```txt\r\n/.\r\n /packages\r\n /unlimited\r\n /lib\r\n engine.dart\r\n /src\r\n /engine\r\n zone.dart\r\n```\r\n\r\nConsistently when I add a _new_ file thrugh VSCode, I get `uri_does_not_exist`:\r\n\r\n\r\n\r\nAuto complete even shows the file does exist and helps me select it:\r\n\r\n\r\n\r\n... but I get `uri_does_not_exist` upon doing so:\r\n\r\n\r\n\r\nSome other interesting bits:\r\n\r\n- Ctrl-click works, I can navigate to the file that doesn't exist (?)\r\n- If I make an edit in the file, everything goes back to normal (as expected)\r\n\r\n---\r\n\r\n#### General info\r\n\r\n- Dart 3.3.1 (stable) (Wed Mar 6 13:09:19 2024 +0000) on \"macos_arm64\"\r\n- on macos / Version 14.3 (Build 23D56)\r\n- locale is en-US\r\n\r\n#### Process info\r\n\r\n| Memory | CPU | Elapsed time | Command line |\r\n| ------: | ---: | -----------: | ------------------------------------------------------------------------------- |\r\n| 29 MB | 0.0% | 01-23:21:13 | dart devtools --machine --allow-embedding --port 9100 |\r\n| 1798 MB | 0.0% | 01-23:21:13 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.84.0 |\r\n| 72 MB | 0.2% | 01-23:21:13 | flutter_tools.snapshot daemon |","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55318/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55318/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55317","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55317/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55317/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55317/events","html_url":"https://github.com/dart-lang/sdk/issues/55317","id":2211803919,"node_id":"I_kwDOAiEj5s6D1XMP","number":55317,"title":"[dart2wasm] Include the text of the condition when throwing an assertion","user":{"login":"eyebrowsoffire","id":26911996,"node_id":"MDQ6VXNlcjI2OTExOTk2","avatar_url":"https://avatars.githubusercontent.com/u/26911996?v=4","gravatar_id":"","url":"https://api.github.com/users/eyebrowsoffire","html_url":"https://github.com/eyebrowsoffire","followers_url":"https://api.github.com/users/eyebrowsoffire/followers","following_url":"https://api.github.com/users/eyebrowsoffire/following{/other_user}","gists_url":"https://api.github.com/users/eyebrowsoffire/gists{/gist_id}","starred_url":"https://api.github.com/users/eyebrowsoffire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyebrowsoffire/subscriptions","organizations_url":"https://api.github.com/users/eyebrowsoffire/orgs","repos_url":"https://api.github.com/users/eyebrowsoffire/repos","events_url":"https://api.github.com/users/eyebrowsoffire/events{/privacy}","received_events_url":"https://api.github.com/users/eyebrowsoffire/received_events","type":"User","site_admin":false},"labels":[{"id":3764045790,"node_id":"LA_kwDOAiEj5s7gWsfe","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-dart2wasm","name":"area-dart2wasm","color":"c7def8","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-27T20:07:16Z","updated_at":"2024-03-27T20:50:32Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"When dart2wasm throws an assertion, it just throws \"assertion failed\" but does not include the text of the condition like other backends do. We should do this, some flutter framework tests rely on it.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55317/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55317/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55313","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55313/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55313/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55313/events","html_url":"https://github.com/dart-lang/sdk/issues/55313","id":2210999235,"node_id":"I_kwDOAiEj5s6DySvD","number":55313,"title":"pkg/dds/test/dap/integration/debug_attach_test is failing on unittest-asserts-release-win-arm64","user":{"login":"derekxu16","id":1782969,"node_id":"MDQ6VXNlcjE3ODI5Njk=","avatar_url":"https://avatars.githubusercontent.com/u/1782969?v=4","gravatar_id":"","url":"https://api.github.com/users/derekxu16","html_url":"https://github.com/derekxu16","followers_url":"https://api.github.com/users/derekxu16/followers","following_url":"https://api.github.com/users/derekxu16/following{/other_user}","gists_url":"https://api.github.com/users/derekxu16/gists{/gist_id}","starred_url":"https://api.github.com/users/derekxu16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekxu16/subscriptions","organizations_url":"https://api.github.com/users/derekxu16/orgs","repos_url":"https://api.github.com/users/derekxu16/repos","events_url":"https://api.github.com/users/derekxu16/events{/privacy}","received_events_url":"https://api.github.com/users/derekxu16/received_events","type":"User","site_admin":false},"labels":[{"id":512342379,"node_id":"MDU6TGFiZWw1MTIzNDIzNzk=","url":"https://api.github.com/repos/dart-lang/sdk/labels/gardening","name":"gardening","color":"E91E63","default":false,"description":null},{"id":2256268242,"node_id":"MDU6TGFiZWwyMjU2MjY4MjQy","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-tools","name":"area-tools","color":"c7def8","default":false,"description":"A general category for issues that we think should be addressed by tooling."},{"id":4236200565,"node_id":"LA_kwDOAiEj5s78f0p1","url":"https://api.github.com/repos/dart-lang/sdk/labels/dds-dap","name":"dds-dap","color":"5D0C33","default":false,"description":"DDS issues related to the Debug Adapter Protocol (DAP) implementation"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2024-03-27T14:44:19Z","updated_at":"2024-03-28T13:58:23Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"The tests\r\n```\r\npkg/dds/test/dap/integration/debug_attach_test RuntimeError (expected Pass)\r\n```\r\nare failing on configurations\r\n```\r\nunittest-asserts-release-win-arm64\r\n```\r\n\r\n```\r\n00:01 \u001B[32m+0\u001B[0m\u001B[31m -1\u001B[0m: debug mode can attach to a simple script using vmServiceUri \u001B[1m\u001B[31m[E]\u001B[0m\u001B[0m\r\n\r\n SocketException: Write failed (OS Error: The pipe is being closed.\r\n\r\n , errno = 232), port = 0\r\n\r\n dart:io-patch/socket_patch.dart 1246:34 _NativeSocket.write\r\n dart:io-patch/socket_patch.dart 2004:15 _RawSocket.write\r\n dart:io-patch/socket_patch.dart 2481:18 _Socket._write\r\n dart:io-patch/socket_patch.dart 2216:28 _SocketStreamConsumer.write\r\n dart:io-patch/socket_patch.dart 2168:11 _SocketStreamConsumer.addStream.\r\n dart:async/zone.dart 1407:47 _rootRunUnary\r\n dart:async/zone.dart 1308:19 _CustomZone.runUnary\r\n dart:async/zone.dart 1217:7 _CustomZone.runUnaryGuarded\r\n dart:async/stream_impl.dart 365:11 _BufferingStreamSubscription._sendData\r\n dart:async/stream_impl.dart 541:14 _DelayedData.perform\r\n dart:async/stream_impl.dart 646:11 _PendingEvents.handleNext\r\n dart:async/stream_impl.dart 617:7 _PendingEvents.schedule.\r\n dart:async/zone.dart 1391:47 _rootRun\r\n dart:async/zone.dart 1301:19 _CustomZone.run\r\n dart:async/zone.dart 1209:7 _CustomZone.runGuarded\r\n dart:async/zone.dart 1249:23 _CustomZone.bindCallbackGuarded.\r\n dart:async/zone.dart 1399:13 _rootRun\r\n dart:async/zone.dart 1301:19 _CustomZone.run\r\n dart:async/zone.dart 1209:7 _CustomZone.runGuarded\r\n dart:async/zone.dart 1249:23 _CustomZone.bindCallbackGuarded.\r\n dart:async/schedule_microtask.dart 40:21 _microtaskLoop\r\n dart:async/schedule_microtask.dart 49:5 _startMicrotaskLoop\r\n dart:isolate-patch/isolate_patch.dart 118:13 _runPendingImmediateCallback\r\n dart:isolate-patch/isolate_patch.dart 185:5 _RawReceivePort._handleMessage\r\n```\r\n\r\nhttps://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-win-release-arm64/1155/overview\r\n\r\nThis could be a Windows pipe problem, or it could be a problem with how DAP is using pipes.\r\n\r\ncc @brianquinlan and @DanTup","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55313/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55313/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55312","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55312/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55312/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55312/events","html_url":"https://github.com/dart-lang/sdk/issues/55312","id":2210613671,"node_id":"I_kwDOAiEj5s6Dw0mn","number":55312,"title":"\"Invalid argument(s):: InterfaceType(s) can only be created for declarations\" when using augmentations","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928274,"node_id":"MDU6TGFiZWwyMTk5MjgyNzQ=","url":"https://api.github.com/repos/dart-lang/sdk/labels/analyzer-server","name":"analyzer-server","color":"d4c5f9","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2024-03-27T11:58:21Z","updated_at":"2024-03-28T15:19:48Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"Given the following code:\r\n\r\n```dart\r\nclass A {\r\n void foo() {}\r\n}\r\n\r\naugment class A {\r\n augment void foo() {}\r\n}\r\n```\r\n\r\nPutting the caret in `foo()` for the augmentation triggers a `textDocument/codeAction` request which fails with the following:\r\n\r\n```\r\n1711537670051:Ex:An error occurred while handling textDocument/codeAction request\r\nInvalid argument(s):: InterfaceType(s) can only be created for declarations\r\n#0 new InterfaceTypeImpl (package::analyzer/src/dart/element/type.dart::479::7)\r\n#1 InterfaceElementImpl.instantiate (package::analyzer/src/dart/element/element.dart::3650::20)\r\n#2 InterfaceElementImpl.thisType (package::analyzer/src/dart/element/element.dart::3575::26)\r\n#3 AddDiagnosticPropertyReference.compute (package::analysis_server/src/services/correction/dart/add_diagnostic_property_reference.dart::48::69)\r\n#4 AssistProcessor._addFromProducers.compute (package::analysis_server/src/services/correction/assist_internal.dart::210::24)\r\n#5 AssistProcessor._addFromProducers (package::analysis_server/src/services/correction/assist_internal.dart::230::15)\r\n#6 AssistProcessor.compute (package::analysis_server/src/services/correction/assist_internal.dart::179::11)\r\n#7 DartCodeActionsProducer.getAssistActions (package::analysis_server/src/lsp/handlers/code_actions/dart.dart::133::39)\r\n\r\n#8 OperationPerformanceImpl.runAsync (package::analyzer/src/util/performance/operation_performance.dart::172::14)\r\n\r\n#9 CodeActionHandler.handle (package::analysis_server/src/lsp/handlers/handler_code_actions.dart::235::16)\r\n\r\n#10 ServerStateMessageHandler.handleMessage (package::analysis_server/src/lsp/handlers/handlers.dart::396::11)\r\n\r\n#11 LspAnalysisServer._handleRequestMessage (package::analysis_server/src/lsp/lsp_analysis_server.dart::1001::20)\r\n\r\n#12 LspAnalysisServer.handleMessage.. (package::analysis_server/src/lsp/lsp_analysis_server.dart::461::15)\r\n\r\n#13 OperationPerformanceImpl.runAsync (package::analyzer/src/util/performance/operation_performance.dart::172::14)\r\n\r\n#14 LspAnalysisServer.handleMessage. (package::analysis_server/src/lsp/lsp_analysis_server.dart::444::11)\r\n\r\n\r\n:null\r\n```\r\n\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55312/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55312/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55311","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55311/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55311/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55311/events","html_url":"https://github.com/dart-lang/sdk/issues/55311","id":2210493436,"node_id":"I_kwDOAiEj5s6DwXP8","number":55311,"title":"[test-runner] Matching too many file names with `Co19TestSuite.isTestFile`?","user":{"login":"eernstg","id":9606994,"node_id":"MDQ6VXNlcjk2MDY5OTQ=","avatar_url":"https://avatars.githubusercontent.com/u/9606994?v=4","gravatar_id":"","url":"https://api.github.com/users/eernstg","html_url":"https://github.com/eernstg","followers_url":"https://api.github.com/users/eernstg/followers","following_url":"https://api.github.com/users/eernstg/following{/other_user}","gists_url":"https://api.github.com/users/eernstg/gists{/gist_id}","starred_url":"https://api.github.com/users/eernstg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eernstg/subscriptions","organizations_url":"https://api.github.com/users/eernstg/orgs","repos_url":"https://api.github.com/users/eernstg/repos","events_url":"https://api.github.com/users/eernstg/events{/privacy}","received_events_url":"https://api.github.com/users/eernstg/received_events","type":"User","site_admin":false},"labels":[{"id":2256268242,"node_id":"MDU6TGFiZWwyMjU2MjY4MjQy","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-tools","name":"area-tools","color":"c7def8","default":false,"description":"A general category for issues that we think should be addressed by tooling."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-27T11:00:10Z","updated_at":"2024-03-27T11:03:13Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"I just noted that \r\n\r\n```dart\r\nclass Co19TestSuite extends StandardTestSuite {\r\n static final _testRegExp = RegExp(r\"t[0-9]{2,3}.dart$\");\r\n ...\r\n bool isTestFile(String filename) => _testRegExp.hasMatch(filename);\r\n ...\r\n}\r\n```\r\n\r\nwhich would include `WHATEVERt123^dart`. Presumably the `.` should be escaped. It could be useful to include an underscore character before the `t` as well, because this is the file name pattern which is actually followed, and it might help excluding a few files that shouldn't be considered to be test files anyway.\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55311/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55311/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55310","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55310/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55310/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55310/events","html_url":"https://github.com/dart-lang/sdk/issues/55310","id":2210488556,"node_id":"I_kwDOAiEj5s6DwWDs","number":55310,"title":"AOT compiler seems to remove switch branches that are actually needed at runtime","user":{"login":"Yegair","id":27617923,"node_id":"MDQ6VXNlcjI3NjE3OTIz","avatar_url":"https://avatars.githubusercontent.com/u/27617923?v=4","gravatar_id":"","url":"https://api.github.com/users/Yegair","html_url":"https://github.com/Yegair","followers_url":"https://api.github.com/users/Yegair/followers","following_url":"https://api.github.com/users/Yegair/following{/other_user}","gists_url":"https://api.github.com/users/Yegair/gists{/gist_id}","starred_url":"https://api.github.com/users/Yegair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yegair/subscriptions","organizations_url":"https://api.github.com/users/Yegair/orgs","repos_url":"https://api.github.com/users/Yegair/repos","events_url":"https://api.github.com/users/Yegair/events{/privacy}","received_events_url":"https://api.github.com/users/Yegair/received_events","type":"User","site_admin":false},"labels":[{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":524536392,"node_id":"MDU6TGFiZWw1MjQ1MzYzOTI=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-front-end","name":"area-front-end","color":"c5def5","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2024-03-27T10:57:55Z","updated_at":"2024-03-28T08:03:58Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"#### `dart info`:\r\n\r\n```\r\n#### General info\r\n\r\n- Dart 3.3.2 (stable) (Tue Mar 19 20:44:48 2024 +0000) on \"macos_arm64\"\r\n- on macos / Version 14.1.1 (Build 23B81)\r\n- locale is en-DE\r\n\r\n#### Project info\r\n\r\n- sdk constraint: '^3.3.2'\r\n- dependencies: freezed_annotation\r\n- dev_dependencies: build_runner, freezed, lints, test\r\n\r\n#### Process info\r\n\r\n| Memory | CPU | Elapsed time | Command line |\r\n| ------: | ---: | -----------: | ------------------------------------------------------------------------------------------ |\r\n| 41 MB | 0.0% | 18:54:33 | dart devtools --machine --allow-embedding |\r\n| 3542 MB | 0.0% | 18:54:33 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.84.0 |\r\n| 926 MB | 0.0% | 01:58:29 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.84.0 |\r\n| 904 MB | 0.0% | 01:38:51 | dart lib/custom_lint_client.dart ::1 62540 |\r\n| 63 MB | 0.0% | 18:54:33 | flutter_tools.snapshot daemon |\r\n| 69 MB | 0.0% | 01:46:44 | flutter_tools.snapshot debug_adapter |\r\n```\r\n\r\n#### Operating System\r\n I have reproduced the issue on MacOS as well as iOS and Android (with Flutter)\r\n\r\n#### How to reproduce\r\nI have set up a minimal example that reproduces the error (at least on my machine): https://github.com/Yegair/dart-aot-error-reproduction\r\n\r\n#### About the Error\r\n \r\nThe error first showed up in a Flutter release build on Android, but it was also reproducible on iOS as well as in a non-Flutter project running on MacOS (see reproducible example above).\r\n\r\nApparently the compiler removes some branches from a `switch` expression that are actually needed at runtime. The expression looks something like in the following example. `WrapperA` and `WrapperB` are subclasses of some `sealed class Wrapper`. The implementations of those classes have been generated using the [freezed](https://pub.dev/packages/freezed) library. Without the usage of freezed, I have not been able to reproduce the issue, so this might be where the problem originates from, but I have been unable to figure out the exact cause so far.\r\n\r\n```dart\r\nswitch (wrapper) {\r\n WrapperA(inner: Inner(other: final Other other)) => other.text,\r\n WrapperA(inner: Inner(other: null)) => \"no other\",\r\n WrapperB(inner: Inner(other: final Other other)) => other.text,\r\n WrapperB(inner: Inner(other: null)) => \"no other\",\r\n}\r\n```\r\n\r\nFrom what I can tell, the last two branches are removed during compilation, which at runtime leads to the error:\r\n\r\n```\r\nAttempt to execute code removed by Dart AOT compiler (TFA)\r\n```\r\n\r\nI assume the compiler for some reason concludes, that the first two branches already cover all possible cases, which is not that far from the truth, because rewriting the expression like the following fixes the issue.\r\n\r\n```dart\r\nswitch (wrapper) {\r\n Wrapper(inner: Inner(other: final Other other)) => other.text,\r\n Wrapper(inner: Inner(other: null)) => \"no other\",\r\n}\r\n```\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55310/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55310/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55307","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55307/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55307/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55307/events","html_url":"https://github.com/dart-lang/sdk/issues/55307","id":2210152630,"node_id":"I_kwDOAiEj5s6DvEC2","number":55307,"title":"Surprising type inference failure","user":{"login":"eernstg","id":9606994,"node_id":"MDQ6VXNlcjk2MDY5OTQ=","avatar_url":"https://avatars.githubusercontent.com/u/9606994?v=4","gravatar_id":"","url":"https://api.github.com/users/eernstg","html_url":"https://github.com/eernstg","followers_url":"https://api.github.com/users/eernstg/followers","following_url":"https://api.github.com/users/eernstg/following{/other_user}","gists_url":"https://api.github.com/users/eernstg/gists{/gist_id}","starred_url":"https://api.github.com/users/eernstg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eernstg/subscriptions","organizations_url":"https://api.github.com/users/eernstg/orgs","repos_url":"https://api.github.com/users/eernstg/repos","events_url":"https://api.github.com/users/eernstg/events{/privacy}","received_events_url":"https://api.github.com/users/eernstg/received_events","type":"User","site_admin":false},"labels":[{"id":5386282454,"node_id":"LA_kwDOAiEj5s8AAAABQQwl1g","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-fe-analyzer-shared","name":"area-fe-analyzer-shared","color":"c7def8","default":false,"description":"Issues with code that is shared between the analyzer and CFE"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-03-27T08:21:19Z","updated_at":"2024-03-27T09:43:56Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"Consider the following program:\r\n\r\n```dart\r\nvoid f(List xs, X Function(X) g) {}\r\nvoid main() => f([], (int i) => i);\r\n```\r\n\r\nBoth the analyzer and the CFE reject this program, reporting that \"`X` couldn't be inferred\" respectively \"'int Function(int)' can't be assigned to the parameter type 'dynamic Function(dynamic)'\".\r\n\r\nThe horizontal inference rules do not give rise to any separation of the actual arguments into phases, so I'd expect the declared parameter type `int` as well as the return type `int` of the second argument to suffice to conclude that `X` must be `int`.\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55307/reactions","total_count":1,"+1":1,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55307/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55305","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55305/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55305/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55305/events","html_url":"https://github.com/dart-lang/sdk/issues/55305","id":2208583640,"node_id":"I_kwDOAiEj5s6DpE_Y","number":55305,"title":"Make connectionInfo a top-level field of the HttpProfileRequest type in the dart:io Service Extension spec","user":{"login":"derekxu16","id":1782969,"node_id":"MDQ6VXNlcjE3ODI5Njk=","avatar_url":"https://avatars.githubusercontent.com/u/1782969?v=4","gravatar_id":"","url":"https://api.github.com/users/derekxu16","html_url":"https://github.com/derekxu16","followers_url":"https://api.github.com/users/derekxu16/followers","following_url":"https://api.github.com/users/derekxu16/following{/other_user}","gists_url":"https://api.github.com/users/derekxu16/gists{/gist_id}","starred_url":"https://api.github.com/users/derekxu16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekxu16/subscriptions","organizations_url":"https://api.github.com/users/derekxu16/orgs","repos_url":"https://api.github.com/users/derekxu16/repos","events_url":"https://api.github.com/users/derekxu16/events{/privacy}","received_events_url":"https://api.github.com/users/derekxu16/received_events","type":"User","site_admin":false},"labels":[{"id":219928165,"node_id":"MDU6TGFiZWwyMTk5MjgxNjU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-vm","name":"area-vm","color":"c7def8","default":false,"description":null},{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":4930193978,"node_id":"LA_kwDOAiEj5s8AAAABJdzKOg","url":"https://api.github.com/repos/dart-lang/sdk/labels/triaged","name":"triaged","color":"0052cc","default":false,"description":"Issue has been triaged by sub team"},{"id":5017856615,"node_id":"LA_kwDOAiEj5s8AAAABKxZqZw","url":"https://api.github.com/repos/dart-lang/sdk/labels/vm-service","name":"vm-service","color":"8453b2","default":false,"description":"The VM Service Protocol, both the specification and its implementation"}],"state":"open","locked":false,"assignee":{"login":"derekxu16","id":1782969,"node_id":"MDQ6VXNlcjE3ODI5Njk=","avatar_url":"https://avatars.githubusercontent.com/u/1782969?v=4","gravatar_id":"","url":"https://api.github.com/users/derekxu16","html_url":"https://github.com/derekxu16","followers_url":"https://api.github.com/users/derekxu16/followers","following_url":"https://api.github.com/users/derekxu16/following{/other_user}","gists_url":"https://api.github.com/users/derekxu16/gists{/gist_id}","starred_url":"https://api.github.com/users/derekxu16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekxu16/subscriptions","organizations_url":"https://api.github.com/users/derekxu16/orgs","repos_url":"https://api.github.com/users/derekxu16/repos","events_url":"https://api.github.com/users/derekxu16/events{/privacy}","received_events_url":"https://api.github.com/users/derekxu16/received_events","type":"User","site_admin":false},"assignees":[{"login":"derekxu16","id":1782969,"node_id":"MDQ6VXNlcjE3ODI5Njk=","avatar_url":"https://avatars.githubusercontent.com/u/1782969?v=4","gravatar_id":"","url":"https://api.github.com/users/derekxu16","html_url":"https://github.com/derekxu16","followers_url":"https://api.github.com/users/derekxu16/followers","following_url":"https://api.github.com/users/derekxu16/following{/other_user}","gists_url":"https://api.github.com/users/derekxu16/gists{/gist_id}","starred_url":"https://api.github.com/users/derekxu16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekxu16/subscriptions","organizations_url":"https://api.github.com/users/derekxu16/orgs","repos_url":"https://api.github.com/users/derekxu16/repos","events_url":"https://api.github.com/users/derekxu16/events{/privacy}","received_events_url":"https://api.github.com/users/derekxu16/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2024-03-26T15:29:29Z","updated_at":"2024-03-26T15:29:30Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"To do so, we need to deprecate `HttpProfileRequestData.connectionInfo`, deprecate `HttpProfileResponseData.connectionInfo`, and add `HttpProfileRequest.connectionInfo`.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55305/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55305/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55304","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55304/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55304/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55304/events","html_url":"https://github.com/dart-lang/sdk/issues/55304","id":2207969315,"node_id":"I_kwDOAiEj5s6DmvAj","number":55304,"title":"[gardening] standalone/io/resource_handle_test flaky timeout","user":{"login":"dcharkes","id":3601775,"node_id":"MDQ6VXNlcjM2MDE3NzU=","avatar_url":"https://avatars.githubusercontent.com/u/3601775?v=4","gravatar_id":"","url":"https://api.github.com/users/dcharkes","html_url":"https://github.com/dcharkes","followers_url":"https://api.github.com/users/dcharkes/followers","following_url":"https://api.github.com/users/dcharkes/following{/other_user}","gists_url":"https://api.github.com/users/dcharkes/gists{/gist_id}","starred_url":"https://api.github.com/users/dcharkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcharkes/subscriptions","organizations_url":"https://api.github.com/users/dcharkes/orgs","repos_url":"https://api.github.com/users/dcharkes/repos","events_url":"https://api.github.com/users/dcharkes/events{/privacy}","received_events_url":"https://api.github.com/users/dcharkes/received_events","type":"User","site_admin":false},"labels":[{"id":219928165,"node_id":"MDU6TGFiZWwyMTk5MjgxNjU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-vm","name":"area-vm","color":"c7def8","default":false,"description":null},{"id":512342379,"node_id":"MDU6TGFiZWw1MTIzNDIzNzk=","url":"https://api.github.com/repos/dart-lang/sdk/labels/gardening","name":"gardening","color":"E91E63","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-26T11:22:10Z","updated_at":"2024-03-26T11:22:10Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"```\r\n--- Command \"vm_compile_to_kernel\" (took 03.000056s):\r\nDART_CONFIGURATION=ReleaseMSANX64 /b/s/w/ir/cache/builder/sdk/pkg/vm/tool/gen_kernel --aot --platform=out/ReleaseMSANX64/vm_platform_strong.dill -o /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.dill /b/s/w/ir/cache/builder/sdk/tests/standalone/io/resource_handle_test.dart -Dtest_runner.configuration=vm-aot-msan-linux-release-x64 --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json -Ddart.vm.product=false --sound-null-safety\r\n\r\nexit code:\r\n0\r\n\r\n--- Command \"precompiler\" (took 11.000736s):\r\nDART_CONFIGURATION=ReleaseMSANX64 out/ReleaseMSANX64/gen_snapshot --snapshot-kind=app-aot-assembly --assembly=/b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.S --sound-null-safety -Dtest_runner.configuration=vm-aot-msan-linux-release-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.dill\r\n\r\nexit code:\r\n0\r\n\r\n--- Command \"remove_kernel_file\" (took 52ms):\r\nDART_CONFIGURATION=ReleaseMSANX64 rm /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.dill\r\n\r\nexit code:\r\n0\r\n\r\n--- Command \"assemble\" (took 01.000383s):\r\nDART_CONFIGURATION=ReleaseMSANX64 gcc -Wl,--no-undefined -shared -o /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.aotsnapshot /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.S\r\n\r\nexit code:\r\n0\r\n\r\n--- Command \"remove_assembly\" (took 50ms):\r\nDART_CONFIGURATION=ReleaseMSANX64 rm /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.S\r\n\r\nexit code:\r\n0\r\n\r\n--- Command \"vm\" (took 08:00.000703s):\r\nDART_CONFIGURATION=ReleaseMSANX64 TEST_COMPILATION_DIR=/b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test out/ReleaseMSANX64/dart_precompiled_runtime --sound-null-safety -Dtest_runner.configuration=vm-aot-msan-linux-release-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /b/s/w/ir/cache/builder/sdk/out/ReleaseMSANX64/generated_compilations/vm-aot-msan-linux-release-x64/tests_standalone_io_resource_handle_test/out.aotsnapshot\r\n\r\nexit code:\r\n1\r\n\r\ndiagnostics:\r\nProcess list including children: [107443]\r\nTrying to capture stack trace for pid 107443\r\nPID 107443 - process\r\nTID 107443:\r\n#0 0x00007fdb5a9f6376 pthread_cond_wait@@GLIBC_2.3.2\r\n#1 0x00005637e15185d6 dart::Monitor::WaitMicros(long)\r\n#2 0x00005637e15daa3f dart::ServiceIsolate::Shutdown()\r\n#3 0x00005637e1372ddd dart::Dart::Cleanup()\r\n#4 0x00005637e0fed261 dart::bin::main(int, char**)\r\n#5 0x00005637e0feb63d main\r\n#6 0x00007fdb5a6a4083 __libc_start_main\r\n#7 0x00005637e0f5da19 _start\r\nTID 107444:\r\n#0 0x00007fdb5a79f68e epoll_wait\r\n#1 0x00005637e0f89507 ___interceptor_epoll_wait\r\n#2 0x00005637e10060b3 dart::bin::EventHandlerImplementation::Poll(unsigned long)\r\n#3 0x00005637e12f0b29 dart::bin::ThreadStart(void*)\r\n#4 0x00007fdb5a9ef609 start_thread\r\n#5 0x00007fdb5a79f353 __clone\r\n\r\n\r\n\r\n--- Re-run this test:\r\npython3 tools/test.py -n vm-aot-msan-linux-release-x64 standalone/io/resource_handle_test\r\n```\r\n\r\nhttps://dart-ci.appspot.com/log/vm-aot-msan-linux-release-x64/vm-aot-msan-linux-release-x64/379/standalone/io/resource_handle_test\r\n\r\nThis test has been flaking time out on multiple configurations:\r\n\r\nhttps://dart-ci.web.app/#showLatestFailures=false&test=standalone/io/resource_handle_test\r\n\r\n![image](https://github.com/dart-lang/sdk/assets/3601775/66568310-9a65-40a9-89e9-9d9b7eb40d78)\r\n\r\n[flakiness dashboard](https://dashboards.corp.google.com/_0d7e1e34_2c58_4d29_bf12_cf7bed10396d?fb=configuration:re:%5Evm-.*&fb=name:in:standalone%2Fio%2Fresource_handle_test&fh=eJyljTEOwjAMRe_iOVPUhd6gc8aqg5UasJS4UbAHhLh7E5GBgY3x2frvrS_gHWaIh1z5ZhWVDwHXOFmWHw99FmpnlmLacEfFUCguXeL9ZZp8X9-xaj-tm4NsSTlQoqgwazVqEtbULfB2oy-Y6Ts7eNQen_X_ue0EBp9NZw..)","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55304/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55304/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55301","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55301/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55301/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55301/events","html_url":"https://github.com/dart-lang/sdk/issues/55301","id":2206791670,"node_id":"I_kwDOAiEj5s6DiPf2","number":55301,"title":"CFE allows trailing comma in catch clause","user":{"login":"munificent","id":46275,"node_id":"MDQ6VXNlcjQ2Mjc1","avatar_url":"https://avatars.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"labels":[{"id":524536392,"node_id":"MDU6TGFiZWw1MjQ1MzYzOTI=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-front-end","name":"area-front-end","color":"c5def5","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-25T21:56:14Z","updated_at":"2024-03-25T21:56:14Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"Consider:\r\n\r\n```dart\r\nmain() {\r\n try {\r\n throw 'Error';\r\n } catch (e, s,) {\r\n print('$e');\r\n }\r\n}\r\n```\r\n\r\nAnalyzer correctly reports and error on the trailing comma after `s`, which isn't allowed by the language grammar. But the VM is happy to run this program without error. It should also report an error on the trailing comma. I haven't tested any other compilers, so it may be that this is a VM-specific error. But I'm guessing that because it's a missing parser error, it's probably a bug in the CFE.\r\n","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55301/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55301/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55300","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55300/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55300/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55300/events","html_url":"https://github.com/dart-lang/sdk/issues/55300","id":2206746433,"node_id":"I_kwDOAiEj5s6DiEdB","number":55300,"title":"evaluate performance for multi-option contexts","user":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"labels":[{"id":219928158,"node_id":"MDU6TGFiZWwyMTk5MjgxNTg=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P1","name":"P1","color":"eb6420","default":false,"description":"A high priority bug; for example, a single project is unusable or has many test failures"},{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928321,"node_id":"MDU6TGFiZWwyMTk5MjgzMjE=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-performance","name":"type-performance","color":"ededed","default":false,"description":"Issue relates to performance or code size"},{"id":2904984403,"node_id":"MDU6TGFiZWwyOTA0OTg0NDAz","url":"https://api.github.com/repos/dart-lang/sdk/labels/analyzer-analysis-options","name":"analyzer-analysis-options","color":"D4C5F9","default":false,"description":""}],"state":"open","locked":false,"assignee":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"assignees":[{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-25T21:23:00Z","updated_at":"2024-03-25T21:41:22Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"Before turning on multi-option contexts, we'll want to be sure we aren't regressing performance. (I'm in particular concerned w/ the additional lookups required to map files being analyzed to their corresponding options files but there could be other impacts I'm not aware of.)","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55300/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55300/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55299","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55299/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55299/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55299/events","html_url":"https://github.com/dart-lang/sdk/issues/55299","id":2206743497,"node_id":"I_kwDOAiEj5s6DiDvJ","number":55299,"title":"[ddc] flaky behavior in for-loop eval test","user":{"login":"sigmundch","id":2049220,"node_id":"MDQ6VXNlcjIwNDkyMjA=","avatar_url":"https://avatars.githubusercontent.com/u/2049220?v=4","gravatar_id":"","url":"https://api.github.com/users/sigmundch","html_url":"https://github.com/sigmundch","followers_url":"https://api.github.com/users/sigmundch/followers","following_url":"https://api.github.com/users/sigmundch/following{/other_user}","gists_url":"https://api.github.com/users/sigmundch/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmundch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmundch/subscriptions","organizations_url":"https://api.github.com/users/sigmundch/orgs","repos_url":"https://api.github.com/users/sigmundch/repos","events_url":"https://api.github.com/users/sigmundch/events{/privacy}","received_events_url":"https://api.github.com/users/sigmundch/received_events","type":"User","site_admin":false},"labels":[{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":417806791,"node_id":"MDU6TGFiZWw0MTc4MDY3OTE=","url":"https://api.github.com/repos/dart-lang/sdk/labels/web-dev-compiler","name":"web-dev-compiler","color":"96f2ed","default":false,"description":""},{"id":1459742567,"node_id":"MDU6TGFiZWwxNDU5NzQyNTY3","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-web","name":"area-web","color":"c7def8","default":false,"description":"Issues related to Dart Web."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-03-25T21:21:05Z","updated_at":"2024-03-28T23:48:02Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"We have an [expression evaluation test](https://github.com/dart-lang/sdk/blob/97d8445e5f6395293f458761fe628588dd8ecb6a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart#L1428) that checks for the value of a loop variable on the first iteration of a loop. The test is flaky about 3% of the time in linux bots, but doesn't repro locally (I tested running it >1K times w/o success).\r\n\r\nThe failure logs suggest that the breakpoint is not hit on the first iteration of the loop, but the second iteration ([recent failure](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8752574142135385857/+/u/test_results/ignored_flaky_test_failure_logs)).\r\n\r\nTo reduce flakiness, I'll change the expectations to accept the current behavior (hit the breakpoint on either the first or second iteration), but if it continues to flake, we may prefer to skip it altogether.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55299/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55299/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55298","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55298/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55298/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55298/events","html_url":"https://github.com/dart-lang/sdk/issues/55298","id":2206524942,"node_id":"I_kwDOAiEj5s6DhOYO","number":55298,"title":"[dart2js] Incorrect code generated in body of a function used as a .call getter","user":{"login":"nshahan","id":2498387,"node_id":"MDQ6VXNlcjI0OTgzODc=","avatar_url":"https://avatars.githubusercontent.com/u/2498387?v=4","gravatar_id":"","url":"https://api.github.com/users/nshahan","html_url":"https://github.com/nshahan","followers_url":"https://api.github.com/users/nshahan/followers","following_url":"https://api.github.com/users/nshahan/following{/other_user}","gists_url":"https://api.github.com/users/nshahan/gists{/gist_id}","starred_url":"https://api.github.com/users/nshahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshahan/subscriptions","organizations_url":"https://api.github.com/users/nshahan/orgs","repos_url":"https://api.github.com/users/nshahan/repos","events_url":"https://api.github.com/users/nshahan/events{/privacy}","received_events_url":"https://api.github.com/users/nshahan/received_events","type":"User","site_admin":false},"labels":[{"id":219928173,"node_id":"MDU6TGFiZWwyMTk5MjgxNzM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/web-dart2js","name":"web-dart2js","color":"96f2ed","default":false,"description":""},{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":1459742567,"node_id":"MDU6TGFiZWwxNDU5NzQyNTY3","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-web","name":"area-web","color":"c7def8","default":false,"description":"Issues related to Dart Web."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-25T19:26:49Z","updated_at":"2024-03-25T19:47:52Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"There is some randomness thrown into this example to avoid inlining.\r\n\r\n```dart\r\nimport 'dart:math';\r\n\r\nclass C {\r\n int Function(String) get call => (s) => s.length;\r\n}\r\n\r\nmain() {\r\n var s = '${Random().nextBool() ? 'hello' : 'goodbye'} world';\r\n print(s.length); // prints as expected\r\n var c = C();\r\n print(c.call(s)); // boom!\r\n}\r\n```\r\n\r\nIn the main method `s.length` gets compiled to `s.length` in JavaScript. \r\n\r\nIn the body of the `.call` function `s.length` gets compiled to `s.get$length` in JavaScript which is not defined and will cause an error to be thrown.\r\n\r\n```\r\nUncaught TypeError: s.get$length is not a function\r\n at C_call_closure.call$1 (out.js:2628:16)\r\n at C.call$1 (out.js:2623:31)\r\n at main (out.js:2322:25)\r\n at out.js:2728:7\r\n at out.js:2709:7\r\n at dartProgram (out.js:2722:5)\r\n at out.js:2731:3\r\n```","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55298/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55298/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55297","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55297/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55297/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55297/events","html_url":"https://github.com/dart-lang/sdk/issues/55297","id":2206453898,"node_id":"I_kwDOAiEj5s6Dg9CK","number":55297,"title":"Hot reload test suite crashes test bots when parsing results logs","user":{"login":"Markzipan","id":6394052,"node_id":"MDQ6VXNlcjYzOTQwNTI=","avatar_url":"https://avatars.githubusercontent.com/u/6394052?v=4","gravatar_id":"","url":"https://api.github.com/users/Markzipan","html_url":"https://github.com/Markzipan","followers_url":"https://api.github.com/users/Markzipan/followers","following_url":"https://api.github.com/users/Markzipan/following{/other_user}","gists_url":"https://api.github.com/users/Markzipan/gists{/gist_id}","starred_url":"https://api.github.com/users/Markzipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markzipan/subscriptions","organizations_url":"https://api.github.com/users/Markzipan/orgs","repos_url":"https://api.github.com/users/Markzipan/repos","events_url":"https://api.github.com/users/Markzipan/events{/privacy}","received_events_url":"https://api.github.com/users/Markzipan/received_events","type":"User","site_admin":false},"labels":[{"id":417806791,"node_id":"MDU6TGFiZWw0MTc4MDY3OTE=","url":"https://api.github.com/repos/dart-lang/sdk/labels/web-dev-compiler","name":"web-dev-compiler","color":"96f2ed","default":false,"description":""},{"id":1459742567,"node_id":"MDU6TGFiZWwxNDU5NzQyNTY3","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-web","name":"area-web","color":"c7def8","default":false,"description":"Issues related to Dart Web."},{"id":3487336660,"node_id":"LA_kwDOAiEj5s7P3IjU","url":"https://api.github.com/repos/dart-lang/sdk/labels/web-infrastructure","name":"web-infrastructure","color":"96f2ed","default":false,"description":"internal techdebt or infrastructure issues affecting the web team specifically"}],"state":"open","locked":false,"assignee":{"login":"Markzipan","id":6394052,"node_id":"MDQ6VXNlcjYzOTQwNTI=","avatar_url":"https://avatars.githubusercontent.com/u/6394052?v=4","gravatar_id":"","url":"https://api.github.com/users/Markzipan","html_url":"https://github.com/Markzipan","followers_url":"https://api.github.com/users/Markzipan/followers","following_url":"https://api.github.com/users/Markzipan/following{/other_user}","gists_url":"https://api.github.com/users/Markzipan/gists{/gist_id}","starred_url":"https://api.github.com/users/Markzipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markzipan/subscriptions","organizations_url":"https://api.github.com/users/Markzipan/orgs","repos_url":"https://api.github.com/users/Markzipan/repos","events_url":"https://api.github.com/users/Markzipan/events{/privacy}","received_events_url":"https://api.github.com/users/Markzipan/received_events","type":"User","site_admin":false},"assignees":[{"login":"Markzipan","id":6394052,"node_id":"MDQ6VXNlcjYzOTQwNTI=","avatar_url":"https://avatars.githubusercontent.com/u/6394052?v=4","gravatar_id":"","url":"https://api.github.com/users/Markzipan","html_url":"https://github.com/Markzipan","followers_url":"https://api.github.com/users/Markzipan/followers","following_url":"https://api.github.com/users/Markzipan/following{/other_user}","gists_url":"https://api.github.com/users/Markzipan/gists{/gist_id}","starred_url":"https://api.github.com/users/Markzipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markzipan/subscriptions","organizations_url":"https://api.github.com/users/Markzipan/orgs","repos_url":"https://api.github.com/users/Markzipan/repos","events_url":"https://api.github.com/users/Markzipan/events{/privacy}","received_events_url":"https://api.github.com/users/Markzipan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2024-03-25T18:54:03Z","updated_at":"2024-03-25T18:54:04Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"```\r\nUnhandled exception:\r\nFormatException: Unexpected end of input (at character 1)\r\n\r\n^\r\n\r\n#0 _ChunkedJsonParser.fail (dart:convert-patch/convert_patch.dart:1376:5)\r\n#1 _ChunkedJsonParser.close (dart:convert-patch/convert_patch.dart:494:7)\r\n#2 _parseJson (dart:convert-patch/convert_patch.dart:36:10)\r\n#3 JsonDecoder.convert (dart:convert/json.dart:610:36)\r\n#4 JsonCodec.decode (dart:convert/json.dart:216:41)\r\n#5 jsonDecode (dart:convert/json.dart:155:10)\r\n#6 loadResults (package:test_runner/bot_results.dart:171:17)\r\n\r\n#7 loadResultsMap (package:test_runner/bot_results.dart:190:22)\r\n\r\n#8 main (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/test_runner/bin/compare_results.dart:237:9)\r\n\r\n```\r\n\r\nThe trybots' test output expects a valid JSON object on each line of the output, and every output blob must be followed by a line delimiter (delimiters are not platform-specific). However, results for this test appear to still be crashing.\r\n\r\nThe following `results.json` snippet does not cause failures:\r\n```\r\n{\"name\":\"tests/reload/framework_timing_test\",\"configuration\":\"ddc-win-chrome\",\"suite\":\"tests/reload\",\"test_name\":\"framework_timing_test\",\"time_ms\":3181,\"expected\":\"Pass\",\"result\":\"Pass\",\"matches\":true}\r\n{\"name\":\"tests/reload/hot_restart_constant_equality\",\"configuration\":\"ddc-win-chrome\",\"suite\":\"tests/reload\",\"test_name\":\"hot_restart_constant_equality\",\"time_ms\":1089,\"expected\":\"Pass\",\"result\":\"Pass\",\"matches\":true}\r\n```\r\n\r\nBut the following `logs.json` fails:\r\n```\r\n{\"name\":\"tests/reload/framework_timing_test\",\"configuration\":\"ddc-win-chrome\",\"result\":\"Pass\",\"log\":\"console.info: DDC is about to load 4/4 scripts with pool size = 1000\\nconsole.info: DDC: Subapp Module [main.dart:main.dart:00000000-0000-0000-0000-000000000000] is starting\\nRe-loading main.dart\\nconsole.info: DDC: Subapp Module [main.dart:main.dart:00000000-0000-0000-0000-000000000000] is starting\\nRe-loading main.dart\\nconsole.info: DDC: Subapp Module [main.dart:main.dart:00000000-0000-0000-0000-000000000000] is starting\\n\"}\r\n{\"name\":\"tests/reload/hot_restart_constant_equality\",\"configuration\":\"ddc-win-chrome\",\"result\":\"Pass\",\"log\":\"console.info: DDC is about to load 6/6 scripts with pool size = 1000\\nconsole.info: DDC: Subapp Module [main.dart:main.dart:00000000-0000-0000-0000-000000000000] is starting\\nRe-loading main.dart\\nRe-loading library_b.dart\\nconsole.info: DDC: Subapp Module [main.dart:main.dart:00000000-0000-0000-0000-000000000000] is starting\\n\"}\r\n\r\n```","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55297/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55297/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55295","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55295/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55295/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55295/events","html_url":"https://github.com/dart-lang/sdk/issues/55295","id":2205294743,"node_id":"I_kwDOAiEj5s6DciCX","number":55295,"title":"No error in the analyzer if augment class goes before original class","user":{"login":"sgrekhov","id":4627088,"node_id":"MDQ6VXNlcjQ2MjcwODg=","avatar_url":"https://avatars.githubusercontent.com/u/4627088?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrekhov","html_url":"https://github.com/sgrekhov","followers_url":"https://api.github.com/users/sgrekhov/followers","following_url":"https://api.github.com/users/sgrekhov/following{/other_user}","gists_url":"https://api.github.com/users/sgrekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrekhov/subscriptions","organizations_url":"https://api.github.com/users/sgrekhov/orgs","repos_url":"https://api.github.com/users/sgrekhov/repos","events_url":"https://api.github.com/users/sgrekhov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrekhov/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":6120007145,"node_id":"LA_kwDOAiEj5s8AAAABbMfl6Q","url":"https://api.github.com/repos/dart-lang/sdk/labels/feature-macros","name":"feature-macros","color":"bfdadc","default":false,"description":"Implementation of the macros feature"}],"state":"open","locked":false,"assignee":{"login":"scheglov","id":384794,"node_id":"MDQ6VXNlcjM4NDc5NA==","avatar_url":"https://avatars.githubusercontent.com/u/384794?v=4","gravatar_id":"","url":"https://api.github.com/users/scheglov","html_url":"https://github.com/scheglov","followers_url":"https://api.github.com/users/scheglov/followers","following_url":"https://api.github.com/users/scheglov/following{/other_user}","gists_url":"https://api.github.com/users/scheglov/gists{/gist_id}","starred_url":"https://api.github.com/users/scheglov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheglov/subscriptions","organizations_url":"https://api.github.com/users/scheglov/orgs","repos_url":"https://api.github.com/users/scheglov/repos","events_url":"https://api.github.com/users/scheglov/events{/privacy}","received_events_url":"https://api.github.com/users/scheglov/received_events","type":"User","site_admin":false},"assignees":[{"login":"scheglov","id":384794,"node_id":"MDQ6VXNlcjM4NDc5NA==","avatar_url":"https://avatars.githubusercontent.com/u/384794?v=4","gravatar_id":"","url":"https://api.github.com/users/scheglov","html_url":"https://github.com/scheglov","followers_url":"https://api.github.com/users/scheglov/followers","following_url":"https://api.github.com/users/scheglov/following{/other_user}","gists_url":"https://api.github.com/users/scheglov/gists{/gist_id}","starred_url":"https://api.github.com/users/scheglov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheglov/subscriptions","organizations_url":"https://api.github.com/users/scheglov/orgs","repos_url":"https://api.github.com/users/scheglov/repos","events_url":"https://api.github.com/users/scheglov/events{/privacy}","received_events_url":"https://api.github.com/users/scheglov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-25T09:32:40Z","updated_at":"2024-03-26T20:35:32Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"According to the [specification](https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/feature-specification.md#augmenting-declarations)\r\n\r\n> It is a compile-time error if:\r\n> ...\r\n> - An augmenting declaration appears in a library before the library where the original declaration occurs, according to merge order.\r\n> \r\n\r\nSee https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/merge_order_A01_t02.dart\r\nThere is no this error in the analyzer\r\n```dart\r\n// merge_order_A01_t02.dart\r\nimport augment 'merge_order_A01_t02_lib1.dart';\r\n\r\naugment class A {} // No expected error\r\n// ^\r\n// [analyzer] unspecified\r\n// [cfe] unspecified\r\n\r\n// merge_order_A01_t02_lib1.dart\r\nlibrary augment 'merge_order_A01_t02.dart'; // The new syntax is augment library, I know\r\n\r\nclass A {\r\n}\r\n```","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55295/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55295/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55294","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55294/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55294/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55294/events","html_url":"https://github.com/dart-lang/sdk/issues/55294","id":2205215537,"node_id":"I_kwDOAiEj5s6DcOsx","number":55294,"title":"No error in the analyzer if augmenting type declares different number of parameters","user":{"login":"sgrekhov","id":4627088,"node_id":"MDQ6VXNlcjQ2MjcwODg=","avatar_url":"https://avatars.githubusercontent.com/u/4627088?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrekhov","html_url":"https://github.com/sgrekhov","followers_url":"https://api.github.com/users/sgrekhov/followers","following_url":"https://api.github.com/users/sgrekhov/following{/other_user}","gists_url":"https://api.github.com/users/sgrekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrekhov/subscriptions","organizations_url":"https://api.github.com/users/sgrekhov/orgs","repos_url":"https://api.github.com/users/sgrekhov/repos","events_url":"https://api.github.com/users/sgrekhov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrekhov/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":6120007145,"node_id":"LA_kwDOAiEj5s8AAAABbMfl6Q","url":"https://api.github.com/repos/dart-lang/sdk/labels/feature-macros","name":"feature-macros","color":"bfdadc","default":false,"description":"Implementation of the macros feature"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-25T08:53:41Z","updated_at":"2024-03-26T16:13:09Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"According to the augmentation libraries [specification](https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/feature-specification.md#augmenting-types)\r\n\r\n> It is a compile-time error if:\r\n> ...\r\n> - The type parameters of the type augmentation do not match the original type's type parameters. This means there must be the same number of type parameters with the same bounds and names.\r\n\r\nBut there is no such error in the analyzer. See https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmenting_types_A05_t01.dart\r\n```dart\r\n//augmenting_types_A05_t01.dart\r\n\r\nimport augment 'augmenting_types_A05_t01_lib.dart';\r\n\r\nclass C {}\r\n\r\n// augmenting_types_A05_t01_lib.dart\r\n\r\nlibrary augment 'augmenting_types_A05_t01.dart';\r\n\r\naugment class C {} // No expected error\r\n// ^\r\n// [analyzer] unspecified\r\n// [cfe] unspecified\r\n\r\naugment class C {} // No expected error\r\n// ^^^^\r\n// [analyzer] unspecified\r\n// [cfe] unspecified\r\n```\r\nTested on the edge SDK (March 25, 2024)","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55294/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55294/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55293","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55293/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55293/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55293/events","html_url":"https://github.com/dart-lang/sdk/issues/55293","id":2205198744,"node_id":"I_kwDOAiEj5s6DcKmY","number":55293,"title":"No error in the analyzer to augment different type","user":{"login":"sgrekhov","id":4627088,"node_id":"MDQ6VXNlcjQ2MjcwODg=","avatar_url":"https://avatars.githubusercontent.com/u/4627088?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrekhov","html_url":"https://github.com/sgrekhov","followers_url":"https://api.github.com/users/sgrekhov/followers","following_url":"https://api.github.com/users/sgrekhov/following{/other_user}","gists_url":"https://api.github.com/users/sgrekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrekhov/subscriptions","organizations_url":"https://api.github.com/users/sgrekhov/orgs","repos_url":"https://api.github.com/users/sgrekhov/repos","events_url":"https://api.github.com/users/sgrekhov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrekhov/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":334171875,"node_id":"MDU6TGFiZWwzMzQxNzE4NzU=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P2","name":"P2","color":"fbca04","default":false,"description":"A bug or feature request we're likely to work on"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":6120007145,"node_id":"LA_kwDOAiEj5s8AAAABbMfl6Q","url":"https://api.github.com/repos/dart-lang/sdk/labels/feature-macros","name":"feature-macros","color":"bfdadc","default":false,"description":"Implementation of the macros feature"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-25T08:43:29Z","updated_at":"2024-03-26T16:14:01Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"According to the augmentation libraries [specification](https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/feature-specification.md#augmenting-types)\r\n\r\n> It is a compile-time error if:\r\n> \r\n> - The augmenting type and corresponding type are not the same kind: class, mixin, enum, extension, or extension type. You can't augment a class with a mixin, etc.\r\n> \r\n\r\nBut the analyzer doesn't report this error. See https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmenting_types_A01_t02.dart\r\n\r\n```dart\r\n// augmenting_types_A01_t02.dart\r\n\r\nimport augment 'augmenting_types_A01_t02_lib1.dart';\r\n\r\nclass C {}\r\n\r\ntypedef CAlias = C;\r\n\r\n// augmenting_types_A01_t02_lib1.dart\r\nlibrary augment 'augmenting_types_A01_t02.dart'; // I know that the new syntax is `augment library ...`\r\n\r\naugment mixin CAlias {} // No expected error\r\n// ^^^^^^\r\n// [analyzer] unspecified\r\n// [cfe] unspecified\r\n```\r\n Tested on the edge SDK (March 25, 2024)","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55293/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55293/timeline","performed_via_github_app":null,"state_reason":null},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55289","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55289/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55289/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55289/events","html_url":"https://github.com/dart-lang/sdk/issues/55289","id":2203988012,"node_id":"I_kwDOAiEj5s6DXjAs","number":55289,"title":"Adding package http makes dart run really slow","user":{"login":"knopp","id":96958,"node_id":"MDQ6VXNlcjk2OTU4","avatar_url":"https://avatars.githubusercontent.com/u/96958?v=4","gravatar_id":"","url":"https://api.github.com/users/knopp","html_url":"https://github.com/knopp","followers_url":"https://api.github.com/users/knopp/followers","following_url":"https://api.github.com/users/knopp/following{/other_user}","gists_url":"https://api.github.com/users/knopp/gists{/gist_id}","starred_url":"https://api.github.com/users/knopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knopp/subscriptions","organizations_url":"https://api.github.com/users/knopp/orgs","repos_url":"https://api.github.com/users/knopp/repos","events_url":"https://api.github.com/users/knopp/events{/privacy}","received_events_url":"https://api.github.com/users/knopp/received_events","type":"User","site_admin":false},"labels":[{"id":1757975932,"node_id":"MDU6TGFiZWwxNzU3OTc1OTMy","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-dart-cli","name":"area-dart-cli","color":"c7def8","default":false,"description":"Issues related to the Dart unified command line interface, also known as DartDev"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2024-03-23T18:10:05Z","updated_at":"2024-03-27T14:09:41Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"I'm not sure if this is the right project to report this.\r\n\r\nDart SDK version: 3.4.0-265.0.dev (dev) (Sat Mar 23 01:03:42 2024 -0700) on \"macos_arm64\"\r\n\r\nSteps to reproduce\r\n```sh\r\n% dart create -t cli test_1\r\n% cd test_1\r\n% time dart run\r\n```\r\noutputs\r\n```\r\nResolving dependencies in /Users/Matej/Projects/dart/test_1...\r\nDownloading packages...\r\nGot dependencies in /Users/Matej/Projects/dart/test_1.\r\nBuilding package executable...\r\nBuilt test_1:test_1.\r\nPositional arguments: []\r\ndart run 0.54s user 0.09s system 137% cpu 0.454 total\r\n```\r\n\r\nadd package `http`\r\n```\r\ndart pub add http\r\ntime dart run\r\n```\r\n\r\noutputs\r\n\r\n```\r\nResolving dependencies in /Users/Matej/Projects/dart/test_1...\r\nDownloading packages...\r\nGot dependencies in /Users/Matej/Projects/dart/test_1.\r\nBuilding package executable...\r\nBuilt test_1:test_1.\r\nPositional arguments: []\r\ndart run 0.64s user 0.11s system 4% cpu 15.846 total\r\n```\r\n\r\nNot sure why this takes 15 seconds. It seems that the main thread is waiting for something\r\n```\r\n * frame #0: 0x0000000183e60524 libsystem_kernel.dylib`__psynch_mutexwait + 8\r\n frame #1: 0x0000000183e9b168 libsystem_pthread.dylib`_pthread_mutex_firstfit_lock_wait + 84\r\n frame #2: 0x0000000183e98af8 libsystem_pthread.dylib`_pthread_mutex_firstfit_lock_slow + 248\r\n frame #3: 0x0000000183e9e688 libsystem_pthread.dylib`_pthread_cond_wait + 1368\r\n frame #4: 0x00000001044e2610 dart`___lldb_unnamed_symbol4504 + 152\r\n frame #5: 0x000000010440d324 dart`___lldb_unnamed_symbol1429 + 160\r\n frame #6: 0x000000010440d954 dart`___lldb_unnamed_symbol1433 + 40\r\n frame #7: 0x000000010440faa0 dart`___lldb_unnamed_symbol1475 + 1248\r\n frame #8: 0x000000010440ec84 dart`___lldb_unnamed_symbol1470 + 16\r\n frame #9: 0x0000000183b1d0e0 dyld`start + 2360\r\n```\r\nThe dart build shipped with Flutter has stripped symbols so it doesn't help much. I'll try running this with custom engine build.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55289/reactions","total_count":6,"+1":6,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55289/timeline","performed_via_github_app":null,"state_reason":"reopened"},{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55284","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/55284/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/55284/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/55284/events","html_url":"https://github.com/dart-lang/sdk/issues/55284","id":2203540561,"node_id":"I_kwDOAiEj5s6DV1xR","number":55284,"title":"Weird type inference issue","user":{"login":"lukehutch","id":811305,"node_id":"MDQ6VXNlcjgxMTMwNQ==","avatar_url":"https://avatars.githubusercontent.com/u/811305?v=4","gravatar_id":"","url":"https://api.github.com/users/lukehutch","html_url":"https://github.com/lukehutch","followers_url":"https://api.github.com/users/lukehutch/followers","following_url":"https://api.github.com/users/lukehutch/following{/other_user}","gists_url":"https://api.github.com/users/lukehutch/gists{/gist_id}","starred_url":"https://api.github.com/users/lukehutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukehutch/subscriptions","organizations_url":"https://api.github.com/users/lukehutch/orgs","repos_url":"https://api.github.com/users/lukehutch/repos","events_url":"https://api.github.com/users/lukehutch/events{/privacy}","received_events_url":"https://api.github.com/users/lukehutch/received_events","type":"User","site_admin":false},"labels":[{"id":219928186,"node_id":"MDU6TGFiZWwyMTk5MjgxODY=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-analyzer","name":"area-analyzer","color":"c7def8","default":false,"description":null},{"id":219928190,"node_id":"MDU6TGFiZWwyMTk5MjgxOTA=","url":"https://api.github.com/repos/dart-lang/sdk/labels/P3","name":"P3","color":"bfe5bf","default":false,"description":"A lower priority bug or feature request"},{"id":334529063,"node_id":"MDU6TGFiZWwzMzQ1MjkwNjM=","url":"https://api.github.com/repos/dart-lang/sdk/labels/type-bug","name":"type-bug","color":"ededed","default":false,"description":"Incorrect behavior (everything from a crash to more subtle misbehavior)"},{"id":524536392,"node_id":"MDU6TGFiZWw1MjQ1MzYzOTI=","url":"https://api.github.com/repos/dart-lang/sdk/labels/area-front-end","name":"area-front-end","color":"c5def5","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2024-03-23T00:05:27Z","updated_at":"2024-03-27T16:38:39Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"Given this code:\r\n\r\n```dart\r\nMap> names = {};\r\n\r\nList getNames(int id) {\r\n var result = [...names[id] ?? []];\r\n return result;\r\n}\r\n```\r\n\r\nI get no type error in VS Code, but when I try to build and run the project, I get this error:\r\n\r\n```console\r\ntest.dart:9:10: Error: A value of type 'List' can't be returned from a function with return type 'List'.\r\n - 'List' is from 'dart:core'.\r\n return result;\r\n ^\r\n```\r\n\r\nWeirdly, converting this into a lambda fixes the compile-time error:\r\n\r\n```dart\r\nMap> names = {};\r\n\r\nList getNames(int id) => [...names[id] ?? []];\r\n```\r\n\r\nI don't understand how type inference could work in this latter case but not work in the former case.\r\n\r\nAlso, the analyzer that VS Code relies upon should give this sort of error while editing the code, there shouldn't be new errors that pop up at compile-time that were not already shown in the editor.","reactions":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/55284/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/dart-lang/sdk/issues/55284/timeline","performed_via_github_app":null,"state_reason":null}]