{"url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221","repository_url":"https://api.github.com/repos/jito-foundation/jito-solana","labels_url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221/comments","events_url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221/events","html_url":"https://github.com/jito-foundation/jito-solana/pull/221","id":1509029860,"node_id":"PR_kwDOG7KhZ85GGnFP","number":221,"title":"fix: simulate bundle rpc was returning sucess on empty list","user":{"login":"anoushk1234","id":32778608,"node_id":"MDQ6VXNlcjMyNzc4NjA4","avatar_url":"https://avatars.githubusercontent.com/u/32778608?v=4","gravatar_id":"","url":"https://api.github.com/users/anoushk1234","html_url":"https://github.com/anoushk1234","followers_url":"https://api.github.com/users/anoushk1234/followers","following_url":"https://api.github.com/users/anoushk1234/following{/other_user}","gists_url":"https://api.github.com/users/anoushk1234/gists{/gist_id}","starred_url":"https://api.github.com/users/anoushk1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anoushk1234/subscriptions","organizations_url":"https://api.github.com/users/anoushk1234/orgs","repos_url":"https://api.github.com/users/anoushk1234/repos","events_url":"https://api.github.com/users/anoushk1234/events{/privacy}","received_events_url":"https://api.github.com/users/anoushk1234/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[],"state":"closed","locked":false,"assignees":[],"milestone":null,"comments":3,"created_at":"2022-12-23T08:03:39Z","updated_at":"2023-02-14T17:23:19Z","closed_at":"2023-02-14T17:23:18Z","assignee":null,"author_association":"NONE","type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/jito-foundation/jito-solana/pulls/221","html_url":"https://github.com/jito-foundation/jito-solana/pull/221","diff_url":"https://github.com/jito-foundation/jito-solana/pull/221.diff","patch_url":"https://github.com/jito-foundation/jito-solana/pull/221.patch","merged_at":null},"body":"#### Problem\r\nThe function simulate_bundle in rpc.rs would return success even if list of encoded transactions was empty, this is misleading.\r\n\r\n#### Summary of Changes\r\n- Changed simulate_bundle to early return error if rpc_bundle_request has empty list of encoded transactions\r\n- Added test case test_rpc_simulate_bundle_error_on_empty_list that verifies that the function returns the InvalidParams error if an empty list is passed\r\n\r\nFixes #165 \r\n<!-- OPTIONAL: Feature Gate Issue: # -->\r\n<!-- Don't forget to add the \"feature-gate\" label -->\r\n","closed_by":{"login":"segfaultdoc","id":17258903,"node_id":"MDQ6VXNlcjE3MjU4OTAz","avatar_url":"https://avatars.githubusercontent.com/u/17258903?v=4","gravatar_id":"","url":"https://api.github.com/users/segfaultdoc","html_url":"https://github.com/segfaultdoc","followers_url":"https://api.github.com/users/segfaultdoc/followers","following_url":"https://api.github.com/users/segfaultdoc/following{/other_user}","gists_url":"https://api.github.com/users/segfaultdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/segfaultdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segfaultdoc/subscriptions","organizations_url":"https://api.github.com/users/segfaultdoc/orgs","repos_url":"https://api.github.com/users/segfaultdoc/repos","events_url":"https://api.github.com/users/segfaultdoc/events{/privacy}","received_events_url":"https://api.github.com/users/segfaultdoc/received_events","type":"User","user_view_type":"public","site_admin":false},"reactions":{"url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/jito-foundation/jito-solana/issues/221/timeline","performed_via_github_app":null,"state_reason":null}