{"url":"https://api.github.com/repos/nushell/nushell/issues/3359","repository_url":"https://api.github.com/repos/nushell/nushell","labels_url":"https://api.github.com/repos/nushell/nushell/issues/3359/labels{/name}","comments_url":"https://api.github.com/repos/nushell/nushell/issues/3359/comments","events_url":"https://api.github.com/repos/nushell/nushell/issues/3359/events","html_url":"https://github.com/nushell/nushell/pull/3359","id":868224133,"node_id":"MDExOlB1bGxSZXF1ZXN0NjIzNzgyNjIz","number":3359,"title":"Fix table-pager feature compilation","user":{"login":"kubouch","id":25571562,"node_id":"MDQ6VXNlcjI1NTcxNTYy","avatar_url":"https://avatars.githubusercontent.com/u/25571562?v=4","gravatar_id":"","url":"https://api.github.com/users/kubouch","html_url":"https://github.com/kubouch","followers_url":"https://api.github.com/users/kubouch/followers","following_url":"https://api.github.com/users/kubouch/following{/other_user}","gists_url":"https://api.github.com/users/kubouch/gists{/gist_id}","starred_url":"https://api.github.com/users/kubouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubouch/subscriptions","organizations_url":"https://api.github.com/users/kubouch/orgs","repos_url":"https://api.github.com/users/kubouch/repos","events_url":"https://api.github.com/users/kubouch/events{/privacy}","received_events_url":"https://api.github.com/users/kubouch/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[],"state":"closed","locked":false,"assignees":[],"milestone":null,"comments":1,"created_at":"2021-04-26T21:39:44Z","updated_at":"2021-05-01T12:39:41Z","closed_at":"2021-04-27T07:06:58Z","assignee":null,"author_association":"CONTRIBUTOR","type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/nushell/nushell/pulls/3359","html_url":"https://github.com/nushell/nushell/pull/3359","diff_url":"https://github.com/nushell/nushell/pull/3359.diff","patch_url":"https://github.com/nushell/nushell/pull/3359.patch","merged_at":"2021-04-27T07:06:57Z"},"body":"Due to the engine change, the `table-pager` feature was broken. This is a quick and dirty attempt to fix it.\r\n\r\nIt compiles fine and seems to run without errors but the pager is now synchronous. When you run `seq 1 1000000`, you need to wait until it finishes before the pager is displayed. I tried to make it async but couldn't figure it out -- I'm not really experienced with async programming.\r\n\r\nThe synchronous implementation could possibly be simplified but I kept the async stuff in as a possibility to run the pager asynchronously again.\r\n\r\nCloses #3277 \r\nWould close #3355 (already closed)","closed_by":{"login":"sophiajt","id":547158,"node_id":"MDQ6VXNlcjU0NzE1OA==","avatar_url":"https://avatars.githubusercontent.com/u/547158?v=4","gravatar_id":"","url":"https://api.github.com/users/sophiajt","html_url":"https://github.com/sophiajt","followers_url":"https://api.github.com/users/sophiajt/followers","following_url":"https://api.github.com/users/sophiajt/following{/other_user}","gists_url":"https://api.github.com/users/sophiajt/gists{/gist_id}","starred_url":"https://api.github.com/users/sophiajt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophiajt/subscriptions","organizations_url":"https://api.github.com/users/sophiajt/orgs","repos_url":"https://api.github.com/users/sophiajt/repos","events_url":"https://api.github.com/users/sophiajt/events{/privacy}","received_events_url":"https://api.github.com/users/sophiajt/received_events","type":"User","user_view_type":"public","site_admin":false},"reactions":{"url":"https://api.github.com/repos/nushell/nushell/issues/3359/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/nushell/nushell/issues/3359/timeline","performed_via_github_app":null,"state_reason":null}