[{"id":"36561018839","type":"ReleaseEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":299675717,"name":"Azure/bicep-types-az","url":"https://api.github.com/repos/Azure/bicep-types-az"},"payload":{"action":"published","release":{"url":"https://api.github.com/repos/Azure/bicep-types-az/releases/146640219","assets_url":"https://api.github.com/repos/Azure/bicep-types-az/releases/146640219/assets","upload_url":"https://uploads.github.com/repos/Azure/bicep-types-az/releases/146640219/assets{?name,label}","html_url":"https://github.com/Azure/bicep-types-az/releases/tag/0.0.0-test","id":146640219,"author":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"node_id":"RE_kwDOEdywRc4IvY1b","tag_name":"0.0.0-test","target_commitish":"main","name":"Test","draft":false,"prerelease":false,"created_at":"2024-03-10T13:10:18Z","published_at":"2024-03-14T17:51:44Z","assets":[{"url":"https://api.github.com/repos/Azure/bicep-types-az/releases/assets/156709856","id":156709856,"node_id":"RA_kwDOEdywRc4JVzPg","name":"generated.zip","label":null,"uploader":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"content_type":"application/x-zip-compressed","state":"uploaded","size":35081543,"download_count":0,"created_at":"2024-03-14T17:50:31Z","updated_at":"2024-03-14T17:50:37Z","browser_download_url":"https://github.com/Azure/bicep-types-az/releases/download/0.0.0-test/generated.zip"}],"tarball_url":"https://api.github.com/repos/Azure/bicep-types-az/tarball/0.0.0-test","zipball_url":"https://api.github.com/repos/Azure/bicep-types-az/zipball/0.0.0-test","body":"This is a test release to test azure function app hanlder","short_description_html":"
This is a test release to test azure function app hanlder
","is_short_description_html_truncated":false}},"public":true,"created_at":"2024-03-14T17:51:44Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36561019084","type":"CreateEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":299675717,"name":"Azure/bicep-types-az","url":"https://api.github.com/repos/Azure/bicep-types-az"},"payload":{"ref":"0.0.0-test","ref_type":"tag","master_branch":"main","description":"Bicep type definitions for ARM resources","pusher_type":"user"},"public":true,"created_at":"2024-03-14T17:51:45Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36387838665","type":"ReleaseEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":299675717,"name":"Azure/bicep-types-az","url":"https://api.github.com/repos/Azure/bicep-types-az"},"payload":{"action":"published","release":{"url":"https://api.github.com/repos/Azure/bicep-types-az/releases/145570386","assets_url":"https://api.github.com/repos/Azure/bicep-types-az/releases/145570386/assets","upload_url":"https://uploads.github.com/repos/Azure/bicep-types-az/releases/145570386/assets{?name,label}","html_url":"https://github.com/Azure/bicep-types-az/releases/tag/v0.0-test","id":145570386,"author":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"node_id":"RE_kwDOEdywRc4IrTpS","tag_name":"v0.0-test","target_commitish":"main","name":"Test","draft":false,"prerelease":true,"created_at":"2024-03-04T20:23:24Z","published_at":"2024-03-08T22:20:03Z","assets":[{"url":"https://api.github.com/repos/Azure/bicep-types-az/releases/assets/155698313","id":155698313,"node_id":"RA_kwDOEdywRc4JR8SJ","name":"generated.zip","label":null,"uploader":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"content_type":"application/x-zip-compressed","state":"uploaded","size":29948222,"download_count":0,"created_at":"2024-03-08T22:19:52Z","updated_at":"2024-03-08T22:19:59Z","browser_download_url":"https://github.com/Azure/bicep-types-az/releases/download/v0.0-test/generated.zip"}],"tarball_url":"https://api.github.com/repos/Azure/bicep-types-az/tarball/v0.0-test","zipball_url":"https://api.github.com/repos/Azure/bicep-types-az/zipball/v0.0-test","body":"","short_description_html":"","is_short_description_html_truncated":false}},"public":true,"created_at":"2024-03-08T22:20:03Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36387838726","type":"CreateEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":299675717,"name":"Azure/bicep-types-az","url":"https://api.github.com/repos/Azure/bicep-types-az"},"payload":{"ref":"v0.0-test","ref_type":"tag","master_branch":"main","description":"Bicep type definitions for ARM resources","pusher_type":"user"},"public":true,"created_at":"2024-03-08T22:20:03Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36355978048","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1923784372,"node_id":"PRR_kwDOD7S9ks5yqp60","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"Regarding the use of the identifier syntax, I thought that the idea was to hide it behind a feature flag (FF), but it seems like the way to do it is adopting the new syntax without subjecting it to the presence of the dynamic type loading FF ","commit_id":"f8872c25da531eb6b0e72854f914e696d84503a1","submitted_at":"2024-03-07T23:47:35Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13542#pullrequestreview-1923784372","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13542","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13542#pullrequestreview-1923784372"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13542"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13542","id":1760169969,"node_id":"PR_kwDOD7S9ks5o6g_x","html_url":"https://github.com/Azure/bicep/pull/13542","diff_url":"https://github.com/Azure/bicep/pull/13542.diff","patch_url":"https://github.com/Azure/bicep/pull/13542.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13542","number":13542,"state":"closed","locked":false,"title":"Fix for various issues noticed with provider syntax","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"1. The `BCP395` codefix incorrectly replaces `provider 'kubernetes@1.0.0'` with non-working syntax `provider 'kubernetes'`, whereas it should be `provider kubernetes`.\r\n1. Completions recommend the 'legacy' syntax instead of the recommended one.\r\n1. Completions don't work in the following case: `provider k|`\r\n1. Hovers show `import ` instead of `provider `\r\n1. ImportKubernetesManifest generates the 'legacy' syntax instead of the recommended one.\r\n1. Many tests are using the legacy syntax with a suppression for `BCP395`, rather than the new one.","created_at":"2024-03-07T04:06:05Z","updated_at":"2024-03-07T23:47:35Z","closed_at":"2024-03-07T17:31:57Z","merged_at":"2024-03-07T17:31:57Z","merge_commit_sha":"6b4769fd5e0acaf5913b03e467731caf3d65b7d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13542/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13542/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13542/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/f8872c25da531eb6b0e72854f914e696d84503a1","head":{"label":"Azure:ant/codefix","ref":"ant/codefix","sha":"f8872c25da531eb6b0e72854f914e696d84503a1","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-06T21:18:13Z","pushed_at":"2024-03-07T22:44:09Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133982,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1175,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1175,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"9fd452ed39fda306e0881387a535eaef78a91661","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-06T21:18:13Z","pushed_at":"2024-03-07T22:44:09Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133982,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1175,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1175,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13542"},"html":{"href":"https://github.com/Azure/bicep/pull/13542"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13542"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13542/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13542/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13542/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/f8872c25da531eb6b0e72854f914e696d84503a1"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-07T23:47:35Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36281475540","type":"PushEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"repository_id":263503250,"push_id":17405568688,"size":1,"distinct_size":1,"ref":"refs/heads/main","head":"c49faacc0d2426a6201d3e7332f6952a0a31723e","before":"3a300e5b1c3a9a523c7943bc04e674c3a523475f","commits":[{"sha":"c49faacc0d2426a6201d3e7332f6952a0a31723e","author":{"email":"38542602+anthony-c-martin@users.noreply.github.com","name":"Anthony Martin"},"message":"Refactor SourceFileGrouping to remove provider logic (#13522)\n\nI felt like the logic in the `SourceFileGroupingBuilder` was becoming\r\noverly complex, with the introduction of concerns about how to parse and\r\ninterpret provider declarations. This refactor moves provider\r\ninterpretation logic into `DeclarationVisitor`, and keeps the\r\nresponsibility of the `SourceFileGroupingBuilder` focused on obtaining\r\nthe full set of source files + files that need to be restored from the\r\nregistry.\r\n\r\n###### Microsoft Reviewers: [Open in\r\nCodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","distinct":true,"url":"https://api.github.com/repos/Azure/bicep/commits/c49faacc0d2426a6201d3e7332f6952a0a31723e"}]},"public":true,"created_at":"2024-03-06T01:48:43Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36281475446","type":"DeleteEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"ref":"ant/sfg","ref_type":"branch","pusher_type":"user"},"public":true,"created_at":"2024-03-06T01:48:43Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36281475357","type":"PullRequestEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"closed","number":13522,"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"closed","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-06T01:48:42Z","closed_at":"2024-03-06T01:48:41Z","merged_at":"2024-03-06T01:48:41Z","merge_commit_sha":"c49faacc0d2426a6201d3e7332f6952a0a31723e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6463971587,"node_id":"LA_kwDOD7S9ks8AAAABgUhhAw","url":"https://api.github.com/repos/Azure/bicep/labels/housekeeping","name":"housekeeping","color":"74D4B5","default":false,"description":"Things that we do to make the codebase easier to maintain"}],"milestone":{"url":"https://api.github.com/repos/Azure/bicep/milestones/31","html_url":"https://github.com/Azure/bicep/milestone/31","labels_url":"https://api.github.com/repos/Azure/bicep/milestones/31/labels","id":10503326,"node_id":"MI_kwDOD7S9ks4AoESe","number":31,"title":"v0.27","description":"","creator":{"login":"puicchan","id":8701892,"node_id":"MDQ6VXNlcjg3MDE4OTI=","avatar_url":"https://avatars.githubusercontent.com/u/8701892?v=4","gravatar_id":"","url":"https://api.github.com/users/puicchan","html_url":"https://github.com/puicchan","followers_url":"https://api.github.com/users/puicchan/followers","following_url":"https://api.github.com/users/puicchan/following{/other_user}","gists_url":"https://api.github.com/users/puicchan/gists{/gist_id}","starred_url":"https://api.github.com/users/puicchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puicchan/subscriptions","organizations_url":"https://api.github.com/users/puicchan/orgs","repos_url":"https://api.github.com/users/puicchan/repos","events_url":"https://api.github.com/users/puicchan/events{/privacy}","received_events_url":"https://api.github.com/users/puicchan/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":2,"state":"open","created_at":"2024-02-01T22:25:37Z","updated_at":"2024-03-06T01:48:41Z","due_on":"2024-03-31T07:00:00Z","closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/137d365a9544ba255e7529f0da6b3424875aac56","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"137d365a9544ba255e7529f0da6b3424875aac56","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-06T01:48:42Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134038,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1187,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1187,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"3a300e5b1c3a9a523c7943bc04e674c3a523475f","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-06T01:48:42Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134038,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1187,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1187,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/137d365a9544ba255e7529f0da6b3424875aac56"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"comments":7,"review_comments":25,"maintainer_can_modify":false,"commits":4,"additions":409,"deletions":531,"changed_files":33}},"public":true,"created_at":"2024-03-06T01:48:42Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36278528726","type":"PushEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"repository_id":263503250,"push_id":17404038601,"size":1,"distinct_size":1,"ref":"refs/heads/main","head":"3a300e5b1c3a9a523c7943bc04e674c3a523475f","before":"27a4913931bb3c72edb461af24a8c2b53a6b46eb","commits":[{"sha":"3a300e5b1c3a9a523c7943bc04e674c3a523475f","author":{"email":"asilverman@users.noreply.github.com","name":"Ariel Silverman"},"message":"Feat: Implements design in Azure/bicep-reps/pull/5 (#13537)\n\n###### Microsoft Reviewers: [Open in\r\nCodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13537)\r\n\r\nhttps://github.com/Azure/bicep-reps/pull/5\r\n\r\nCo-authored-by: asilverman ","distinct":true,"url":"https://api.github.com/repos/Azure/bicep/commits/3a300e5b1c3a9a523c7943bc04e674c3a523475f"}]},"public":true,"created_at":"2024-03-05T22:57:01Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36278528667","type":"DeleteEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"ref":"asilverman/central-mgmt-providers","ref_type":"branch","pusher_type":"user"},"public":true,"created_at":"2024-03-05T22:57:00Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36278528448","type":"PullRequestEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"closed","number":13537,"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13537","id":1757718017,"node_id":"PR_kwDOD7S9ks5oxKYB","html_url":"https://github.com/Azure/bicep/pull/13537","diff_url":"https://github.com/Azure/bicep/pull/13537.diff","patch_url":"https://github.com/Azure/bicep/pull/13537.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13537","number":13537,"state":"closed","locked":false,"title":"Feat: Implements design in Azure/bicep-reps/pull/5","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":" ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13537)\r\n\r\nhttps://github.com/Azure/bicep-reps/pull/5","created_at":"2024-03-05T21:24:33Z","updated_at":"2024-03-05T22:56:59Z","closed_at":"2024-03-05T22:56:59Z","merged_at":"2024-03-05T22:56:59Z","merge_commit_sha":"3a300e5b1c3a9a523c7943bc04e674c3a523475f","assignee":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"assignees":[{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"majastrz","id":22460039,"node_id":"MDQ6VXNlcjIyNDYwMDM5","avatar_url":"https://avatars.githubusercontent.com/u/22460039?v=4","gravatar_id":"","url":"https://api.github.com/users/majastrz","html_url":"https://github.com/majastrz","followers_url":"https://api.github.com/users/majastrz/followers","following_url":"https://api.github.com/users/majastrz/following{/other_user}","gists_url":"https://api.github.com/users/majastrz/gists{/gist_id}","starred_url":"https://api.github.com/users/majastrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majastrz/subscriptions","organizations_url":"https://api.github.com/users/majastrz/orgs","repos_url":"https://api.github.com/users/majastrz/repos","events_url":"https://api.github.com/users/majastrz/events{/privacy}","received_events_url":"https://api.github.com/users/majastrz/received_events","type":"User","site_admin":false},{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":5746004672,"node_id":"LA_kwDOD7S9ks8AAAABVn0SwA","url":"https://api.github.com/repos/Azure/bicep/labels/story:%20dynamic%20type%20loading","name":"story: dynamic type loading","color":"3A7DE5","default":false,"description":"Collects all work items related to decoupling of Bicep types from compiler"}],"milestone":{"url":"https://api.github.com/repos/Azure/bicep/milestones/31","html_url":"https://github.com/Azure/bicep/milestone/31","labels_url":"https://api.github.com/repos/Azure/bicep/milestones/31/labels","id":10503326,"node_id":"MI_kwDOD7S9ks4AoESe","number":31,"title":"v0.27","description":"","creator":{"login":"puicchan","id":8701892,"node_id":"MDQ6VXNlcjg3MDE4OTI=","avatar_url":"https://avatars.githubusercontent.com/u/8701892?v=4","gravatar_id":"","url":"https://api.github.com/users/puicchan","html_url":"https://github.com/puicchan","followers_url":"https://api.github.com/users/puicchan/followers","following_url":"https://api.github.com/users/puicchan/following{/other_user}","gists_url":"https://api.github.com/users/puicchan/gists{/gist_id}","starred_url":"https://api.github.com/users/puicchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puicchan/subscriptions","organizations_url":"https://api.github.com/users/puicchan/orgs","repos_url":"https://api.github.com/users/puicchan/repos","events_url":"https://api.github.com/users/puicchan/events{/privacy}","received_events_url":"https://api.github.com/users/puicchan/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":1,"state":"open","created_at":"2024-02-01T22:25:37Z","updated_at":"2024-03-05T22:56:59Z","due_on":"2024-03-31T07:00:00Z","closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13537/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13537/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13537/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6d061b47cb2c519e090a3f3bedef498ab4d4b01f","head":{"label":"Azure:asilverman/central-mgmt-providers","ref":"asilverman/central-mgmt-providers","sha":"6d061b47cb2c519e090a3f3bedef498ab4d4b01f","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T22:56:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133999,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1185,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"b41394e08edc9b49d110d84b11aebf658d26cba4","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T22:56:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133999,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1185,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1185,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537"},"html":{"href":"https://github.com/Azure/bicep/pull/13537"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13537"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13537/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6d061b47cb2c519e090a3f3bedef498ab4d4b01f"}},"author_association":"CONTRIBUTOR","auto_merge":null,"active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":87,"deletions":194,"changed_files":18}},"public":true,"created_at":"2024-03-05T22:57:00Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36276518250","type":"IssueCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/bicep/issues/13522","repository_url":"https://api.github.com/repos/Azure/bicep","labels_url":"https://api.github.com/repos/Azure/bicep/issues/13522/labels{/name}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","events_url":"https://api.github.com/repos/Azure/bicep/issues/13522/events","html_url":"https://github.com/Azure/bicep/pull/13522","id":2167568689,"node_id":"PR_kwDOD7S9ks5ooQX_","number":13522,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"labels":[{"id":6463971587,"node_id":"LA_kwDOD7S9ks8AAAABgUhhAw","url":"https://api.github.com/repos/Azure/bicep/labels/housekeeping","name":"housekeeping","color":"74D4B5","default":false,"description":"Things that we do to make the codebase easier to maintain"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Azure/bicep/milestones/31","html_url":"https://github.com/Azure/bicep/milestone/31","labels_url":"https://api.github.com/repos/Azure/bicep/milestones/31/labels","id":10503326,"node_id":"MI_kwDOD7S9ks4AoESe","number":31,"title":"v0.27","description":"","creator":{"login":"puicchan","id":8701892,"node_id":"MDQ6VXNlcjg3MDE4OTI=","avatar_url":"https://avatars.githubusercontent.com/u/8701892?v=4","gravatar_id":"","url":"https://api.github.com/users/puicchan","html_url":"https://github.com/puicchan","followers_url":"https://api.github.com/users/puicchan/followers","following_url":"https://api.github.com/users/puicchan/following{/other_user}","gists_url":"https://api.github.com/users/puicchan/gists{/gist_id}","starred_url":"https://api.github.com/users/puicchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puicchan/subscriptions","organizations_url":"https://api.github.com/users/puicchan/orgs","repos_url":"https://api.github.com/users/puicchan/repos","events_url":"https://api.github.com/users/puicchan/events{/privacy}","received_events_url":"https://api.github.com/users/puicchan/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":0,"state":"open","created_at":"2024-02-01T22:25:37Z","updated_at":"2024-03-05T21:24:33Z","due_on":"2024-03-31T07:00:00Z","closed_at":null},"comments":6,"created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T21:25:46Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","merged_at":null},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","reactions":{"url":"https://api.github.com/repos/Azure/bicep/issues/13522/reactions","total_count":1,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":1,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/Azure/bicep/issues/13522/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/Azure/bicep/issues/comments/1979662072","html_url":"https://github.com/Azure/bicep/pull/13522#issuecomment-1979662072","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","id":1979662072,"node_id":"IC_kwDOD7S9ks51_z74","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"created_at":"2024-03-05T21:25:44Z","updated_at":"2024-03-05T21:25:44Z","author_association":"CONTRIBUTOR","body":"Hey @anthony-c-martin , can this wait for https://github.com/Azure/bicep/pull/13537?","reactions":{"url":"https://api.github.com/repos/Azure/bicep/issues/comments/1979662072/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-05T21:25:46Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36276487083","type":"PullRequestEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"opened","number":13537,"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13537","id":1757718017,"node_id":"PR_kwDOD7S9ks5oxKYB","html_url":"https://github.com/Azure/bicep/pull/13537","diff_url":"https://github.com/Azure/bicep/pull/13537.diff","patch_url":"https://github.com/Azure/bicep/pull/13537.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13537","number":13537,"state":"open","locked":false,"title":"Feat: Implements design in https://github.com/Azure/bicep-reps/pull/5","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":null,"created_at":"2024-03-05T21:24:33Z","updated_at":"2024-03-05T21:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"assignees":[{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shenglol","id":16367959,"node_id":"MDQ6VXNlcjE2MzY3OTU5","avatar_url":"https://avatars.githubusercontent.com/u/16367959?v=4","gravatar_id":"","url":"https://api.github.com/users/shenglol","html_url":"https://github.com/shenglol","followers_url":"https://api.github.com/users/shenglol/followers","following_url":"https://api.github.com/users/shenglol/following{/other_user}","gists_url":"https://api.github.com/users/shenglol/gists{/gist_id}","starred_url":"https://api.github.com/users/shenglol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenglol/subscriptions","organizations_url":"https://api.github.com/users/shenglol/orgs","repos_url":"https://api.github.com/users/shenglol/repos","events_url":"https://api.github.com/users/shenglol/events{/privacy}","received_events_url":"https://api.github.com/users/shenglol/received_events","type":"User","site_admin":false},{"login":"majastrz","id":22460039,"node_id":"MDQ6VXNlcjIyNDYwMDM5","avatar_url":"https://avatars.githubusercontent.com/u/22460039?v=4","gravatar_id":"","url":"https://api.github.com/users/majastrz","html_url":"https://github.com/majastrz","followers_url":"https://api.github.com/users/majastrz/followers","following_url":"https://api.github.com/users/majastrz/following{/other_user}","gists_url":"https://api.github.com/users/majastrz/gists{/gist_id}","starred_url":"https://api.github.com/users/majastrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majastrz/subscriptions","organizations_url":"https://api.github.com/users/majastrz/orgs","repos_url":"https://api.github.com/users/majastrz/repos","events_url":"https://api.github.com/users/majastrz/events{/privacy}","received_events_url":"https://api.github.com/users/majastrz/received_events","type":"User","site_admin":false},{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":5746004672,"node_id":"LA_kwDOD7S9ks8AAAABVn0SwA","url":"https://api.github.com/repos/Azure/bicep/labels/story:%20dynamic%20type%20loading","name":"story: dynamic type loading","color":"3A7DE5","default":false,"description":"Collects all work items related to decoupling of Bicep types from compiler"}],"milestone":{"url":"https://api.github.com/repos/Azure/bicep/milestones/31","html_url":"https://github.com/Azure/bicep/milestone/31","labels_url":"https://api.github.com/repos/Azure/bicep/milestones/31/labels","id":10503326,"node_id":"MI_kwDOD7S9ks4AoESe","number":31,"title":"v0.27","description":"","creator":{"login":"puicchan","id":8701892,"node_id":"MDQ6VXNlcjg3MDE4OTI=","avatar_url":"https://avatars.githubusercontent.com/u/8701892?v=4","gravatar_id":"","url":"https://api.github.com/users/puicchan","html_url":"https://github.com/puicchan","followers_url":"https://api.github.com/users/puicchan/followers","following_url":"https://api.github.com/users/puicchan/following{/other_user}","gists_url":"https://api.github.com/users/puicchan/gists{/gist_id}","starred_url":"https://api.github.com/users/puicchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puicchan/subscriptions","organizations_url":"https://api.github.com/users/puicchan/orgs","repos_url":"https://api.github.com/users/puicchan/repos","events_url":"https://api.github.com/users/puicchan/events{/privacy}","received_events_url":"https://api.github.com/users/puicchan/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":0,"state":"open","created_at":"2024-02-01T22:25:37Z","updated_at":"2024-03-05T21:24:33Z","due_on":"2024-03-31T07:00:00Z","closed_at":null},"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13537/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13537/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13537/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6d061b47cb2c519e090a3f3bedef498ab4d4b01f","head":{"label":"Azure:asilverman/central-mgmt-providers","ref":"asilverman/central-mgmt-providers","sha":"6d061b47cb2c519e090a3f3bedef498ab4d4b01f","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T21:24:33Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133977,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1188,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1188,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"b41394e08edc9b49d110d84b11aebf658d26cba4","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T21:24:33Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133977,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1188,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1188,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537"},"html":{"href":"https://github.com/Azure/bicep/pull/13537"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13537"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13537/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13537/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6d061b47cb2c519e090a3f3bedef498ab4d4b01f"}},"author_association":"CONTRIBUTOR","auto_merge":null,"active_lock_reason":null,"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":87,"deletions":194,"changed_files":18}},"public":true,"created_at":"2024-03-05T21:24:35Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36276448340","type":"CreateEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"ref":"asilverman/central-mgmt-providers","ref_type":"branch","master_branch":"main","description":"Bicep is a declarative language for describing and deploying Azure resources","pusher_type":"user"},"public":true,"created_at":"2024-03-05T21:23:00Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36275789809","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1918119394,"node_id":"PRR_kwDOD7S9ks5yVC3i","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"","commit_id":"9f943430ba06fb8f53c84c39742e1afc5d4fe2c6","submitted_at":"2024-03-05T20:56:19Z","state":"approved","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1918119394","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1918119394"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T20:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ff127e1b94e3a8f9c1f2f5d4fe36cef1aa9cc36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/9f943430ba06fb8f53c84c39742e1afc5d4fe2c6","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"9f943430ba06fb8f53c84c39742e1afc5d4fe2c6","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T20:28:37Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133977,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1187,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1187,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T20:28:37Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133977,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1187,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1187,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/9f943430ba06fb8f53c84c39742e1afc5d4fe2c6"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T20:56:20Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36275742621","type":"IssueCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/bicep/issues/13522","repository_url":"https://api.github.com/repos/Azure/bicep","labels_url":"https://api.github.com/repos/Azure/bicep/issues/13522/labels{/name}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","events_url":"https://api.github.com/repos/Azure/bicep/issues/13522/events","html_url":"https://github.com/Azure/bicep/pull/13522","id":2167568689,"node_id":"PR_kwDOD7S9ks5ooQX_","number":13522,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T20:54:25Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","merged_at":null},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","reactions":{"url":"https://api.github.com/repos/Azure/bicep/issues/13522/reactions","total_count":1,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":1,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/Azure/bicep/issues/13522/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/Azure/bicep/issues/comments/1979619416","html_url":"https://github.com/Azure/bicep/pull/13522#issuecomment-1979619416","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","id":1979619416,"node_id":"IC_kwDOD7S9ks51_phY","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"created_at":"2024-03-05T20:54:24Z","updated_at":"2024-03-05T20:54:24Z","author_association":"CONTRIBUTOR","body":"LGTM, ship it! 🚀 ","reactions":{"url":"https://api.github.com/repos/Azure/bicep/issues/comments/1979619416/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-05T20:54:25Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36272992632","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513362546","pull_request_review_id":1917908274,"id":1513362546,"node_id":"PRRC_kwDOD7S9ks5aNBRy","diff_hunk":"@@ -161,291 +161,165 @@ private ResultWithDiagnostic PopulateRecursive(Uri fileUri, Artifac\n \n private void PopulateRecursive(BicepSourceFile file, IFeatureProviderFactory featureProviderFactory, IConfigurationManager configurationManager, ImmutableHashSet? sourceFilesToRebuild)\n {\n- var featureProvider = featureProviderFactory.GetFeatureProvider(file.FileUri);\n- if (featureProvider.ExtensibilityEnabled)\n- {\n- PopulateProviderDeclarations(file, featureProviderFactory, configurationManager);\n- }\n-\n- foreach (var restorable in file.ProgramSyntax.Children.OfType().Where(x => x is not ProviderDeclarationSyntax))\n+ var config = configurationManager.GetConfiguration(file.FileUri);\n+ foreach (var restorable in GetArtifactReferences(file.ProgramSyntax))\n {\n- var (childArtifactReference, uriResult) = GetArtifactRestoreResult(file.FileUri, restorable);\n- if (!uriResultByBicepSourceFileByArtifactReferenceSyntax.TryGetValue(file, out var uriResultByArtifactReferenceSyntaxLookup))\n+ if (restorable is ProviderDeclarationSyntax providerDeclaration)\n {\n- uriResultByArtifactReferenceSyntaxLookup = [];\n- uriResultByBicepSourceFileByArtifactReferenceSyntax[file] = uriResultByArtifactReferenceSyntaxLookup;\n+ var isBuiltInProvider = providerDeclaration.Specification switch {\n+ LegacyProviderSpecification => true,\n+ ConfigurationManagedProviderSpecification configSpec => config.ProvidersConfig.IsSysOrBuiltIn(configSpec.NamespaceIdentifier),\n+ _ => false,\n+ };\n+\n+ if (isBuiltInProvider)\n+ {\n+ // built-in provider - no restoration required\n+ continue;\n+ }\n+\n+ artifactLookup[restorable] = GetArtifactRestoreResult(file, restorable);\n+\n+ // recursion not needed for provider declarations\n+ continue;\n }\n- uriResultByArtifactReferenceSyntaxLookup[restorable] = uriResult;\n \n- if (!uriResult.IsSuccess(out var artifactUri))\n+ var resolutionInfo = GetArtifactRestoreResult(file, restorable);","path":"src/Bicep.Core/Workspaces/SourceFileGroupingBuilder.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"This is just my opinion, but I think there are 2 main benefits:\r\n1. As a reader it makes it clear that the artifact restore result doesn't depend on the restorable type, and that the restore result is terminal\r\n2. It reduces the chance that one will change but not the other in future refactorings\r\n\r\nThese may not be strong enough justification, can you share your thoughts on the drawbacks of my suggestion and the benefits of keeping it as is?","created_at":"2024-03-05T19:09:30Z","updated_at":"2024-03-05T19:09:32Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513362546","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513362546"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513362546"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513362546/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":187,"original_line":187,"side":"RIGHT","in_reply_to_id":1513271924,"original_position":192,"position":192,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T19:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133953,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133953,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T19:09:30Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36272992521","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917908274,"node_id":"PRR_kwDOD7S9ks5yUPUy","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T19:09:32Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917908274","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917908274"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T19:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133953,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":133953,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T19:09:32Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271845379","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513312874","pull_request_review_id":1917823287,"id":1513312874,"node_id":"PRRC_kwDOD7S9ks5aM1Jq","diff_hunk":"@@ -89,7 +90,7 @@ public interface IArtifactRegistry\n /// Returns description for the module.\n /// \n /// The module reference\n- Task TryGetDescription(ArtifactReference reference);\n+ Task TryGetDescription(ModuleSymbol module, ArtifactReference reference);","path":"src/Bicep.Core/Registry/IArtifactRegistry.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"Also about this interface since we are refactoring maybe its worth separating it into two separate interfaces, one that is module specific and one that isn't to have better separation of concerns.","created_at":"2024-03-05T18:28:58Z","updated_at":"2024-03-05T18:28:59Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513312874","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513312874"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513312874"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513312874/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":93,"original_line":93,"side":"RIGHT","in_reply_to_id":1513311417,"original_position":13,"position":13,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:28:58Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271845256","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917823287,"node_id":"PRR_kwDOD7S9ks5yT6k3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:28:59Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917823287","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917823287"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:29:00Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271806865","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917820893,"node_id":"PRR_kwDOD7S9ks5yT5_d","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":null,"commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:27:40Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917820893","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917820893"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:27:41Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271806948","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513311417","pull_request_review_id":1917820893,"id":1513311417,"node_id":"PRRC_kwDOD7S9ks5aM0y5","diff_hunk":"@@ -89,7 +90,7 @@ public interface IArtifactRegistry\n /// Returns description for the module.\n /// \n /// The module reference\n- Task TryGetDescription(ArtifactReference reference);\n+ Task TryGetDescription(ModuleSymbol module, ArtifactReference reference);","path":"src/Bicep.Core/Registry/IArtifactRegistry.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"nit: Parameter 'module' has no matching param tag in the XML comment for 'IArtifactRegistry.TryGetDescription(ModuleSymbol, ArtifactReference)' (but other parameters do) CS1573","created_at":"2024-03-05T18:27:39Z","updated_at":"2024-03-05T18:27:40Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513311417","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513311417"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513311417"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513311417/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":93,"original_line":93,"side":"RIGHT","original_position":13,"position":13,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:27:39Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271713406","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917814646,"node_id":"PRR_kwDOD7S9ks5yT4d2","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:24:29Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917814646","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917814646"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:24:30Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271713414","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513307321","pull_request_review_id":1917814646,"id":1513307321,"node_id":"PRRC_kwDOD7S9ks5aMzy5","diff_hunk":"@@ -175,7 +175,7 @@ public static string GetPublicBicepModuleDocumentationUri(string publicModuleNam\n return $\"https://github.com/Azure/bicep-registry-modules/tree/{publicModuleName}/{tag}/modules/{publicModuleName}/README.md\";\n }\n \n- public override Task TryGetDescription(OciArtifactReference ociArtifactModuleReference)\n+ public override Task TryGetDescription(ModuleSymbol module, OciArtifactReference ociArtifactModuleReference)","path":"src/Bicep.Core/Registry/OciArtifactRegistry.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"I am a bit torn with the addition of this argument which is module specific, it appears to violate polymorfism for ArtifactRegistry but maybe it isn't. I have to admit I am not following the implementation of `ArtifactRegistry` to really know what I am talking about. I would love to learn more about this stuff if you can share. ","created_at":"2024-03-05T18:24:27Z","updated_at":"2024-03-05T18:24:29Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513307321","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513307321"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513307321"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513307321/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":178,"original_line":178,"side":"RIGHT","in_reply_to_id":1513300432,"original_position":5,"position":5,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:24:27Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271559897","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513300432","pull_request_review_id":1917804159,"id":1513300432,"node_id":"PRRC_kwDOD7S9ks5aMyHQ","diff_hunk":"@@ -175,7 +175,7 @@ public static string GetPublicBicepModuleDocumentationUri(string publicModuleNam\n return $\"https://github.com/Azure/bicep-registry-modules/tree/{publicModuleName}/{tag}/modules/{publicModuleName}/README.md\";\n }\n \n- public override Task TryGetDescription(OciArtifactReference ociArtifactModuleReference)\n+ public override Task TryGetDescription(ModuleSymbol module, OciArtifactReference ociArtifactModuleReference)","path":"src/Bicep.Core/Registry/OciArtifactRegistry.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"nit: should `module` be renamed to `_` since its not in use?","created_at":"2024-03-05T18:19:09Z","updated_at":"2024-03-05T18:19:11Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513300432","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513300432"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513300432"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513300432/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":178,"original_line":178,"side":"RIGHT","original_position":5,"position":5,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:19:09Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271559804","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917804159,"node_id":"PRR_kwDOD7S9ks5yT15_","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":null,"commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:19:11Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917804159","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917804159"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:19:11Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271479044","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513293857","pull_request_review_id":1917794481,"id":1513293857,"node_id":"PRRC_kwDOD7S9ks5aMwgh","diff_hunk":"@@ -116,13 +113,12 @@ private Compilation Create(SourceFileGrouping sourceFileGrouping)\n \n static IEnumerable<(BicepSourceFile, IDiagnostic)> GetDiagnosticsForModulesToRestore(SourceFileGrouping grouping, ImmutableHashSet originalArtifactsToRestore)\n {\n- var originalModulesToRestore = originalArtifactsToRestore.OfType();\n- foreach (var (module, sourceFile) in originalModulesToRestore)\n+ foreach (var artifact in originalArtifactsToRestore)\n {\n- if (sourceFile is BicepSourceFile bicepFile &&\n- DiagnosticForModule(grouping, module) is { } diagnostic)\n+ if (artifact.Syntax is {} &&","path":"src/Bicep.Core/BicepCompiler.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"there are a couple of places where we make this check to decide if an artifact is implicit. I think it may be worth it to implement a `public bool IsImplicit()` instead","created_at":"2024-03-05T18:16:27Z","updated_at":"2024-03-05T18:16:29Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513293857","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513293857"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513293857"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513293857/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":null,"original_start_line":null,"start_side":null,"line":118,"original_line":118,"side":"RIGHT","original_position":52,"position":52,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:16:27Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271478981","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917794481,"node_id":"PRR_kwDOD7S9ks5yTzix","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":null,"commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:16:29Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917794481","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917794481"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:16:29Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271188675","type":"PullRequestReviewCommentEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513277388","pull_request_review_id":1917767197,"id":1513277388,"node_id":"PRRC_kwDOD7S9ks5aMsfM","diff_hunk":"@@ -161,291 +161,165 @@ private ResultWithDiagnostic PopulateRecursive(Uri fileUri, Artifac\n \n private void PopulateRecursive(BicepSourceFile file, IFeatureProviderFactory featureProviderFactory, IConfigurationManager configurationManager, ImmutableHashSet? sourceFilesToRebuild)\n {\n- var featureProvider = featureProviderFactory.GetFeatureProvider(file.FileUri);\n- if (featureProvider.ExtensibilityEnabled)\n- {\n- PopulateProviderDeclarations(file, featureProviderFactory, configurationManager);\n- }\n-\n- foreach (var restorable in file.ProgramSyntax.Children.OfType().Where(x => x is not ProviderDeclarationSyntax))\n+ var config = configurationManager.GetConfiguration(file.FileUri);\n+ foreach (var restorable in GetArtifactReferences(file.ProgramSyntax))\n {\n- var (childArtifactReference, uriResult) = GetArtifactRestoreResult(file.FileUri, restorable);\n- if (!uriResultByBicepSourceFileByArtifactReferenceSyntax.TryGetValue(file, out var uriResultByArtifactReferenceSyntaxLookup))\n+ if (restorable is ProviderDeclarationSyntax providerDeclaration)\n {\n- uriResultByArtifactReferenceSyntaxLookup = [];\n- uriResultByBicepSourceFileByArtifactReferenceSyntax[file] = uriResultByArtifactReferenceSyntaxLookup;\n+ var isBuiltInProvider = providerDeclaration.Specification switch {\n+ LegacyProviderSpecification => true,\n+ ConfigurationManagedProviderSpecification configSpec => config.ProvidersConfig.IsSysOrBuiltIn(configSpec.NamespaceIdentifier),\n+ _ => false,\n+ };\n+\n+ if (isBuiltInProvider)\n+ {\n+ // built-in provider - no restoration required\n+ continue;\n+ }\n+\n+ artifactLookup[restorable] = GetArtifactRestoreResult(file, restorable);\n+\n+ // recursion not needed for provider declarations\n+ continue;\n }\n- uriResultByArtifactReferenceSyntaxLookup[restorable] = uriResult;\n \n- if (!uriResult.IsSuccess(out var artifactUri))\n+ var resolutionInfo = GetArtifactRestoreResult(file, restorable);\n+ artifactLookup[restorable] = resolutionInfo;\n+ if (!resolutionInfo.Result.IsSuccess(out var artifactUri))\n {\n+ // recursion not possible\n continue;\n }\n \n if (!fileResultByUri.TryGetValue(artifactUri, out var childResult) ||\n (childResult.IsSuccess(out var childFile) && sourceFilesToRebuild is not null && sourceFilesToRebuild.Contains(childFile)))\n {\n // only recurse if we've not seen this file before - to avoid infinite loops\n- childResult = PopulateRecursive(artifactUri, childArtifactReference, sourceFilesToRebuild, featureProviderFactory, configurationManager);\n+ childResult = PopulateRecursive(artifactUri, resolutionInfo.Reference, sourceFilesToRebuild, featureProviderFactory, configurationManager);\n }\n fileResultByUri[artifactUri] = childResult;\n }\n+\n+ foreach (var providerName in config.ImplicitProvidersConfig.GetImplicitProviderNames())\n+ {\n+ if (TryGetImplicitProvider(providerName, file, config) is { } implicitProvider)\n+ {\n+ implicitArtifacts.Add(implicitProvider);\n+ }\n+ }","path":"src/Bicep.Core/Workspaces/SourceFileGroupingBuilder.cs","commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","original_commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":"nit: It may be easier on the reader to extract this to a separate function and invoke it above the processing of the provider declaration loop, this way its easier to follow that we process all providers, and once done we go ahead and process other artifacts.","created_at":"2024-03-05T18:07:18Z","updated_at":"2024-03-05T18:07:19Z","html_url":"https://github.com/Azure/bicep/pull/13522#discussion_r1513277388","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513277388"},"html":{"href":"https://github.com/Azure/bicep/pull/13522#discussion_r1513277388"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}},"reactions":{"url":"https://api.github.com/repos/Azure/bicep/pulls/comments/1513277388/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"start_line":204,"original_start_line":204,"start_side":"RIGHT","line":210,"original_line":210,"side":"RIGHT","original_position":216,"position":216,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:07:18Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}},{"id":"36271188625","type":"PullRequestReviewEvent","actor":{"id":9611108,"login":"asilverman","display_login":"asilverman","gravatar_id":"","url":"https://api.github.com/users/asilverman","avatar_url":"https://avatars.githubusercontent.com/u/9611108?"},"repo":{"id":263503250,"name":"Azure/bicep","url":"https://api.github.com/repos/Azure/bicep"},"payload":{"action":"created","review":{"id":1917767197,"node_id":"PRR_kwDOD7S9ks5yTs4d","user":{"login":"asilverman","id":9611108,"node_id":"MDQ6VXNlcjk2MTExMDg=","avatar_url":"https://avatars.githubusercontent.com/u/9611108?v=4","gravatar_id":"","url":"https://api.github.com/users/asilverman","html_url":"https://github.com/asilverman","followers_url":"https://api.github.com/users/asilverman/followers","following_url":"https://api.github.com/users/asilverman/following{/other_user}","gists_url":"https://api.github.com/users/asilverman/gists{/gist_id}","starred_url":"https://api.github.com/users/asilverman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilverman/subscriptions","organizations_url":"https://api.github.com/users/asilverman/orgs","repos_url":"https://api.github.com/users/asilverman/repos","events_url":"https://api.github.com/users/asilverman/events{/privacy}","received_events_url":"https://api.github.com/users/asilverman/received_events","type":"User","site_admin":false},"body":null,"commit_id":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","submitted_at":"2024-03-05T18:07:19Z","state":"commented","html_url":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917767197","pull_request_url":"https://api.github.com/repos/Azure/bicep/pulls/13522","author_association":"CONTRIBUTOR","_links":{"html":{"href":"https://github.com/Azure/bicep/pull/13522#pullrequestreview-1917767197"},"pull_request":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/bicep/pulls/13522","id":1755383295,"node_id":"PR_kwDOD7S9ks5ooQX_","html_url":"https://github.com/Azure/bicep/pull/13522","diff_url":"https://github.com/Azure/bicep/pull/13522.diff","patch_url":"https://github.com/Azure/bicep/pull/13522.patch","issue_url":"https://api.github.com/repos/Azure/bicep/issues/13522","number":13522,"state":"open","locked":false,"title":"Refactor SourceFileGrouping to remove provider logic","user":{"login":"anthony-c-martin","id":38542602,"node_id":"MDQ6VXNlcjM4NTQyNjAy","avatar_url":"https://avatars.githubusercontent.com/u/38542602?v=4","gravatar_id":"","url":"https://api.github.com/users/anthony-c-martin","html_url":"https://github.com/anthony-c-martin","followers_url":"https://api.github.com/users/anthony-c-martin/followers","following_url":"https://api.github.com/users/anthony-c-martin/following{/other_user}","gists_url":"https://api.github.com/users/anthony-c-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/anthony-c-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthony-c-martin/subscriptions","organizations_url":"https://api.github.com/users/anthony-c-martin/orgs","repos_url":"https://api.github.com/users/anthony-c-martin/repos","events_url":"https://api.github.com/users/anthony-c-martin/events{/privacy}","received_events_url":"https://api.github.com/users/anthony-c-martin/received_events","type":"User","site_admin":false},"body":"I felt like the logic in the `SourceFileGroupingBuilder` was becoming overly complex, with the introduction of concerns about how to parse and interpret provider declarations. This refactor moves provider interpretation logic into `DeclarationVisitor`, and keeps the responsibility of the `SourceFileGroupingBuilder` focused on obtaining the full set of source files + files that need to be restored from the registry.\r\n\r\n ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13522)","created_at":"2024-03-04T19:18:01Z","updated_at":"2024-03-05T18:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486fcb3657329aacc9de216f95a1e2d26b97ebe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits","review_comments_url":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments","review_comment_url":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/bicep/issues/13522/comments","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3","head":{"label":"Azure:ant/sfg","ref":"ant/sfg","sha":"6f409978d02e9cdd8660c52a04e693d1ee795ca3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"base":{"label":"Azure:main","ref":"main","sha":"faecd56892713a897aa2f01c2b41bd91b60d2e89","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":263503250,"node_id":"MDEwOlJlcG9zaXRvcnkyNjM1MDMyNTA=","name":"bicep","full_name":"Azure/bicep","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/bicep","description":"Bicep is a declarative language for describing and deploying Azure resources","fork":false,"url":"https://api.github.com/repos/Azure/bicep","forks_url":"https://api.github.com/repos/Azure/bicep/forks","keys_url":"https://api.github.com/repos/Azure/bicep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/bicep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/bicep/teams","hooks_url":"https://api.github.com/repos/Azure/bicep/hooks","issue_events_url":"https://api.github.com/repos/Azure/bicep/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/bicep/events","assignees_url":"https://api.github.com/repos/Azure/bicep/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/bicep/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/bicep/tags","blobs_url":"https://api.github.com/repos/Azure/bicep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/bicep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/bicep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/bicep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/bicep/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/bicep/languages","stargazers_url":"https://api.github.com/repos/Azure/bicep/stargazers","contributors_url":"https://api.github.com/repos/Azure/bicep/contributors","subscribers_url":"https://api.github.com/repos/Azure/bicep/subscribers","subscription_url":"https://api.github.com/repos/Azure/bicep/subscription","commits_url":"https://api.github.com/repos/Azure/bicep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/bicep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/bicep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/bicep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/bicep/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/bicep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/bicep/merges","archive_url":"https://api.github.com/repos/Azure/bicep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/bicep/downloads","issues_url":"https://api.github.com/repos/Azure/bicep/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/bicep/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/bicep/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/bicep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/bicep/labels{/name}","releases_url":"https://api.github.com/repos/Azure/bicep/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/bicep/deployments","created_at":"2020-05-13T02:18:30Z","updated_at":"2024-03-05T12:42:46Z","pushed_at":"2024-03-05T18:01:59Z","git_url":"git://github.com/Azure/bicep.git","ssh_url":"git@github.com:Azure/bicep.git","clone_url":"https://github.com/Azure/bicep.git","svn_url":"https://github.com/Azure/bicep","homepage":"","size":134018,"stargazers_count":3079,"watchers_count":3079,"language":"Bicep","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":true,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["arm-json","arm-templates","bicep"],"visibility":"public","forks":713,"open_issues":1186,"watchers":3079,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522"},"html":{"href":"https://github.com/Azure/bicep/pull/13522"},"issue":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522"},"comments":{"href":"https://api.github.com/repos/Azure/bicep/issues/13522/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/bicep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/bicep/pulls/13522/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/bicep/statuses/6f409978d02e9cdd8660c52a04e693d1ee795ca3"}},"author_association":"MEMBER","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-05T18:07:20Z","org":{"id":6844498,"login":"Azure","gravatar_id":"","url":"https://api.github.com/orgs/Azure","avatar_url":"https://avatars.githubusercontent.com/u/6844498?"}}]