[{"id":"12982511246","type":"IssuesEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"labeled","issue":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280","repository_url":"https://api.github.com/repos/biomejs/biome","labels_url":"https://api.github.com/repos/biomejs/biome/issues/11280/labels{/name}","comments_url":"https://api.github.com/repos/biomejs/biome/issues/11280/comments","events_url":"https://api.github.com/repos/biomejs/biome/issues/11280/events","html_url":"https://github.com/biomejs/biome/issues/11280","id":5098282235,"node_id":"I_kwDOKAiibM8AAAABL-Gc-w","number":11280,"title":"📝 Formatter breaks the CSS Selector when comment is inside it","user":{"login":"mozesstumpf","id":78926228,"node_id":"MDQ6VXNlcjc4OTI2MjI4","avatar_url":"https://avatars.githubusercontent.com/u/78926228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozesstumpf","html_url":"https://github.com/mozesstumpf","followers_url":"https://api.github.com/users/mozesstumpf/followers","following_url":"https://api.github.com/users/mozesstumpf/following{/other_user}","gists_url":"https://api.github.com/users/mozesstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/mozesstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozesstumpf/subscriptions","organizations_url":"https://api.github.com/users/mozesstumpf/orgs","repos_url":"https://api.github.com/users/mozesstumpf/repos","events_url":"https://api.github.com/users/mozesstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/mozesstumpf/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"}],"state":"open","locked":false,"assignees":[],"milestone":null,"comments":2,"created_at":"2026-08-08T16:00:50Z","updated_at":"2026-08-08T18:50:59Z","closed_at":null,"assignee":null,"issue_field_values":[],"type":{"id":20003647,"node_id":"IT_kwDOCFsES84BMTs_","name":"Bug","description":"An unexpected problem or behavior","color":"red","created_at":"2024-02-17T21:28:04Z","updated_at":"2024-07-26T15:19:13Z","is_enabled":true},"active_lock_reason":null,"sub_issues_summary":{"total":0,"completed":0,"percent_completed":0},"issue_dependencies_summary":{"blocked_by":0,"total_blocked_by":0,"blocking":0,"total_blocking":0},"body":"### Environment information\n\n\n\n```bash\n\nCLI:\n Version: 2.5.4\n Color support: true\n\nPlatform:\n CPU Architecture: x86_64\n OS: windows\n\nEnvironment:\n BIOME_DISTRIBUTION: npm\n BIOME_LOG_PATH: unset\n BIOME_LOG_PREFIX_NAME: unset\n BIOME_LOG_LEVEL: unset\n BIOME_LOG_KIND: unset\n BIOME_CONFIG_PATH: unset\n BIOME_THREADS: unset\n BIOME_WATCHER_KIND: unset\n BIOME_WATCHER_POLLING_INTERVAL: unset\n NO_COLOR: unset\n TERM: xterm-256color\n JS_RUNTIME_VERSION: v24.13.0\n JS_RUNTIME_NAME: node\n NODE_PACKAGE_MANAGER: bun/1.3.9\n\nBiome Configuration:\n Status: Loaded successfully.\n Path: biome.json\n Formatter enabled: true\n Linter enabled: true\n Assist enabled: true\n VCS enabled: false\n HTML full support enabled: unset\n\nFormatter:\n Format with errors: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n Bracket spacing: unset\n Includes: unset\n\nJavaScript Formatter:\n Enabled: unset\n JSX quote style: unset\n Quote properties: unset\n Trailing commas: unset\n Semicolons: unset\n Arrow parentheses: unset\n Bracket spacing: unset\n Bracket same line: unset\n Quote style: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n\nJSON Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Trailing Commas: unset\n Expand lists: unset\n\nCSS Formatter:\n Enabled: true\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Quote style: unset\n\nGraphQL Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Bracket spacing: unset\n Quote style: unset\n\nWorkspace:\n Open Documents: 0\n\n```\n\n \n\n\n### Configuration\n\n```JSON\n\n```\n\n### Playground link\n\nhttps://biomejs.dev/playground/?tab=formatter&pane=Diagnostics&code=OgB3AGgAZQByAGUAKAAKACAAIAAvACoAIAAgACoALwAKACAAIABkAGkAdgApACAAewAKACAAIABjAG8AbABvAHIAOgAgAHIAZQBkADsACgB9AA%3D%3D&language=css\n\n### Code of Conduct\n\n- [x] I agree to follow Biome's Code of Conduct","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/biomejs/biome/issues/11280/timeline","performed_via_github_app":null,"state_reason":null,"pinned_comment":null},"label":{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"},{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"}]},"public":true,"created_at":"2026-08-08T18:50:29Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12982511215","type":"IssuesEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"labeled","issue":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280","repository_url":"https://api.github.com/repos/biomejs/biome","labels_url":"https://api.github.com/repos/biomejs/biome/issues/11280/labels{/name}","comments_url":"https://api.github.com/repos/biomejs/biome/issues/11280/comments","events_url":"https://api.github.com/repos/biomejs/biome/issues/11280/events","html_url":"https://github.com/biomejs/biome/issues/11280","id":5098282235,"node_id":"I_kwDOKAiibM8AAAABL-Gc-w","number":11280,"title":"📝 Formatter breaks the CSS Selector when comment is inside it","user":{"login":"mozesstumpf","id":78926228,"node_id":"MDQ6VXNlcjc4OTI2MjI4","avatar_url":"https://avatars.githubusercontent.com/u/78926228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozesstumpf","html_url":"https://github.com/mozesstumpf","followers_url":"https://api.github.com/users/mozesstumpf/followers","following_url":"https://api.github.com/users/mozesstumpf/following{/other_user}","gists_url":"https://api.github.com/users/mozesstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/mozesstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozesstumpf/subscriptions","organizations_url":"https://api.github.com/users/mozesstumpf/orgs","repos_url":"https://api.github.com/users/mozesstumpf/repos","events_url":"https://api.github.com/users/mozesstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/mozesstumpf/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"}],"state":"open","locked":false,"assignees":[],"milestone":null,"comments":2,"created_at":"2026-08-08T16:00:50Z","updated_at":"2026-08-08T18:50:59Z","closed_at":null,"assignee":null,"issue_field_values":[],"type":{"id":20003647,"node_id":"IT_kwDOCFsES84BMTs_","name":"Bug","description":"An unexpected problem or behavior","color":"red","created_at":"2024-02-17T21:28:04Z","updated_at":"2024-07-26T15:19:13Z","is_enabled":true},"active_lock_reason":null,"sub_issues_summary":{"total":0,"completed":0,"percent_completed":0},"issue_dependencies_summary":{"blocked_by":0,"total_blocked_by":0,"blocking":0,"total_blocking":0},"body":"### Environment information\n\n\n\n```bash\n\nCLI:\n Version: 2.5.4\n Color support: true\n\nPlatform:\n CPU Architecture: x86_64\n OS: windows\n\nEnvironment:\n BIOME_DISTRIBUTION: npm\n BIOME_LOG_PATH: unset\n BIOME_LOG_PREFIX_NAME: unset\n BIOME_LOG_LEVEL: unset\n BIOME_LOG_KIND: unset\n BIOME_CONFIG_PATH: unset\n BIOME_THREADS: unset\n BIOME_WATCHER_KIND: unset\n BIOME_WATCHER_POLLING_INTERVAL: unset\n NO_COLOR: unset\n TERM: xterm-256color\n JS_RUNTIME_VERSION: v24.13.0\n JS_RUNTIME_NAME: node\n NODE_PACKAGE_MANAGER: bun/1.3.9\n\nBiome Configuration:\n Status: Loaded successfully.\n Path: biome.json\n Formatter enabled: true\n Linter enabled: true\n Assist enabled: true\n VCS enabled: false\n HTML full support enabled: unset\n\nFormatter:\n Format with errors: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n Bracket spacing: unset\n Includes: unset\n\nJavaScript Formatter:\n Enabled: unset\n JSX quote style: unset\n Quote properties: unset\n Trailing commas: unset\n Semicolons: unset\n Arrow parentheses: unset\n Bracket spacing: unset\n Bracket same line: unset\n Quote style: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n\nJSON Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Trailing Commas: unset\n Expand lists: unset\n\nCSS Formatter:\n Enabled: true\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Quote style: unset\n\nGraphQL Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Bracket spacing: unset\n Quote style: unset\n\nWorkspace:\n Open Documents: 0\n\n```\n\n \n\n\n### Configuration\n\n```JSON\n\n```\n\n### Playground link\n\nhttps://biomejs.dev/playground/?tab=formatter&pane=Diagnostics&code=OgB3AGgAZQByAGUAKAAKACAAIAAvACoAIAAgACoALwAKACAAIABkAGkAdgApACAAewAKACAAIABjAG8AbABvAHIAOgAgAHIAZQBkADsACgB9AA%3D%3D&language=css\n\n### Code of Conduct\n\n- [x] I agree to follow Biome's Code of Conduct","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/biomejs/biome/issues/11280/timeline","performed_via_github_app":null,"state_reason":null,"pinned_comment":null},"label":{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"},{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"}]},"public":true,"created_at":"2026-08-08T18:50:29Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12982511185","type":"IssuesEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"labeled","issue":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280","repository_url":"https://api.github.com/repos/biomejs/biome","labels_url":"https://api.github.com/repos/biomejs/biome/issues/11280/labels{/name}","comments_url":"https://api.github.com/repos/biomejs/biome/issues/11280/comments","events_url":"https://api.github.com/repos/biomejs/biome/issues/11280/events","html_url":"https://github.com/biomejs/biome/issues/11280","id":5098282235,"node_id":"I_kwDOKAiibM8AAAABL-Gc-w","number":11280,"title":"📝 Formatter breaks the CSS Selector when comment is inside it","user":{"login":"mozesstumpf","id":78926228,"node_id":"MDQ6VXNlcjc4OTI2MjI4","avatar_url":"https://avatars.githubusercontent.com/u/78926228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozesstumpf","html_url":"https://github.com/mozesstumpf","followers_url":"https://api.github.com/users/mozesstumpf/followers","following_url":"https://api.github.com/users/mozesstumpf/following{/other_user}","gists_url":"https://api.github.com/users/mozesstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/mozesstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozesstumpf/subscriptions","organizations_url":"https://api.github.com/users/mozesstumpf/orgs","repos_url":"https://api.github.com/users/mozesstumpf/repos","events_url":"https://api.github.com/users/mozesstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/mozesstumpf/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"}],"state":"open","locked":false,"assignees":[],"milestone":null,"comments":2,"created_at":"2026-08-08T16:00:50Z","updated_at":"2026-08-08T18:50:59Z","closed_at":null,"assignee":null,"issue_field_values":[],"type":{"id":20003647,"node_id":"IT_kwDOCFsES84BMTs_","name":"Bug","description":"An unexpected problem or behavior","color":"red","created_at":"2024-02-17T21:28:04Z","updated_at":"2024-07-26T15:19:13Z","is_enabled":true},"active_lock_reason":null,"sub_issues_summary":{"total":0,"completed":0,"percent_completed":0},"issue_dependencies_summary":{"blocked_by":0,"total_blocked_by":0,"blocking":0,"total_blocking":0},"body":"### Environment information\n\n\n\n```bash\n\nCLI:\n Version: 2.5.4\n Color support: true\n\nPlatform:\n CPU Architecture: x86_64\n OS: windows\n\nEnvironment:\n BIOME_DISTRIBUTION: npm\n BIOME_LOG_PATH: unset\n BIOME_LOG_PREFIX_NAME: unset\n BIOME_LOG_LEVEL: unset\n BIOME_LOG_KIND: unset\n BIOME_CONFIG_PATH: unset\n BIOME_THREADS: unset\n BIOME_WATCHER_KIND: unset\n BIOME_WATCHER_POLLING_INTERVAL: unset\n NO_COLOR: unset\n TERM: xterm-256color\n JS_RUNTIME_VERSION: v24.13.0\n JS_RUNTIME_NAME: node\n NODE_PACKAGE_MANAGER: bun/1.3.9\n\nBiome Configuration:\n Status: Loaded successfully.\n Path: biome.json\n Formatter enabled: true\n Linter enabled: true\n Assist enabled: true\n VCS enabled: false\n HTML full support enabled: unset\n\nFormatter:\n Format with errors: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n Bracket spacing: unset\n Includes: unset\n\nJavaScript Formatter:\n Enabled: unset\n JSX quote style: unset\n Quote properties: unset\n Trailing commas: unset\n Semicolons: unset\n Arrow parentheses: unset\n Bracket spacing: unset\n Bracket same line: unset\n Quote style: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n\nJSON Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Trailing Commas: unset\n Expand lists: unset\n\nCSS Formatter:\n Enabled: true\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Quote style: unset\n\nGraphQL Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Bracket spacing: unset\n Quote style: unset\n\nWorkspace:\n Open Documents: 0\n\n```\n\n \n\n\n### Configuration\n\n```JSON\n\n```\n\n### Playground link\n\nhttps://biomejs.dev/playground/?tab=formatter&pane=Diagnostics&code=OgB3AGgAZQByAGUAKAAKACAAIAAvACoAIAAgACoALwAKACAAIABkAGkAdgApACAAewAKACAAIABjAG8AbABvAHIAOgAgAHIAZQBkADsACgB9AA%3D%3D&language=css\n\n### Code of Conduct\n\n- [x] I agree to follow Biome's Code of Conduct","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/biomejs/biome/issues/11280/timeline","performed_via_github_app":null,"state_reason":null,"pinned_comment":null},"label":{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"},{"id":7575472908,"node_id":"LA_kwDOKAiibM8AAAABw4iLDA","url":"https://api.github.com/repos/biomejs/biome/labels/S-Needs%20triage","name":"S-Needs triage","color":"ddecff","default":false,"description":"Status: this issue needs to be triaged"}]},"public":true,"created_at":"2026-08-08T18:50:29Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12982507602","type":"IssueCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280","repository_url":"https://api.github.com/repos/biomejs/biome","labels_url":"https://api.github.com/repos/biomejs/biome/issues/11280/labels{/name}","comments_url":"https://api.github.com/repos/biomejs/biome/issues/11280/comments","events_url":"https://api.github.com/repos/biomejs/biome/issues/11280/events","html_url":"https://github.com/biomejs/biome/issues/11280","id":5098282235,"node_id":"I_kwDOKAiibM8AAAABL-Gc-w","number":11280,"title":"📝 Formatter breaks the CSS Selector when comment is inside it","user":{"login":"mozesstumpf","id":78926228,"node_id":"MDQ6VXNlcjc4OTI2MjI4","avatar_url":"https://avatars.githubusercontent.com/u/78926228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozesstumpf","html_url":"https://github.com/mozesstumpf","followers_url":"https://api.github.com/users/mozesstumpf/followers","following_url":"https://api.github.com/users/mozesstumpf/following{/other_user}","gists_url":"https://api.github.com/users/mozesstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/mozesstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozesstumpf/subscriptions","organizations_url":"https://api.github.com/users/mozesstumpf/orgs","repos_url":"https://api.github.com/users/mozesstumpf/repos","events_url":"https://api.github.com/users/mozesstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/mozesstumpf/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[{"id":5855718184,"node_id":"LA_kwDOKAiibM8AAAABXQcrKA","url":"https://api.github.com/repos/biomejs/biome/labels/A-Formatter","name":"A-Formatter","color":"a4c8fc","default":false,"description":"Area: formatter"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":5885643810,"node_id":"LA_kwDOKAiibM8AAAABXs_MIg","url":"https://api.github.com/repos/biomejs/biome/labels/S-Bug-confirmed","name":"S-Bug-confirmed","color":"E99695","default":false,"description":"Status: report has been confirmed as a valid bug"}],"state":"open","locked":false,"assignees":[],"milestone":null,"comments":2,"created_at":"2026-08-08T16:00:50Z","updated_at":"2026-08-08T18:50:59Z","closed_at":null,"assignee":null,"issue_field_values":[],"type":{"id":20003647,"node_id":"IT_kwDOCFsES84BMTs_","name":"Bug","description":"An unexpected problem or behavior","color":"red","created_at":"2024-02-17T21:28:04Z","updated_at":"2024-07-26T15:19:13Z","is_enabled":true},"active_lock_reason":null,"sub_issues_summary":{"total":0,"completed":0,"percent_completed":0},"issue_dependencies_summary":{"blocked_by":0,"total_blocked_by":0,"blocking":0,"total_blocking":0},"body":"### Environment information\n\n\n\n```bash\n\nCLI:\n Version: 2.5.4\n Color support: true\n\nPlatform:\n CPU Architecture: x86_64\n OS: windows\n\nEnvironment:\n BIOME_DISTRIBUTION: npm\n BIOME_LOG_PATH: unset\n BIOME_LOG_PREFIX_NAME: unset\n BIOME_LOG_LEVEL: unset\n BIOME_LOG_KIND: unset\n BIOME_CONFIG_PATH: unset\n BIOME_THREADS: unset\n BIOME_WATCHER_KIND: unset\n BIOME_WATCHER_POLLING_INTERVAL: unset\n NO_COLOR: unset\n TERM: xterm-256color\n JS_RUNTIME_VERSION: v24.13.0\n JS_RUNTIME_NAME: node\n NODE_PACKAGE_MANAGER: bun/1.3.9\n\nBiome Configuration:\n Status: Loaded successfully.\n Path: biome.json\n Formatter enabled: true\n Linter enabled: true\n Assist enabled: true\n VCS enabled: false\n HTML full support enabled: unset\n\nFormatter:\n Format with errors: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n Bracket spacing: unset\n Includes: unset\n\nJavaScript Formatter:\n Enabled: unset\n JSX quote style: unset\n Quote properties: unset\n Trailing commas: unset\n Semicolons: unset\n Arrow parentheses: unset\n Bracket spacing: unset\n Bracket same line: unset\n Quote style: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Attribute position: unset\n\nJSON Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Trailing Commas: unset\n Expand lists: unset\n\nCSS Formatter:\n Enabled: true\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Quote style: unset\n\nGraphQL Formatter:\n Enabled: unset\n Indent style: unset\n Indent width: unset\n Line ending: unset\n Line width: unset\n Bracket spacing: unset\n Quote style: unset\n\nWorkspace:\n Open Documents: 0\n\n```\n\n \n\n\n### Configuration\n\n```JSON\n\n```\n\n### Playground link\n\nhttps://biomejs.dev/playground/?tab=formatter&pane=Diagnostics&code=OgB3AGgAZQByAGUAKAAKACAAIAAvACoAIAAgACoALwAKACAAIABkAGkAdgApACAAewAKACAAIABjAG8AbABvAHIAOgAgAHIAZQBkADsACgB9AA%3D%3D&language=css\n\n### Code of Conduct\n\n- [x] I agree to follow Biome's Code of Conduct","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/11280/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/biomejs/biome/issues/11280/timeline","performed_via_github_app":null,"state_reason":null,"pinned_comment":null},"comment":{"url":"https://api.github.com/repos/biomejs/biome/issues/comments/5227591330","html_url":"https://github.com/biomejs/biome/issues/11280#issuecomment-5227591330","issue_url":"https://api.github.com/repos/biomejs/biome/issues/11280","id":5227591330,"node_id":"IC_kwDOKAiibM8AAAABN5a2og","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-08T18:50:17Z","updated_at":"2026-08-08T18:50:17Z","body":"cc @denbezrukov ","pin":null,"reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/comments/5227591330/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null}},"public":true,"created_at":"2026-08-08T18:50:17Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12973675848","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888675074,"node_id":"PRR_kwDOKAiibM8AAAABI2NDAg","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":null,"commit_id":"abb4272df1055b84479eb4689c7f7a6565015382","state":"commented","html_url":"https://github.com/biomejs/biome/pull/11191#pullrequestreview-4888675074","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11191","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11191#pullrequestreview-4888675074"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11191"}},"submitted_at":"2026-08-08T10:56:06Z","updated_at":"2026-08-08T10:56:06Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11191","id":4189655097,"number":11191,"head":{"ref":"feat/no-undefined-custom-property","sha":"043974d458fccaf53708ebfb9ceea9eaad693025","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}},"base":{"ref":"main","sha":"23c0369c43b59284ca68c65883d6ede4228b6fb8","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"created"},"public":true,"created_at":"2026-08-08T10:56:08Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12973675561","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740537245","pull_request_review_id":4888675074,"id":3740537245,"node_id":"PRRC_kwDOKAiibM7e9BGd","diff_hunk":"@@ -138,7 +138,16 @@ impl<'a> JsModuleVisitor<'a> {\n JsImportPhase::Type\n }\n AnyJsImportClause::JsImportNamedClause(clause)\n- if clause.type_token().is_some() =>\n+ if clause.type_token().is_some()\n+ || clause.named_specifiers().is_ok_and(|specifiers| {\n+ let mut specifiers = specifiers.specifiers().iter();\n+ specifiers.len() > 0\n+ && specifiers.all(|specifier| {\n+ specifier.is_ok_and(|specifier| {\n+ specifier.imports_only_types()\n+ })\n+ })\n+ }) =>","path":"crates/biome_module_graph/src/js_module_info/visitor.rs","commit_id":"043974d458fccaf53708ebfb9ceea9eaad693025","original_commit_id":"abb4272df1055b84479eb4689c7f7a6565015382","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"@coderabbitai that's an impossible situation, how can you import a type from a CSS file? ","created_at":"2026-08-08T10:56:06Z","updated_at":"2026-08-08T10:56:06Z","html_url":"https://github.com/biomejs/biome/pull/11191#discussion_r3740537245","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11191","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740537245"},"html":{"href":"https://github.com/biomejs/biome/pull/11191#discussion_r3740537245"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11191"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740537245/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"in_reply_to_id":3740456246,"original_position":23,"position":23,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11191","id":4189655097,"number":11191,"head":{"ref":"feat/no-undefined-custom-property","sha":"043974d458fccaf53708ebfb9ceea9eaad693025","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}},"base":{"ref":"main","sha":"23c0369c43b59284ca68c65883d6ede4228b6fb8","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T10:56:06Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12973660140","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888673567,"node_id":"PRR_kwDOKAiibM8AAAABI2M9Hw","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":null,"commit_id":"abb4272df1055b84479eb4689c7f7a6565015382","state":"commented","html_url":"https://github.com/biomejs/biome/pull/11191#pullrequestreview-4888673567","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11191","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11191#pullrequestreview-4888673567"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11191"}},"submitted_at":"2026-08-08T10:55:07Z","updated_at":"2026-08-08T10:55:07Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11191","id":4189655097,"number":11191,"head":{"ref":"feat/no-undefined-custom-property","sha":"043974d458fccaf53708ebfb9ceea9eaad693025","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}},"base":{"ref":"main","sha":"23c0369c43b59284ca68c65883d6ede4228b6fb8","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"created"},"public":true,"created_at":"2026-08-08T10:55:09Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12973659613","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740535563","pull_request_review_id":4888673567,"id":3740535563,"node_id":"PRRC_kwDOKAiibM7e9AsL","diff_hunk":"@@ -101,20 +101,48 @@ pub fn parse_embedded_css(src: &str, file_source: CssFileSource) -> HtmlEmbedded\n ..Default::default()\n },\n );\n- HtmlEmbeddedContent::Css(parsed.tree(), file_source, 0.into())\n+ (parsed.into(), file_source)\n }\n \n pub fn build_html_db(\n fs: &MemoryFileSystem,\n- files: &[(&str, &str, HtmlFileSource, Vec)],\n+ files: &[(&str, &str, HtmlFileSource, Vec<(AnyParse, CssFileSource)>)],\n ) -> WorkspaceDb {\n let mut db = WorkspaceDb::default();\n let cache = PathInfoCache::default();\n for (path, source, file_source, embedded) in files {\n let path = BiomePath::new(*path);\n- let root = biome_html_parser::parse_html(source, file_source.into()).tree();\n- let (info, _, _) =\n- resolve_html_module(root, embedded, &path, fs, &ProjectLayout::default(), &cache);\n+ let snippets = embedded\n+ .iter()\n+ .map(|(parsed, file_source)| {\n+ let source_index = db.insert_source(DocumentFileSource::Css(*file_source));\n+ ParsedSnippet::new(\n+ &db,\n+ parsed.clone(),\n+ Default::default(),\n+ Default::default(),\n+ 0.into(),\n+ source_index,\n+ )\n+ })\n+ .collect();","path":"crates/biome_module_graph/tests/spec_tests/support.rs","commit_id":"043974d458fccaf53708ebfb9ceea9eaad693025","original_commit_id":"abb4272df1055b84479eb4689c7f7a6565015382","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"@coderabbitai what's the real problem here? It's a test","created_at":"2026-08-08T10:55:07Z","updated_at":"2026-08-08T10:55:07Z","html_url":"https://github.com/biomejs/biome/pull/11191#discussion_r3740535563","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11191","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740535563"},"html":{"href":"https://github.com/biomejs/biome/pull/11191#discussion_r3740535563"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11191"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740535563/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"in_reply_to_id":3740456251,"original_position":60,"position":74,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11191","id":4189655097,"number":11191,"head":{"ref":"feat/no-undefined-custom-property","sha":"043974d458fccaf53708ebfb9ceea9eaad693025","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}},"base":{"ref":"main","sha":"23c0369c43b59284ca68c65883d6ede4228b6fb8","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T10:55:07Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17120777199","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39437937268,"ref":"refs/heads/feat/no-undefined-custom-property","head":"043974d458fccaf53708ebfb9ceea9eaad693025","before":"cba84a066f853939a2eaa1c77b475a1f7263ae1a"},"public":true,"created_at":"2026-08-08T10:53:15Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17117825137","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39434967932,"ref":"refs/heads/feat/no-undefined-custom-property","head":"abb4272df1055b84479eb4689c7f7a6565015382","before":"ebf476fd74d7fb477c2b8f65433d30ed0ff7d066"},"public":true,"created_at":"2026-08-08T09:46:41Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17117824406","type":"DeleteEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"ref":"feat/lint-property-init-value","ref_type":"branch","full_ref":"refs/heads/feat/lint-property-init-value","pusher_type":"user"},"public":true,"created_at":"2026-08-08T09:46:40Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17117824711","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39434967502,"ref":"refs/heads/main","head":"23c0369c43b59284ca68c65883d6ede4228b6fb8","before":"f3a9868974e43ac73552cb6f1630059d95a9e3d8"},"public":true,"created_at":"2026-08-08T09:46:40Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12972568269","type":"PullRequestEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"merged","number":11187,"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11187","id":4189444840,"number":11187,"head":{"ref":"feat/lint-property-init-value","sha":"3773e3ac0d60d34a9937b31127be1f5db8f4c32a","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}},"base":{"ref":"main","sha":"73896e6712ba4c398ba21141829f8361ace45eb2","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T09:46:37Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17117813881","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39434956633,"ref":"refs/heads/feat/no-undefined-custom-property","head":"ebf476fd74d7fb477c2b8f65433d30ed0ff7d066","before":"91651f1478ac5def93fd989bee8d88c8a5097ba3"},"public":true,"created_at":"2026-08-08T09:46:26Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17114983775","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39432110066,"ref":"refs/heads/feat/no-undefined-custom-property","head":"91651f1478ac5def93fd989bee8d88c8a5097ba3","before":"4f5818cadddb512e2df49b8203c5c7fcf438b0f1"},"public":true,"created_at":"2026-08-08T08:51:14Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"17114773730","type":"PushEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"repository_id":671654508,"push_id":39431897911,"ref":"refs/heads/feat/lint-property-init-value","head":"3773e3ac0d60d34a9937b31127be1f5db8f4c32a","before":"36f9f1c89bfa85b9c292435173876d6eae8e062c"},"public":true,"created_at":"2026-08-08T08:46:59Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968891410","type":"IssueCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/biomejs/biome/issues/11238","repository_url":"https://api.github.com/repos/biomejs/biome","labels_url":"https://api.github.com/repos/biomejs/biome/issues/11238/labels{/name}","comments_url":"https://api.github.com/repos/biomejs/biome/issues/11238/comments","events_url":"https://api.github.com/repos/biomejs/biome/issues/11238/events","html_url":"https://github.com/biomejs/biome/pull/11238","id":5063157993,"node_id":"PR_kwDOKAiibM76rTYN","number":11238,"title":"feat(linter): add skipComments option to noExcessiveLinesPerFile","user":{"login":"raulchincaamal","id":111538549,"node_id":"U_kgDOBqXxdQ","avatar_url":"https://avatars.githubusercontent.com/u/111538549?v=4","gravatar_id":"","url":"https://api.github.com/users/raulchincaamal","html_url":"https://github.com/raulchincaamal","followers_url":"https://api.github.com/users/raulchincaamal/followers","following_url":"https://api.github.com/users/raulchincaamal/following{/other_user}","gists_url":"https://api.github.com/users/raulchincaamal/gists{/gist_id}","starred_url":"https://api.github.com/users/raulchincaamal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulchincaamal/subscriptions","organizations_url":"https://api.github.com/users/raulchincaamal/orgs","repos_url":"https://api.github.com/users/raulchincaamal/repos","events_url":"https://api.github.com/users/raulchincaamal/events{/privacy}","received_events_url":"https://api.github.com/users/raulchincaamal/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[{"id":5855716217,"node_id":"LA_kwDOKAiibM8AAAABXQcjeQ","url":"https://api.github.com/repos/biomejs/biome/labels/A-Linter","name":"A-Linter","color":"a4c8fc","default":false,"description":"Area: linter"},{"id":5855724088,"node_id":"LA_kwDOKAiibM8AAAABXQdCOA","url":"https://api.github.com/repos/biomejs/biome/labels/L-JavaScript","name":"L-JavaScript","color":"ffe2bf","default":false,"description":"Language: JavaScript and super languages"},{"id":5855724791,"node_id":"LA_kwDOKAiibM8AAAABXQdE9w","url":"https://api.github.com/repos/biomejs/biome/labels/L-CSS","name":"L-CSS","color":"ffe2bf","default":false,"description":"Language: CSS and super languages"},{"id":7425265033,"node_id":"LA_kwDOKAiibM8AAAABupSNiQ","url":"https://api.github.com/repos/biomejs/biome/labels/L-HTML","name":"L-HTML","color":"ffe2bf","default":false,"description":"Language: HTML and super languages"}],"state":"open","locked":false,"assignees":[],"milestone":null,"comments":5,"created_at":"2026-08-04T17:24:10Z","updated_at":"2026-08-08T06:18:56Z","closed_at":null,"assignee":null,"issue_field_values":[],"type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","html_url":"https://github.com/biomejs/biome/pull/11238","diff_url":"https://github.com/biomejs/biome/pull/11238.diff","patch_url":"https://github.com/biomejs/biome/pull/11238.patch","merged_at":null},"body":"## Summary\n\nAdds `skipComments` option to `noExcessiveLinesPerFile` across JS, CSS, GraphQL, and HTML analyzers.\nWhen set to `true`, lines consisting only of `//` or `/* */` comments are excluded from the line count.\nThis brings the rule closer to feature parity with ESLint's `max-lines` rule.\n\n## Test Plan\n\n- Added `skipComments.js` and `skipCommentsInvalid.js` snapshot tests in `biome_js_analyze`\n- Verified locally with `cargo test` and a Node.js project using the compiled binary\n\n## Docs\n\nRustdoc examples added to `declare_lint_rule!` for JS and CSS rules. HTML excluded because `` comments are not yet supported by the line-counting logic.\n","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/11238/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/biomejs/biome/issues/11238/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/biomejs/biome/issues/comments/5224851780","html_url":"https://github.com/biomejs/biome/pull/11238#issuecomment-5224851780","issue_url":"https://api.github.com/repos/biomejs/biome/issues/11238","id":5224851780,"node_id":"IC_kwDOKAiibM8AAAABN2zpRA","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-08-08T06:06:14Z","updated_at":"2026-08-08T06:06:14Z","body":"@raulchincaamal \n\nThe list of changes you listed in your pr don't reflect the code. You changed the algorithm of the rule and you didn't explain why. That's an important detail that shouldn't be omitted ","reactions":{"url":"https://api.github.com/repos/biomejs/biome/issues/comments/5224851780/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null,"minimized":null}},"public":true,"created_at":"2026-08-08T06:06:14Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968831932","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888276113,"node_id":"PRR_kwDOKAiibM8AAAABI10skQ","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The change in the algorithm is wrong. ","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","state":"changes_requested","html_url":"https://github.com/biomejs/biome/pull/11238#pullrequestreview-4888276113","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11238#pullrequestreview-4888276113"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"submitted_at":"2026-08-08T06:02:36Z","updated_at":"2026-08-08T06:02:36Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"created"},"public":true,"created_at":"2026-08-08T06:02:37Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968831922","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888276113,"node_id":"PRR_kwDOKAiibM8AAAABI10skQ","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The change in the algorithm is wrong. ","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","state":"changes_requested","html_url":"https://github.com/biomejs/biome/pull/11238#pullrequestreview-4888276113","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11238#pullrequestreview-4888276113"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"submitted_at":"2026-08-08T06:02:36Z","updated_at":"2026-08-08T06:02:36Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"updated"},"public":true,"created_at":"2026-08-08T06:02:37Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968789437","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740132135","pull_request_review_id":4888276113,"id":3740132135,"node_id":"PRRC_kwDOKAiibM7e7eMn","diff_hunk":"@@ -235,30 +235,56 @@ where\n /// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.\n ///\n /// When `skip_blank_lines` is true, counts tokens with leading newlines (excluding blank lines).\n+/// When `skip_comments` is true, lines consisting only of comments are not counted.\n /// When false, counts all newline characters in leading trivia (trailing trivia is trimmed\n /// to prevent double-counting). Returns total + 1 to account for the first line.\n pub fn count_lines_in_file(\n node: &SyntaxNode,\n is_eof_token: impl Fn(&SyntaxToken) -> bool,\n skip_blank_lines: bool,\n+ skip_comments: bool,\n ) -> usize {\n- let mut count = 0;\n- for descendant in node.descendants() {\n- for token in descendant.tokens() {\n+ if skip_comments {\n+ // Each code token occupies exactly one line. Comments are stored as\n+ // leading trivia of the following token, so comment-only lines never\n+ // have a token starting on them. Counting tokens that begin a new line\n+ // (have a leading newline) plus the first line gives the number of\n+ // lines that contain code.\n+ let mut count = 0;\n+ let mut first_token_seen = false;\n+\n+ for token in node.descendants_tokens(biome_rowan::Direction::Next) {\n if is_eof_token(&token) {\n continue;\n }\n- if skip_blank_lines {\n- count += token.has_leading_newline() as usize;\n- } else {\n- count += token\n- .trim_trailing_trivia()\n- .leading_trivia()\n- .pieces()\n- .filter(|piece| piece.is_newline())\n- .count();\n+\n+ if !first_token_seen {\n+ first_token_seen = true;\n+ count = 1;\n+ } else if token.has_leading_newline() {","path":"crates/biome_analyze/src/utils.rs","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","original_commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This is... Wrong? Multiple newlines can be attached to a token \n\nhttps://biomejs.dev/playground/?indentStyle=space&tab=syntax&pane=Diagnostics&code=YwBvAG4AcwB0AAoACgAgACAAZgBvAG8ACgAKAAoACgAKACAAIAA9ACAACgAKAAoACgAgACAAIAAxADsA","created_at":"2026-08-08T06:00:02Z","updated_at":"2026-08-08T06:02:36Z","html_url":"https://github.com/biomejs/biome/pull/11238#discussion_r3740132135","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740132135"},"html":{"href":"https://github.com/biomejs/biome/pull/11238#discussion_r3740132135"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740132135/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":51,"position":51,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T06:00:02Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968766275","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740129830","pull_request_review_id":4888276113,"id":3740129830,"node_id":"PRRC_kwDOKAiibM7e7dom","diff_hunk":"@@ -235,30 +235,56 @@ where\n /// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.\n ///\n /// When `skip_blank_lines` is true, counts tokens with leading newlines (excluding blank lines).\n+/// When `skip_comments` is true, lines consisting only of comments are not counted.\n /// When false, counts all newline characters in leading trivia (trailing trivia is trimmed\n /// to prevent double-counting). Returns total + 1 to account for the first line.\n pub fn count_lines_in_file(\n node: &SyntaxNode,\n is_eof_token: impl Fn(&SyntaxToken) -> bool,\n skip_blank_lines: bool,\n+ skip_comments: bool,\n ) -> usize {\n- let mut count = 0;\n- for descendant in node.descendants() {\n- for token in descendant.tokens() {\n+ if skip_comments {\n+ // Each code token occupies exactly one line. Comments are stored as\n+ // leading trivia of the following token, so comment-only lines never\n+ // have a token starting on them. Counting tokens that begin a new line\n+ // (have a leading newline) plus the first line gives the number of\n+ // lines that contain code.\n+ let mut count = 0;\n+ let mut first_token_seen = false;\n+\n+ for token in node.descendants_tokens(biome_rowan::Direction::Next) {\n if is_eof_token(&token) {\n continue;\n }\n- if skip_blank_lines {\n- count += token.has_leading_newline() as usize;\n- } else {\n- count += token\n- .trim_trailing_trivia()\n- .leading_trivia()\n- .pieces()\n- .filter(|piece| piece.is_newline())\n- .count();\n+\n+ if !first_token_seen {\n+ first_token_seen = true;\n+ count = 1;\n+ } else if token.has_leading_newline() {\n+ count += 1;\n+ }\n+ }\n+ count\n+ } else {\n+ let mut count = 0;\n+ for descendant in node.descendants() {\n+ for token in descendant.tokens() {","path":"crates/biome_analyze/src/utils.rs","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","original_commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"There's already a function that gives you the descendants tokens ","created_at":"2026-08-08T05:58:28Z","updated_at":"2026-08-08T06:02:36Z","html_url":"https://github.com/biomejs/biome/pull/11238#discussion_r3740129830","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740129830"},"html":{"href":"https://github.com/biomejs/biome/pull/11238#discussion_r3740129830"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740129830/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":59,"position":59,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T05:58:28Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968755902","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740128952","pull_request_review_id":4888276113,"id":3740128952,"node_id":"PRRC_kwDOKAiibM7e7da4","diff_hunk":"@@ -235,30 +235,56 @@ where\n /// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.\n ///\n /// When `skip_blank_lines` is true, counts tokens with leading newlines (excluding blank lines).\n+/// When `skip_comments` is true, lines consisting only of comments are not counted.\n /// When false, counts all newline characters in leading trivia (trailing trivia is trimmed\n /// to prevent double-counting). Returns total + 1 to account for the first line.\n pub fn count_lines_in_file(\n node: &SyntaxNode,\n is_eof_token: impl Fn(&SyntaxToken) -> bool,\n skip_blank_lines: bool,\n+ skip_comments: bool,\n ) -> usize {\n- let mut count = 0;\n- for descendant in node.descendants() {\n- for token in descendant.tokens() {\n+ if skip_comments {\n+ // Each code token occupies exactly one line. Comments are stored as\n+ // leading trivia of the following token, so comment-only lines never\n+ // have a token starting on them. Counting tokens that begin a new line\n+ // (have a leading newline) plus the first line gives the number of\n+ // lines that contain code.\n+ let mut count = 0;","path":"crates/biome_analyze/src/utils.rs","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","original_commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Better names ","created_at":"2026-08-08T05:57:45Z","updated_at":"2026-08-08T06:02:36Z","html_url":"https://github.com/biomejs/biome/pull/11238#discussion_r3740128952","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740128952"},"html":{"href":"https://github.com/biomejs/biome/pull/11238#discussion_r3740128952"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740128952/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":31,"position":31,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T05:57:45Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968744192","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740127718","pull_request_review_id":4888276113,"id":3740127718,"node_id":"PRRC_kwDOKAiibM7e7dHm","diff_hunk":"@@ -235,30 +235,56 @@ where\n /// Counts lines in a syntax tree, used by `noExcessiveLinesPerFile`.\n ///\n /// When `skip_blank_lines` is true, counts tokens with leading newlines (excluding blank lines).\n+/// When `skip_comments` is true, lines consisting only of comments are not counted.\n /// When false, counts all newline characters in leading trivia (trailing trivia is trimmed\n /// to prevent double-counting). Returns total + 1 to account for the first line.\n pub fn count_lines_in_file(\n node: &SyntaxNode,\n is_eof_token: impl Fn(&SyntaxToken) -> bool,\n skip_blank_lines: bool,\n+ skip_comments: bool,\n ) -> usize {\n- let mut count = 0;\n- for descendant in node.descendants() {\n- for token in descendant.tokens() {\n+ if skip_comments {\n+ // Each code token occupies exactly one line. Comments are stored as\n+ // leading trivia of the following token, so comment-only lines never\n+ // have a token starting on them. Counting tokens that begin a new line\n+ // (have a leading newline) plus the first line gives the number of\n+ // lines that contain code.","path":"crates/biome_analyze/src/utils.rs","commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","original_commit_id":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"This comment says many things that are wrong:\n- there's no concept of lines among tokens. Two tokens can occupy the same line\n- comments _can_ be stored as trailing trivia too\n- the second sentence is confusing, maybe rephrase it","created_at":"2026-08-08T05:57:01Z","updated_at":"2026-08-08T06:02:36Z","html_url":"https://github.com/biomejs/biome/pull/11238#discussion_r3740127718","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11238","_links":{"self":{"href":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740127718"},"html":{"href":"https://github.com/biomejs/biome/pull/11238#discussion_r3740127718"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11238"}},"reactions":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740127718/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":30,"position":30,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11238","id":4205655565,"number":11238,"head":{"ref":"feat/skip-comments-no-excessive-lines","sha":"93ef69cb09106b6bc8bb367049e9e22fcdb26489","repo":{"id":1315206933,"url":"https://api.github.com/repos/raulchincaamal/biome","name":"biome"}},"base":{"ref":"next","sha":"fa63050d37f0ee45195ca62bf192c5e9800705b6","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}}},"public":true,"created_at":"2026-08-08T05:57:01Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968360681","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888219892,"node_id":"PRR_kwDOKAiibM8AAAABI1xQ9A","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"","commit_id":"09b8afbe12905e000ac54e7cff3941ce48d6f66d","state":"commented","html_url":"https://github.com/biomejs/biome/pull/11220#pullrequestreview-4888219892","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11220","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11220#pullrequestreview-4888219892"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11220"}},"submitted_at":"2026-08-08T05:33:11Z","updated_at":"2026-08-08T05:33:11Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11220","id":4197399072,"number":11220,"head":{"ref":"fix/svelte-vue-exported-embedded-bindings","sha":"8dc7e218376e579479548ada780167372e72ecd2","repo":{"id":1322065939,"url":"https://api.github.com/repos/santichausis/biome","name":"biome"}},"base":{"ref":"main","sha":"6556ca3c11659ba67c33e7be3605d12f33c8616b","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"created"},"public":true,"created_at":"2026-08-08T05:33:13Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968360668","type":"PullRequestReviewEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"review":{"id":4888219892,"node_id":"PRR_kwDOKAiibM8AAAABI1xQ9A","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"","commit_id":"09b8afbe12905e000ac54e7cff3941ce48d6f66d","state":"commented","html_url":"https://github.com/biomejs/biome/pull/11220#pullrequestreview-4888219892","pull_request_url":"https://api.github.com/repos/biomejs/biome/pulls/11220","_links":{"html":{"href":"https://github.com/biomejs/biome/pull/11220#pullrequestreview-4888219892"},"pull_request":{"href":"https://api.github.com/repos/biomejs/biome/pulls/11220"}},"submitted_at":"2026-08-08T05:33:11Z","updated_at":"2026-08-08T05:33:11Z"},"pull_request":{"url":"https://api.github.com/repos/biomejs/biome/pulls/11220","id":4197399072,"number":11220,"head":{"ref":"fix/svelte-vue-exported-embedded-bindings","sha":"8dc7e218376e579479548ada780167372e72ecd2","repo":{"id":1322065939,"url":"https://api.github.com/repos/santichausis/biome","name":"biome"}},"base":{"ref":"main","sha":"6556ca3c11659ba67c33e7be3605d12f33c8616b","repo":{"id":671654508,"url":"https://api.github.com/repos/biomejs/biome","name":"biome"}}},"action":"updated"},"public":true,"created_at":"2026-08-08T05:33:13Z","org":{"id":140182603,"login":"biomejs","gravatar_id":"","url":"https://api.github.com/orgs/biomejs","avatar_url":"https://avatars.githubusercontent.com/u/140182603?"}},{"id":"12968356537","type":"PullRequestReviewCommentEvent","actor":{"id":602478,"login":"ematipico","display_login":"ematipico","gravatar_id":"","url":"https://api.github.com/users/ematipico","avatar_url":"https://avatars.githubusercontent.com/u/602478?"},"repo":{"id":671654508,"name":"biomejs/biome","url":"https://api.github.com/repos/biomejs/biome"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/biomejs/biome/pulls/comments/3740080901","pull_request_review_id":4888219892,"id":3740080901,"node_id":"PRRC_kwDOKAiibM7e7RsF","diff_hunk":"@@ -0,0 +1,5 @@\n+---\n+\"@biomejs/biome\": patch\n+---\n+\n+Fixed [#9541](https://github.com/biomejs/biome/issues/9541): `noUndeclaredVariables` (and other rules relying on cross-script-block bindings, such as `noUnusedImports` and `noUnusedVariables`) failed to recognize a top-level binding declared with `export` (e.g. `export const foo = ...`, `export function foo() {}`) inside one embedded script block as visible from a sibling script block. This affected Svelte's `