[{"id":"36969909478","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/events","html_url":"https://github.com/google/site-kit-wp/issues/8141","id":2098754767,"node_id":"I_kwDOC2hWJc59GHTP","number":8141,"title":"Add “partial data” states infrastructure","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"},{"id":3327716157,"node_id":"MDU6TGFiZWwzMzI3NzE2MTU3","url":"https://api.github.com/repos/google/site-kit-wp/labels/PHP","name":"PHP","color":"8892BF","default":false,"description":""},{"id":5204615861,"node_id":"LA_kwDOC2hWJc8AAAABNjgitQ","url":"https://api.github.com/repos/google/site-kit-wp/labels/Sp%20Wk%202","name":"Sp Wk 2","color":"1d76db","default":false,"description":"Issues to be completed in the second week of the assigned sprint"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2024-01-24T17:29:50Z","updated_at":"2024-03-28T14:27:51Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAdd the full infrastructure for determining and exposing the \"partial data\" states for audiences, custom dimensions and properties.\r\n\r\nSee [partial data states](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.5p6ukexs73j4) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Analytics module should have new selectors for detecting whether an audience, custom dimension or analytics property (referred as resource in the following points) is in \"partial data\" state. \r\n * A resource is considered to be in \"partial data\" state until it has been active for the full duration of the currently selected date range. \r\n * A resource is also considered to be in \"partial data\" state if the GA4 itself is in gathering data. \r\n* Partial data state should be determined by retrieving a report of the given resource and checking the date of the earliest event and making a comparison with the start date of the current date range.\r\n* Similarly how it's done for the gathering data states, the date of the earliest event, once determined, should be persisted on the server and made available in client on page load. \r\n * The persisted date for a given resource. whenever available. should be used instead of making a report request to determine the partial states in the resolvers of partial data selectors.\r\n * Persisted dates for all resources should be reset whenever Analytics property or measurement ID changes, Analytics module is deactivated or Site Kit is reset. \r\n\r\n## Implementation Brief\r\n\r\n **Note: the following IB is heavily based on and inspired by Data_Available state for modules and custom dimensions. Any gap in the IB may be filled in by reassessing the implementation and comparing with the aforementioned infrastructure.** \r\n\r\n### PHP\r\n\r\n* [ ] Create class `Google\\Site_Kit\\Modules\\Analytics_4\\Resource_Data_Availability_Date`.\r\n * [ ] Take `Transients $transients` in the constructor and initialize as a field. \r\n * [ ] Use Const `VALID_CUSTOM_DIMENSION_SLUGS` and `VALID_AUDIENCE_SLUGS` to store valid and allowed custom dimensions and slugs. \r\n * [ ] Have `RESOURCE_TYPE_**` consts for audience, custom dimension and property resources. \r\n * [ ] Method `get_resource_transient_name` takes resource name and resource type parameters and returns the computed transient name. ie. `return \"googlesitekit_{$resource_type}_{$resource_name}_data_availability_date\";`\r\n * [ ] Method `get_resource_dates` should return an associative array of the data availability date of resources. This can be multi dimensional array or the resources can be prefixed with the resource type. \r\n * [ ] Other methods `get_resource_date`, `set_resource_date`, `reset_resource_date` etc should be implemented similarly to how it is done on `Google\\Site_Kit\\Modules\\Analytics_4\\Custom_Dimensions_Data_Available` class. \r\n* [ ] In `Google\\Site_Kit\\Modules\\Analytics_4` class:\r\n * [ ] Add `$resource_data_available_date` field and instantiate it with `Resource_Data_Availability_Date` in the constructor. \r\n * [ ] Create A New REST Endpoint `POST:save-resource-data-availability-date` in `Analytics_4` module. \r\n * [ ] It should check if the passed resource(s) in the $data (`audience`, `customDimension` or `property`) are valid, and then persist the date values as a timestamp in the DB using the `$this->resource_data_available_date->set_resource_date` method. \r\n * [ ] Expose the persisted dates of resource data availability to client using `googlesitekit_inline_modules_data` filter in the `register` method. \r\n * [ ] Call `$resource_data_available_date->reset_resource_date()` in `on_deactivation` method to reset all persisted dates on module deactivation. \r\n * [ ] Call `$resource_data_available_date->reset_resource_date()` in the `$this->get_settings()->on_change()` when property ID or measurement ID is different, similarly to how it's done with `$this->custom_dimensions_data_available->reset_data_available()` to reset the persisted dates when analytics property/measurement ID changes. \r\n\r\n### JS\r\n\r\n* [ ] Create `assets/js/modules/analytics-4/datastore/partial-data.js` file.\r\n * [ ] Create a fetch store for the aforementioned POST API. \r\n * [ ] Actions:\r\n * [ ] `saveResourceDataAvailabilityDate` takes an array of the object `{resource name, resource type and date}` and save it to the server using the fetch store. \r\n * [ ] Selectors: \r\n * [ ] `getResourceDataAvailabilityDate(resourceName, resourceTyoe)`: returns the date associated with the given resource if available, otherwise resolves to the first date in the last 90 days that the report data became available using the associated resolver (described below). The 90 days is chosen because that's the longest date range available in Site Kit. \r\n * [ ] `is{audience|customDimension|Property}PartialData(resourceName)`: \r\n * [ ] Return `true` when GA4 is in gathering Data state. \r\n * [ ] Return `false` when the `dataAvailabilityDate` for the is same or earlier than the `startDate` of currently selected date range. \r\n * [ ] Otherwise, return `true`. This also handles the case where `dataAvailabilityDate` for a given resource can not be determined due to errors or being in the shared dashboard. \r\n * [ ] Resolvers\r\n * [ ] `getResourceDataAvailabilityDate`: \r\n * [ ] Get `reportArgs` for the given resource. \r\n * [ ] For a property, this `ReportArgs` is similar to one returned by `getSampleReportArgs` from `assets/js/modules/analytics-4/utils/report-args.js`, while the change here being:\r\n * [ ] Start date: creation date of the current GA property. \r\n * [ ] End date: the reference date.\r\n * [ ] For audience, the `reportArgs` will include `audienceResourceName` as an additional `dimension`. \r\n * [ ] This will allow for a single report for all audience resources, and filtering the resulted report for a specific resource in JS to get the earliest date for a given audience resource. \r\n * [ ] For Custom Dimension, report args should be the following:\r\n * [ ] Start date: creation date of the current GA property. \r\n * [ ] End date: the reference date. \r\n * [ ] The dimension: `date` for property resource, and `customEvent:${ resourceName }` \r\n * [ ] Metric: `eventCount`. \r\n * [ ] See `getDataAvailabilityReportOptions` selector in `assets/js/modules/analytics-4/datastore/custom-dimensions-gathering-data.js` and `getSampleReportArgs` in `assets/js/modules/analytics-4/datastore/report.js` for more complete example. The implementation can largely be followed. \r\n * [ ] Make a simple report request to the given resource using the above report args. \r\n * [ ] Find the date of the first available report. \r\n * [ ] If there is any error or user doesn't have permission (ie. the property creation date can not be accessed in shared dashboard), return `null` and do not persist anything. \r\n * [ ]Otherwise, persist the date for the given resource using `saveResourceDataAvailabilityDate` and return the date. \r\n* [ ] Add the newly added store partial to `assets/js/modules/analytics-4/datastore/index.js`. \r\n\r\n### Test Coverage\r\n\r\n* Add PHP Unit test for the newly added infrastructure. \r\n* Add Jest test for the newly added selectors and actions. \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2025339061","html_url":"https://github.com/google/site-kit-wp/issues/8141#issuecomment-2025339061","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","id":2025339061,"node_id":"IC_kwDOC2hWJc54uDi1","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-28T14:27:50Z","updated_at":"2024-03-28T14:27:50Z","author_association":"COLLABORATOR","body":"Thanks, @kuasha420. IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2025339061/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-28T14:27:52Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36943555399","type":"PushEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"repository_id":191387173,"push_id":17734642250,"size":2,"distinct_size":2,"ref":"refs/heads/develop","head":"14cdd8a2377d3298392e2ce05dddc9c512b46805","before":"a3d2a7dc124edb9faf692ae008183095862fd566","commits":[{"sha":"047f818f297b1ed4ae6f64a7527d44abbfecfa65","author":{"email":"hi@tofumatt.com","name":"Matthew Riley MacPherson (tofumatt)"},"message":"Update string to use new wording in setup component.","distinct":true,"url":"https://api.github.com/repos/google/site-kit-wp/commits/047f818f297b1ed4ae6f64a7527d44abbfecfa65"},{"sha":"14cdd8a2377d3298392e2ce05dddc9c512b46805","author":{"email":"eugene.manuilov@get10up.com","name":"Eugene Manuilov"},"message":"Merge pull request #8433 from google/existing-tag-follow-up-8405\n\nUpdate string to use new wording in setup component.","distinct":true,"url":"https://api.github.com/repos/google/site-kit-wp/commits/14cdd8a2377d3298392e2ce05dddc9c512b46805"}]},"public":true,"created_at":"2024-03-27T19:14:36Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36943555167","type":"DeleteEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"ref":"existing-tag-follow-up-8405","ref_type":"branch","pusher_type":"user"},"public":true,"created_at":"2024-03-27T19:14:36Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36943554875","type":"PullRequestEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"closed","number":8433,"pull_request":{"url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433","id":1793711867,"node_id":"PR_kwDOC2hWJc5q6d77","html_url":"https://github.com/google/site-kit-wp/pull/8433","diff_url":"https://github.com/google/site-kit-wp/pull/8433.diff","patch_url":"https://github.com/google/site-kit-wp/pull/8433.patch","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8433","number":8433,"state":"closed","locked":false,"title":"Update string to use new wording in setup component.","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"## Summary\n\n\nAddresses issue:\n\n- #8405\n\n## PR Author Checklist\n\n- [x] My code is tested and passes existing unit tests.\n- [x] My code has an appropriate set of unit tests which all pass.\n- [x] My code is backward-compatible with WordPress 5.2 and PHP 5.6.\n- [x] My code follows the [WordPress](https://make.wordpress.org/core/handbook/best-practices/coding-standards/) coding standards.\n- [x] My code has proper inline documentation.\n- [x] I have added a QA Brief on the issue linked above.\n- [x] I have signed the Contributor License Agreement (see ).\n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Code Reviewer Checklist\n\n- [ ] Run the code.\n- [ ] Ensure the acceptance criteria are satisfied.\n- [ ] Reassess the implementation with the IB.\n- [ ] Ensure no unrelated changes are included.\n- [ ] Ensure CI checks pass.\n- [ ] Check Storybook where applicable.\n- [ ] Ensure there is a QA Brief.\n\n## Merge Reviewer Checklist\n\n- [ ] Ensure the PR has the correct target branch.\n- [ ] Double-check that the PR is okay to be merged.\n- [ ] Ensure the corresponding issue has a ZenHub release assigned.\n- [ ] Add a changelog message to the issue.\n","created_at":"2024-03-27T11:14:00Z","updated_at":"2024-03-27T19:14:35Z","closed_at":"2024-03-27T19:14:34Z","merged_at":"2024-03-27T19:14:34Z","merge_commit_sha":"14cdd8a2377d3298392e2ce05dddc9c512b46805","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/commits","review_comments_url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/comments","review_comment_url":"https://api.github.com/repos/google/site-kit-wp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8433/comments","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/047f818f297b1ed4ae6f64a7527d44abbfecfa65","head":{"label":"google:existing-tag-follow-up-8405","ref":"existing-tag-follow-up-8405","sha":"047f818f297b1ed4ae6f64a7527d44abbfecfa65","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":191387173,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEzODcxNzM=","name":"site-kit-wp","full_name":"google/site-kit-wp","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/site-kit-wp","description":"Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.","fork":false,"url":"https://api.github.com/repos/google/site-kit-wp","forks_url":"https://api.github.com/repos/google/site-kit-wp/forks","keys_url":"https://api.github.com/repos/google/site-kit-wp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/site-kit-wp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/site-kit-wp/teams","hooks_url":"https://api.github.com/repos/google/site-kit-wp/hooks","issue_events_url":"https://api.github.com/repos/google/site-kit-wp/issues/events{/number}","events_url":"https://api.github.com/repos/google/site-kit-wp/events","assignees_url":"https://api.github.com/repos/google/site-kit-wp/assignees{/user}","branches_url":"https://api.github.com/repos/google/site-kit-wp/branches{/branch}","tags_url":"https://api.github.com/repos/google/site-kit-wp/tags","blobs_url":"https://api.github.com/repos/google/site-kit-wp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/site-kit-wp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/site-kit-wp/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/site-kit-wp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/{sha}","languages_url":"https://api.github.com/repos/google/site-kit-wp/languages","stargazers_url":"https://api.github.com/repos/google/site-kit-wp/stargazers","contributors_url":"https://api.github.com/repos/google/site-kit-wp/contributors","subscribers_url":"https://api.github.com/repos/google/site-kit-wp/subscribers","subscription_url":"https://api.github.com/repos/google/site-kit-wp/subscription","commits_url":"https://api.github.com/repos/google/site-kit-wp/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/site-kit-wp/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/site-kit-wp/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/site-kit-wp/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/site-kit-wp/contents/{+path}","compare_url":"https://api.github.com/repos/google/site-kit-wp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/site-kit-wp/merges","archive_url":"https://api.github.com/repos/google/site-kit-wp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/site-kit-wp/downloads","issues_url":"https://api.github.com/repos/google/site-kit-wp/issues{/number}","pulls_url":"https://api.github.com/repos/google/site-kit-wp/pulls{/number}","milestones_url":"https://api.github.com/repos/google/site-kit-wp/milestones{/number}","notifications_url":"https://api.github.com/repos/google/site-kit-wp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/site-kit-wp/labels{/name}","releases_url":"https://api.github.com/repos/google/site-kit-wp/releases{/id}","deployments_url":"https://api.github.com/repos/google/site-kit-wp/deployments","created_at":"2019-06-11T14:20:21Z","updated_at":"2024-03-26T02:00:47Z","pushed_at":"2024-03-27T19:14:34Z","git_url":"git://github.com/google/site-kit-wp.git","ssh_url":"git@github.com:google/site-kit-wp.git","clone_url":"https://github.com/google/site-kit-wp.git","svn_url":"https://github.com/google/site-kit-wp","homepage":"https://sitekit.withgoogle.com","size":2494477,"stargazers_count":1208,"watchers_count":1208,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":false,"forks_count":277,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":486,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["site-kit","wordpress"],"visibility":"public","forks":277,"open_issues":486,"watchers":1208,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"a3d2a7dc124edb9faf692ae008183095862fd566","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":191387173,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEzODcxNzM=","name":"site-kit-wp","full_name":"google/site-kit-wp","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/site-kit-wp","description":"Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.","fork":false,"url":"https://api.github.com/repos/google/site-kit-wp","forks_url":"https://api.github.com/repos/google/site-kit-wp/forks","keys_url":"https://api.github.com/repos/google/site-kit-wp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/site-kit-wp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/site-kit-wp/teams","hooks_url":"https://api.github.com/repos/google/site-kit-wp/hooks","issue_events_url":"https://api.github.com/repos/google/site-kit-wp/issues/events{/number}","events_url":"https://api.github.com/repos/google/site-kit-wp/events","assignees_url":"https://api.github.com/repos/google/site-kit-wp/assignees{/user}","branches_url":"https://api.github.com/repos/google/site-kit-wp/branches{/branch}","tags_url":"https://api.github.com/repos/google/site-kit-wp/tags","blobs_url":"https://api.github.com/repos/google/site-kit-wp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/site-kit-wp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/site-kit-wp/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/site-kit-wp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/{sha}","languages_url":"https://api.github.com/repos/google/site-kit-wp/languages","stargazers_url":"https://api.github.com/repos/google/site-kit-wp/stargazers","contributors_url":"https://api.github.com/repos/google/site-kit-wp/contributors","subscribers_url":"https://api.github.com/repos/google/site-kit-wp/subscribers","subscription_url":"https://api.github.com/repos/google/site-kit-wp/subscription","commits_url":"https://api.github.com/repos/google/site-kit-wp/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/site-kit-wp/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/site-kit-wp/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/site-kit-wp/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/site-kit-wp/contents/{+path}","compare_url":"https://api.github.com/repos/google/site-kit-wp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/site-kit-wp/merges","archive_url":"https://api.github.com/repos/google/site-kit-wp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/site-kit-wp/downloads","issues_url":"https://api.github.com/repos/google/site-kit-wp/issues{/number}","pulls_url":"https://api.github.com/repos/google/site-kit-wp/pulls{/number}","milestones_url":"https://api.github.com/repos/google/site-kit-wp/milestones{/number}","notifications_url":"https://api.github.com/repos/google/site-kit-wp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/site-kit-wp/labels{/name}","releases_url":"https://api.github.com/repos/google/site-kit-wp/releases{/id}","deployments_url":"https://api.github.com/repos/google/site-kit-wp/deployments","created_at":"2019-06-11T14:20:21Z","updated_at":"2024-03-26T02:00:47Z","pushed_at":"2024-03-27T19:14:34Z","git_url":"git://github.com/google/site-kit-wp.git","ssh_url":"git@github.com:google/site-kit-wp.git","clone_url":"https://github.com/google/site-kit-wp.git","svn_url":"https://github.com/google/site-kit-wp","homepage":"https://sitekit.withgoogle.com","size":2494477,"stargazers_count":1208,"watchers_count":1208,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":false,"forks_count":277,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":486,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["site-kit","wordpress"],"visibility":"public","forks":277,"open_issues":486,"watchers":1208,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433"},"html":{"href":"https://github.com/google/site-kit-wp/pull/8433"},"issue":{"href":"https://api.github.com/repos/google/site-kit-wp/issues/8433"},"comments":{"href":"https://api.github.com/repos/google/site-kit-wp/issues/8433/comments"},"review_comments":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/comments"},"review_comment":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/commits"},"statuses":{"href":"https://api.github.com/repos/google/site-kit-wp/statuses/047f818f297b1ed4ae6f64a7527d44abbfecfa65"}},"author_association":"COLLABORATOR","auto_merge":null,"active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}},"public":true,"created_at":"2024-03-27T19:14:35Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36943552016","type":"PullRequestReviewEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","review":{"id":1964542038,"node_id":"PRR_kwDOC2hWJc51GIhW","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"body":"","commit_id":"047f818f297b1ed4ae6f64a7527d44abbfecfa65","submitted_at":"2024-03-27T19:14:27Z","state":"approved","html_url":"https://github.com/google/site-kit-wp/pull/8433#pullrequestreview-1964542038","pull_request_url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433","author_association":"COLLABORATOR","_links":{"html":{"href":"https://github.com/google/site-kit-wp/pull/8433#pullrequestreview-1964542038"},"pull_request":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433"}}},"pull_request":{"url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433","id":1793711867,"node_id":"PR_kwDOC2hWJc5q6d77","html_url":"https://github.com/google/site-kit-wp/pull/8433","diff_url":"https://github.com/google/site-kit-wp/pull/8433.diff","patch_url":"https://github.com/google/site-kit-wp/pull/8433.patch","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8433","number":8433,"state":"open","locked":false,"title":"Update string to use new wording in setup component.","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"## Summary\n\n\nAddresses issue:\n\n- #8405\n\n## PR Author Checklist\n\n- [x] My code is tested and passes existing unit tests.\n- [x] My code has an appropriate set of unit tests which all pass.\n- [x] My code is backward-compatible with WordPress 5.2 and PHP 5.6.\n- [x] My code follows the [WordPress](https://make.wordpress.org/core/handbook/best-practices/coding-standards/) coding standards.\n- [x] My code has proper inline documentation.\n- [x] I have added a QA Brief on the issue linked above.\n- [x] I have signed the Contributor License Agreement (see ).\n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Code Reviewer Checklist\n\n- [ ] Run the code.\n- [ ] Ensure the acceptance criteria are satisfied.\n- [ ] Reassess the implementation with the IB.\n- [ ] Ensure no unrelated changes are included.\n- [ ] Ensure CI checks pass.\n- [ ] Check Storybook where applicable.\n- [ ] Ensure there is a QA Brief.\n\n## Merge Reviewer Checklist\n\n- [ ] Ensure the PR has the correct target branch.\n- [ ] Double-check that the PR is okay to be merged.\n- [ ] Ensure the corresponding issue has a ZenHub release assigned.\n- [ ] Add a changelog message to the issue.\n","created_at":"2024-03-27T11:14:00Z","updated_at":"2024-03-27T19:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f92d5db8fffada4a06c9ab8f1fcb79f37820d07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/commits","review_comments_url":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/comments","review_comment_url":"https://api.github.com/repos/google/site-kit-wp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8433/comments","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/047f818f297b1ed4ae6f64a7527d44abbfecfa65","head":{"label":"google:existing-tag-follow-up-8405","ref":"existing-tag-follow-up-8405","sha":"047f818f297b1ed4ae6f64a7527d44abbfecfa65","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":191387173,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEzODcxNzM=","name":"site-kit-wp","full_name":"google/site-kit-wp","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/site-kit-wp","description":"Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.","fork":false,"url":"https://api.github.com/repos/google/site-kit-wp","forks_url":"https://api.github.com/repos/google/site-kit-wp/forks","keys_url":"https://api.github.com/repos/google/site-kit-wp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/site-kit-wp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/site-kit-wp/teams","hooks_url":"https://api.github.com/repos/google/site-kit-wp/hooks","issue_events_url":"https://api.github.com/repos/google/site-kit-wp/issues/events{/number}","events_url":"https://api.github.com/repos/google/site-kit-wp/events","assignees_url":"https://api.github.com/repos/google/site-kit-wp/assignees{/user}","branches_url":"https://api.github.com/repos/google/site-kit-wp/branches{/branch}","tags_url":"https://api.github.com/repos/google/site-kit-wp/tags","blobs_url":"https://api.github.com/repos/google/site-kit-wp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/site-kit-wp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/site-kit-wp/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/site-kit-wp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/{sha}","languages_url":"https://api.github.com/repos/google/site-kit-wp/languages","stargazers_url":"https://api.github.com/repos/google/site-kit-wp/stargazers","contributors_url":"https://api.github.com/repos/google/site-kit-wp/contributors","subscribers_url":"https://api.github.com/repos/google/site-kit-wp/subscribers","subscription_url":"https://api.github.com/repos/google/site-kit-wp/subscription","commits_url":"https://api.github.com/repos/google/site-kit-wp/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/site-kit-wp/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/site-kit-wp/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/site-kit-wp/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/site-kit-wp/contents/{+path}","compare_url":"https://api.github.com/repos/google/site-kit-wp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/site-kit-wp/merges","archive_url":"https://api.github.com/repos/google/site-kit-wp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/site-kit-wp/downloads","issues_url":"https://api.github.com/repos/google/site-kit-wp/issues{/number}","pulls_url":"https://api.github.com/repos/google/site-kit-wp/pulls{/number}","milestones_url":"https://api.github.com/repos/google/site-kit-wp/milestones{/number}","notifications_url":"https://api.github.com/repos/google/site-kit-wp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/site-kit-wp/labels{/name}","releases_url":"https://api.github.com/repos/google/site-kit-wp/releases{/id}","deployments_url":"https://api.github.com/repos/google/site-kit-wp/deployments","created_at":"2019-06-11T14:20:21Z","updated_at":"2024-03-26T02:00:47Z","pushed_at":"2024-03-27T13:48:46Z","git_url":"git://github.com/google/site-kit-wp.git","ssh_url":"git@github.com:google/site-kit-wp.git","clone_url":"https://github.com/google/site-kit-wp.git","svn_url":"https://github.com/google/site-kit-wp","homepage":"https://sitekit.withgoogle.com","size":2494477,"stargazers_count":1208,"watchers_count":1208,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":false,"forks_count":277,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":487,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["site-kit","wordpress"],"visibility":"public","forks":277,"open_issues":487,"watchers":1208,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"a3d2a7dc124edb9faf692ae008183095862fd566","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":191387173,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEzODcxNzM=","name":"site-kit-wp","full_name":"google/site-kit-wp","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/site-kit-wp","description":"Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.","fork":false,"url":"https://api.github.com/repos/google/site-kit-wp","forks_url":"https://api.github.com/repos/google/site-kit-wp/forks","keys_url":"https://api.github.com/repos/google/site-kit-wp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/site-kit-wp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/site-kit-wp/teams","hooks_url":"https://api.github.com/repos/google/site-kit-wp/hooks","issue_events_url":"https://api.github.com/repos/google/site-kit-wp/issues/events{/number}","events_url":"https://api.github.com/repos/google/site-kit-wp/events","assignees_url":"https://api.github.com/repos/google/site-kit-wp/assignees{/user}","branches_url":"https://api.github.com/repos/google/site-kit-wp/branches{/branch}","tags_url":"https://api.github.com/repos/google/site-kit-wp/tags","blobs_url":"https://api.github.com/repos/google/site-kit-wp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/site-kit-wp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/site-kit-wp/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/site-kit-wp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/site-kit-wp/statuses/{sha}","languages_url":"https://api.github.com/repos/google/site-kit-wp/languages","stargazers_url":"https://api.github.com/repos/google/site-kit-wp/stargazers","contributors_url":"https://api.github.com/repos/google/site-kit-wp/contributors","subscribers_url":"https://api.github.com/repos/google/site-kit-wp/subscribers","subscription_url":"https://api.github.com/repos/google/site-kit-wp/subscription","commits_url":"https://api.github.com/repos/google/site-kit-wp/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/site-kit-wp/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/site-kit-wp/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/site-kit-wp/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/site-kit-wp/contents/{+path}","compare_url":"https://api.github.com/repos/google/site-kit-wp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/site-kit-wp/merges","archive_url":"https://api.github.com/repos/google/site-kit-wp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/site-kit-wp/downloads","issues_url":"https://api.github.com/repos/google/site-kit-wp/issues{/number}","pulls_url":"https://api.github.com/repos/google/site-kit-wp/pulls{/number}","milestones_url":"https://api.github.com/repos/google/site-kit-wp/milestones{/number}","notifications_url":"https://api.github.com/repos/google/site-kit-wp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/site-kit-wp/labels{/name}","releases_url":"https://api.github.com/repos/google/site-kit-wp/releases{/id}","deployments_url":"https://api.github.com/repos/google/site-kit-wp/deployments","created_at":"2019-06-11T14:20:21Z","updated_at":"2024-03-26T02:00:47Z","pushed_at":"2024-03-27T13:48:46Z","git_url":"git://github.com/google/site-kit-wp.git","ssh_url":"git@github.com:google/site-kit-wp.git","clone_url":"https://github.com/google/site-kit-wp.git","svn_url":"https://github.com/google/site-kit-wp","homepage":"https://sitekit.withgoogle.com","size":2494477,"stargazers_count":1208,"watchers_count":1208,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"has_discussions":false,"forks_count":277,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":487,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["site-kit","wordpress"],"visibility":"public","forks":277,"open_issues":487,"watchers":1208,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433"},"html":{"href":"https://github.com/google/site-kit-wp/pull/8433"},"issue":{"href":"https://api.github.com/repos/google/site-kit-wp/issues/8433"},"comments":{"href":"https://api.github.com/repos/google/site-kit-wp/issues/8433/comments"},"review_comments":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/comments"},"review_comment":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/site-kit-wp/pulls/8433/commits"},"statuses":{"href":"https://api.github.com/repos/google/site-kit-wp/statuses/047f818f297b1ed4ae6f64a7527d44abbfecfa65"}},"author_association":"COLLABORATOR","auto_merge":null,"active_lock_reason":null}},"public":true,"created_at":"2024-03-27T19:14:28Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36942288753","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8356","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8356/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8356/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8356/events","html_url":"https://github.com/google/site-kit-wp/issues/8356","id":2170889215,"node_id":"I_kwDOC2hWJc6BZSP_","number":8356,"title":"Add a Site Health section for consent mode","user":{"login":"adamdunnage","id":91896826,"node_id":"U_kgDOBXo7-g","avatar_url":"https://avatars.githubusercontent.com/u/91896826?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdunnage","html_url":"https://github.com/adamdunnage","followers_url":"https://api.github.com/users/adamdunnage/followers","following_url":"https://api.github.com/users/adamdunnage/following{/other_user}","gists_url":"https://api.github.com/users/adamdunnage/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdunnage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdunnage/subscriptions","organizations_url":"https://api.github.com/users/adamdunnage/orgs","repos_url":"https://api.github.com/users/adamdunnage/repos","events_url":"https://api.github.com/users/adamdunnage/events{/privacy}","received_events_url":"https://api.github.com/users/adamdunnage/received_events","type":"User","site_admin":false},"labels":[{"id":1401246658,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjU4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Support","name":"Type: Support","color":"008672","default":false,"description":"Support request"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-06T08:10:23Z","updated_at":"2024-03-27T18:33:24Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"Add a section to the Site Kit Site Health to show if a user has enabled consent mode on their site. If possible, we could also display if Site Kit has detected the WP Consent API. \r\n\r\nSections to add:\r\n1. **Consent mode:** enabled/disabled\r\n2. **WP Consent API:** Detected/Not detected\r\n\r\n## Acceptance criteria\r\n\r\n* Site Kit Site Health should show a new field labelled \"Consent Mode\", with the text \"Enabled\" or \"Disabled\" based on whether or not the site has Consent Mode enabled.\r\n* Site Kit Site Health should show a new field labelled \"WP Consent API\", with the text \"Detected\" or \"Not detected\" based on whether or not the WP Consent API functionality is available on this site.\r\n\r\n## Implementation Brief\r\n\r\n- [ ] In `includes/Core/Site_Health/Debug_Data.php`:\r\n\t- [ ] Add a new `get_consent_mode_fields` method. In this method:\r\n\t\t- [ ] It should return an associative multidimensional array with the named keys: `consent_mode` array `consent_api`. Each key should have another associative array assigned as its value which should have the named keys: `label`, `value`, and `debug`. The structure should follow as described below:\r\n\t\t\t- [ ] `consent_mode` =>\r\n\t\t\t\t- [ ] `label` => `Consent Mode` (translatable).\r\n\t\t\t\t- [ ] `value` => This should either be `Enabled` or `Disabled` (translatable) based on whether Site Kit has Consent Mode enabled.\r\n\t\t\t\t- [ ] `debug` => This should either be `enabled` or `disabled` based on whether Site Kit has Consent Mode enabled.\r\n\t\t\t- [ ] `consent_api` =>\r\n\t\t\t\t- [ ] `label` => `WP Consent API` (translatable).\r\n\t\t\t\t- [ ] `value` => This should either be `Detected` or `Not detected` (translatable) based on whether WP Consent API functionality is available on the site.\r\n\t\t\t\t- [ ] `debug` => This should either be `detected` or `not-detected` based on whether WP Consent API functionality is available on the site.\r\n\t\t- [ ] In order to determine if Site Kit has Consent Mode enabled, instantiate a new instance of the `Core\\Consent_Mode\\Consent_Mode_Settings` class passing `$this->options` to its constructor, and call its `is_consent_mode_enabled` method.\r\n\t\t- [ ] In order to determine if WP Consent API functionality is available on the site, check if the `wp_set_consent` function exists (using `function_exists`).\r\n\t- [ ] Update the `get_fields` method:\r\n\t\t- [ ] Right after the definition of the `$fields` array, update it by merging the array returned by the `get_consent_mode_fields` method to it.\r\n\r\n### Test Coverage\r\n\r\n- [ ] In `tests/phpunit/integration/Core/Site_Health/Debug_DataTest.php`:\r\n\t- [ ] Add a new test case verifying that the debug fields include the new Consent Mode keys with appropriate values.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8356/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8356/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2023621187","html_url":"https://github.com/google/site-kit-wp/issues/8356#issuecomment-2023621187","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8356","id":2023621187,"node_id":"IC_kwDOC2hWJc54ngJD","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-27T18:33:23Z","updated_at":"2024-03-27T18:33:23Z","author_association":"COLLABORATOR","body":"> * In order to determine if Site Kit has Consent Mode enabled, instantiate a new instance of the `Core\\Consent_Mode\\Consent_Mode_Settings` class passing `$this->options` to its constructor, and call its `is_consent_mode_enabled` method.\r\n\r\n@nfmohit this is not really how it should be done. Instead of creating a new instance, we need to either add a new filter that will allow us to add new fields in the consent class or add a filter that will indicate wether needed settings are enabled.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2023621187/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-27T18:33:24Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36940075012","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8432","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8432/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8432/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8432/events","html_url":"https://github.com/google/site-kit-wp/issues/8432","id":2210512447,"node_id":"I_kwDOC2hWJc6Dwb4_","number":8432,"title":"Extend Consent Mode conditions for determining Ads connection status via Analytics tag config","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-27T11:09:23Z","updated_at":"2024-03-27T17:28:29Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nWe should extend the Consent Mode conditions for determining whether Ads is connected to include a check for the presence of an Ads tag as the destination of the connected Analytics property's Google tag.\r\n\r\nAs described under [\"when does this apply?\"](https://docs.google.com/document/d/1KSTPqXNlGcN-krK5pxzdP2a-sHaVO9RYzIEU7qIF9qA/edit?tab=t.0#heading=h.t6jfalui4jsi) in the one-pager:\r\n\r\n> For Site Kit, this affects measurement that is connected to Ads in some way. The most explicit example is the placement of an Ads conversion ID tag on the page (e.g. `AW-12345678`). However, this also applies to Analytics in the event where it is connected to Ads in some way, such as an [Ads link](https://support.google.com/analytics/answer/9379420) (service side link between a GA4 property and Ads account), or using an Ads tag as a destination of a Google Tag (GT-, G-)\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The list of destination IDs for the connected Analytics property's Google tag should be looked up and stored when the property is connected.\r\n* The list of destination IDs should be updated on a regular basis alongside the current Google tag settings sync (i.e. this should be included in the [`*syncGoogleTagSettings()`](https://github.com/google/site-kit-wp/blob/1ee2a8a87e7cf9bedb82ffa25563f3b7272c6345/assets/js/modules/analytics-4/datastore/properties.js#L589-L594) action).\r\n* Within the Consent Mode feature, the conditions for determining whether Ads is connected should include a check for the presence of an Ads tag (starting with `AW-`) in the list of destination IDs. Specifically this means the conditions for showing the following should be updated:\r\n * The Setup CTA Banner.\r\n * The \"Recommended\" badge and the notice reading \"If you have Google Ads campaigns for this site, it's highly recommended to enable Consent mode...\" on the Consent Mode section of the Settings screen.\r\n\r\n## Implementation Brief\r\n\r\n* [ ] \r\n\r\n### Test Coverage\r\n\r\n* \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8432/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8432/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2023373065","html_url":"https://github.com/google/site-kit-wp/issues/8432#issuecomment-2023373065","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8432","id":2023373065,"node_id":"IC_kwDOC2hWJc54mjkJ","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-27T17:28:28Z","updated_at":"2024-03-27T17:28:28Z","author_association":"COLLABORATOR","body":"AC ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2023373065/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-27T17:28:29Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36894170390","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8161","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8161/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8161/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8161/events","html_url":"https://github.com/google/site-kit-wp/issues/8161","id":2100220895,"node_id":"I_kwDOC2hWJc59LtPf","number":8161,"title":"Implement the unhappy path for Selection Panel audience count retrieval (error notice above footer)","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-01-25T11:50:17Z","updated_at":"2024-03-26T14:05:47Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nImplement the error states that can occur while retrieving the audience user counts for the Selection Panel.\r\n\r\nSee [selection panel > error states](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.odyvy9h583qb) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* If an API call for retrieving the Selection Panel audience user counts returns an error:\r\n * The user counts should be displayed as dashes.\r\n * An error notice should be displayed above the footer. This should be implemented as per the [Figma design](https://www.figma.com/file/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?type=design&node-id=1719-17437&mode=design&t=fs1zWH0V3fC3ft7u-0).\r\n * If the error is a permissions error, the \"insufficient permissions\" variant of the error notice will be shown, including a _Get help_ link and a **Request access** buttons.\r\n * Its _Get help_ link will open the [Analytics insufficient permissions support document](https://sitekit.withgoogle.com/documentation/troubleshooting/analytics/#insufficient-permissions).\r\n * The **Request access** button will open the URL for the connected web data stream in the Analytics UI, allowing the user to request access.\r\n * Otherwise, the catch-all variant will be shown which just includes the **Retry** button.\r\n * Clicking the **Retry** button will re-request the report.\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Once #8158 and #8157 are merged.\r\n* [ ] Create an `ErrorNotice` component within the selection panel directory with the following:\r\n * [ ] It should receive a list of errors as a prop.\r\n * [ ] Check for \"insufficient permissions\" errors using the `isInsufficientPermissionsError` helper function and render the `Insufficient permissions, contact your administrator. Trouble getting access?` copy with the `Get help` link and the `Request access` button.\r\n * [ ] Otherwise, render the `Data loading failed` copy with the `Retry` button.\r\n * [ ] Mirror most of the logic from the `ReportErrorActions` component to determine the error variant and render the appropriate buttons.\r\n * [ ] Adjust the styles that match the [Figma design](https://www.figma.com/file/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?type=design&node-id=1719-17437&mode=design&t=fs1zWH0V3fC3ft7u-0).\r\n* [ ] A `Footer` component is being implemented in #8157. Modify the `Footer` component with the following changes:\r\n * [ ] Check for `getReport` errors using the `getErrorForSelector` selector to determine if there are errors in the user counts.\r\n * [ ] Use the `totalUsers` metric and the `audienceResourceName` dimension as report args to query the `getReport` selector errors.\r\n * [ ] If there are errors, render the `ErrorNotice` component and pass the `errors` as a prop.\r\n * [ ] If there are errors, display the user counts as dashes in the appropriate child component, which is being implemented in #8157.\r\n\r\n### Test Coverage\r\n\r\n* [ ] Add storybook stories for the `ErrorNotice` component.\r\n* [ ] Add storybook stories for the selection panel component with the error state.\r\n* [ ] Add basic test coverage for the `ErrorNotice` component.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8161/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8161/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020522656","html_url":"https://github.com/google/site-kit-wp/issues/8161#issuecomment-2020522656","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8161","id":2020522656,"node_id":"IC_kwDOC2hWJc54brqg","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-26T14:05:47Z","updated_at":"2024-03-26T14:05:47Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020522656/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-26T14:05:48Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36892203815","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8159","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8159/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8159/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8159/events","html_url":"https://github.com/google/site-kit-wp/issues/8159","id":2100214298,"node_id":"I_kwDOC2hWJc59Lroa","number":8159,"title":"Implement the Selection Panel Info Notice","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-01-25T11:46:35Z","updated_at":"2024-03-26T13:15:20Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nImplement the info notice will be displayed when the Selection Panel is opened with only one item selected.\r\n\r\nSee [audiences creation > info notice](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.vm6vp7cnnu2r) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* If there is only one audience currently selected, when the Selection Panel is opened it will display a dismissible info notice encouraging the user to add another audience to the selection.\r\n* This should be implemented as per the [Figma design](https://www.figma.com/file/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?type=design&node-id=1046-44966&mode=design&t=9sm6bwApE8GcSrQa-0).\r\n* It will have a **Got it** button for dismissing the notice. Clicking the button will permanently dismiss the notice and it will not be shown again to the current user.\r\n\r\n## Implementation Brief\r\n\r\n_Note: It could be worth taking a look at the Info Notice component to see if can be refactored for reuse. See https://github.com/google/site-kit-wp/issues/8137._\r\n\r\n* [ ] Once #8158 and #8157 are merged.\r\n\r\nIn `assets/js/modules/analytics-4/components/dashboard/AudienceSegmentation/InfoNotice.js`:\r\n\r\n* [ ] Add a new `id` prop to the `InfoNotice` component.\r\n* [ ] Add a new `infoIcon` prop to the `InfoNotice` component.\r\n* [ ] Add the `id` to the `div` element.\r\n* [ ] Render the `infoIcon` prop if it is provided. Otherwise, render the `LightbulbIcon` component.\r\n\r\nIn the selection panel component, which is being implemented in #8157:\r\n\r\n* [ ] Get the selected/configured audiences using the `getConfiguredAudiences` selector.\r\n* [ ] Get the `InfoNotice` dismissible state using the `isItemDismissed` selector using an appropriate `id` value.\r\n* [ ] If only one audience AND the `InfoNotice` is not dismissed, render the `AudienceSegmentation/InfoNotice` component.\r\n* [ ] Pass an appropriate `id` value to the `InfoNotice` component.\r\n* [ ] Extract the info icon from the [Figma design](https://www.figma.com/file/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?type=design&node-id=1046-44966&mode=design&t=9sm6bwApE8GcSrQa-0) and pass it as the `infoIcon` prop to the `InfoNotice` component.\r\n* [ ] Pass `Got it` as the `dismissLabel` prop.\r\n* [ ] Pass a callback function to the `onDismiss` prop that dismisses the `InfoNotice` using the `dismissItem` action.\r\n* [ ] Pass the below text to the `content` prop:\r\n ```\r\n By adding another group to your dashboard, you will be able to compare them and understand which content brings back users from each group\r\n ```\r\n* [ ] Preferably, create a new component for the selection panel info notice and use it in the selection panel component to keep the code clean and maintainable.\r\n\r\n\r\n### Test Coverage\r\n\r\n* [ ] In case of a new component, create a new storybook file for it.\r\n* [ ] Add a story to the selection panel storybook to show the info notice when only one audience is selected.\r\n* [ ] Add a new story to the `AudienceSegmentation/InfoNotice` storybook to include the new `infoIcon` prop.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8159/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8159/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020403380","html_url":"https://github.com/google/site-kit-wp/issues/8159#issuecomment-2020403380","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8159","id":2020403380,"node_id":"IC_kwDOC2hWJc54bOi0","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-26T13:15:18Z","updated_at":"2024-03-26T13:15:18Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020403380/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-26T13:15:20Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36892047588","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8417","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8417/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8417/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8417/events","html_url":"https://github.com/google/site-kit-wp/issues/8417","id":2200672486,"node_id":"I_kwDOC2hWJc6DK5jm","number":8417,"title":"Search queries in the \"Top search queries\" widget are overflowing on the shared dashboard at narrow viewports","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":2338634876,"node_id":"MDU6TGFiZWwyMzM4NjM0ODc2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Search%20Console","name":"Module: Search Console","color":"31cebc","default":false,"description":"Search Console module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-21T16:45:03Z","updated_at":"2024-03-26T13:11:15Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nWhen viewing the \"Top search queries\" widget on the shared dashboard at narrow viewports, long search queries can currently overflow the clicks and impressions metrics.\r\n\r\n## Steps to reproduce\r\n\r\n\r\n1. Login to Site Kit as an admin and share Search Console.\r\n2. Login as a second user with shared access to Search Console and scroll down to the \"Top search queries\" widget.\r\n3. Ensure the viewport is set to a relatively narrow width.\r\n4. See that long search queries overflow the clicks and impressions metrics.\r\n5. Note that this is of course dependent on having some long search queries appear in the list for the connected Analytics property. I discovered this using the `oi.ie` property. Alternatively, it can be verified using Storybook by making the search results a bit longer for the [view-only story](https://google.github.io/site-kit-wp/storybook/develop/?path=/story/search-console-module-components-view-only-dashboard-popular-keywords-widget--loaded).\r\n\r\n## Screenshots\r\n\r\n_Search queries overflow in the \"Top search queries\" widget:_\r\n![image](https://github.com/google/site-kit-wp/assets/18395600/e4684a78-4ad0-48bb-be32-1d11a6d720ac)\r\n\r\n_They should show ellipses similarly to the \"Top performing keywords\" Key Metrics widget:_\r\n![image](https://github.com/google/site-kit-wp/assets/18395600/282f41e8-4051-4f3d-840e-d11e79998acb)\r\n\r\n## Additional Context\r\n\r\n\r\n - PHP Version: any\r\n - OS: any\r\n - Browser: any with a narrow enough viewport\r\n - Plugin Version: noticed on 1.122.0\r\n - Device: any\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* When viewing the \"Top search queries\" widget on the shared dashboard at narrow viewports, long search queries should not overflow the clicks and impressions metrics, and should instead be truncated with ellipses (similarly to the \"Top performing keywords\" Key Metrics widget).\r\n\r\n## Implementation Brief\r\n\r\n* [ ] In `assets/sass/components/global/_googlesitekit-table.scss`:\r\n * [ ] Add styling for `.googlesitekit-table .googlesitekit-table__body-item-content span` for a max viewport width of `$bp-tablet` to the following:\r\n \r\n ```\r\n display: block;\r\n overflow: hidden;\r\n text-overflow: ellipsis;\r\n ```\r\n * [ ] This is similar to what is set for `.googlesitekit-table .googlesitekit-table__body-item-content .googlesitekit-cta-link`.\r\n\r\n\r\n### Test Coverage\r\n\r\n* No tests need to be added/updated.\r\n* Update any failing VRT references if required.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8417/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8417/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020394569","html_url":"https://github.com/google/site-kit-wp/issues/8417#issuecomment-2020394569","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8417","id":2020394569,"node_id":"IC_kwDOC2hWJc54bMZJ","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-26T13:11:15Z","updated_at":"2024-03-26T13:11:15Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020394569/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-26T13:11:15Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36891978830","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8408","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8408/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8408/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8408/events","html_url":"https://github.com/google/site-kit-wp/issues/8408","id":2191914745,"node_id":"I_kwDOC2hWJc6Cpfb5","number":8408,"title":"Consent Mode related console error on View only Dashboard ","user":{"login":"wpdarren","id":73545194,"node_id":"MDQ6VXNlcjczNTQ1MTk0","avatar_url":"https://avatars.githubusercontent.com/u/73545194?v=4","gravatar_id":"","url":"https://api.github.com/users/wpdarren","html_url":"https://github.com/wpdarren","followers_url":"https://api.github.com/users/wpdarren/followers","following_url":"https://api.github.com/users/wpdarren/following{/other_user}","gists_url":"https://api.github.com/users/wpdarren/gists{/gist_id}","starred_url":"https://api.github.com/users/wpdarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpdarren/subscriptions","organizations_url":"https://api.github.com/users/wpdarren/orgs","repos_url":"https://api.github.com/users/wpdarren/repos","events_url":"https://api.github.com/users/wpdarren/events{/privacy}","received_events_url":"https://api.github.com/users/wpdarren/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-18T11:13:59Z","updated_at":"2024-03-26T13:09:34Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nWhile testing Dashboard Sharing, I encountered a console error message on the view only, main and entity dashboard. `Google Site Kit API Error method:GET datapoint:consent-mode type:core identifier:site error:\"Sorry, you are not allowed to do that.\"` Chatting to @techanvil on Slack and he confirmed that we should avoid making the call on the view-only dashboard for the new Consent Mode CTA banner notification. \r\n\r\n## Screenshots\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Consent mode API (`GET:consent-mode`) should not be called in shared dashboard, thus preventing any permission related console errors. \r\n\r\n## Implementation Brief\r\n\r\n* [ ] Do not render ` }`\r\n\r\n### Test Coverage\r\n\r\n* No changes needed. \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8408/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8408/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020390975","html_url":"https://github.com/google/site-kit-wp/issues/8408#issuecomment-2020390975","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8408","id":2020390975,"node_id":"IC_kwDOC2hWJc54bLg_","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-26T13:09:34Z","updated_at":"2024-03-26T13:09:34Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020390975/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-26T13:09:35Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36891884249","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/events","html_url":"https://github.com/google/site-kit-wp/issues/8141","id":2098754767,"node_id":"I_kwDOC2hWJc59GHTP","number":8141,"title":"Add “partial data” states infrastructure","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"},{"id":3327716157,"node_id":"MDU6TGFiZWwzMzI3NzE2MTU3","url":"https://api.github.com/repos/google/site-kit-wp/labels/PHP","name":"PHP","color":"8892BF","default":false,"description":""},{"id":5204615861,"node_id":"LA_kwDOC2hWJc8AAAABNjgitQ","url":"https://api.github.com/repos/google/site-kit-wp/labels/Sp%20Wk%202","name":"Sp Wk 2","color":"1d76db","default":false,"description":"Issues to be completed in the second week of the assigned sprint"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2024-01-24T17:29:50Z","updated_at":"2024-03-26T13:07:02Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAdd the full infrastructure for determining and exposing the \"partial data\" states for audiences, custom dimensions and properties.\r\n\r\nSee [partial data states](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.5p6ukexs73j4) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Analytics module should have new selectors for detecting whether an audience, custom dimension or analytics property (referred as resource in the following points) is in \"partial data\" state. \r\n * A resource is considered to be in \"partial data\" state until it has been active for the full duration of the currently selected date range. \r\n * A resource is also considered to be in \"partial data\" state if the GA4 itself is in gathering data. \r\n* Partial data state should be determined by retrieving a report of the given resource and checking the date of the earliest event and making a comparison with the start date of the current date range.\r\n* Similarly how it's done for the gathering data states, the date of the earliest event, once determined, should be persisted on the server and made available in client on page load. \r\n * The persisted date for a given resource. whenever available. should be used instead of making a report request to determine the partial states in the resolvers of partial data selectors.\r\n * Persisted dates for all resources should be reset whenever Analytics property or measurement ID changes, Analytics module is deactivated or Site Kit is reset. \r\n\r\n## Implementation Brief\r\n\r\n **Note: the following IB is heavily based on and inspired by Data_Available state for modules and custom dimensions. Any gap in the IB may be filled in by reassessing the implementation and comparing with the aforementioned infrastructure.** \r\n\r\n### PHP\r\n\r\n* [ ] Create class `Google\\Site_Kit\\Modules\\Analytics_4\\Resource_Data_Availability_Date`.\r\n * [ ] Take `Transients $transients` in the constructor and initialize as a field. \r\n * [ ] Use Const `CUSTOM_DIMENSION_SLUGS` and `AUDIENCE_SLUGS` to store valid custom dimensions and slugs. \r\n * [ ] Have `RESOURCE_TYPE_**` consts for audience, custom dimension and property resources. \r\n * [ ] Method `get_resource_data_availability_date_transient_name` takes resource name and resource type parameters and returns the computed transient name. ie. `return \"googlesitekit_custom_dimension_{$resource_type}_{$resource_name}_data_availability_date\";`\r\n * [ ] Method `get_resource_data_availability_dates` should return an associative array of the data availability date of resources. This can be multi dimensional array or the resources can be prefixed with the resource type. \r\n * [ ] Other methods `get_resource_data_availability_date`, `set_resource_data_availability_date`, `reset_resource_data_availability_date` etc should be implemented similarly to how it is done on `Google\\Site_Kit\\Modules\\Analytics_4\\Custom_Dimensions_Data_Available` class. \r\n* [ ] In `Google\\Site_Kit\\Modules\\Analytics_4` class:\r\n * [ ] Add `$resource_data_available_date` field and instantiate it with `Resource_Data_Availability_Date` in the constructor. \r\n * [ ] Create A New REST Endpoint `POST:save-resource-data-availability-date` in `Analytics_4` module. \r\n * [ ] It should check if the passed resource(s) in the $data (`audience`, `customDimension` or `property`) are valid, and then persist the date values as a timestamp in the DB using the `$this->resource_data_available_date->set_resource_data_availability_date` method. \r\n * [ ] Expose the persisted dates of resource data availability to client using `googlesitekit_inline_modules_data` filter in the `register` method. \r\n * [ ] Call `$resource_data_available_date->reset_resource_data_availability_date()` in `on_deactivation` method to reset all persisted dates on module deactivation. \r\n * [ ] Call `$resource_data_available_date->reset_resource_data_availability_date()` in the `$this->get_settings()->on_change()` when property ID or measurement ID is different, similarly to how it's done with `$this->custom_dimensions_data_available->reset_data_available()` to reset the persisted dates when analytics property/measurement ID changes. \r\n\r\n### JS\r\n\r\n* [ ] Create `assets/js/modules/analytics-4/datastore/partial-data.js` file.\r\n * [ ] Create a fetch store for the aforementioned POST API. \r\n * [ ] Actions:\r\n * [ ] `saveResourceDataAvailabilityDate` takes an array of the object `{resource name, resource type and date}` and save it to the server using the fetch store. \r\n * [ ] Selectors: \r\n * [ ] `getResourceDataAvailabilityDate(resourceName, resourceTyoe)`: returns the date associated with the given resource if available, otherwise resolves to the first date in the last 90 days that the report data became available using the associated resolver (described below). The 90 days is chosen because that's the longest date range available in Site Kit. \r\n * [ ] `is{audience|customDimension|Property}PartialData(resourceName)`: \r\n * [ ] Return `true` when GA4 is in gathering Data state. \r\n * [ ] Return `false` when the `dataAvailabilityDate` for the is same or earlier than the `startDate` of currently selected date range. \r\n * [ ] Otherwise, return `true`. This also handles the case where `dataAvailabilityDate` for a given resource can not be determined due to errors or being in the shared dashboard. \r\n * [ ] Resolvers\r\n * [ ] `getResourceDataAvailabilityDate`: \r\n * [ ] Get `reportArgs` for the given resource. \r\n * [ ] For a property, this `ReportArgs` is similar to one returned by `getSampleReportArgs` from `assets/js/modules/analytics-4/utils/report-args.js`, while the change here being:\r\n * [ ] Start date: creation date of the current GA property. \r\n * [ ] End date: the reference date.\r\n * [ ] For audience, the `reportArgs` will include `audienceResourceName` as an additional `dimension`. \r\n * [ ] This will allow for a single report for all audience resources, and filtering the resulted report for a specific resource in JS to get the earliest date for a given audience resource. \r\n * [ ] For Custom Dimension, report args should be the following:\r\n * [ ] Start date: creation date of the current GA property. \r\n * [ ] End date: the reference date. \r\n * [ ] The dimension: `date` for property resource, and `customEvent:${ resourceName }` \r\n * [ ] Metric: `eventCount`. \r\n * [ ] See `getDataAvailabilityReportOptions` selector in `assets/js/modules/analytics-4/datastore/custom-dimensions-gathering-data.js` and `getSampleReportArgs` in `assets/js/modules/analytics-4/datastore/report.js` for more complete example. The implementation can largely be followed. \r\n * [ ] Make a simple report request to the given resource using the above report args. \r\n * [ ] Find the date of the first available report. \r\n * [ ] If there is any error or user doesn't have permission (ie. the property creation date can not be accessed in shared dashboard), return `null` and do not persist anything. \r\n * [ ]Otherwise, persist the date for the given resource using `saveResourceDataAvailabilityDate` and return the date. \r\n* [ ] Add the newly added store partial to `assets/js/modules/analytics-4/datastore/index.js`. \r\n\r\n### Test Coverage\r\n\r\n* Add PHP Unit test for the newly added infrastructure. \r\n* Add Jest test for the newly added selectors and actions. \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020384997","html_url":"https://github.com/google/site-kit-wp/issues/8141#issuecomment-2020384997","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","id":2020384997,"node_id":"IC_kwDOC2hWJc54bKDl","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-26T13:07:01Z","updated_at":"2024-03-26T13:07:01Z","author_association":"COLLABORATOR","body":"Thanks, @kuasha420. Mostly looks good to me. Added a few pretty minor comments for you:\r\n\r\n> * Method `get_resource_data_availability_date_transient_name` takes resource name ...\r\n> * Method `get_resource_data_availability_dates` should return ...\r\n> * Other methods `get_resource_data_availability_date`, `set_resource_data_availability_date`, `reset_resource_data_availability_date` etc ...\r\n\r\nThere is no need to duplicate `data_availability_date` in methods names if only having it makes a big difference for the method. In other words, if we call the method as `get_resource_transient_name` it will remain the same meaning and will be more concise.\r\n* `get_resource_data_availability_dates` -> `get_resource_dates`\r\n* `get_resource_data_availability_date` -> `get_resource_date`\r\n* `set_resource_data_availability_date` -> `set_resource_date`\r\n* `reset_resource_data_availability_date` -> `reset_resource_date`\r\n\r\n> ... and resource type parameters and returns the computed transient name. ie. `return \"googlesitekit_custom_dimension_{$resource_type}_{$resource_name}_data_availability_date\";`\r\n\r\nI believe the `_constom_dimension_` part is not needed and the template should be as `googlesitekit_{$resource_type}_{$resource_name}_data_availability_date`, right?\r\n\r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2020384997/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-26T13:07:03Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36803333923","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8268","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8268/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8268/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8268/events","html_url":"https://github.com/google/site-kit-wp/issues/8268","id":2143098467,"node_id":"I_kwDOC2hWJc5_vRZj","number":8268,"title":"`connection-check` endpoint logging errors unnecessarily","user":{"login":"aaemnnosttv","id":1621608,"node_id":"MDQ6VXNlcjE2MjE2MDg=","avatar_url":"https://avatars.githubusercontent.com/u/1621608?v=4","gravatar_id":"","url":"https://api.github.com/users/aaemnnosttv","html_url":"https://github.com/aaemnnosttv","followers_url":"https://api.github.com/users/aaemnnosttv/followers","following_url":"https://api.github.com/users/aaemnnosttv/following{/other_user}","gists_url":"https://api.github.com/users/aaemnnosttv/gists{/gist_id}","starred_url":"https://api.github.com/users/aaemnnosttv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaemnnosttv/subscriptions","organizations_url":"https://api.github.com/users/aaemnnosttv/orgs","repos_url":"https://api.github.com/users/aaemnnosttv/repos","events_url":"https://api.github.com/users/aaemnnosttv/events{/privacy}","received_events_url":"https://api.github.com/users/aaemnnosttv/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-02-19T20:28:18Z","updated_at":"2024-03-22T16:08:06Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nOur API client logs request failures automatically. Recently we added a new request for testing if the client is connected to the internet. This is expected to \"fail\" from time to time and isn't useful to be reported. \r\n\r\nThis is currently reporting a significant number of events and should be updated to avoid tracking for this endpoint specifically.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Requests to `core/site/data/connection-check` should not track API errors\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Update `assets/js/util/api.js` adding a new array called `excludedDataPoints` to the top of the file, with the only value being the string `connection-check`.\r\n * [ ] Add a new condition ` || excludedDataPoints.includes( datapoint )` the first conditional in `trackAPIError`:\r\nhttps://github.com/google/site-kit-wp/blob/5d3ec528ceb637fbd296861f4ce93e2a6d1d2a46/assets/js/util/api.js#L50-L52\r\n\r\n### Test Coverage\r\n\r\n* [ ] Add a new test `doesn't track excluded datapoints` to test the new functionality.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8268/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8268/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2015423434","html_url":"https://github.com/google/site-kit-wp/issues/8268#issuecomment-2015423434","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8268","id":2015423434,"node_id":"IC_kwDOC2hWJc54IOvK","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-22T16:08:05Z","updated_at":"2024-03-22T16:08:05Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2015423434/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-22T16:08:06Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36803125452","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8409","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8409/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8409/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8409/events","html_url":"https://github.com/google/site-kit-wp/issues/8409","id":2192595291,"node_id":"I_kwDOC2hWJc6CsFlb","number":8409,"title":"Enhanced Measurement Created Despite Disabled","user":{"login":"wpdarren","id":73545194,"node_id":"MDQ6VXNlcjczNTQ1MTk0","avatar_url":"https://avatars.githubusercontent.com/u/73545194?v=4","gravatar_id":"","url":"https://api.github.com/users/wpdarren","html_url":"https://github.com/wpdarren","followers_url":"https://api.github.com/users/wpdarren/followers","following_url":"https://api.github.com/users/wpdarren/following{/other_user}","gists_url":"https://api.github.com/users/wpdarren/gists{/gist_id}","starred_url":"https://api.github.com/users/wpdarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpdarren/subscriptions","organizations_url":"https://api.github.com/users/wpdarren/orgs","repos_url":"https://api.github.com/users/wpdarren/repos","events_url":"https://api.github.com/users/wpdarren/events{/privacy}","received_events_url":"https://api.github.com/users/wpdarren/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"},{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-18T15:51:27Z","updated_at":"2024-03-22T16:01:22Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nWhile completing testing on the Singular Analytics Module, I noticed that when setting up Analytics, the user creates a new property/web data stream and disables Enhanced Measurement; when the new property is created, the Enhanced Measurement toggle is changed and enabled. This is not a regression, as it occurs on the latest release. \r\n\r\nYou can see it in action on this screencast. \r\n\r\nhttps://github.com/google/site-kit-wp/assets/73545194/dfdff5f1-b82c-460b-a4e2-24602e958fe5\r\n\r\n## Acceptance criteria\r\n1. Activate Analytics Module. \r\n2. During setup, select and existing account but chose to create a New property. \r\n3. Toggle the enhanced measurement switch off. \r\n4. Continue setup. \r\n5. See that the enhance measurement for the newly created property/data stream is enabled anyways. \r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Creating a new property during Analytics setup should honor the \"Enable enhanced measurement toggle\" and only enable enhanced measurement for the newly created web data stream associated with newly created property when the toggle is \"On\". \r\n\r\n## Implementation Brief\r\n\r\n* [ ] \r\n\r\n### Test Coverage\r\n\r\n* \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8409/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8409/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2015408986","html_url":"https://github.com/google/site-kit-wp/issues/8409#issuecomment-2015408986","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8409","id":2015408986,"node_id":"IC_kwDOC2hWJc54ILNa","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-22T16:01:21Z","updated_at":"2024-03-22T16:01:21Z","author_association":"COLLABORATOR","body":"AC ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2015408986/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-22T16:01:23Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36722545974","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/6503","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/6503/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/6503/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/6503/events","html_url":"https://github.com/google/site-kit-wp/issues/6503","id":1564492328,"node_id":"I_kwDOC2hWJc5dQEIo","number":6503,"title":"Add Google Analytics page views count to WP Admin's Pages list view. ","user":{"login":"jimmymadon","id":1721319,"node_id":"MDQ6VXNlcjE3MjEzMTk=","avatar_url":"https://avatars.githubusercontent.com/u/1721319?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmymadon","html_url":"https://github.com/jimmymadon","followers_url":"https://api.github.com/users/jimmymadon/followers","following_url":"https://api.github.com/users/jimmymadon/following{/other_user}","gists_url":"https://api.github.com/users/jimmymadon/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmymadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmymadon/subscriptions","organizations_url":"https://api.github.com/users/jimmymadon/orgs","repos_url":"https://api.github.com/users/jimmymadon/repos","events_url":"https://api.github.com/users/jimmymadon/events{/privacy}","received_events_url":"https://api.github.com/users/jimmymadon/received_events","type":"User","site_admin":false},"labels":[{"id":1401246652,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjUy","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Feature","name":"Type: Feature","color":"a2eeef","default":false,"description":"New feature"},{"id":1401246658,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjU4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Support","name":"Type: Support","color":"008672","default":false,"description":"Support request"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2023-01-31T15:06:57Z","updated_at":"2024-03-20T13:33:26Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nThis issue was \"split out\" from #5418 to implement the new GA Page Views column for the Pages list view. \r\n\r\n--------------\r\n\r\nConsidering adding a total Google Analytics view count on both the pages and posts tab, as per the screenshot below, once Site Kit is set up with Analytics connected. This could be a sortable column, as some of the other columns are within the same list views. \r\n\r\n![image](https://user-images.githubusercontent.com/41326532/175268060-bf542971-4662-469c-aaee-33797c2ecd10.png)\r\n\r\nThis is a feature request on behalf of [one user in the support forums](https://wordpress.org/support/topic/a-sortable-view-menu/#post-15761795). \r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Given GA4 is connected, when an admin visits the Pages list view, then they should see a new column as follows:\r\n * Column title: __GA Page Views__ (translatable string)\r\n * Column data: Metric should be `screenPageViews` and dimension should be `pagePathPlusQueryString` for the Page's URL. (Use existing GA4 datastore infrastructure to fetch this data).\r\n * The column should appear after the \"Author\" column (if it exists), else it should appear before the \"Date\" column.\r\n * Sortable: Sort based on the number of `screenPageViews`.\r\n* The above will require Site Kit's assets to be loaded on the `Pages` wp-admin page similar to how we load them for the WP Dashboard.\r\n\r\n## Implementation Brief\r\n\r\nNote to IB reviewer: Plenty of [docs](https://developer.wordpress.org/reference/hooks/manage_post_type_posts_columns/) and [guides](https://awhitepixel.com/blog/modify-add-custom-columns-post-list-wordpress-admin/) on how to implement the above. \r\n\r\n- TBC: Waiting for an IB review of #5418 to make a final decision on the approach here.\r\n- In `includes/Modules/Analytics_4/Page_Views_Post_List_Column.php` (being added in #5418) file:\r\n - Update the `register()` method:\r\n\t - Besides adding the `manage_columns` and `manage_custom_column` as callback functions to the `manage_post_posts_columns` and `manage_post_posts_custom_column` hooks, they should also be added to the `manage_page_posts_columns` and `manage_page_posts_custom_column` hooks respectively.\r\n\r\n### Test Coverage\r\n\r\n- No tests need to be added/updated.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/6503/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/6503/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2009571186","html_url":"https://github.com/google/site-kit-wp/issues/6503#issuecomment-2009571186","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/6503","id":2009571186,"node_id":"IC_kwDOC2hWJc53x59y","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-20T13:30:20Z","updated_at":"2024-03-20T13:30:20Z","author_association":"COLLABORATOR","body":"Discussed this task in [the slack thread](https://10up.slack.com/archives/CFFRMC5DE/p1710437836075669). Moving this task to backlog for now. We will need to make a decision how this feature will be activated/deactivated and how to improve accuracy of pageviews results.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2009571186/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-20T13:33:26Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36697241733","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8207","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8207/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8207/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8207/events","html_url":"https://github.com/google/site-kit-wp/issues/8207","id":2110423008,"node_id":"I_kwDOC2hWJc59yn_g","number":8207,"title":"Release automation fails with `'{directory}' is not a working copy` errors","user":{"login":"aaemnnosttv","id":1621608,"node_id":"MDQ6VXNlcjE2MjE2MDg=","avatar_url":"https://avatars.githubusercontent.com/u/1621608?v=4","gravatar_id":"","url":"https://api.github.com/users/aaemnnosttv","html_url":"https://github.com/aaemnnosttv","followers_url":"https://api.github.com/users/aaemnnosttv/followers","following_url":"https://api.github.com/users/aaemnnosttv/following{/other_user}","gists_url":"https://api.github.com/users/aaemnnosttv/gists{/gist_id}","starred_url":"https://api.github.com/users/aaemnnosttv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaemnnosttv/subscriptions","organizations_url":"https://api.github.com/users/aaemnnosttv/orgs","repos_url":"https://api.github.com/users/aaemnnosttv/repos","events_url":"https://api.github.com/users/aaemnnosttv/events{/privacy}","received_events_url":"https://api.github.com/users/aaemnnosttv/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":2846161365,"node_id":"MDU6TGFiZWwyODQ2MTYxMzY1","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Infrastructure","name":"Type: Infrastructure","color":"CD9F94","default":false,"description":"Engineering infrastructure & tooling"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-01-31T15:54:55Z","updated_at":"2024-03-19T19:19:08Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nWhen attempting to deploy the release to wp.org, there are svn errors raised seemingly related to dependencies in the plugin\r\n\r\nExample run https://github.com/google/site-kit-wp/actions/runs/7701119995/job/20986692669#step:4:1624\r\n\r\n```\r\n➤ Copying files...\r\nℹ︎ Using .distignore\r\nℹ︎ No assets directory found; skipping asset copy\r\n➤ Preparing files...\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/cache' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/cache/src' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/http-message' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/http-message/src' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/log' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/log/Psr' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/log/Psr/Log' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/psr/log/Psr/Log/Test' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/ralouphie/getallheaders' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/ralouphie/getallheaders/src' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-idn' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-idn/Resources' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-idn/Resources/unidata' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-normalizer' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-normalizer/Resources' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-normalizer/Resources/stubs' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-intl-normalizer/Resources/unidata' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-php70' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-php70/Resources' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-php70/Resources/stubs' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/symfony/polyfill-php72' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/true/punycode' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/true/punycode/src' is not a working copy\r\nsvn: E155007: '/home/runner/svn-***-site-kit/L trunk/third-party/true/punycode/src/Exception' is not a working copy\r\nError: Process completed with exit code 123.\r\n```\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The `publish-to-wporg` job of the `zips` workflow should complete successfully\r\n\r\n## Implementation Brief\r\n\r\n* [ ] \r\n\r\n### Test Coverage\r\n\r\n* \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8207/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8207/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007948225","html_url":"https://github.com/google/site-kit-wp/issues/8207#issuecomment-2007948225","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8207","id":2007948225,"node_id":"IC_kwDOC2hWJc53rtvB","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-19T19:19:06Z","updated_at":"2024-03-19T19:19:06Z","author_association":"COLLABORATOR","body":"> Are you planning to work on this soon? If not, can you please unassign yourself so someone else can pick it up? Thank you!\r\n\r\n@aaemnnosttv promised to help troubleshooting it. I'll assign this task for him for now.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007948225/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-19T19:19:08Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36696981667","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8030","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8030/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8030/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8030/events","html_url":"https://github.com/google/site-kit-wp/issues/8030","id":2064534294,"node_id":"I_kwDOC2hWJc57DksW","number":8030,"title":"Raise minimum required version of PHP to 7.4","user":{"login":"aaemnnosttv","id":1621608,"node_id":"MDQ6VXNlcjE2MjE2MDg=","avatar_url":"https://avatars.githubusercontent.com/u/1621608?v=4","gravatar_id":"","url":"https://api.github.com/users/aaemnnosttv","html_url":"https://github.com/aaemnnosttv","followers_url":"https://api.github.com/users/aaemnnosttv/followers","following_url":"https://api.github.com/users/aaemnnosttv/following{/other_user}","gists_url":"https://api.github.com/users/aaemnnosttv/gists{/gist_id}","starred_url":"https://api.github.com/users/aaemnnosttv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaemnnosttv/subscriptions","organizations_url":"https://api.github.com/users/aaemnnosttv/orgs","repos_url":"https://api.github.com/users/aaemnnosttv/repos","events_url":"https://api.github.com/users/aaemnnosttv/events{/privacy}","received_events_url":"https://api.github.com/users/aaemnnosttv/received_events","type":"User","site_admin":false},"labels":[{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":2846161365,"node_id":"MDU6TGFiZWwyODQ2MTYxMzY1","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Infrastructure","name":"Type: Infrastructure","color":"CD9F94","default":false,"description":"Engineering infrastructure & tooling"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2024-01-03T19:23:41Z","updated_at":"2024-03-19T19:09:38Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nWhile Site Kit has long supported the minimum version of PHP required by WP, recent changes in core dependencies require that we raise our minimum version to leverage features, fixes, and language compatibility updates that are only available in more recent releases.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The minimum required version of PHP should be updated to 7.4\r\n* All composer dependencies should be updated\r\n* Any infrastructure specific to older versions of PHP should be updated or removed\r\n\t* E.g. Test workflows\r\n* Must target the release scheduled for April 22\r\n\r\n**Check with @aaemnnosttv before merging a PR for these changes**\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Update `google-site-kit.php`\r\n * [ ] In plugin header comments increment `Requires PHP` to `7.4`\r\n * [ ] Update constant https://github.com/google/site-kit-wp/blob/49c312cf8b54f93bce33cc467b7bfad2f48d235f/google-site-kit.php#L31\r\n* [ ] Update `composer.json`\r\n * [ ] Edit `require.php` to `>=7.4`\r\n * [ ] Edit `config.platform.php` to `7.4.30`\r\n* [ ] Update `phpcs.xml`, in `testVersion` config increment php version to `7.4-` \r\n* [ ] Update https://github.com/google/site-kit-wp/blob/49c312cf8b54f93bce33cc467b7bfad2f48d235f/composer.json#L31 package so instead of replacing everything `*`, it needs to have `>=3.0.34`, as versions bellow are added to the conflict list of [SecurityAdvisory](https://github.com/Roave/SecurityAdvisories/blob/4b114c23632bc3580a1688f3a92f81d3c05bcd19/composer.json#L410) and `composer update` will fail\r\n* [ ] After packages are updated to reflect the changes in the lock file, running php tests - only 1 test is failing at the time of writing.\r\n * `Google\\Site_Kit\\Tests\\Core\\Authentication\\Clients\\OAuth_ClientTest::test_get_authentication_url` test is failing as `google/apiclient` package version (updates to `v2.14.0`) and in one of the versions it changes the OAuth url path to include `v2` - and we are looking for and expecting `https://accounts.google.com/o/oauth2/auth` which will be now `https://accounts.google.com/o/oauth2/v2/auth`. You can see the change in this [commit](https://github.com/googleapis/google-api-php-client/commit/b2624d21fce894126b9975a872cf5cda8038b254)\r\n * After fixing the test, run a search through the codebase for files where we are using the `https://accounts.google.com/o/oauth2/auth`and update it to correctly has `v2` in the path. At the time of writing we are using it in `includes/Core/Authentication/Clients/Client_Factory.php` and several E2E tests\r\n* [ ] Do a proper testing of OAuth redirection, and general smoke testing of the plugin\r\n* [ ] You can check if there is some other critical change that might happened between versions of `v2.12.2 `and `v2.14.0` in the [change log](https://github.com/googleapis/google-api-php-client/releases?page=1). During the definition, I took a brief look, and v2 is the only one I saw, but more might surface during actual execution\r\n* Some useful documentation for checking depricated/changed functions - [here](https://www.php.net/manual/en/migration70.php) and [here](https://www.php.net/manual/en/migration74.php)\r\n\r\n\r\n### Test Coverage\r\n\r\n* Not applicable\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8030/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8030/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007934002","html_url":"https://github.com/google/site-kit-wp/issues/8030#issuecomment-2007934002","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8030","id":2007934002,"node_id":"IC_kwDOC2hWJc53rqQy","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-19T19:09:36Z","updated_at":"2024-03-19T19:09:36Z","author_association":"COLLABORATOR","body":"Assigning this task back to @zutigrm, since he worked on IB for it.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007934002/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-19T19:09:38Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36696905279","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/events","html_url":"https://github.com/google/site-kit-wp/issues/8141","id":2098754767,"node_id":"I_kwDOC2hWJc59GHTP","number":8141,"title":"Add “partial data” states infrastructure","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"},{"id":3327716157,"node_id":"MDU6TGFiZWwzMzI3NzE2MTU3","url":"https://api.github.com/repos/google/site-kit-wp/labels/PHP","name":"PHP","color":"8892BF","default":false,"description":""},{"id":5204615861,"node_id":"LA_kwDOC2hWJc8AAAABNjgitQ","url":"https://api.github.com/repos/google/site-kit-wp/labels/Sp%20Wk%202","name":"Sp Wk 2","color":"1d76db","default":false,"description":"Issues to be completed in the second week of the assigned sprint"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2024-01-24T17:29:50Z","updated_at":"2024-03-19T19:06:48Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAdd the full infrastructure for determining and exposing the \"partial data\" states for audiences, custom dimensions and properties.\r\n\r\nSee [partial data states](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.5p6ukexs73j4) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Analytics module should have new selectors for detecting whether an audience, custom dimension or analytics property (referred as resource in the following points) is in \"partial data\" state. \r\n * A resource is considered to be in \"partial data\" state until it has been active for the full duration of the currently selected date range. \r\n * A resource is also considered to be in \"partial data\" state if the GA4 itself is in gathering data. \r\n* Partial data state should be determined by retrieving a report of the given resource and checking the date of the earliest event and making a comparison with the start date of the current date range.\r\n* Similarly how it's done for the gathering data states, the date of the earliest event, once determined, should be persisted on the server and made available in client on page load. \r\n * The persisted date for a given resource. whenever available. should be used instead of making a report request to determine the partial states in the resolvers of partial data selectors.\r\n\r\n## Implementation Brief\r\n\r\n **Note: the following IB is heavily based on and inspired by Data_Available state for modules and custom dimensions. Any gap in the IB may be filled in by reassessing the implementation and comparing with the aforementioned infrastructure.** \r\n\r\n### PHP\r\n\r\n* [ ] Create class `Google\\Site_Kit\\Modules\\Analytics_4\\Resource_Data_Availability_Date`.\r\n * [ ] Take `Transients $transients` in the constructor and initialize as a field. \r\n * [ ] Use Const `CUSTOM_DIMENSION_SLUGS` and `AUDIENCE_SLUGS` to store valid custom dimensions and slugs. \r\n * [ ] Have `RESOURCE_TYPE_**` consts for audience, custom dimension and property resources. \r\n * [ ] Method `get_resource_data_availability_date_transient_name` takes resource name and resource type parameters and returns the computed transient name. ie. `return \"googlesitekit_custom_dimension_{$resource_type}_{$resource_name}_data_availability_date\";`\r\n * [ ] Method `get_resource_data_availability_dates` should return an associative array of the data availability date of resources. This can be multi dimensional array or the resources can be prefixed with the resource type. \r\n * [ ] Other methods `get_resource_data_availability_date`, `set_resource_data_availability_date`, `reset_resource_data_availability_date` etc should be implemented similarly to how it is done on `Google\\Site_Kit\\Modules\\Analytics_4\\Custom_Dimensions_Data_Available` class. \r\n* [ ] In `Google\\Site_Kit\\Modules\\Analytics_4` class:\r\n * [ ] Add `$resource_data_available_date` field and instantiate it with `Resource_Data_Availability_Date` in the constructor. \r\n * [ ] Create A New REST Endpoint `POST:save-resource-data-availability-date` in `Analytics_4` module. \r\n * [ ] It should check if the passed resource(s) in the $data (`audience`, `customDimension` or `property`) are valid, and then persist the date values as a timestamp in the DB using the `$this->resource_data_available_date->set_resource_data_availability_date` method. \r\n* [ ] Expose the persisted dates of resource data availability to client using `googlesitekit_inline_modules_data` filter in the `register` method. \r\n\r\n### JS\r\n\r\n* [ ] Create `assets/js/modules/analytics-4/datastore/partial-data.js` file.\r\n * [ ] Create a fetch store for the aforementioned POST API. \r\n * [ ] Actions:\r\n * [ ] `saveResourceDataAvailabilityDate` takes an array of the object `{resource name, resource type and date}` and save it to the server using the fetch store. \r\n * [ ] Selectors: \r\n * [ ] `getResourceDataAvailabilityDate(resourceName, resourceTyoe)`: returns the date associated with the given resource if available, otherwise resolves to the first date in the last 90 days that the report data became available using the associated resolver (described below). The 90 days is chosen because that's the longest date range available in Site Kit. \r\n * [ ] `is{audience|customDimension|Property}PartialData(resourceName)`: \r\n * [ ] Return `true` when GA4 is in gathering Data state. \r\n * [ ] Return `false` when the `dataAvailabilityDate` for the is same or earlier than the `startDate` of currently selected date range. \r\n * [ ] Otherwise, return `true`. \r\n * [ ] Resolvers\r\n * [ ] `getResourceDataAvailabilityDate`: \r\n * [ ] Make a simple report request to the given resource using a 90-day date range. \r\n * [ ] Find the date of the first available report. \r\n * [ ] Persist the date for the given resource using `saveResourceDataAvailabilityDate`. \r\n * [ ] Return the date. \r\n* [ ] Add the newly added store partial to `assets/js/modules/analytics-4/datastore/index.js`. \r\n\r\n### Test Coverage\r\n\r\n* Add PHP Unit test for the newly added infrastructure. \r\n* Add Jest test for the newly added selectors and actions. \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007929755","html_url":"https://github.com/google/site-kit-wp/issues/8141#issuecomment-2007929755","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","id":2007929755,"node_id":"IC_kwDOC2hWJc53rpOb","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-19T19:06:47Z","updated_at":"2024-03-19T19:06:47Z","author_association":"COLLABORATOR","body":"> > My thinking here is that something can be in partial data state for a 28-day range, but still can have all the data it needs for a 7-day range and thus not being in partial data. So by saving the first available date for a 90 day report instead, we can recompute the partial data state for all our supported date range.\r\n> \r\n> Hey @kuasha420 @eugene-manuilov, just chipping in here as I had imagined we'd probably want to take the approach of requesting a report with a start date of the property creation time, that way we could get a definitive first-event-date and not keep requesting reports if say a property's events are all prior to the current 90 window. WDYT?\r\n\r\nThanks, @techanvil. I think this is a good idea. @kuasha420, could you please update your IB to use what Tom suggests? We also need to make sure that this information is reset when the user changes Analytics settings.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007929755/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-19T19:06:48Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36696763828","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8213","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8213/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8213/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8213/events","html_url":"https://github.com/google/site-kit-wp/issues/8213","id":2113759915,"node_id":"I_kwDOC2hWJc59_Wqr","number":8213,"title":"Add GA events for \"Top Earnings Pages\" overlay CTA","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"},{"id":4016653825,"node_id":"LA_kwDOC2hWJc7vaUYB","url":"https://api.github.com/repos/google/site-kit-wp/labels/javascript","name":"javascript","color":"168700","default":false,"description":"Pull requests that update Javascript code"},{"id":5204615861,"node_id":"LA_kwDOC2hWJc8AAAABNjgitQ","url":"https://api.github.com/repos/google/site-kit-wp/labels/Sp%20Wk%202","name":"Sp Wk 2","color":"1d76db","default":false,"description":"Issues to be completed in the second week of the assigned sprint"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2024-02-02T00:07:07Z","updated_at":"2024-03-19T19:01:47Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nGA events (eg. `trackEvent` calls) should be added to the new \"Top Earnings Pages\" overlay (#8237) that appears on the Site Kit dashboard when the user connects their accounts and has data available. There should be one when a user views the overlay, one when they click the \"Show me\" link in the overlay, and another when the user dismisses the overlay.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* When the AdSense + GA connected with data overlay is shown (see #8237), the following `trackEvent` calls should be made:\r\n * trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'view_overlay_CTA' )
when the notification is rendered and shown to the user\r\n * trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'confirm_overlay_CTA' )
when the user clicks the \"Show me\"/primary CTA\r\n * trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'dismiss_overlay_CTA' )
when the user clicks the \"Maybe later\"/secondary CTA\r\n\r\nCTA widget screenshot:\r\n\r\n![Screenshot 2024-02-19 at 23 35 03](https://github.com/google/site-kit-wp/assets/90871/1b918a18-0ee7-4f2e-8468-be7dcc7a61d7)\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Call trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'view_overlay_CTA' )
when [`shouldShowNotification` is `true` in `AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification`](https://github.com/google/site-kit-wp/pull/8399/files#diff-dde7a931a349093a2dc4b056807b51019b4555ec16f3dbf4a8793a82c1c66ff3R157)\r\n* [ ] Change the `onClick` handler for the [\"Show me\" button](https://github.com/google/site-kit-wp/pull/8399/files#diff-dde7a931a349093a2dc4b056807b51019b4555ec16f3dbf4a8793a82c1c66ff3R230-R232) to also call trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'confirm_overlay_CTA' )
\r\n* [ ] Add trackEvent( \\`{viewContext}_top-earning-pages-widget\\`, 'dismiss_overlay_CTA' )
to the \"dismiss\" handler at https://github.com/google/site-kit-wp/pull/8399/files#diff-dde7a931a349093a2dc4b056807b51019b4555ec16f3dbf4a8793a82c1c66ff3R167-R173\r\n\r\n### Test Coverage\r\n\r\n* No tests needed.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8213/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8213/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007921740","html_url":"https://github.com/google/site-kit-wp/issues/8213#issuecomment-2007921740","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8213","id":2007921740,"node_id":"IC_kwDOC2hWJc53rnRM","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-19T19:01:46Z","updated_at":"2024-03-19T19:01:46Z","author_association":"COLLABORATOR","body":"Thanks, @tofumatt. IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2007921740/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-19T19:01:48Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36654430764","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/events","html_url":"https://github.com/google/site-kit-wp/issues/8141","id":2098754767,"node_id":"I_kwDOC2hWJc59GHTP","number":8141,"title":"Add “partial data” states infrastructure","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2338632990,"node_id":"MDU6TGFiZWwyMzM4NjMyOTkw","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Analytics","name":"Module: Analytics","color":"f2aa03","default":false,"description":"Google Analytics module related issues"},{"id":3327716157,"node_id":"MDU6TGFiZWwzMzI3NzE2MTU3","url":"https://api.github.com/repos/google/site-kit-wp/labels/PHP","name":"PHP","color":"8892BF","default":false,"description":""},{"id":5204615861,"node_id":"LA_kwDOC2hWJc8AAAABNjgitQ","url":"https://api.github.com/repos/google/site-kit-wp/labels/Sp%20Wk%202","name":"Sp Wk 2","color":"1d76db","default":false,"description":"Issues to be completed in the second week of the assigned sprint"},{"id":6186757738,"node_id":"LA_kwDOC2hWJc8AAAABcMJuag","url":"https://api.github.com/repos/google/site-kit-wp/labels/Next%20Up","name":"Next Up","color":"F341CD","default":false,"description":"Issues to prioritize for definition"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-01-24T17:29:50Z","updated_at":"2024-03-18T17:16:42Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAdd the full infrastructure for determining and exposing the \"partial data\" states for audiences, custom dimensions and properties.\r\n\r\nSee [partial data states](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.5p6ukexs73j4) in the design doc.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Analytics module should have new selectors for detecting whether an audience, custom dimension or analytics property (referred as resource in the following points) is in \"partial data\" state. \r\n * A resource is considered to be in \"partial data\" state until it has been active for the full duration of the currently selected date range. \r\n * A resource is also considered to be in \"partial data\" state if the GA4 itself is in gathering data. \r\n* Partial data state should be determined by retrieving a report of the given resource and checking the date of the earliest event and making a comparison with the start date of the current date range.\r\n* Similarly how it's done for the gathering data states, the date of the earliest event, once determined, should be persisted on the server and made available in client on page load. \r\n * The persisted date for a given resource. whenever available. should be used instead of making a report request to determine the partial states in the resolvers of partial data selectors.\r\n\r\n## Implementation Brief\r\n\r\n **Note: the following IB is heavily based on and inspired by Data_Available state for modules and custom dimensions. Any gap in the IB may be filled in by reassessing the implementation and comparing with the aforementioned infrastructure.** \r\n\r\n### PHP\r\n\r\n* [ ] Create class `Google\\Site_Kit\\Modules\\Analytics_4\\Resource_Data_Availability_Date`.\r\n * [ ] Take `Transients $transients` in the constructor and initialize as a field. \r\n * [ ] Use Const `CUSTOM_DIMENSION_SLUGS` and `AUDIENCE_SLUGS` to store valid custom dimensions and slugs. \r\n * [ ] Have `RESOURCE_TYPE_**` consts for audience, custom dimension and property resources. \r\n * [ ] Method `get_resource_data_availability_date_transient_name` takes resource name and resource type parameters and returns the computed transient name. ie. `return \"googlesitekit_custom_dimension_{$resource_type}_{$resource_name}_data_availability_date\";`\r\n * [ ] Method `get_resource_data_availability_dates` should return an associative array of the data availability date of resources. This can be multi dimensional array or the resources can be prefixed with the resource type. \r\n * [ ] Other methods `get_resource_data_availability_date`, `set_resource_data_availability_date`, `reset_resource_data_availability_date` etc should be implemented similarly to how it is done on `Google\\Site_Kit\\Modules\\Analytics_4\\Custom_Dimensions_Data_Available` class. \r\n* [ ] In `Google\\Site_Kit\\Modules\\Analytics_4` class:\r\n * [ ] Add `$resource_data_available_date` field and instantiate it with `Resource_Data_Availability_Date` in the constructor. \r\n * [ ] Create A New REST Endpoint `POST:save-resource-data-availability-date` in `Analytics_4` module. \r\n * [ ] It should check if the passed resource(s) in the $data (`audience`, `customDimension` or `property`) are valid, and then persist the date values as a timestamp in the DB using the `$this->resource_data_available_date->set_resource_data_availability_date` method. \r\n* [ ] Expose the persisted dates of resource data availability to client using `googlesitekit_inline_modules_data` filter in the `register` method. \r\n\r\n### JS\r\n\r\n* [ ] Create `assets/js/modules/analytics-4/datastore/custom-dimensions-partial-data.js` file.\r\n * [ ] Create a fetch store for the aforementioned POST API. \r\n * [ ] Actions:\r\n * [ ] `saveResourceDataAvailabilityDate` takes an array of the object `{resource name, resource type and date}` and save it to the server using the fetch store. \r\n * [ ] Selectors: \r\n * [ ] `getResourceDataAvailabilityDate(resourceName, resourceTyoe)`: returns the date associated with the given resource if available, otherwise resolves to the first date in the last 90 days that the report data became available using the associated resolver (described below). The 90 days is chosen because that's the longest date range available in Site Kit. \r\n * [ ] `is{audience/customDimensionResource}PartialData(resourceName)`: \r\n * [ ] Return `true` when GA4 is in gathering Data state. \r\n * [ ] Return `false` when the `dataAvailabilityDate` for the is same or earlier than the `startDate` of currently selected date range. \r\n * [ ] Otherwise, return `true`. \r\n * [ ] Resolvers\r\n * [ ] `getResourceDataAvailabilityDate`: \r\n * [ ] Make a simple report request to the given resource using a 90-day date range. \r\n * [ ] Find the date of the first available report. \r\n * [ ] Persist the date for the given resource using `saveResourceDataAvailabilityDate`. \r\n * [ ] Return the date. \r\n* [ ] Add the newly added store partial to `assets/js/modules/analytics-4/datastore/index.js`. \r\n\r\n### Test Coverage\r\n\r\n* Add PHP Unit test for the newly added infrastructure. \r\n* Add Jest test for the newly added selectors and actions. \r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004500374","html_url":"https://github.com/google/site-kit-wp/issues/8141#issuecomment-2004500374","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8141","id":2004500374,"node_id":"IC_kwDOC2hWJc53ej-W","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-18T17:16:42Z","updated_at":"2024-03-18T17:16:42Z","author_association":"COLLABORATOR","body":"> * Create `assets/js/modules/analytics-4/datastore/custom-dimensions-partial-data.js` file.\r\n\r\nI think the file should be renamed to be more generic, something like `partial-data.js` because `custom-dimensions-` prefix refers to the custom dimensions matter which is just one out of three matters of the task.\r\n\r\n> Add the full infrastructure for determining and exposing the \"partial data\" states for audiences, custom dimensions and properties.\r\n\r\nThe \"determining\" part is missing in IB. We need to add instructions how to detect and save partial data information for all three matters.","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004500374/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-18T17:16:43Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36653931832","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8393","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8393/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8393/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8393/events","html_url":"https://github.com/google/site-kit-wp/issues/8393","id":2184137977,"node_id":"I_kwDOC2hWJc6CL0z5","number":8393,"title":"Change the `Ads Conversion ID` Field to `Conversion Tracking ID`","user":{"login":"10upsimon","id":72872375,"node_id":"MDQ6VXNlcjcyODcyMzc1","avatar_url":"https://avatars.githubusercontent.com/u/72872375?v=4","gravatar_id":"","url":"https://api.github.com/users/10upsimon","html_url":"https://github.com/10upsimon","followers_url":"https://api.github.com/users/10upsimon/followers","following_url":"https://api.github.com/users/10upsimon/following{/other_user}","gists_url":"https://api.github.com/users/10upsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/10upsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10upsimon/subscriptions","organizations_url":"https://api.github.com/users/10upsimon/orgs","repos_url":"https://api.github.com/users/10upsimon/repos","events_url":"https://api.github.com/users/10upsimon/events{/privacy}","received_events_url":"https://api.github.com/users/10upsimon/received_events","type":"User","site_admin":false},"labels":[{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":4016653825,"node_id":"LA_kwDOC2hWJc7vaUYB","url":"https://api.github.com/repos/google/site-kit-wp/labels/javascript","name":"javascript","color":"168700","default":false,"description":"Pull requests that update Javascript code"},{"id":6493803336,"node_id":"LA_kwDOC2hWJc8AAAABgw-TSA","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Ads","name":"Module: Ads","color":"1D76DB","default":false,"description":"Google Ads module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2024-03-13T14:20:14Z","updated_at":"2024-03-18T17:03:28Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAs part of a recent set of Ads Module updates issues, the need to update the field named Ads Conversion ID was raised. The field, contained within the SetupComponent, SettingsEdit and SettingsView components, should now be called \"Conversion Tracking ID\".\r\n\r\nFigma Reference: https://www.figma.com/file/THG1FJw5SaUxmiq38Mkf1x/Ads?type=design&node-id=653-3876&mode=design&t=jlu0HcZCByxfpa3E-0\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The current field labelled with value of \"Ads Conversion ID\" (found in SetupComponent, SettingsView and SettingsEdit components within the Ads module) should have the label updated to read as follows: \"Conversion Tracking ID\"\r\n\r\n## Implementation Brief\r\n\r\n* Rename the \"Ads Conversion ID\" labels to \"Conversion Tracking ID\" in the following components:\r\n * `/assets/js/modules/analytics/components/common/AdsConversionIDTextField.js`\r\n * `assets/js/modules/analytics/components/settings/OptionalSettingsView.js`\r\n * `assets/js/modules/analytics-4/components/common/AdsConversionIDTextField.js`\r\n * `assets/js/modules/analytics-4/components/settings/OptionalSettingsView.js`\r\n* In `assets/js/modules/analytics-4/components/common/AdsConversionIDTextField.js` also rename the description.\r\n \r\n\r\n\r\n\r\n### Test Coverage\r\n\r\n* Update VRT reference images\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8393/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8393/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004467068","html_url":"https://github.com/google/site-kit-wp/issues/8393#issuecomment-2004467068","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8393","id":2004467068,"node_id":"IC_kwDOC2hWJc53eb18","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-18T17:03:26Z","updated_at":"2024-03-18T17:03:26Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004467068/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-18T17:03:29Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36653889954","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8365","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8365/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8365/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8365/events","html_url":"https://github.com/google/site-kit-wp/issues/8365","id":2176169181,"node_id":"I_kwDOC2hWJc6BtbTd","number":8365,"title":"Update Consent Mode once the Ads Conversion ID setting has been migrated to the Ads module.","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":6493803336,"node_id":"LA_kwDOC2hWJc8AAAABgw-TSA","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Ads","name":"Module: Ads","color":"1D76DB","default":false,"description":"Google Ads module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-08T14:39:38Z","updated_at":"2024-03-18T17:00:41Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nEnsure that the relevant parts of Consent Mode are updated once the Ads Conversion ID setting has been migrated to the Ads module.\r\n\r\nSome of this will almost certainly be updated as part of the Ads Module work, this issue is to ensure nothing is missed.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* Once the Ads Conversion ID has been migrated to the Ads Module:\r\n * All references to it in the Consent Mode feature should be updated to use the value from the Ads Module.\r\n * The confirmation dialog shown when disabling Consent Mode on the Settings screen should be updated to include the Ads module when it's connected.\r\n\r\n## Implementation Brief\r\n\r\n_An initial IB has been drafted, to be completed._\r\n\r\n* [ ] Ensure the following code snippets are updated to get the `adsConversionID` from the `ads` module:\r\n\r\nhttps://github.com/google/site-kit-wp/blob/26e6a4318b09e47796fa5c02adf263ab756cb383/assets/js/components/consent-mode/ConsentModeSetupCTAWidget.js#L72-L75\r\n\r\nhttps://github.com/google/site-kit-wp/blob/26e6a4318b09e47796fa5c02adf263ab756cb383/assets/js/components/settings/SettingsCardConsentMode.js#L50-L53\r\n\r\nhttps://github.com/google/site-kit-wp/blob/26e6a4318b09e47796fa5c02adf263ab756cb383/assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js#L45-L47\r\n\r\n### Test Coverage\r\n\r\n* Update the `assets/js/components/consent-mode/ConsentModeSetupCTAWidget.stories.js` story to use the ads store.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8365/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8365/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004462752","html_url":"https://github.com/google/site-kit-wp/issues/8365#issuecomment-2004462752","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8365","id":2004462752,"node_id":"IC_kwDOC2hWJc53eayg","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-18T17:00:40Z","updated_at":"2024-03-18T17:00:40Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004462752/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-18T17:00:41Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36653781020","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/7642","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/7642/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/7642/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/7642/events","html_url":"https://github.com/google/site-kit-wp/issues/7642","id":1918583704,"node_id":"I_kwDOC2hWJc5yW0OY","number":7642,"title":"Improve UX/UI on AdSense notifications","user":{"login":"wpdarren","id":73545194,"node_id":"MDQ6VXNlcjczNTQ1MTk0","avatar_url":"https://avatars.githubusercontent.com/u/73545194?v=4","gravatar_id":"","url":"https://api.github.com/users/wpdarren","html_url":"https://github.com/wpdarren","followers_url":"https://api.github.com/users/wpdarren/followers","following_url":"https://api.github.com/users/wpdarren/following{/other_user}","gists_url":"https://api.github.com/users/wpdarren/gists{/gist_id}","starred_url":"https://api.github.com/users/wpdarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpdarren/subscriptions","organizations_url":"https://api.github.com/users/wpdarren/orgs","repos_url":"https://api.github.com/users/wpdarren/repos","events_url":"https://api.github.com/users/wpdarren/events{/privacy}","received_events_url":"https://api.github.com/users/wpdarren/received_events","type":"User","site_admin":false},"labels":[{"id":1412248542,"node_id":"MDU6TGFiZWwxNDEyMjQ4NTQy","url":"https://api.github.com/repos/google/site-kit-wp/labels/P2","name":"P2","color":"4bcc74","default":false,"description":"Low priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":2340690998,"node_id":"MDU6TGFiZWwyMzQwNjkwOTk4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20AdSense","name":"Module: AdSense","color":"adffc1","default":false,"description":"Google AdSense module related issues"},{"id":2931383078,"node_id":"MDU6TGFiZWwyOTMxMzgzMDc4","url":"https://api.github.com/repos/google/site-kit-wp/labels/UX","name":"UX","color":"DEC2F2","default":false,"description":"Issues that require UX input"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2023-09-29T04:31:26Z","updated_at":"2024-03-18T16:57:36Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nWhile testing the AdSense alerts in #7559 I spotted two UX/UI improvements that we should fix.\r\n\r\n1. The AdSense logo and text is rather small and not consistant with other notifications. \r\n2. The SVG does not align very well with the text and CTA. \r\n\r\nWould be good to tidy up these when we can. \r\n\r\n## Steps to reproduce\r\n\r\n1. Set up AdSense using an account that has a server alert (oi.ie has two which you can use to test this) \r\n2. Go to the Dashboard. \r\n3. The AdSense alert will appear (you might have to close other notifications that appear first) \r\n4. See UX/UI observations above. \r\n\r\n## Screenshots\r\n\r\n![image](https://github.com/google/site-kit-wp/assets/73545194/f9266e56-686f-48c5-b0c5-2c880344db2b)\r\n\r\n## Additional Context\r\n\r\nThis issue appears on all supported browsers. \r\n\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The SVG Icon that appears in the AdSense alert should be reduced in size to align with the text and CTA on its left, and have the unnecessary white spaces around it reduced. \r\n\r\n## Implementation Brief\r\n\r\n* Update `assets/js/components/notifications/AdSenseAlerts.js` passing the class `googlesitekit-adsense-alert` to the `BannerNotification` component.\r\n* Create a new scss file `assets/sass/components/adsense/_googlesitekit-adsense-alerts.scss` overiding the following notification styles for the AdSense notifications:\r\n```\r\n\t.googlesitekit-adsense-alert {\r\n\r\n\t\t&.googlesitekit-publisher-win .googlesitekit-publisher-win__module-name {\r\n\t\t\tfont-size: $fs-title-md;\r\n\t\t}\r\n\r\n\t\t.googlesitekit-publisher-win__image-small svg {\r\n\t\t\twidth: 68px;\r\n\t\t}\r\n\t}\r\n```\r\n\r\n### Test Coverage\r\n\r\n* Update VRTs. No further testing required.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/7642/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/7642/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004453851","html_url":"https://github.com/google/site-kit-wp/issues/7642#issuecomment-2004453851","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/7642","id":2004453851,"node_id":"IC_kwDOC2hWJc53eYnb","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-18T16:57:35Z","updated_at":"2024-03-18T16:57:35Z","author_association":"COLLABORATOR","body":"Thanks, @benbowler. IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004453851/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-18T16:57:36Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36649717885","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8398","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8398/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8398/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8398/events","html_url":"https://github.com/google/site-kit-wp/issues/8398","id":2185843388,"node_id":"I_kwDOC2hWJc6CSVK8","number":8398,"title":"Add Placeholder Content to The `Conversion Tracking ID` Field (`AW-`)","user":{"login":"10upsimon","id":72872375,"node_id":"MDQ6VXNlcjcyODcyMzc1","avatar_url":"https://avatars.githubusercontent.com/u/72872375?v=4","gravatar_id":"","url":"https://api.github.com/users/10upsimon","html_url":"https://github.com/10upsimon","followers_url":"https://api.github.com/users/10upsimon/followers","following_url":"https://api.github.com/users/10upsimon/following{/other_user}","gists_url":"https://api.github.com/users/10upsimon/gists{/gist_id}","starred_url":"https://api.github.com/users/10upsimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10upsimon/subscriptions","organizations_url":"https://api.github.com/users/10upsimon/orgs","repos_url":"https://api.github.com/users/10upsimon/repos","events_url":"https://api.github.com/users/10upsimon/events{/privacy}","received_events_url":"https://api.github.com/users/10upsimon/received_events","type":"User","site_admin":false},"labels":[{"id":1412247193,"node_id":"MDU6TGFiZWwxNDEyMjQ3MTkz","url":"https://api.github.com/repos/google/site-kit-wp/labels/P0","name":"P0","color":"ef8783","default":false,"description":"High priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":4016653825,"node_id":"LA_kwDOC2hWJc7vaUYB","url":"https://api.github.com/repos/google/site-kit-wp/labels/javascript","name":"javascript","color":"168700","default":false,"description":"Pull requests that update Javascript code"},{"id":6493803336,"node_id":"LA_kwDOC2hWJc8AAAABgw-TSA","url":"https://api.github.com/repos/google/site-kit-wp/labels/Module:%20Ads","name":"Module: Ads","color":"1D76DB","default":false,"description":"Google Ads module related issues"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-14T09:14:56Z","updated_at":"2024-03-18T15:11:13Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nAs part of a stint of recently identified Ads Module Phase 1 updates is the need to create placeholder text for the `Conversion Tracking ID` field, so that it is clear that users should enter only the numerical aspect of the gtag ID, and not the `AW-` portion.\r\n\r\nThis will take the form of a pre-applied `AW-` placeholder within the input field, as per the following Figma mock:\r\n\r\n\r\n\r\nThe Figma mock can be found [here](https://www.figma.com/file/THG1FJw5SaUxmiq38Mkf1x/Ads?type=design&node-id=653-3876&mode=design&t=EATE08eXwZ3T9n5J-0).\r\n\r\nThese updates will apply to the input field currently found within the `SetupComponent` and `SettingsEdit` components of the Ads Module.\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The input fields for the `Conversion Tracking ID` field, found within the `SetupComponent` and `SettingsEdit` components of the Ads Module, should meet the following criteria:\r\n * Permanent placeholder text should be present within the input field that prepends `AW-` to the value the user is entering.\r\n * The user should still be able to type or paste the full `AW-XXXXX` pattern of the ID, but it will be magically stripped away, indicating the full `AW-` field as a combination of the pre-existing `AW-` portion and the numerical part entered as part of the user input.\r\n * Field placeholder text following the permanent `AW-` text should read as per the Figma mock\r\n * Field validation messages should remain as they are.\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Update `assets/js/googlesitekit/components-gm2/TextField.js`\r\n * Include `leadingIcon` prop - it should accept type `element` (we can pass html markup or svg), and add it to the `MaterialTextField` component as `leadingIcon` prop\r\n* [ ] Update `assets/js/modules/ads/components/common/AdsConversionIDTextField.js`: \r\n * Add `leadingIcon` prop to the `TextField` component, and pass `__('AW-', 'google-site-kit')` markup for example\r\n * Update the `value` prop to replace `AW` and `AW-` with empty string. Example `adsConversionID?.replace( 'AW-', '' )?.replace( 'AW', '' )`\r\n* [ ] Add `assets/sass/components/setup/_googlesitekit-ads-conversion-tracking-id.scss`\r\n * Apply the styling for `AW` prefix and main input value as per figma design \r\n\r\n### Test Coverage\r\n\r\n* No test update is needed\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8398/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8398/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004178683","html_url":"https://github.com/google/site-kit-wp/issues/8398#issuecomment-2004178683","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8398","id":2004178683,"node_id":"IC_kwDOC2hWJc53dVb7","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-18T15:11:11Z","updated_at":"2024-03-18T15:11:11Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/2004178683/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-18T15:11:13Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36618811132","type":"WatchEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":140112834,"name":"johanbrandhorst/grpcweb-wasm-example","url":"https://api.github.com/repos/johanbrandhorst/grpcweb-wasm-example"},"payload":{"action":"started"},"public":true,"created_at":"2024-03-17T09:52:05Z"},{"id":"36561397015","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8397","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/events","html_url":"https://github.com/google/site-kit-wp/issues/8397","id":2185746232,"node_id":"I_kwDOC2hWJc6CR9c4","number":8397,"title":"\"Set up Google Analytics\" step not appearing in SK setup flow","user":{"login":"nfmohit","id":20284937,"node_id":"MDQ6VXNlcjIwMjg0OTM3","avatar_url":"https://avatars.githubusercontent.com/u/20284937?v=4","gravatar_id":"","url":"https://api.github.com/users/nfmohit","html_url":"https://github.com/nfmohit","followers_url":"https://api.github.com/users/nfmohit/followers","following_url":"https://api.github.com/users/nfmohit/following{/other_user}","gists_url":"https://api.github.com/users/nfmohit/gists{/gist_id}","starred_url":"https://api.github.com/users/nfmohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfmohit/subscriptions","organizations_url":"https://api.github.com/users/nfmohit/orgs","repos_url":"https://api.github.com/users/nfmohit/repos","events_url":"https://api.github.com/users/nfmohit/events{/privacy}","received_events_url":"https://api.github.com/users/nfmohit/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2024-03-14T08:32:42Z","updated_at":"2024-03-14T18:04:28Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nIn the Singular Analytics Module feature branch, when setting up Site Kit with the option to set up Google Analytics, the fourth step \"Set up Google Analytics\" isn't appearing.\r\n\r\n[Asana Task](https://app.asana.com/0/1206822627583085/1206832148100121/f)\r\n\r\nReported by @wpdarren in the Asana Task:\r\n\r\n> Usually, when you select Analytics in the Site Kit setup flow, there's a step 4 to set up Analytics. I noticed that on the feature branch, this is not appearing. Here's what I see.\r\n> ![image](https://github.com/google/site-kit-wp/assets/20284937/078dd118-0adf-4908-a3a7-1ce0435a1494)\r\n> This is what I see on the latest release. \r\n> ![image](https://github.com/google/site-kit-wp/assets/20284937/110d88ae-641d-44da-b800-843f51705315)\r\n> I am redirected to set up Analytics as expected, but the setup screens are confusing because the CTA appears saying go to dashboard and then it sets up Analytics\r\n\r\n## Steps to reproduce\r\n\r\n\r\n1. Use the SAM feature branch.\r\n2. In the SK setup splash screen, choose to connect Analytics, and start setup.\r\n3. In the setup flow, observe that there are only three steps, instead of four.\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n- When setting up Site Kit with the option to set up Analytics chosen, the fourth \"Set up Google Analytics\" step should appear in the setup flow in the SAM feature branch, as it does in the `develop` branch.\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Add the following missing filter usage to the `Modules\\Analytics_4::register` method:\r\nhttps://github.com/google/site-kit-wp/blob/cc9f305aa736d7509e303ead63c37f089b21b221/includes/Modules/Analytics.php#L113-L120\r\n * [ ] Add an explanatory comment explaining what this filter is used for here.\r\n\r\n### Test Coverage\r\n\r\n- No tests need to be added/updated.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1998038814","html_url":"https://github.com/google/site-kit-wp/issues/8397#issuecomment-1998038814","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397","id":1998038814,"node_id":"IC_kwDOC2hWJc53F6ce","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-14T18:04:27Z","updated_at":"2024-03-14T18:04:27Z","author_association":"COLLABORATOR","body":"IB also looks good. ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1998038814/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-14T18:04:28Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36560964859","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8397","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/events","html_url":"https://github.com/google/site-kit-wp/issues/8397","id":2185746232,"node_id":"I_kwDOC2hWJc6CR9c4","number":8397,"title":"\"Set up Google Analytics\" step not appearing in SK setup flow","user":{"login":"nfmohit","id":20284937,"node_id":"MDQ6VXNlcjIwMjg0OTM3","avatar_url":"https://avatars.githubusercontent.com/u/20284937?v=4","gravatar_id":"","url":"https://api.github.com/users/nfmohit","html_url":"https://github.com/nfmohit","followers_url":"https://api.github.com/users/nfmohit/followers","following_url":"https://api.github.com/users/nfmohit/following{/other_user}","gists_url":"https://api.github.com/users/nfmohit/gists{/gist_id}","starred_url":"https://api.github.com/users/nfmohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfmohit/subscriptions","organizations_url":"https://api.github.com/users/nfmohit/orgs","repos_url":"https://api.github.com/users/nfmohit/repos","events_url":"https://api.github.com/users/nfmohit/events{/privacy}","received_events_url":"https://api.github.com/users/nfmohit/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-14T08:32:42Z","updated_at":"2024-03-14T17:49:55Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\r\n\r\nIn the Singular Analytics Module feature branch, when setting up Site Kit with the option to set up Google Analytics, the fourth step \"Set up Google Analytics\" isn't appearing.\r\n\r\n[Asana Task](https://app.asana.com/0/1206822627583085/1206832148100121/f)\r\n\r\nReported by @wpdarren in the Asana Task:\r\n\r\n> Usually, when you select Analytics in the Site Kit setup flow, there's a step 4 to set up Analytics. I noticed that on the feature branch, this is not appearing. Here's what I see.\r\n> ![image](https://github.com/google/site-kit-wp/assets/20284937/078dd118-0adf-4908-a3a7-1ce0435a1494)\r\n> This is what I see on the latest release. \r\n> ![image](https://github.com/google/site-kit-wp/assets/20284937/110d88ae-641d-44da-b800-843f51705315)\r\n> I am redirected to set up Analytics as expected, but the setup screens are confusing because the CTA appears saying go to dashboard and then it sets up Analytics\r\n\r\n## Steps to reproduce\r\n\r\n\r\n1. Use the SAM feature branch.\r\n2. In the SK setup splash screen, choose to connect Analytics, and start setup.\r\n3. In the setup flow, observe that there are only three steps, instead of four.\r\n\r\n\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n- When setting up Site Kit with the option to set up Analytics chosen, the fourth \"Set up Google Analytics\" step should appear in the setup flow in the SAM feature branch, as it does in the `develop` branch.\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Add the following missing filter usage to the `Modules\\Analytics_4::register` method:\r\nhttps://github.com/google/site-kit-wp/blob/cc9f305aa736d7509e303ead63c37f089b21b221/includes/Modules/Analytics.php#L113-L120\r\n * [ ] Add an explanatory comment explaining what this filter is used for here.\r\n\r\n### Test Coverage\r\n\r\n- No tests need to be added/updated.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1998012586","html_url":"https://github.com/google/site-kit-wp/issues/8397#issuecomment-1998012586","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8397","id":1998012586,"node_id":"IC_kwDOC2hWJc53F0Cq","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-14T17:49:54Z","updated_at":"2024-03-14T17:49:54Z","author_association":"COLLABORATOR","body":"AC ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1998012586/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-14T17:49:55Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36518258846","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8381","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8381/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8381/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8381/events","html_url":"https://github.com/google/site-kit-wp/issues/8381","id":2181420619,"node_id":"I_kwDOC2hWJc6CBdZL","number":8381,"title":"Remove Ads bullet point from Consent Mode modal when Ads is not connected.","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-12T11:48:51Z","updated_at":"2024-03-13T16:09:17Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\n\nWhen an Ads Conversion ID has not been set up, we should not show the \"Performance of your Ad campaigns\" bullet point in the disable modal (screenshots taken from [Figma](https://www.figma.com/file/mdQi9qajirgoMHKy4DiVa8/Consent-Mode?node-id=59%3A16582&mode=dev)):\n\n![image](https://github.com/google/site-kit-wp/assets/18395600/27f50972-dfc7-4fe7-964a-05d7e2a61bd4)\n\nAs a result the copy above the bullet points should also be updated, so the modal description and bullet point list should read as follows:\n\n![image](https://github.com/google/site-kit-wp/assets/18395600/1d71a6ac-2554-4c50-b92a-9b1309f0824d)\n\nSee also the related issue https://github.com/google/site-kit-wp/issues/8389.\n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Acceptance criteria\n\n* When an Ads Conversion ID has not been set up, the Consent Mode disable modal should have its description copy updated as follows:\n * _Disabling consent mode may affect your ability in the European Economic Area to:_\n* Additionally, the bullet point relating to Ads should be removed.\n\n## Implementation Brief\n\n* [ ] Update `assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js`:\n* [ ] Use the get the adsConversionID from the `MODULE_ADS` store using the `getAdsConversionID` selector.\n* [ ] Add a new variable that uses `useMemo` return a new `provides` array based on the Ads Conversion ID's presence:\n```\n\tconst provides = useMemo( () => {\n\t\tlet providesArray = [\n\t\t\t__(\n\t\t\t\t'How visitors interact with your site via Analytics',\n\t\t\t\t'google-site-kit'\n\t\t\t),\n\t\t];\n\n\t\tif ( adsConversionID !== undefined && adsConversionID !== '' ) {\n\t\t\tprovidesArray = [\n\t\t\t\t...providesArray,\n\t\t\t\t__( 'Performance of your Ad campaigns', 'google-site-kit' ),\n\t\t\t];\n\t\t}\n\n\t\treturn providesArray;\n\t}, [ adsConversionID ] );\n```\n - [ ] Update the `provides` prop on the `ModalDialog` to take the new `provides` array: `provides={ provides }`\n\n### Test Coverage\n\n* No additional test coverage is required.\n\n## QA Brief\n\n* \n\n## Changelog entry\n\n* \n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8381/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8381/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994817494","html_url":"https://github.com/google/site-kit-wp/issues/8381#issuecomment-1994817494","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8381","id":1994817494,"node_id":"IC_kwDOC2hWJc525n_W","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-13T16:09:16Z","updated_at":"2024-03-13T16:09:16Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994817494/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-13T16:09:17Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36518218021","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8375","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8375/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8375/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8375/events","html_url":"https://github.com/google/site-kit-wp/issues/8375","id":2179832811,"node_id":"I_kwDOC2hWJc6B7Zvr","number":8375,"title":"WP Consent API active tick is squashed at narrow tablet viewports.","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1401246638,"node_id":"MDU6TGFiZWwxNDAxMjQ2NjM4","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false,"description":"Something isn't working"},{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2024-03-11T17:59:21Z","updated_at":"2024-03-13T16:08:09Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Bug Description\n\nThe circle around the tick that indicates the WP Consent API is active is squashed at narrow tablet viewports.\n\n## Steps to reproduce\n\n\n1. Install and activate the WP Consent API and navigate to the Consent Mode settings.\n2. Set the viewport to a narrow tablet width e.g. 601px.\n3. See the circle around the tick is squashed and clipped as per the screenshot below.\n\n## Screenshots\n\n![image](https://github.com/google/site-kit-wp/assets/18395600/9a53a6b9-3b7e-44c6-8b6c-01df3ba25448)\n\n\n## Additional Context\n\n\n - PHP Version: any\n - OS: any\n - Browser: any\n - Plugin Version: pre-release 1.122.0\n - Device: any\n\n\n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Acceptance criteria\n\n* The circle around the tick as described above should remain a proper circle at all viewport widths.\n\n## Implementation Brief\n\n* [ ] Add `min-width: 22px` to the styling for the circle. Alternatively `flex-basis` might be appropriate to use here.\n\n### Test Coverage\n\n* \n\n## QA Brief\n\n* \n\n## Changelog entry\n\n* \n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8375/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8375/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994813602","html_url":"https://github.com/google/site-kit-wp/issues/8375#issuecomment-1994813602","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8375","id":1994813602,"node_id":"IC_kwDOC2hWJc525nCi","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-13T16:08:08Z","updated_at":"2024-03-13T16:08:08Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994813602/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-13T16:08:09Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}},{"id":"36518190829","type":"IssueCommentEvent","actor":{"id":873049,"login":"eugene-manuilov","display_login":"eugene-manuilov","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","avatar_url":"https://avatars.githubusercontent.com/u/873049?"},"repo":{"id":191387173,"name":"google/site-kit-wp","url":"https://api.github.com/repos/google/site-kit-wp"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8389","repository_url":"https://api.github.com/repos/google/site-kit-wp","labels_url":"https://api.github.com/repos/google/site-kit-wp/issues/8389/labels{/name}","comments_url":"https://api.github.com/repos/google/site-kit-wp/issues/8389/comments","events_url":"https://api.github.com/repos/google/site-kit-wp/issues/8389/events","html_url":"https://github.com/google/site-kit-wp/issues/8389","id":2182265795,"node_id":"I_kwDOC2hWJc6CErvD","number":8389,"title":"Update the description copy in the Consent Mode modal.","user":{"login":"techanvil","id":18395600,"node_id":"MDQ6VXNlcjE4Mzk1NjAw","avatar_url":"https://avatars.githubusercontent.com/u/18395600?v=4","gravatar_id":"","url":"https://api.github.com/users/techanvil","html_url":"https://github.com/techanvil","followers_url":"https://api.github.com/users/techanvil/followers","following_url":"https://api.github.com/users/techanvil/following{/other_user}","gists_url":"https://api.github.com/users/techanvil/gists{/gist_id}","starred_url":"https://api.github.com/users/techanvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techanvil/subscriptions","organizations_url":"https://api.github.com/users/techanvil/orgs","repos_url":"https://api.github.com/users/techanvil/repos","events_url":"https://api.github.com/users/techanvil/events{/privacy}","received_events_url":"https://api.github.com/users/techanvil/received_events","type":"User","site_admin":false},"labels":[{"id":1412247954,"node_id":"MDU6TGFiZWwxNDEyMjQ3OTU0","url":"https://api.github.com/repos/google/site-kit-wp/labels/P1","name":"P1","color":"f7d488","default":false,"description":"Medium priority"},{"id":1425834856,"node_id":"MDU6TGFiZWwxNDI1ODM0ODU2","url":"https://api.github.com/repos/google/site-kit-wp/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"c5def5","default":false,"description":"Improvement of an existing feature"},{"id":1930899964,"node_id":"MDU6TGFiZWwxOTMwODk5OTY0","url":"https://api.github.com/repos/google/site-kit-wp/labels/Good%20First%20Issue","name":"Good First Issue","color":"37569e","default":false,"description":"Good first issue for new engineers"}],"state":"open","locked":false,"assignee":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2024-03-12T17:25:28Z","updated_at":"2024-03-13T16:07:23Z","closed_at":null,"author_association":"COLLABORATOR","active_lock_reason":null,"body":"## Feature Description\r\n\r\nThe description copy in the Consent Mode modal currently reads as follows:\r\n- _Disabling consent mode will remove the additional tag from your website. In the European Economic Area, you will no longer be able to track:_\r\n\r\n![image](https://github.com/google/site-kit-wp/assets/18395600/74c78bc0-8866-423d-bf0a-75948a7f7f55)\r\n\r\nThis copy should be updated to follow the current [Figma design](https://www.figma.com/file/mdQi9qajirgoMHKy4DiVa8/Consent-Mode?type=design&node-id=18-7217&mode=design&t=ALUBQ8QQpbygr3Pk-0):\r\n\r\n![image](https://github.com/google/site-kit-wp/assets/18395600/3bf0078a-16d4-446a-bbcc-83db6105dfa8)\r\n\r\nSee also the related issue https://github.com/google/site-kit-wp/issues/8381.\r\n\r\n---------------\r\n\r\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\r\n\r\n## Acceptance criteria\r\n\r\n* The Consent Mode disable modal should have its description copy updated as follows:\r\n * _Disabling consent mode may affect your ability to track these in the European Economic Area:_\r\n\r\n## Implementation Brief\r\n\r\n* [ ] Update the `subtitle` prop of the `ModalDialog` component to the new copy in `assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js`\r\nhttps://github.com/google/site-kit-wp/blob/cc9f305aa736d7509e303ead63c37f089b21b221/assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js#L78-L81\r\n\r\n### Test Coverage\r\n\r\n* No new tests required.\r\n\r\n## QA Brief\r\n\r\n* \r\n\r\n## Changelog entry\r\n\r\n* \r\n","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/8389/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/google/site-kit-wp/issues/8389/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994810820","html_url":"https://github.com/google/site-kit-wp/issues/8389#issuecomment-1994810820","issue_url":"https://api.github.com/repos/google/site-kit-wp/issues/8389","id":1994810820,"node_id":"IC_kwDOC2hWJc525mXE","user":{"login":"eugene-manuilov","id":873049,"node_id":"MDQ6VXNlcjg3MzA0OQ==","avatar_url":"https://avatars.githubusercontent.com/u/873049?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-manuilov","html_url":"https://github.com/eugene-manuilov","followers_url":"https://api.github.com/users/eugene-manuilov/followers","following_url":"https://api.github.com/users/eugene-manuilov/following{/other_user}","gists_url":"https://api.github.com/users/eugene-manuilov/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-manuilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-manuilov/subscriptions","organizations_url":"https://api.github.com/users/eugene-manuilov/orgs","repos_url":"https://api.github.com/users/eugene-manuilov/repos","events_url":"https://api.github.com/users/eugene-manuilov/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-manuilov/received_events","type":"User","site_admin":false},"created_at":"2024-03-13T16:07:21Z","updated_at":"2024-03-13T16:07:21Z","author_association":"COLLABORATOR","body":"IB ✔️ ","reactions":{"url":"https://api.github.com/repos/google/site-kit-wp/issues/comments/1994810820/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-03-13T16:07:23Z","org":{"id":1342004,"login":"google","gravatar_id":"","url":"https://api.github.com/orgs/google","avatar_url":"https://avatars.githubusercontent.com/u/1342004?"}}]