[{"id":"36141542247","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/events","html_url":"https://github.com/CesiumGS/cesium/pull/11837","id":2139250408,"node_id":"PR_kwDOADcI0s5nHz0E","number":11837,"title":"Fix camera collision on tileset load","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[{"id":14745816,"node_id":"MDU6TGFiZWwxNDc0NTgxNg==","url":"https://api.github.com/repos/CesiumGS/cesium/labels/priority%20-%20next%20release","name":"priority - next release","color":"e99695","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2024-02-16T19:06:38Z","updated_at":"2024-02-29T21:29:22Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/11837","html_url":"https://github.com/CesiumGS/cesium/pull/11837","diff_url":"https://github.com/CesiumGS/cesium/pull/11837.diff","patch_url":"https://github.com/CesiumGS/cesium/pull/11837.patch","merged_at":null},"body":"\r\n\r\n# Description\r\n\r\nMerge https://github.com/CesiumGS/cesium/pull/11829 first!\r\n\r\nThis ensures the scene is subscribed to tileset height updates, ie. when a tile loads. The subscription requires the current position, so it should only check for updates when a tile above or below the provided position loads in, and we reset the subscription when the camera position changes. \r\n\r\nThis is a similar workflow to how clamp to ground works, which is why these functions already exist.\r\n\r\n## Issue number and link\r\n\r\nFixes https://github.com/CesiumGS/cesium/issues/11824\r\n\r\n## Testing plan\r\n\r\n1. Go to the [Google 3D Tiles Sandcastle](https://sandcastle.cesium.com/?src=Google%20Photorealistic%203D%20Tiles.html&label=All)\r\n2. Use the geocoder to navigate to the Grand Canyon\r\n3. Quickly move the camera down and underground before the view is stable. The camera should no longer ever get \"stuck\" under terrain as it does in main.\r\n4. Ensure consistant FPS with Google P3DT\r\n5. Repeat the above steps with [CWT](https://sandcastle.cesium.com/?src=Cesium%20World%20Terrain.html&label=All)\r\n\r\n# Author checklist\r\n\r\n- [x] I have submitted a Contributor License Agreement\r\n- [x] I have added my name to `CONTRIBUTORS.md`\r\n- [x] I have updated `CHANGES.md` with a short summary of my change\r\n- [x] I have added or updated unit tests to ensure consistent code coverage\r\n- [ ] ~I have update the inline documentation, and included code examples where relevant~\r\n- [x] I have performed a self-review of my code\r\n- [x] https://github.com/CesiumGS/cesium/pull/11829 is merged\r\n","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971993723","html_url":"https://github.com/CesiumGS/cesium/pull/11837#issuecomment-1971993723","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","id":1971993723,"node_id":"IC_kwDOADcI0s51ijx7","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-29T21:29:20Z","updated_at":"2024-02-29T21:29:20Z","author_association":"MEMBER","body":"@ggetz fair enough. Are we planning to tackle that issue anytime soon? It's becoming a more common problem given data look Google and CWB.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971993723/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-29T21:29:22Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"36139142223","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/events","html_url":"https://github.com/CesiumGS/cesium/pull/11837","id":2139250408,"node_id":"PR_kwDOADcI0s5nHz0E","number":11837,"title":"Fix camera collision on tileset load","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[{"id":14745816,"node_id":"MDU6TGFiZWwxNDc0NTgxNg==","url":"https://api.github.com/repos/CesiumGS/cesium/labels/priority%20-%20next%20release","name":"priority - next release","color":"e99695","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2024-02-16T19:06:38Z","updated_at":"2024-02-29T19:54:44Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/11837","html_url":"https://github.com/CesiumGS/cesium/pull/11837","diff_url":"https://github.com/CesiumGS/cesium/pull/11837.diff","patch_url":"https://github.com/CesiumGS/cesium/pull/11837.patch","merged_at":null},"body":"\r\n\r\n# Description\r\n\r\nMerge https://github.com/CesiumGS/cesium/pull/11829 first!\r\n\r\nThis ensures the scene is subscribed to tileset height updates, ie. when a tile loads. The subscription requires the current position, so it should only check for updates when a tile above or below the provided position loads in, and we reset the subscription when the camera position changes. \r\n\r\nThis is a similar workflow to how clamp to ground works, which is why these functions already exist.\r\n\r\n## Issue number and link\r\n\r\nFixes https://github.com/CesiumGS/cesium/issues/11824\r\n\r\n## Testing plan\r\n\r\n1. Go to the [Google 3D Tiles Sandcastle](https://sandcastle.cesium.com/?src=Google%20Photorealistic%203D%20Tiles.html&label=All)\r\n2. Use the geocoder to navigate to the Grand Canyon\r\n3. Quickly move the camera down and underground before the view is stable. The camera should no longer ever get \"stuck\" under terrain as it does in main.\r\n4. Ensure consistant FPS with Google P3DT\r\n5. Repeat the above steps with [CWT](https://sandcastle.cesium.com/?src=Cesium%20World%20Terrain.html&label=All)\r\n\r\n# Author checklist\r\n\r\n- [x] I have submitted a Contributor License Agreement\r\n- [x] I have added my name to `CONTRIBUTORS.md`\r\n- [x] I have updated `CHANGES.md` with a short summary of my change\r\n- [x] I have added or updated unit tests to ensure consistent code coverage\r\n- [ ] ~I have update the inline documentation, and included code examples where relevant~\r\n- [x] I have performed a self-review of my code\r\n- [x] https://github.com/CesiumGS/cesium/pull/11829 is merged\r\n","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971854909","html_url":"https://github.com/CesiumGS/cesium/pull/11837#issuecomment-1971854909","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","id":1971854909,"node_id":"IC_kwDOADcI0s51iB49","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-29T19:54:43Z","updated_at":"2024-02-29T19:54:43Z","author_association":"MEMBER","body":"@ggetz Just realized the above happens even when enableCollision is false. Could this be another symptom of #4368 or #7092? (I didn't check to see if this area is below the ellipsoid)","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971854909/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-29T19:54:44Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"36139001683","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/events","html_url":"https://github.com/CesiumGS/cesium/pull/11837","id":2139250408,"node_id":"PR_kwDOADcI0s5nHz0E","number":11837,"title":"Fix camera collision on tileset load","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[{"id":14745816,"node_id":"MDU6TGFiZWwxNDc0NTgxNg==","url":"https://api.github.com/repos/CesiumGS/cesium/labels/priority%20-%20next%20release","name":"priority - next release","color":"e99695","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2024-02-16T19:06:38Z","updated_at":"2024-02-29T19:49:59Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/11837","html_url":"https://github.com/CesiumGS/cesium/pull/11837","diff_url":"https://github.com/CesiumGS/cesium/pull/11837.diff","patch_url":"https://github.com/CesiumGS/cesium/pull/11837.patch","merged_at":null},"body":"\r\n\r\n# Description\r\n\r\nMerge https://github.com/CesiumGS/cesium/pull/11829 first!\r\n\r\nThis ensures the scene is subscribed to tileset height updates, ie. when a tile loads. The subscription requires the current position, so it should only check for updates when a tile above or below the provided position loads in, and we reset the subscription when the camera position changes. \r\n\r\nThis is a similar workflow to how clamp to ground works, which is why these functions already exist.\r\n\r\n## Issue number and link\r\n\r\nFixes https://github.com/CesiumGS/cesium/issues/11824\r\n\r\n## Testing plan\r\n\r\n1. Go to the [Google 3D Tiles Sandcastle](https://sandcastle.cesium.com/?src=Google%20Photorealistic%203D%20Tiles.html&label=All)\r\n2. Use the geocoder to navigate to the Grand Canyon\r\n3. Quickly move the camera down and underground before the view is stable. The camera should no longer ever get \"stuck\" under terrain as it does in main.\r\n4. Ensure consistant FPS with Google P3DT\r\n5. Repeat the above steps with [CWT](https://sandcastle.cesium.com/?src=Cesium%20World%20Terrain.html&label=All)\r\n\r\n# Author checklist\r\n\r\n- [x] I have submitted a Contributor License Agreement\r\n- [x] I have added my name to `CONTRIBUTORS.md`\r\n- [x] I have updated `CHANGES.md` with a short summary of my change\r\n- [x] I have added or updated unit tests to ensure consistent code coverage\r\n- [ ] ~I have update the inline documentation, and included code examples where relevant~\r\n- [x] I have performed a self-review of my code\r\n- [x] https://github.com/CesiumGS/cesium/pull/11829 is merged\r\n","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971847962","html_url":"https://github.com/CesiumGS/cesium/pull/11837#issuecomment-1971847962","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11837","id":1971847962,"node_id":"IC_kwDOADcI0s51iAMa","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-29T19:49:59Z","updated_at":"2024-02-29T19:49:59Z","author_association":"MEMBER","body":"@ggetz The good news is that I was not able to get the camera to go below or stay below the Google tileset. So that's a huge improvement and navigating around was much better. :tada: \r\n\r\nI did run into a (related?) issue when it comes to camera movement near the ground. If you use the GP3DT Sandcastle example and there is a tennis court just off to the right, when you are high up, you can man with the mouse left-button no problem. however the moment you are close to the ground, the camera seems to be \"stuck\". I made a video to show what I mean. When you see me wiggling the mouse pointer and nothing is happening, that's me actually holding down the left button and the camera not really responding. I can show you in person tomorrow if you can't reproduce.\r\n\r\nhttps://github.com/CesiumGS/cesium/assets/1495196/2056362e-ce6f-4568-83c9-17bb75e97ced\r\n\r\n","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1971847962/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-29T19:50:00Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"35917623969","type":"IssuesEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":287389985,"name":"CesiumGS/cesium-native","url":"https://api.github.com/repos/CesiumGS/cesium-native"},"payload":{"action":"opened","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818","repository_url":"https://api.github.com/repos/CesiumGS/cesium-native","labels_url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818/events","html_url":"https://github.com/CesiumGS/cesium-native/issues/818","id":2149456020,"node_id":"I_kwDOESE5Ic6AHhiU","number":818,"title":"Handle 429 responses when streaming data","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[{"id":2274582236,"node_id":"MDU6TGFiZWwyMjc0NTgyMjM2","url":"https://api.github.com/repos/CesiumGS/cesium-native/labels/enhancement","name":"enhancement","color":"a2eeef","default":true,"description":"New feature or request"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-02-22T16:28:14Z","updated_at":"2024-02-22T16:28:14Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"* It's standard for public tile servers to have a IP-based rate limit over a sliding window of time and return a 429 code when that limit is reached.\r\n* Ideally, anywhere we stream data we would have a backoff strategy in place to successfully retry when encountering a 429.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium-native/issues/818/timeline","performed_via_github_app":null,"state_reason":null}},"public":true,"created_at":"2024-02-22T16:28:15Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"35917580221","type":"IssuesEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"opened","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846/events","html_url":"https://github.com/CesiumGS/cesium/issues/11846","id":2149453551,"node_id":"I_kwDOADcI0s6AHg7v","number":11846,"title":"Handle 429 responses when streaming data","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[{"id":653781,"node_id":"MDU6TGFiZWw2NTM3ODE=","url":"https://api.github.com/repos/CesiumGS/cesium/labels/type%20-%20enhancement","name":"type - enhancement","color":"d7e102","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-02-22T16:26:58Z","updated_at":"2024-02-22T16:26:58Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"* It's standard for public tile servers to have a IP-based rate limit over a sliding window of time and return a 429 code when that limit is reached.\r\n* Ideally, anywhere we load data in CesiumJS we would have a backoff strategy in place to successfully retry when encountering a 429. This impacts streaming imagery/terrain/3D Tiles more than anything else.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11846/timeline","performed_via_github_app":null,"state_reason":null}},"public":true,"created_at":"2024-02-22T16:26:59Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"35812656920","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/events","html_url":"https://github.com/CesiumGS/cesium/pull/11829","id":2134754542,"node_id":"PR_kwDOADcI0s5m4biM","number":11829,"title":"Adjust defaults for 3D Tiles collisions","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2024-02-14T16:43:35Z","updated_at":"2024-02-19T22:00:01Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/11829","html_url":"https://github.com/CesiumGS/cesium/pull/11829","diff_url":"https://github.com/CesiumGS/cesium/pull/11829.diff","patch_url":"https://github.com/CesiumGS/cesium/pull/11829.patch","merged_at":null},"body":"\r\n\r\n# Description\r\n\r\nGiven feedback about 3D Tiles camera collision [performance](https://github.com/CesiumGS/cesium/issues/11811) and confusion around the API flag, this PR:\r\n\r\n1. Adjusts the default for tilesets to have collisions disabled rather than enabled\r\n2. Renames the relevant property from `disableCollision` to `enableCollision`\r\n3. For Google P3DT, which has been tested for sufficient performance, sets `enableCollision` to true by default.\r\n\r\nThe reason for making this the new default is that, after investigation, I'm simply not confident we'll be able to ensure performance for every tileset case, particularly for tilesets containing large tiles with few primitives and many vertices.\r\n\r\nWe still will address https://github.com/CesiumGS/cesium/issues/11824 as well as potential performance improvements, but I just wanted to get on the same page about the API beforehand to reduce churn.\r\n\r\n## Issue number and link\r\n\r\nCloses https://github.com/CesiumGS/cesium/issues/11811\r\n\r\n## Testing plan\r\n\r\n- [ ] Verify the Google P3DT examples still have the same behavior with camera collisions as main\r\n- [ ] Ensure the \"Clamp Models to Ground\" and \"Clamp Entities to Ground\" examples have the same behavior as main\r\n- [ ] Ensure other tilesets, especially OSM Buildings and the \"3D Tiles Interior\" example, have collisions disabled by default and the expected performance using\r\n\r\n```\r\nviewer.scene.debugShowFramesPerSecond = true;\r\n```\r\n\r\n# Author checklist\r\n\r\n- [x] I have submitted a Contributor License Agreement\r\n- [x] I have added my name to `CONTRIBUTORS.md`\r\n- [x] I have updated `CHANGES.md` with a short summary of my change\r\n- [x] I have added or updated unit tests to ensure consistent code coverage\r\n- [x] I have update the inline documentation, and included code examples where relevant\r\n- [x] I have performed a self-review of my code\r\n- [ ] Open issue for deprecation","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1953205480","html_url":"https://github.com/CesiumGS/cesium/pull/11829#issuecomment-1953205480","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829","id":1953205480,"node_id":"IC_kwDOADcI0s50a4zo","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-19T22:00:00Z","updated_at":"2024-02-19T22:00:00Z","author_association":"MEMBER","body":"Awesome, thanks @ggetz. Looking forward to given all changes a spin when they are ready.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1953205480/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-19T22:00:01Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"35811828766","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/events","html_url":"https://github.com/CesiumGS/cesium/pull/11829","id":2134754542,"node_id":"PR_kwDOADcI0s5m4biM","number":11829,"title":"Adjust defaults for 3D Tiles collisions","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2024-02-14T16:43:35Z","updated_at":"2024-02-19T21:14:15Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/11829","html_url":"https://github.com/CesiumGS/cesium/pull/11829","diff_url":"https://github.com/CesiumGS/cesium/pull/11829.diff","patch_url":"https://github.com/CesiumGS/cesium/pull/11829.patch","merged_at":null},"body":"\r\n\r\n# Description\r\n\r\nGiven feedback about 3D Tiles camera collision [performance](https://github.com/CesiumGS/cesium/issues/11811) and confusion around the API flag, this PR:\r\n\r\n1. Adjusts the default for tilesets to have collisions disabled rather than enabled\r\n2. Renames the relevant property from `disableCollision` to `enableCollision`\r\n3. For Google P3DT, which has been tested for sufficient performance, sets `enableCollision` to true by default.\r\n\r\nThe reason for making this the new default is that, after investigation, I'm simply not confident we'll be able to ensure performance for every tileset case, particularly for tilesets containing large tiles with few primitives and many vertices.\r\n\r\nWe still will address https://github.com/CesiumGS/cesium/issues/11824 as well as potential performance improvements, but I just wanted to get on the same page about the API beforehand to reduce churn.\r\n\r\n## Issue number and link\r\n\r\nCloses https://github.com/CesiumGS/cesium/issues/11811\r\n\r\n## Testing plan\r\n\r\n- [ ] Verify the Google P3DT examples still have the same behavior with camera collisions as main\r\n- [ ] Ensure the \"Clamp Models to Ground\" and \"Clamp Entities to Ground\" examples have the same behavior as main\r\n- [ ] Ensure other tilesets, especially OSM Buildings and the \"3D Tiles Interior\" example, have collisions disabled by default and the expected performance using\r\n\r\n```\r\nviewer.scene.debugShowFramesPerSecond = true;\r\n```\r\n\r\n# Author checklist\r\n\r\n- [x] I have submitted a Contributor License Agreement\r\n- [x] I have added my name to `CONTRIBUTORS.md`\r\n- [x] I have updated `CHANGES.md` with a short summary of my change\r\n- [x] I have added or updated unit tests to ensure consistent code coverage\r\n- [x] I have update the inline documentation, and included code examples where relevant\r\n- [x] I have performed a self-review of my code\r\n- [ ] Open issue for deprecation","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1953165290","html_url":"https://github.com/CesiumGS/cesium/pull/11829#issuecomment-1953165290","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11829","id":1953165290,"node_id":"IC_kwDOADcI0s50au_q","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-19T21:14:14Z","updated_at":"2024-02-19T21:14:14Z","author_association":"MEMBER","body":"@ggetz Thrilled to see this change being made. At far as defaults go, I only have one thought: Since we're renaming, would `enableCameraCollision` be better/more specific than `enableCollision`? Are there any uses for this outside of camera movement?\r\n\r\nIt's outside the scope of this PR, but in addition to performance, the other requested behavior from the ion side would be to make the camera behave the same way it does with terrain; which unless something has changed means: \"The camera can go insight/under a tileset if it's loading, but the moment the full LOD is loaded it will \"pop\" to be on top of the tileset. The reasons for this are\r\n1. It's hard to prevent the camera from going under during the load process anyway, so better to just allow it until the full detail is loaded for the current location.\r\n2. Saving/restoring camera views is really hard if you don't factor in \"is the data still loading\" before preventing the camera from going somewhere.\r\n3. Similar to 2, camera flights are really hard to do otherwise because the camera usually slams into a lower LOD and stops and you don't end up with the actually desired location for the flight.\r\n\r\nI can write up an additional issue for the above collision feedback if you want.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1953165290/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-19T21:14:15Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"35605736444","type":"ForkEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":6093316,"name":"DefinitelyTyped/DefinitelyTyped","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped"},"payload":{"forkee":{"id":756395626,"node_id":"R_kgDOLRWuag","name":"DefinitelyTyped","full_name":"mramato/DefinitelyTyped","private":false,"owner":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mramato/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/mramato/DefinitelyTyped","forks_url":"https://api.github.com/repos/mramato/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/mramato/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mramato/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mramato/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/mramato/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/mramato/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/mramato/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/mramato/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/mramato/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/mramato/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/mramato/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mramato/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mramato/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/mramato/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mramato/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/mramato/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/mramato/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/mramato/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/mramato/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/mramato/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/mramato/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/mramato/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/mramato/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/mramato/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/mramato/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/mramato/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mramato/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/mramato/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mramato/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/mramato/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/mramato/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/mramato/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/mramato/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mramato/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/mramato/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/mramato/DefinitelyTyped/deployments","created_at":"2024-02-12T15:31:06Z","updated_at":"2024-02-12T15:31:06Z","pushed_at":"2024-02-12T15:29:45Z","git_url":"git://github.com/mramato/DefinitelyTyped.git","ssh_url":"git@github.com:mramato/DefinitelyTyped.git","clone_url":"https://github.com/mramato/DefinitelyTyped.git","svn_url":"https://github.com/mramato/DefinitelyTyped","homepage":"","size":674713,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"has_discussions":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":[],"visibility":"public","forks":0,"open_issues":0,"watchers":0,"default_branch":"main","public":true}},"public":true,"created_at":"2024-02-12T15:31:07Z","org":{"id":3637556,"login":"DefinitelyTyped","gravatar_id":"","url":"https://api.github.com/orgs/DefinitelyTyped","avatar_url":"https://avatars.githubusercontent.com/u/3637556?"}},{"id":"35332733254","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":27551774,"name":"aws/amazon-ecs-agent","url":"https://api.github.com/repos/aws/amazon-ecs-agent"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085","repository_url":"https://api.github.com/repos/aws/amazon-ecs-agent","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/events","html_url":"https://github.com/aws/amazon-ecs-agent/issues/4085","id":2111542369,"node_id":"I_kwDOAaRoHs5925Rh","number":4085,"title":"It seems impossible to define default cgroups settings for tasks","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2024-02-01T04:44:44Z","updated_at":"2024-02-02T00:58:14Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"### Summary\r\n\r\nIt seems impossible to define default cgroups settings for tasks.\r\n\r\n\r\n### Description\r\n\r\n* We are using ECS via AWS Batch to launch multiple jobs with heavy i/o\r\n* The heavy i/o is causing noisy neighbor issues and we would like to limit it. Specifically, Batch (and ecs-agent) fail to spin up new Docker containers, they time out do to delays caused by the heavy I/O. And this is on a Nitro SSD.\r\n* Since there is no way to limit file i/o via AWS Batch, we wanted to configure cgroups (v1) as part of our launch configuration to accomplish this.\r\n* The partial launch configuration is:\r\n ```\r\n # Get the major/minor versions of raid drive and set the limits to 50% so one job won't block other jobs from starting\r\n MAJOR=`stat -c %t /dev/md0`\r\n MINOR=`stat -c %T /dev/md0`\r\n \r\n printf \"$MAJOR:$MINOR 4000000000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.read_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 500000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.read_iops_device > /dev/null\r\n printf \"$MAJOR:$MINOR 2800000000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.write_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 400000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.write_iops_device > /dev/null\r\n \r\n sudo mkdir -p /sys/fs/cgroup/blkio/ecs\r\n printf \"$MAJOR:$MINOR 4000000000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.read_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 500000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.read_iops_device > /dev/null\r\n printf \"$MAJOR:$MINOR 2800000000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.write_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 400000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.write_iops_device > /dev/null\r\n \r\n sudo systemctl daemon-reload\r\n sudo systemctl restart docker\r\n ```\r\n### Expected Behavior\r\n\r\nThe launch configuration sets these values as expected, and since the `ecs-agent` starts jobs under the ecs cgroup, the expectation is that the above would cause all tasks to inherit these settings.\r\n\r\n### Observed Behavior\r\n\r\nAll tasks start with empty cgroups and do not inherit from the ecs parent.\r\n\r\nIf I start a task and then manually adjust the cgroups from the host that works. But since we don't know the task id / container id ahead of time, this is not a viable solution for us.\r\n\r\nFinally, there seems to be almost no documentation available for any of this, though limiting i/o so that multiple jobs can safely run on a single node seems to be a pretty standard use case.\r\n\r\n### Environment Details\r\n\r\n```\r\nsh-4.2$ sudo docker info\r\nClient:\r\n Context: default\r\n Debug Mode: false\r\n Plugins:\r\n buildx: Docker Buildx (Docker Inc., v0.0.0+unknown)\r\n\r\nServer:\r\n Containers: 2\r\n Running: 2\r\n Paused: 0\r\n Stopped: 0\r\n Images: 5\r\n Server Version: 20.10.25\r\n Storage Driver: overlay2\r\n Backing Filesystem: xfs\r\n Supports d_type: true\r\n Native Overlay Diff: true\r\n userxattr: false\r\n Logging Driver: json-file\r\n Cgroup Driver: cgroupfs\r\n Cgroup Version: 1\r\n Plugins:\r\n Volume: local\r\n Network: bridge host ipvlan macvlan null overlay\r\n Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog\r\n Swarm: inactive\r\n Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc\r\n Default Runtime: runc\r\n Init Binary: docker-init\r\n containerd version: 1e1ea6e986c6c86565bc33d52e34b81b3e2bc71f\r\n runc version: 4bccb38cc9cf198d52bebf2b3a90cd14e7af8c06\r\n init version: de40ad0\r\n Security Options:\r\n seccomp\r\n Profile: default\r\n Kernel Version: 4.14.336-253.554.amzn2.x86_64\r\n Operating System: Amazon Linux 2\r\n OSType: linux\r\n Architecture: x86_64\r\n CPUs: 32\r\n Total Memory: 247.9GiB\r\n Name: ip-10-30-13-103.ec2.internal\r\n ID: Z4SU:C7UF:5AZX:UWAD:K4JH:A47W:4OIW:ATJQ:UF2W:43NX:BFBU:ZUOS\r\n Docker Root Dir: /data\r\n Debug Mode: false\r\n Registry: https://index.docker.io/v1/\r\n Labels:\r\n Experimental: false\r\n Insecure Registries:\r\n 127.0.0.0/8\r\n Live Restore Enabled: false\r\n```\r\n\r\n```\r\nsh-4.2$ df -h\r\nFilesystem Size Used Avail Use% Mounted on\r\ndevtmpfs 124G 0 124G 0% /dev\r\ntmpfs 124G 0 124G 0% /dev/shm\r\ntmpfs 124G 428K 124G 1% /run\r\ntmpfs 124G 0 124G 0% /sys/fs/cgroup\r\n/dev/nvme0n1p1 30G 1.9G 29G 7% /\r\n/dev/md0 6.9T 184G 6.7T 3% /data\r\n```\r\n\r\n```\r\nsh-4.2$ curl http://localhost:51678/v1/metadata | jq\r\n % Total % Received % Xferd Average Speed Time Time Time Current\r\n Dload Upload Total Spent Left Speed\r\n100 344 100 344 0 0 91392 0 --:--:-- --:--:-- --:--:-- 111k\r\n{\r\n \"Cluster\": \"cesiumion-tiling-lt-0056ce2591ed453c8-14_Batch_3c431f46-4a1d-3183-a3cb-dfe21fb7b0d4\",\r\n \"ContainerInstanceArn\": \"arn:aws:ecs:us-east-1:899618071680:container-instance/cesiumion-tiling-lt-0056ce2591ed453c8-14_Batch_3c431f46-4a1d-3183-a3cb-dfe21fb7b0d4/833cf211563e4881bdf3baa3f669189f\",\r\n \"Version\": \"Amazon ECS Agent - v1.80.0 (*61c8a8c5)\"\r\n}\r\n```\r\n\r\n### Supporting Log Snippets\r\n\r\nTBD\r\n\r\n\r\n\r\n\r\n","reactions":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/1922594199","html_url":"https://github.com/aws/amazon-ecs-agent/issues/4085#issuecomment-1922594199","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085","id":1922594199,"node_id":"IC_kwDOAaRoHs5ymHWX","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-02-02T00:58:13Z","updated_at":"2024-02-02T00:58:13Z","author_association":"NONE","body":"* We switched to cgroups 2 and Amazon Linux 2023, same problem.\r\n* We are testing a workaround where we use `inotifywait` to watch cgroups and set them once ECS spins up a task. Seems to work, but definitely feels super hacky.","reactions":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/1922594199/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-02-02T00:58:14Z","org":{"id":2232217,"login":"aws","gravatar_id":"","url":"https://api.github.com/orgs/aws","avatar_url":"https://avatars.githubusercontent.com/u/2232217?"}},{"id":"35299526077","type":"IssuesEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":27551774,"name":"aws/amazon-ecs-agent","url":"https://api.github.com/repos/aws/amazon-ecs-agent"},"payload":{"action":"opened","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085","repository_url":"https://api.github.com/repos/aws/amazon-ecs-agent","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/events","html_url":"https://github.com/aws/amazon-ecs-agent/issues/4085","id":2111542369,"node_id":"I_kwDOAaRoHs5925Rh","number":4085,"title":"It seems impossible to define default cgroups settings for tasks","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-02-01T04:44:44Z","updated_at":"2024-02-01T04:44:44Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"### Summary\r\n\r\nIt seems impossible to define default cgroups settings for tasks.\r\n\r\n\r\n### Description\r\n\r\n* We are using ECS via AWS Batch to launch multiple jobs with heavy i/o\r\n* The heavy i/o is causing noisy neighbor issues and we would like to limit it.\r\n* Since there is no way to limit file i/o via AWS Batch, we wanted to configure cgroups (v1) as part of our launch configuration to accomplish this.\r\n* The partial launch configuration is:\r\n ```\r\n # Get the major/minor versions of raid drive and set the limits to 50% so one job won't block other jobs from starting\r\n MAJOR=`stat -c %t /dev/md0`\r\n MINOR=`stat -c %T /dev/md0`\r\n \r\n printf \"$MAJOR:$MINOR 4000000000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.read_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 500000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.read_iops_device > /dev/null\r\n printf \"$MAJOR:$MINOR 2800000000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.write_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 400000\" | sudo tee /sys/fs/cgroup/blkio/blkio.throttle.write_iops_device > /dev/null\r\n \r\n sudo mkdir -p /sys/fs/cgroup/blkio/ecs\r\n printf \"$MAJOR:$MINOR 4000000000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.read_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 500000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.read_iops_device > /dev/null\r\n printf \"$MAJOR:$MINOR 2800000000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.write_bps_device > /dev/null\r\n printf \"$MAJOR:$MINOR 400000\" | sudo tee /sys/fs/cgroup/blkio/ecs/blkio.throttle.write_iops_device > /dev/null\r\n \r\n sudo systemctl daemon-reload\r\n sudo systemctl restart docker\r\n ```\r\n### Expected Behavior\r\n\r\nThe launch configuration sets these values as expected, and since the `ecs-agent` starts jobs under the ecs cgroup, the expectation is that the above would cause all tasks to inherit these settings.\r\n\r\n### Observed Behavior\r\n\r\nAll tasks start with empty cgroups and do not inherit from the ecs parent.\r\n\r\nIf I start a task and then manually adjust the cgroups from the host that works. But since we don't know the task id / container id ahead of time, this is not a viable solution for us.\r\n\r\nFinally, there seems to be almost no documentation available for any of this, though limiting i/o so that multiple jobs can safely run on a single node seems to be a pretty standard use case.\r\n\r\n### Environment Details\r\n\r\n```\r\nsh-4.2$ sudo docker info\r\nClient:\r\n Context: default\r\n Debug Mode: false\r\n Plugins:\r\n buildx: Docker Buildx (Docker Inc., v0.0.0+unknown)\r\n\r\nServer:\r\n Containers: 2\r\n Running: 2\r\n Paused: 0\r\n Stopped: 0\r\n Images: 5\r\n Server Version: 20.10.25\r\n Storage Driver: overlay2\r\n Backing Filesystem: xfs\r\n Supports d_type: true\r\n Native Overlay Diff: true\r\n userxattr: false\r\n Logging Driver: json-file\r\n Cgroup Driver: cgroupfs\r\n Cgroup Version: 1\r\n Plugins:\r\n Volume: local\r\n Network: bridge host ipvlan macvlan null overlay\r\n Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog\r\n Swarm: inactive\r\n Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc\r\n Default Runtime: runc\r\n Init Binary: docker-init\r\n containerd version: 1e1ea6e986c6c86565bc33d52e34b81b3e2bc71f\r\n runc version: 4bccb38cc9cf198d52bebf2b3a90cd14e7af8c06\r\n init version: de40ad0\r\n Security Options:\r\n seccomp\r\n Profile: default\r\n Kernel Version: 4.14.336-253.554.amzn2.x86_64\r\n Operating System: Amazon Linux 2\r\n OSType: linux\r\n Architecture: x86_64\r\n CPUs: 32\r\n Total Memory: 247.9GiB\r\n Name: ip-10-30-13-103.ec2.internal\r\n ID: Z4SU:C7UF:5AZX:UWAD:K4JH:A47W:4OIW:ATJQ:UF2W:43NX:BFBU:ZUOS\r\n Docker Root Dir: /data\r\n Debug Mode: false\r\n Registry: https://index.docker.io/v1/\r\n Labels:\r\n Experimental: false\r\n Insecure Registries:\r\n 127.0.0.0/8\r\n Live Restore Enabled: false\r\n```\r\n\r\n```\r\nsh-4.2$ df -h\r\nFilesystem Size Used Avail Use% Mounted on\r\ndevtmpfs 124G 0 124G 0% /dev\r\ntmpfs 124G 0 124G 0% /dev/shm\r\ntmpfs 124G 428K 124G 1% /run\r\ntmpfs 124G 0 124G 0% /sys/fs/cgroup\r\n/dev/nvme0n1p1 30G 1.9G 29G 7% /\r\n/dev/md0 6.9T 184G 6.7T 3% /data\r\n```\r\n\r\n```\r\nsh-4.2$ curl http://localhost:51678/v1/metadata | jq\r\n % Total % Received % Xferd Average Speed Time Time Time Current\r\n Dload Upload Total Spent Left Speed\r\n100 344 100 344 0 0 91392 0 --:--:-- --:--:-- --:--:-- 111k\r\n{\r\n \"Cluster\": \"cesiumion-tiling-lt-0056ce2591ed453c8-14_Batch_3c431f46-4a1d-3183-a3cb-dfe21fb7b0d4\",\r\n \"ContainerInstanceArn\": \"arn:aws:ecs:us-east-1:899618071680:container-instance/cesiumion-tiling-lt-0056ce2591ed453c8-14_Batch_3c431f46-4a1d-3183-a3cb-dfe21fb7b0d4/833cf211563e4881bdf3baa3f669189f\",\r\n \"Version\": \"Amazon ECS Agent - v1.80.0 (*61c8a8c5)\"\r\n}\r\n```\r\n\r\n### Supporting Log Snippets\r\n\r\nTBD\r\n\r\n\r\n\r\n\r\n","reactions":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/4085/timeline","performed_via_github_app":null,"state_reason":null}},"public":true,"created_at":"2024-02-01T04:44:46Z","org":{"id":2232217,"login":"aws","gravatar_id":"","url":"https://api.github.com/orgs/aws","avatar_url":"https://avatars.githubusercontent.com/u/2232217?"}},{"id":"35290106329","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712/events","html_url":"https://github.com/CesiumGS/cesium/issues/10712","id":1346829559,"node_id":"I_kwDOADcI0s5QRvz3","number":10712,"title":"Remove pinned \"zip.js\" version in `package.json`","user":{"login":"ggetz","id":4439461,"node_id":"MDQ6VXNlcjQ0Mzk0NjE=","avatar_url":"https://avatars.githubusercontent.com/u/4439461?v=4","gravatar_id":"","url":"https://api.github.com/users/ggetz","html_url":"https://github.com/ggetz","followers_url":"https://api.github.com/users/ggetz/followers","following_url":"https://api.github.com/users/ggetz/following{/other_user}","gists_url":"https://api.github.com/users/ggetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ggetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggetz/subscriptions","organizations_url":"https://api.github.com/users/ggetz/orgs","repos_url":"https://api.github.com/users/ggetz/repos","events_url":"https://api.github.com/users/ggetz/events{/privacy}","received_events_url":"https://api.github.com/users/ggetz/received_events","type":"User","site_admin":false},"labels":[{"id":7937425,"node_id":"MDU6TGFiZWw3OTM3NDI1","url":"https://api.github.com/repos/CesiumGS/cesium/labels/cleanup","name":"cleanup","color":"02e10c","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2022-08-22T18:37:52Z","updated_at":"2024-01-31T20:19:54Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"https://github.com/CesiumGS/cesium/pull/10694/ pinned zip.js to `2.4` in order to fix https://github.com/CesiumGS/cesium/issues/10684 based on [this recommendation by the zip.js maintainer](https://github.com/gildas-lormeau/zip.js/issues/340#issuecomment-1177329994). Once the package no longer uses `TransformStream`, this workaround should be removed.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1919884193","html_url":"https://github.com/CesiumGS/cesium/issues/10712#issuecomment-1919884193","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/10712","id":1919884193,"node_id":"IC_kwDOADcI0s5ybxuh","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-01-31T20:19:52Z","updated_at":"2024-01-31T20:19:52Z","author_association":"MEMBER","body":"@jjhembd No, that sounds reasonable to me.","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1919884193/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-01-31T20:19:54Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34601305062","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/events","html_url":"https://github.com/CesiumGS/cesium/issues/11341","id":1745848740,"node_id":"I_kwDOADcI0s5oD4mk","number":11341,"title":"Using 3D Tiles for classification doesn't seem to work","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[{"id":653779,"node_id":"MDU6TGFiZWw2NTM3Nzk=","url":"https://api.github.com/repos/CesiumGS/cesium/labels/type%20-%20bug","name":"type - bug","color":"d7e102","default":false,"description":null},{"id":612429252,"node_id":"MDU6TGFiZWw2MTI0MjkyNTI=","url":"https://api.github.com/repos/CesiumGS/cesium/labels/category%20-%203d%20tiles","name":"category - 3d tiles","color":"bfdadc","default":false,"description":null},{"id":6393323779,"node_id":"LA_kwDOADcI0s8AAAABfRJhAw","url":"https://api.github.com/repos/CesiumGS/cesium/labels/category%20-%20classification","name":"category - classification","color":"bfdadc","default":false,"description":""}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2023-06-07T13:00:25Z","updated_at":"2024-01-05T14:06:49Z","closed_at":"2024-01-04T21:28:42Z","author_association":"MEMBER","active_lock_reason":null,"body":"As an experiment, I threw together this simple Sandcastle to attempt to classify Google buildings with OSM data. [Link](https://sandcastle.cesium.com/#c=fVRbb9owFP4rR2gPqURNQhJCNlqto9VWiapoZXuK1JrkFKw5NrINjFX97zu5sNHrixWf63e+fMe5VtbBRuAWDZyAwi2M0Yp1yX7WNi/r5PV9rJXjQqHJOl14yBSAEyVKsnyEey4tdisbV6LkTmh1aLQ5KrzSBU5F/gvNoWvOLU74Ds1z1+PRp0xlqteD2RJhIfUcodBoQWlHKLEAp6GyCbuSVKDo1sFWqBzBUcp0qZ02yKWwTuQQnsNMSMqnALkuKAaNoXky1czOapCsbsTsUm+JjBrLHsZZUbxVM1PO7BpO8ppOV1nRUQm+5cLtGc0p1eFXrRcSn5YKz2dNileNDfAE08qIUjixQct4UXht8SrwEXLu8iV4NIs2R/8haIlM6oV3d1E5QGpeCLV4k5O2JKvSPzzUxR7v6gbt8FMtlKtpzXmJhgNvbs0sK4m/n/HYhDEqWsnIq4EVSF1Vq44DoY25cfTFVehVYQDH/UEaJmnC4jjwB36UJN3WEfXTJAhjFgeJn0ZJP24d4TCOEt9nCZ1REIWDqLIf1V5tBJJ0X7T9hjUpU0EMftdSts0jNohjn/qm/TgI0vRfj2Of9YeDcJhGdAbhcBgOWk/AwngQJIS0HydJGCQhHid7ACRkqFhslKFt+WUtZNXYzt5TyfVB4JndqbzhkH6v5NaKe5HXE812K9q/PZEvXGx8cXP54+o2PL+dXU4u2rV6T12vAGw2MVOdbmdk3U7iaYME4LMoV9o4WBvpMdZzWNIu0r/szde0zY7l1jZ6Bhj1DlNHhdiAKE5eeVyaAclzv5byRvzBrHM66lH8i9RW1dcbNPQCVGHL4HTSGBljox5dX890Wss5N88q/wU)\r\n\r\nEverything is kind of broken visually, the OSM data should be draped over Google, instead it just appears to render incorrectly.\r\n\r\nTo make sure this was a problem with the OSM tileset and not google, I took our basic classification example and used it with Google and it worked as expected (though it doesn't full line up this is a data problem). [Link](https://sandcastle.cesium.com/#c=xVVRa9tADP4rWtiDA8beFvrSpmVbUkahZYWkezK0F5+S3HY+hbtzSlry3yf77DVOk/VtA4Ox9En36ZNOzsk4D2uFj2jhHAw+wgidKovkR22Lsl5ef4/IeKEM2qwXw3NmALwqULPlFOZCO4wrmzCqEF6R2TW6HA3ekMRblf9Cu+uaCYfXYoN237Xtn2UmM2kK0yXCQtMMQRI6MOSZJUrwBJVNuZXmBDKuwU6ZHMFzyO2SPFkUWjmvchiMYao0xzNAl5IxaC3Xk5lQe1KTTOqDErekRxaj5tLS+CLlsZyZ8XYTNMlrOX1lRc8pxKNQvlU051CP34gWGrupBuNpCImqsgE6nFZWFcqrNbpESBk1yYM+7Ym5Fs6pucpr8Ztkd1bDeYUByHpJkk5EsdI4Fl6kgVFzbDrqRKc1t4UVRYFcWNocmPx0ZLJeza/SA2YDWfwptXShJQ2RTd2DVSdRi32D9b5qHapMY26p4MqiUNixwuPgfg6vV7jNise2PeCVKxldTq7ubu4H4/vp1fVlk2tbvUJ/Dp6aOL/R2L1Eu+QnlTtqGOWkicc969nFTESfTk5i+BCe5KTPV6xCbd8ehoNE2tFoLo8TBR5o1pzsXh0xzEoPFo1EywBDthBabwKSipWwikcgeemfITP6dy2sbuXu7uh05BiV/9GUY1w6kU9ExZT+3sCJMDIXzmus8k5pwYvja+k9GV7Lk2pJdcOr1extiTHMS5NXFmg1XiLvV1nr1Sp6ZIjD7msCzgL0uLoB/W4XXiu0BQbmS4h4zZLtv2xH4mI0LaKHy8oBmoRUZtGO5im8f64jtg8hSy/uDesWXrRj8FkVK7I8xDxAvNQ88lLjterSWckUfJI7129oD9Pd0KFUa1Dy/MAfLWjBnnmp9UQ9Yda7GKaMfxXa8P2+Rsu/nQq2/HhxHYxJkgxT/jwc6Yn0TNi9zL8B)","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/timeline","performed_via_github_app":null,"state_reason":"completed"},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1878733112","html_url":"https://github.com/CesiumGS/cesium/issues/11341#issuecomment-1878733112","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341","id":1878733112,"node_id":"IC_kwDOADcI0s5v-zE4","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-01-05T14:06:49Z","updated_at":"2024-01-05T14:06:49Z","author_association":"MEMBER","body":"@ggetz So since this is closed, is there another issue we opened to track the larger limitation?","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1878733112/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-01-05T14:06:50Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34582626759","type":"IssueCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341","repository_url":"https://api.github.com/repos/CesiumGS/cesium","labels_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/labels{/name}","comments_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/comments","events_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/events","html_url":"https://github.com/CesiumGS/cesium/issues/11341","id":1745848740,"node_id":"I_kwDOADcI0s5oD4mk","number":11341,"title":"Using 3D Tiles for classification doesn't seem to work","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[{"id":653779,"node_id":"MDU6TGFiZWw2NTM3Nzk=","url":"https://api.github.com/repos/CesiumGS/cesium/labels/type%20-%20bug","name":"type - bug","color":"d7e102","default":false,"description":null},{"id":612429252,"node_id":"MDU6TGFiZWw2MTI0MjkyNTI=","url":"https://api.github.com/repos/CesiumGS/cesium/labels/category%20-%203d%20tiles","name":"category - 3d tiles","color":"bfdadc","default":false,"description":null},{"id":3842767762,"node_id":"LA_kwDOADcI0s7lC_uS","url":"https://api.github.com/repos/CesiumGS/cesium/labels/type%20-%20regression","name":"type - regression","color":"BA228A","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2023-06-07T13:00:25Z","updated_at":"2024-01-04T20:21:54Z","closed_at":null,"author_association":"MEMBER","active_lock_reason":null,"body":"As an experiment, I threw together this simple Sandcastle to attempt to classify Google buildings with OSM data. [Link](https://sandcastle.cesium.com/#c=fVRbb9owFP4rR2gPqURNQhJCNlqto9VWiapoZXuK1JrkFKw5NrINjFX97zu5sNHrixWf63e+fMe5VtbBRuAWDZyAwi2M0Yp1yX7WNi/r5PV9rJXjQqHJOl14yBSAEyVKsnyEey4tdisbV6LkTmh1aLQ5KrzSBU5F/gvNoWvOLU74Ds1z1+PRp0xlqteD2RJhIfUcodBoQWlHKLEAp6GyCbuSVKDo1sFWqBzBUcp0qZ02yKWwTuQQnsNMSMqnALkuKAaNoXky1czOapCsbsTsUm+JjBrLHsZZUbxVM1PO7BpO8ppOV1nRUQm+5cLtGc0p1eFXrRcSn5YKz2dNileNDfAE08qIUjixQct4UXht8SrwEXLu8iV4NIs2R/8haIlM6oV3d1E5QGpeCLV4k5O2JKvSPzzUxR7v6gbt8FMtlKtpzXmJhgNvbs0sK4m/n/HYhDEqWsnIq4EVSF1Vq44DoY25cfTFVehVYQDH/UEaJmnC4jjwB36UJN3WEfXTJAhjFgeJn0ZJP24d4TCOEt9nCZ1REIWDqLIf1V5tBJJ0X7T9hjUpU0EMftdSts0jNohjn/qm/TgI0vRfj2Of9YeDcJhGdAbhcBgOWk/AwngQJIS0HydJGCQhHid7ACRkqFhslKFt+WUtZNXYzt5TyfVB4JndqbzhkH6v5NaKe5HXE812K9q/PZEvXGx8cXP54+o2PL+dXU4u2rV6T12vAGw2MVOdbmdk3U7iaYME4LMoV9o4WBvpMdZzWNIu0r/szde0zY7l1jZ6Bhj1DlNHhdiAKE5eeVyaAclzv5byRvzBrHM66lH8i9RW1dcbNPQCVGHL4HTSGBljox5dX890Wss5N88q/wU)\r\n\r\nEverything is kind of broken visually, the OSM data should be draped over Google, instead it just appears to render incorrectly.\r\n\r\nTo make sure this was a problem with the OSM tileset and not google, I took our basic classification example and used it with Google and it worked as expected (though it doesn't full line up this is a data problem). [Link](https://sandcastle.cesium.com/#c=xVVRa9tADP4rWtiDA8beFvrSpmVbUkahZYWkezK0F5+S3HY+hbtzSlry3yf77DVOk/VtA4Ox9En36ZNOzsk4D2uFj2jhHAw+wgidKovkR22Lsl5ef4/IeKEM2qwXw3NmALwqULPlFOZCO4wrmzCqEF6R2TW6HA3ekMRblf9Cu+uaCYfXYoN237Xtn2UmM2kK0yXCQtMMQRI6MOSZJUrwBJVNuZXmBDKuwU6ZHMFzyO2SPFkUWjmvchiMYao0xzNAl5IxaC3Xk5lQe1KTTOqDErekRxaj5tLS+CLlsZyZ8XYTNMlrOX1lRc8pxKNQvlU051CP34gWGrupBuNpCImqsgE6nFZWFcqrNbpESBk1yYM+7Ym5Fs6pucpr8Ztkd1bDeYUByHpJkk5EsdI4Fl6kgVFzbDrqRKc1t4UVRYFcWNocmPx0ZLJeza/SA2YDWfwptXShJQ2RTd2DVSdRi32D9b5qHapMY26p4MqiUNixwuPgfg6vV7jNise2PeCVKxldTq7ubu4H4/vp1fVlk2tbvUJ/Dp6aOL/R2L1Eu+QnlTtqGOWkicc969nFTESfTk5i+BCe5KTPV6xCbd8ehoNE2tFoLo8TBR5o1pzsXh0xzEoPFo1EywBDthBabwKSipWwikcgeemfITP6dy2sbuXu7uh05BiV/9GUY1w6kU9ExZT+3sCJMDIXzmus8k5pwYvja+k9GV7Lk2pJdcOr1extiTHMS5NXFmg1XiLvV1nr1Sp6ZIjD7msCzgL0uLoB/W4XXiu0BQbmS4h4zZLtv2xH4mI0LaKHy8oBmoRUZtGO5im8f64jtg8hSy/uDesWXrRj8FkVK7I8xDxAvNQ88lLjterSWckUfJI7129oD9Pd0KFUa1Dy/MAfLWjBnnmp9UQ9Yda7GKaMfxXa8P2+Rsu/nQq2/HhxHYxJkgxT/jwc6Yn0TNi9zL8B)","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1877711578","html_url":"https://github.com/CesiumGS/cesium/issues/11341#issuecomment-1877711578","issue_url":"https://api.github.com/repos/CesiumGS/cesium/issues/11341","id":1877711578,"node_id":"IC_kwDOADcI0s5v65ra","user":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2024-01-04T20:21:53Z","updated_at":"2024-01-04T20:21:53Z","author_association":"MEMBER","body":"> The documentation for classificationType doesn't mention requiring water-tight geometry, so this should be added to the list of limitations.\r\n\r\nHow often is a 3D Tileset watertight? Is there an easy way to detect this for each tileset? From a user-centric point of view simply documenting it seems to equate to \"Sometimes this feature will work and sometimes it won't, good luck\". Can we do better?","reactions":{"url":"https://api.github.com/repos/CesiumGS/cesium/issues/comments/1877711578/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-01-04T20:21:54Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548654285","type":"DeleteEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":44277172,"name":"CesiumGS/obj2gltf","url":"https://api.github.com/repos/CesiumGS/obj2gltf"},"payload":{"ref":"update-prettier","ref_type":"branch","pusher_type":"user"},"public":true,"created_at":"2024-01-03T16:16:47Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548652861","type":"PushEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":44277172,"name":"CesiumGS/obj2gltf","url":"https://api.github.com/repos/CesiumGS/obj2gltf"},"payload":{"repository_id":44277172,"push_id":16491529598,"size":2,"distinct_size":1,"ref":"refs/heads/main","head":"ce0c36e28193205f6465a22c03f554fe22597f46","before":"a5559a572b8bb25c5df8dbe1afbddb0e70fe7126","commits":[{"sha":"45bf79e04f6332ab12264f663a26bd70c7b31b54","author":{"email":"ankittrehan2000@gmail.com","name":"ankittre2000"},"message":"Update prettier","distinct":false,"url":"https://api.github.com/repos/CesiumGS/obj2gltf/commits/45bf79e04f6332ab12264f663a26bd70c7b31b54"},{"sha":"ce0c36e28193205f6465a22c03f554fe22597f46","author":{"email":"matt.amato@gmail.com","name":"Matthew Amato"},"message":"Merge pull request #302 from CesiumGS/update-prettier\n\nUpdate prettier","distinct":true,"url":"https://api.github.com/repos/CesiumGS/obj2gltf/commits/ce0c36e28193205f6465a22c03f554fe22597f46"}]},"public":true,"created_at":"2024-01-03T16:16:43Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548652476","type":"PullRequestEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":44277172,"name":"CesiumGS/obj2gltf","url":"https://api.github.com/repos/CesiumGS/obj2gltf"},"payload":{"action":"closed","number":302,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302","id":1661864963,"node_id":"PR_kwDOAqOdtM5jDgwD","html_url":"https://github.com/CesiumGS/obj2gltf/pull/302","diff_url":"https://github.com/CesiumGS/obj2gltf/pull/302.diff","patch_url":"https://github.com/CesiumGS/obj2gltf/pull/302.patch","issue_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/302","number":302,"state":"closed","locked":false,"title":"Update prettier","user":{"login":"ankittrehan2000","id":47463734,"node_id":"MDQ6VXNlcjQ3NDYzNzM0","avatar_url":"https://avatars.githubusercontent.com/u/47463734?v=4","gravatar_id":"","url":"https://api.github.com/users/ankittrehan2000","html_url":"https://github.com/ankittrehan2000","followers_url":"https://api.github.com/users/ankittrehan2000/followers","following_url":"https://api.github.com/users/ankittrehan2000/following{/other_user}","gists_url":"https://api.github.com/users/ankittrehan2000/gists{/gist_id}","starred_url":"https://api.github.com/users/ankittrehan2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankittrehan2000/subscriptions","organizations_url":"https://api.github.com/users/ankittrehan2000/orgs","repos_url":"https://api.github.com/users/ankittrehan2000/repos","events_url":"https://api.github.com/users/ankittrehan2000/events{/privacy}","received_events_url":"https://api.github.com/users/ankittrehan2000/received_events","type":"User","site_admin":false},"body":"Updates prettier to latest version.\r\n\r\nThe only library pinned here is mime because it requires ESM. Opened https://github.com/CesiumGS/obj2gltf/issues/301 and created new label for dependency updates","created_at":"2024-01-02T13:59:54Z","updated_at":"2024-01-03T16:16:41Z","closed_at":"2024-01-03T16:16:41Z","merged_at":"2024-01-03T16:16:41Z","merge_commit_sha":"ce0c36e28193205f6465a22c03f554fe22597f46","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302/commits","review_comments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302/comments","review_comment_url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/302/comments","statuses_url":"https://api.github.com/repos/CesiumGS/obj2gltf/statuses/45bf79e04f6332ab12264f663a26bd70c7b31b54","head":{"label":"CesiumGS:update-prettier","ref":"update-prettier","sha":"45bf79e04f6332ab12264f663a26bd70c7b31b54","user":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"repo":{"id":44277172,"node_id":"MDEwOlJlcG9zaXRvcnk0NDI3NzE3Mg==","name":"obj2gltf","full_name":"CesiumGS/obj2gltf","private":false,"owner":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CesiumGS/obj2gltf","description":"Convert OBJ assets to glTF","fork":false,"url":"https://api.github.com/repos/CesiumGS/obj2gltf","forks_url":"https://api.github.com/repos/CesiumGS/obj2gltf/forks","keys_url":"https://api.github.com/repos/CesiumGS/obj2gltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CesiumGS/obj2gltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CesiumGS/obj2gltf/teams","hooks_url":"https://api.github.com/repos/CesiumGS/obj2gltf/hooks","issue_events_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/events{/number}","events_url":"https://api.github.com/repos/CesiumGS/obj2gltf/events","assignees_url":"https://api.github.com/repos/CesiumGS/obj2gltf/assignees{/user}","branches_url":"https://api.github.com/repos/CesiumGS/obj2gltf/branches{/branch}","tags_url":"https://api.github.com/repos/CesiumGS/obj2gltf/tags","blobs_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CesiumGS/obj2gltf/statuses/{sha}","languages_url":"https://api.github.com/repos/CesiumGS/obj2gltf/languages","stargazers_url":"https://api.github.com/repos/CesiumGS/obj2gltf/stargazers","contributors_url":"https://api.github.com/repos/CesiumGS/obj2gltf/contributors","subscribers_url":"https://api.github.com/repos/CesiumGS/obj2gltf/subscribers","subscription_url":"https://api.github.com/repos/CesiumGS/obj2gltf/subscription","commits_url":"https://api.github.com/repos/CesiumGS/obj2gltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/CesiumGS/obj2gltf/contents/{+path}","compare_url":"https://api.github.com/repos/CesiumGS/obj2gltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CesiumGS/obj2gltf/merges","archive_url":"https://api.github.com/repos/CesiumGS/obj2gltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CesiumGS/obj2gltf/downloads","issues_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues{/number}","pulls_url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls{/number}","milestones_url":"https://api.github.com/repos/CesiumGS/obj2gltf/milestones{/number}","notifications_url":"https://api.github.com/repos/CesiumGS/obj2gltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CesiumGS/obj2gltf/labels{/name}","releases_url":"https://api.github.com/repos/CesiumGS/obj2gltf/releases{/id}","deployments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/deployments","created_at":"2015-10-14T21:21:45Z","updated_at":"2023-12-26T09:04:22Z","pushed_at":"2024-01-03T16:16:41Z","git_url":"git://github.com/CesiumGS/obj2gltf.git","ssh_url":"git@github.com:CesiumGS/obj2gltf.git","clone_url":"https://github.com/CesiumGS/obj2gltf.git","svn_url":"https://github.com/CesiumGS/obj2gltf","homepage":null,"size":811,"stargazers_count":1600,"watchers_count":1600,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"has_discussions":false,"forks_count":300,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["3d-converter","gltf"],"visibility":"public","forks":300,"open_issues":59,"watchers":1600,"default_branch":"main"}},"base":{"label":"CesiumGS:main","ref":"main","sha":"a5559a572b8bb25c5df8dbe1afbddb0e70fe7126","user":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"repo":{"id":44277172,"node_id":"MDEwOlJlcG9zaXRvcnk0NDI3NzE3Mg==","name":"obj2gltf","full_name":"CesiumGS/obj2gltf","private":false,"owner":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CesiumGS/obj2gltf","description":"Convert OBJ assets to glTF","fork":false,"url":"https://api.github.com/repos/CesiumGS/obj2gltf","forks_url":"https://api.github.com/repos/CesiumGS/obj2gltf/forks","keys_url":"https://api.github.com/repos/CesiumGS/obj2gltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CesiumGS/obj2gltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CesiumGS/obj2gltf/teams","hooks_url":"https://api.github.com/repos/CesiumGS/obj2gltf/hooks","issue_events_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/events{/number}","events_url":"https://api.github.com/repos/CesiumGS/obj2gltf/events","assignees_url":"https://api.github.com/repos/CesiumGS/obj2gltf/assignees{/user}","branches_url":"https://api.github.com/repos/CesiumGS/obj2gltf/branches{/branch}","tags_url":"https://api.github.com/repos/CesiumGS/obj2gltf/tags","blobs_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CesiumGS/obj2gltf/statuses/{sha}","languages_url":"https://api.github.com/repos/CesiumGS/obj2gltf/languages","stargazers_url":"https://api.github.com/repos/CesiumGS/obj2gltf/stargazers","contributors_url":"https://api.github.com/repos/CesiumGS/obj2gltf/contributors","subscribers_url":"https://api.github.com/repos/CesiumGS/obj2gltf/subscribers","subscription_url":"https://api.github.com/repos/CesiumGS/obj2gltf/subscription","commits_url":"https://api.github.com/repos/CesiumGS/obj2gltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/CesiumGS/obj2gltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/CesiumGS/obj2gltf/contents/{+path}","compare_url":"https://api.github.com/repos/CesiumGS/obj2gltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CesiumGS/obj2gltf/merges","archive_url":"https://api.github.com/repos/CesiumGS/obj2gltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CesiumGS/obj2gltf/downloads","issues_url":"https://api.github.com/repos/CesiumGS/obj2gltf/issues{/number}","pulls_url":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls{/number}","milestones_url":"https://api.github.com/repos/CesiumGS/obj2gltf/milestones{/number}","notifications_url":"https://api.github.com/repos/CesiumGS/obj2gltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CesiumGS/obj2gltf/labels{/name}","releases_url":"https://api.github.com/repos/CesiumGS/obj2gltf/releases{/id}","deployments_url":"https://api.github.com/repos/CesiumGS/obj2gltf/deployments","created_at":"2015-10-14T21:21:45Z","updated_at":"2023-12-26T09:04:22Z","pushed_at":"2024-01-03T16:16:41Z","git_url":"git://github.com/CesiumGS/obj2gltf.git","ssh_url":"git@github.com:CesiumGS/obj2gltf.git","clone_url":"https://github.com/CesiumGS/obj2gltf.git","svn_url":"https://github.com/CesiumGS/obj2gltf","homepage":null,"size":811,"stargazers_count":1600,"watchers_count":1600,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"has_discussions":false,"forks_count":300,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["3d-converter","gltf"],"visibility":"public","forks":300,"open_issues":59,"watchers":1600,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302"},"html":{"href":"https://github.com/CesiumGS/obj2gltf/pull/302"},"issue":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/302"},"comments":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/CesiumGS/obj2gltf/statuses/45bf79e04f6332ab12264f663a26bd70c7b31b54"}},"author_association":"CONTRIBUTOR","auto_merge":null,"active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":2}},"public":true,"created_at":"2024-01-03T16:16:42Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548644473","type":"DeleteEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":46226879,"name":"CesiumGS/gltf-pipeline","url":"https://api.github.com/repos/CesiumGS/gltf-pipeline"},"payload":{"ref":"update-prettier","ref_type":"branch","pusher_type":"user"},"public":true,"created_at":"2024-01-03T16:16:24Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548643387","type":"PushEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":46226879,"name":"CesiumGS/gltf-pipeline","url":"https://api.github.com/repos/CesiumGS/gltf-pipeline"},"payload":{"repository_id":46226879,"push_id":16491524820,"size":3,"distinct_size":1,"ref":"refs/heads/main","head":"adcfeffed552e1de42a8fc0af99783b9dcfa056a","before":"79024c617ce45f91e97bd91eb48c7b9619c8e694","commits":[{"sha":"f7b0739d7dc939a785104f34b6066c2c195cfad0","author":{"email":"ankittrehan2000@gmail.com","name":"ankittre2000"},"message":"Update prettier","distinct":false,"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/commits/f7b0739d7dc939a785104f34b6066c2c195cfad0"},{"sha":"b907f8e9a5e44caf82a32a879a76836be476fc68","author":{"email":"ankittrehan2000@gmail.com","name":"ankittre2000"},"message":"Update global require","distinct":false,"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/commits/b907f8e9a5e44caf82a32a879a76836be476fc68"},{"sha":"adcfeffed552e1de42a8fc0af99783b9dcfa056a","author":{"email":"matt.amato@gmail.com","name":"Matthew Amato"},"message":"Merge pull request #652 from CesiumGS/update-prettier\n\nUpdate prettier","distinct":true,"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/commits/adcfeffed552e1de42a8fc0af99783b9dcfa056a"}]},"public":true,"created_at":"2024-01-03T16:16:21Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34548643051","type":"PullRequestEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":46226879,"name":"CesiumGS/gltf-pipeline","url":"https://api.github.com/repos/CesiumGS/gltf-pipeline"},"payload":{"action":"closed","number":652,"pull_request":{"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652","id":1661853342,"node_id":"PR_kwDOAsFdv85jDd6e","html_url":"https://github.com/CesiumGS/gltf-pipeline/pull/652","diff_url":"https://github.com/CesiumGS/gltf-pipeline/pull/652.diff","patch_url":"https://github.com/CesiumGS/gltf-pipeline/pull/652.patch","issue_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/652","number":652,"state":"closed","locked":false,"title":"Update prettier","user":{"login":"ankittrehan2000","id":47463734,"node_id":"MDQ6VXNlcjQ3NDYzNzM0","avatar_url":"https://avatars.githubusercontent.com/u/47463734?v=4","gravatar_id":"","url":"https://api.github.com/users/ankittrehan2000","html_url":"https://github.com/ankittrehan2000","followers_url":"https://api.github.com/users/ankittrehan2000/followers","following_url":"https://api.github.com/users/ankittrehan2000/following{/other_user}","gists_url":"https://api.github.com/users/ankittrehan2000/gists{/gist_id}","starred_url":"https://api.github.com/users/ankittrehan2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankittrehan2000/subscriptions","organizations_url":"https://api.github.com/users/ankittrehan2000/orgs","repos_url":"https://api.github.com/users/ankittrehan2000/repos","events_url":"https://api.github.com/users/ankittrehan2000/events{/privacy}","received_events_url":"https://api.github.com/users/ankittrehan2000/received_events","type":"User","site_admin":false},"body":"Updates prettier to latest version. \r\n\r\nThe only library pinned here is `mime` because it requires ESM","created_at":"2024-01-02T13:49:34Z","updated_at":"2024-01-03T16:16:20Z","closed_at":"2024-01-03T16:16:20Z","merged_at":"2024-01-03T16:16:19Z","merge_commit_sha":"adcfeffed552e1de42a8fc0af99783b9dcfa056a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"draft":false,"commits_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652/commits","review_comments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652/comments","review_comment_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/652/comments","statuses_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/statuses/b907f8e9a5e44caf82a32a879a76836be476fc68","head":{"label":"CesiumGS:update-prettier","ref":"update-prettier","sha":"b907f8e9a5e44caf82a32a879a76836be476fc68","user":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"node_id":"MDEwOlJlcG9zaXRvcnk0NjIyNjg3OQ==","name":"gltf-pipeline","full_name":"CesiumGS/gltf-pipeline","private":false,"owner":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CesiumGS/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets. :globe_with_meridians:","fork":false,"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline","forks_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2024-01-02T16:21:37Z","pushed_at":"2024-01-03T16:16:19Z","git_url":"git://github.com/CesiumGS/gltf-pipeline.git","ssh_url":"git@github.com:CesiumGS/gltf-pipeline.git","clone_url":"https://github.com/CesiumGS/gltf-pipeline.git","svn_url":"https://github.com/CesiumGS/gltf-pipeline","homepage":"","size":26583,"stargazers_count":1730,"watchers_count":1730,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"has_discussions":false,"forks_count":240,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["3d-converter","gltf"],"visibility":"public","forks":240,"open_issues":91,"watchers":1730,"default_branch":"main"}},"base":{"label":"CesiumGS:main","ref":"main","sha":"79024c617ce45f91e97bd91eb48c7b9619c8e694","user":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"node_id":"MDEwOlJlcG9zaXRvcnk0NjIyNjg3OQ==","name":"gltf-pipeline","full_name":"CesiumGS/gltf-pipeline","private":false,"owner":{"login":"CesiumGS","id":54716382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NzE2Mzgy","avatar_url":"https://avatars.githubusercontent.com/u/54716382?v=4","gravatar_id":"","url":"https://api.github.com/users/CesiumGS","html_url":"https://github.com/CesiumGS","followers_url":"https://api.github.com/users/CesiumGS/followers","following_url":"https://api.github.com/users/CesiumGS/following{/other_user}","gists_url":"https://api.github.com/users/CesiumGS/gists{/gist_id}","starred_url":"https://api.github.com/users/CesiumGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CesiumGS/subscriptions","organizations_url":"https://api.github.com/users/CesiumGS/orgs","repos_url":"https://api.github.com/users/CesiumGS/repos","events_url":"https://api.github.com/users/CesiumGS/events{/privacy}","received_events_url":"https://api.github.com/users/CesiumGS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CesiumGS/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets. :globe_with_meridians:","fork":false,"url":"https://api.github.com/repos/CesiumGS/gltf-pipeline","forks_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/CesiumGS/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2024-01-02T16:21:37Z","pushed_at":"2024-01-03T16:16:19Z","git_url":"git://github.com/CesiumGS/gltf-pipeline.git","ssh_url":"git@github.com:CesiumGS/gltf-pipeline.git","clone_url":"https://github.com/CesiumGS/gltf-pipeline.git","svn_url":"https://github.com/CesiumGS/gltf-pipeline","homepage":"","size":26583,"stargazers_count":1730,"watchers_count":1730,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"has_discussions":false,"forks_count":240,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"allow_forking":true,"is_template":false,"web_commit_signoff_required":false,"topics":["3d-converter","gltf"],"visibility":"public","forks":240,"open_issues":91,"watchers":1730,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652"},"html":{"href":"https://github.com/CesiumGS/gltf-pipeline/pull/652"},"issue":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/652"},"comments":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/CesiumGS/gltf-pipeline/statuses/b907f8e9a5e44caf82a32a879a76836be476fc68"}},"author_association":"CONTRIBUTOR","auto_merge":null,"active_lock_reason":null,"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mramato","id":1495196,"node_id":"MDQ6VXNlcjE0OTUxOTY=","avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=4","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":7,"changed_files":4}},"public":true,"created_at":"2024-01-03T16:16:21Z","org":{"id":54716382,"login":"CesiumGS","gravatar_id":"","url":"https://api.github.com/orgs/CesiumGS","avatar_url":"https://avatars.githubusercontent.com/u/54716382?"}},{"id":"34520669317","type":"PullRequestReviewCommentEvent","actor":{"id":1495196,"login":"mramato","display_login":"mramato","gravatar_id":"","url":"https://api.github.com/users/mramato","avatar_url":"https://avatars.githubusercontent.com/u/1495196?"},"repo":{"id":3606738,"name":"CesiumGS/cesium","url":"https://api.github.com/repos/CesiumGS/cesium"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/CesiumGS/cesium/pulls/comments/1439534248","pull_request_review_id":1800562816,"id":1439534248,"node_id":"PRRC_kwDOADcI0s5VzYyo","diff_hunk":"@@ -0,0 +1,169 @@\n+\n+\n+
\n+ \n+ \n+ \n+ \n+\n+ \n+ \n+ \n+ \n+