[{"id":"36345346185","type":"IssuesEvent","actor":{"id":769,"login":"mvanholstyn","display_login":"mvanholstyn","gravatar_id":"","url":"https://api.github.com/users/mvanholstyn","avatar_url":"https://avatars.githubusercontent.com/u/769?"},"repo":{"id":60660245,"name":"Losant/losant-rest-ruby","url":"https://api.github.com/repos/Losant/losant-rest-ruby"},"payload":{"action":"opened","issue":{"url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2","repository_url":"https://api.github.com/repos/Losant/losant-rest-ruby","labels_url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2/comments","events_url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2/events","html_url":"https://github.com/Losant/losant-rest-ruby/issues/2","id":2174332400,"node_id":"I_kwDOA52aFc6Bma3w","number":2,"title":"Update httparty dependency","user":{"login":"mvanholstyn","id":769,"node_id":"MDQ6VXNlcjc2OQ==","avatar_url":"https://avatars.githubusercontent.com/u/769?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanholstyn","html_url":"https://github.com/mvanholstyn","followers_url":"https://api.github.com/users/mvanholstyn/followers","following_url":"https://api.github.com/users/mvanholstyn/following{/other_user}","gists_url":"https://api.github.com/users/mvanholstyn/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanholstyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanholstyn/subscriptions","organizations_url":"https://api.github.com/users/mvanholstyn/orgs","repos_url":"https://api.github.com/users/mvanholstyn/repos","events_url":"https://api.github.com/users/mvanholstyn/events{/privacy}","received_events_url":"https://api.github.com/users/mvanholstyn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2024-03-07T17:02:17Z","updated_at":"2024-03-07T17:02:17Z","closed_at":null,"author_association":"NONE","active_lock_reason":null,"body":"httparty 0.21.0 included a fix for a security vulnerability: https://github.com/jnunemaker/httparty/blob/master/Changelog.md\r\n\r\nCan we get an updated version of this gem that includes the latest httparty so we can get that security fix included?","reactions":{"url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/Losant/losant-rest-ruby/issues/2/timeline","performed_via_github_app":null,"state_reason":null}},"public":true,"created_at":"2024-03-07T17:02:18Z","org":{"id":18402036,"login":"Losant","gravatar_id":"","url":"https://api.github.com/orgs/Losant","avatar_url":"https://avatars.githubusercontent.com/u/18402036?"}},{"id":"35463074615","type":"WatchEvent","actor":{"id":769,"login":"mvanholstyn","display_login":"mvanholstyn","gravatar_id":"","url":"https://api.github.com/users/mvanholstyn","avatar_url":"https://avatars.githubusercontent.com/u/769?"},"repo":{"id":7885934,"name":"xLightsSequencer/xLights","url":"https://api.github.com/repos/xLightsSequencer/xLights"},"payload":{"action":"started"},"public":true,"created_at":"2024-02-07T00:19:39Z","org":{"id":74886498,"login":"xLightsSequencer","gravatar_id":"","url":"https://api.github.com/orgs/xLightsSequencer","avatar_url":"https://avatars.githubusercontent.com/u/74886498?"}},{"id":"34575801037","type":"IssueCommentEvent","actor":{"id":769,"login":"mvanholstyn","display_login":"mvanholstyn","gravatar_id":"","url":"https://api.github.com/users/mvanholstyn","avatar_url":"https://avatars.githubusercontent.com/u/769?"},"repo":{"id":225463,"name":"Shopify/shopify-api-ruby","url":"https://api.github.com/repos/Shopify/shopify-api-ruby"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164","repository_url":"https://api.github.com/repos/Shopify/shopify-api-ruby","labels_url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164/comments","events_url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164/events","html_url":"https://github.com/Shopify/shopify-api-ruby/issues/1164","id":1726392292,"node_id":"I_kwDOAANwt85m5qfk","number":1164,"title":"Updating assets is broken in v13.0.0","user":{"login":"ClaytonPassmore","id":6856391,"node_id":"MDQ6VXNlcjY4NTYzOTE=","avatar_url":"https://avatars.githubusercontent.com/u/6856391?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaytonPassmore","html_url":"https://github.com/ClaytonPassmore","followers_url":"https://api.github.com/users/ClaytonPassmore/followers","following_url":"https://api.github.com/users/ClaytonPassmore/following{/other_user}","gists_url":"https://api.github.com/users/ClaytonPassmore/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaytonPassmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaytonPassmore/subscriptions","organizations_url":"https://api.github.com/users/ClaytonPassmore/orgs","repos_url":"https://api.github.com/users/ClaytonPassmore/repos","events_url":"https://api.github.com/users/ClaytonPassmore/events{/privacy}","received_events_url":"https://api.github.com/users/ClaytonPassmore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nelsonwittwer","id":758143,"node_id":"MDQ6VXNlcjc1ODE0Mw==","avatar_url":"https://avatars.githubusercontent.com/u/758143?v=4","gravatar_id":"","url":"https://api.github.com/users/nelsonwittwer","html_url":"https://github.com/nelsonwittwer","followers_url":"https://api.github.com/users/nelsonwittwer/followers","following_url":"https://api.github.com/users/nelsonwittwer/following{/other_user}","gists_url":"https://api.github.com/users/nelsonwittwer/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonwittwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonwittwer/subscriptions","organizations_url":"https://api.github.com/users/nelsonwittwer/orgs","repos_url":"https://api.github.com/users/nelsonwittwer/repos","events_url":"https://api.github.com/users/nelsonwittwer/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonwittwer/received_events","type":"User","site_admin":false},"assignees":[{"login":"nelsonwittwer","id":758143,"node_id":"MDQ6VXNlcjc1ODE0Mw==","avatar_url":"https://avatars.githubusercontent.com/u/758143?v=4","gravatar_id":"","url":"https://api.github.com/users/nelsonwittwer","html_url":"https://github.com/nelsonwittwer","followers_url":"https://api.github.com/users/nelsonwittwer/followers","following_url":"https://api.github.com/users/nelsonwittwer/following{/other_user}","gists_url":"https://api.github.com/users/nelsonwittwer/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonwittwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonwittwer/subscriptions","organizations_url":"https://api.github.com/users/nelsonwittwer/orgs","repos_url":"https://api.github.com/users/nelsonwittwer/repos","events_url":"https://api.github.com/users/nelsonwittwer/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonwittwer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2023-05-25T19:41:28Z","updated_at":"2024-01-04T15:30:30Z","closed_at":null,"author_association":"CONTRIBUTOR","active_lock_reason":null,"body":"# Issue summary\r\n\r\nIn v12.5.0, you could update the value of an asset by fetching it, setting a new value, and then saving it:\r\n\r\n```ruby\r\nasset = ShopifyAPI::Asset.all(asset: { key: \"layout/theme.liquid\" }, theme_id: theme.id).first\r\nasset.value = asset.value + \"
Something new
\\n\"\r\nasset.save!\r\n```\r\n\r\nIn v13.0.0, updating an asset results in a 406 Not Acceptable error.\r\n\r\nI'm fairly confident this is broken because of the changes made in #1149. We're no longer sending up the required `key` parameter (because it hasn't changed).\r\n\r\nWith access to the asset API being removed in API version 2023-04, I'm not super hopeful that this is actually going to get fixed 🙈 \r\n\r\n- `shopify_api` version: v13.0.0\r\n- Ruby version: 3.2.2\r\n- Operating system: Ubuntu 22.04 LTS\r\n\r\n## Expected behavior\r\n\r\nUpdating an asset should behave similar to the way it did in v12.5.0 (in that it should work 😄). Including the `key` when we save the model would fix the problem.\r\n\r\nv12.5.0 was obviously sending up more attributes than it should have, but it did work. See the screenshot below. Excuse the large code block - I'm replicating how the gem (incorrectly) determined which attributes changed in v12.5.0.\r\n\r\n\r\n\r\n## Actual behavior\r\n\r\nIn v13.0.0, updating an asset results in a 406 Not Acceptable error. Note that I'm using the new private methods introduced in #1149 for determining the changed attributes.\r\n\r\n\r\n\r\n\r\n## Steps to reproduce the problem\r\n\r\n1. Fetch an asset\r\n1. Change the asset's `value`\r\n1. Try to save the asset\r\n","reactions":{"url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164/reactions","total_count":3,"+1":3,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/comments/1877291125","html_url":"https://github.com/Shopify/shopify-api-ruby/issues/1164#issuecomment-1877291125","issue_url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/1164","id":1877291125,"node_id":"IC_kwDOAANwt85v5TB1","user":{"login":"mvanholstyn","id":769,"node_id":"MDQ6VXNlcjc2OQ==","avatar_url":"https://avatars.githubusercontent.com/u/769?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanholstyn","html_url":"https://github.com/mvanholstyn","followers_url":"https://api.github.com/users/mvanholstyn/followers","following_url":"https://api.github.com/users/mvanholstyn/following{/other_user}","gists_url":"https://api.github.com/users/mvanholstyn/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanholstyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanholstyn/subscriptions","organizations_url":"https://api.github.com/users/mvanholstyn/orgs","repos_url":"https://api.github.com/users/mvanholstyn/repos","events_url":"https://api.github.com/users/mvanholstyn/events{/privacy}","received_events_url":"https://api.github.com/users/mvanholstyn/received_events","type":"User","site_admin":false},"created_at":"2024-01-04T15:30:30Z","updated_at":"2024-01-04T15:30:30Z","author_association":"NONE","body":"@luklapp what I found works for me is instead of finding the order, doing this..\r\n\r\n```\r\n@order = ShopifyAPI::Order.new\r\n@order.id = params[:id]\r\n@order.note_attributes = @order.note_attributes + [NEW ATTRIBUTES]\r\n@order.save!\r\n```\r\n\r\nDoing it this way causes it to only update the attributes you set, and the attributes you don't set get left as-is.","reactions":{"url":"https://api.github.com/repos/Shopify/shopify-api-ruby/issues/comments/1877291125/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2024-01-04T15:30:31Z","org":{"id":8085,"login":"Shopify","gravatar_id":"","url":"https://api.github.com/orgs/Shopify","avatar_url":"https://avatars.githubusercontent.com/u/8085?"}}]