[{"id":"9338717301","type":"DeleteEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":35681376,"name":"stlab/stlab","url":"https://api.github.com/repos/stlab/stlab"},"payload":{"ref":"sean-parent/resume-on-executor","ref_type":"branch","full_ref":"refs/heads/sean-parent/resume-on-executor","pusher_type":"user"},"public":true,"created_at":"2026-03-12T20:56:10Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9338716830","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":35681376,"name":"stlab/stlab","url":"https://api.github.com/repos/stlab/stlab"},"payload":{"repository_id":35681376,"push_id":31632269747,"ref":"refs/heads/main","head":"38001f1327540feac38d588fe7133dca7f72c1ea","before":"a0f3f9190a9dfb72203840fd7f5916b5d55426f8"},"public":true,"created_at":"2026-03-12T20:56:09Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7349342042","type":"PullRequestEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":35681376,"name":"stlab/stlab","url":"https://api.github.com/repos/stlab/stlab"},"payload":{"action":"merged","number":592,"pull_request":{"url":"https://api.github.com/repos/stlab/stlab/pulls/592","id":3338390269,"number":592,"head":{"ref":"sean-parent/resume-on-executor","sha":"9ab5b2578fcebc524ea139ed655a8b4c86425c6f","repo":{"id":35681376,"url":"https://api.github.com/repos/stlab/stlab","name":"stlab"}},"base":{"ref":"main","sha":"e126676725fec8fe539258f1888d4e3b064dd7eb","repo":{"id":35681376,"url":"https://api.github.com/repos/stlab/stlab","name":"stlab"}}}},"public":true,"created_at":"2026-03-12T20:56:07Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9291245192","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":989368556,"name":"stlab/pcl-begin","url":"https://api.github.com/repos/stlab/pcl-begin"},"payload":{"repository_id":989368556,"push_id":31584799594,"ref":"refs/heads/main","head":"557705223724f4589acaf46b7620da29b9206c25","before":"ef42ef9b4bcbe439c2578ac2f3ffbc90bde81f92"},"public":true,"created_at":"2026-03-11T19:04:25Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9291200781","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":116436897,"name":"sean-parent/notebook","url":"https://api.github.com/repos/sean-parent/notebook"},"payload":{"repository_id":116436897,"push_id":31584755338,"ref":"refs/heads/master","head":"98330cba62c725f498eb6abb314829e8a4cfc8a8","before":"b75acfc21d7f75d27253beea54a0392b5241efcf"},"public":true,"created_at":"2026-03-11T19:03:04Z"},{"id":"7304980769","type":"PullRequestEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":153516990,"name":"adobe/hyde","url":"https://api.github.com/repos/adobe/hyde"},"payload":{"action":"opened","number":100,"pull_request":{"url":"https://api.github.com/repos/adobe/hyde/pulls/100","id":3385685352,"number":100,"head":{"ref":"sean-parent/docker-update","sha":"3dc3697b153471e3acfc58c7cef689bb1ba1eebf","repo":{"id":153516990,"url":"https://api.github.com/repos/adobe/hyde","name":"hyde"}},"base":{"ref":"master","sha":"3fdcc772e07a0e1f44d3b8c7bee79a0d5b4f687a","repo":{"id":153516990,"url":"https://api.github.com/repos/adobe/hyde","name":"hyde"}}}},"public":true,"created_at":"2026-03-11T18:54:17Z","org":{"id":476009,"login":"adobe","gravatar_id":"","url":"https://api.github.com/orgs/adobe","avatar_url":"https://avatars.githubusercontent.com/u/476009?"}},{"id":"9290661972","type":"CreateEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":153516990,"name":"adobe/hyde","url":"https://api.github.com/repos/adobe/hyde"},"payload":{"ref":"sean-parent/docker-update","ref_type":"branch","full_ref":"refs/heads/sean-parent/docker-update","master_branch":"master","description":"A front-end to Jekyll that parses C++ sources to produce and enforce out-of-line documentation","pusher_type":"user"},"public":true,"created_at":"2026-03-11T18:47:10Z","org":{"id":476009,"login":"adobe","gravatar_id":"","url":"https://api.github.com/orgs/adobe","avatar_url":"https://avatars.githubusercontent.com/u/476009?"}},{"id":"9290492419","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":131344326,"name":"sean-parent/tools","url":"https://api.github.com/repos/sean-parent/tools"},"payload":{"repository_id":131344326,"push_id":31584046834,"ref":"refs/heads/master","head":"131c3532ee689255b9398991ef6a7f38eac8c1cf","before":"be6d4a78404473935dea0d37bbed4509a19a548a"},"public":true,"created_at":"2026-03-11T18:42:15Z"},{"id":"9256809519","type":"CreateEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"ref":"sean-parent/eve-limiter","ref_type":"branch","full_ref":"refs/heads/sean-parent/eve-limiter","master_branch":"main","description":"Adobe Source Libraries","pusher_type":"user"},"public":true,"created_at":"2026-03-11T00:14:18Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9168179960","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"repository_id":6608880,"push_id":31461895302,"ref":"refs/heads/main","head":"4a83677650a259594aff600b08a318cb4786e18e","before":"26b88ed49d6ebf4bae1a100233b60796d0f90ac5"},"public":true,"created_at":"2026-03-08T19:16:02Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7192315040","type":"IssueCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154","repository_url":"https://api.github.com/repos/stlab/adobe_source_libraries","labels_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154/comments","events_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154/events","html_url":"https://github.com/stlab/adobe_source_libraries/pull/154","id":4032964489,"node_id":"PR_kwDOAGTX8M7Ib_bn","number":154,"title":"remove deprecated code and de-boost","user":{"login":"venik","id":54374,"node_id":"MDQ6VXNlcjU0Mzc0","avatar_url":"https://avatars.githubusercontent.com/u/54374?v=4","gravatar_id":"","url":"https://api.github.com/users/venik","html_url":"https://github.com/venik","followers_url":"https://api.github.com/users/venik/followers","following_url":"https://api.github.com/users/venik/following{/other_user}","gists_url":"https://api.github.com/users/venik/gists{/gist_id}","starred_url":"https://api.github.com/users/venik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venik/subscriptions","organizations_url":"https://api.github.com/users/venik/orgs","repos_url":"https://api.github.com/users/venik/repos","events_url":"https://api.github.com/users/venik/events{/privacy}","received_events_url":"https://api.github.com/users/venik/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[],"state":"closed","locked":false,"assignees":[],"milestone":null,"comments":1,"created_at":"2026-03-06T08:34:16Z","updated_at":"2026-03-08T19:16:01Z","closed_at":"2026-03-08T19:16:01Z","assignee":null,"type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/154","html_url":"https://github.com/stlab/adobe_source_libraries/pull/154","diff_url":"https://github.com/stlab/adobe_source_libraries/pull/154.diff","patch_url":"https://github.com/stlab/adobe_source_libraries/pull/154.patch","merged_at":"2026-03-08T19:16:01Z"},"body":"vector.hpp and string_fwd.hpp were deprecated 12 years ago, and cstdint is not very useful. Beside that replace boost::filesystem with std, and other minor de-boost changes","reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/comments/4019815047","html_url":"https://github.com/stlab/adobe_source_libraries/pull/154#issuecomment-4019815047","issue_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/154","id":4019815047,"node_id":"IC_kwDOAGTX8M7vmYKH","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-03-08T19:15:37Z","updated_at":"2026-03-08T19:15:37Z","body":"LGTM","reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/comments/4019815047/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2026-03-08T19:15:37Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7130838131","type":"IssueCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":35681376,"name":"stlab/stlab","url":"https://api.github.com/repos/stlab/stlab"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/stlab/stlab/issues/593","repository_url":"https://api.github.com/repos/stlab/stlab","labels_url":"https://api.github.com/repos/stlab/stlab/issues/593/labels{/name}","comments_url":"https://api.github.com/repos/stlab/stlab/issues/593/comments","events_url":"https://api.github.com/repos/stlab/stlab/issues/593/events","html_url":"https://github.com/stlab/stlab/pull/593","id":4030736141,"node_id":"PR_kwDOAiB0YM7IVFQ9","number":593,"title":"Fix pre_exit ordering so thread pool teardown always runs last","user":{"login":"bmedina","id":41739,"node_id":"MDQ6VXNlcjQxNzM5","avatar_url":"https://avatars.githubusercontent.com/u/41739?v=4","gravatar_id":"","url":"https://api.github.com/users/bmedina","html_url":"https://github.com/bmedina","followers_url":"https://api.github.com/users/bmedina/followers","following_url":"https://api.github.com/users/bmedina/following{/other_user}","gists_url":"https://api.github.com/users/bmedina/gists{/gist_id}","starred_url":"https://api.github.com/users/bmedina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmedina/subscriptions","organizations_url":"https://api.github.com/users/bmedina/orgs","repos_url":"https://api.github.com/users/bmedina/repos","events_url":"https://api.github.com/users/bmedina/events{/privacy}","received_events_url":"https://api.github.com/users/bmedina/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[],"state":"closed","locked":false,"assignees":[],"milestone":null,"comments":1,"created_at":"2026-03-05T21:31:15Z","updated_at":"2026-03-05T23:09:11Z","closed_at":"2026-03-05T23:09:11Z","assignee":null,"type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/stlab/stlab/pulls/593","html_url":"https://github.com/stlab/stlab/pull/593","diff_url":"https://github.com/stlab/stlab/pull/593.diff","patch_url":"https://github.com/stlab/stlab/pull/593.patch","merged_at":null},"body":"## Problem Description\r\n- Client code registered via `at_pre_exit()` before the executor is initialized ends up at a lower index in the pre_exit stack than the thread pool teardown handler. Since `pre_exit()` pops in LIFO order, the teardown runs first, leaving the client handler unable to use the executor. This causes hangs on PORTABLE and WINDOWS backends where teardown destroys the pool. I ran into this issue when refactoring some code to use stlab::serial_queue.\r\n\r\n## Solution\r\nAdd `stlab_at_pre_exit_first`, an internal function that inserts handlers at the front of the stack (index 0) so they are always popped last. The thread pool teardown on all three backends (libdispatch, portable, windows) now uses this function. \r\n\r\n## Automated Tests\r\n- New unit test (`pre_exit_first_test`) verifies that handlers registered via `stlab_at_pre_exit_first` always execute last, regardless of registration order\r\n- New integration test (`pre_exit_order_test`) verifies a client handler registered before executor init can still use the executor during `pre_exit()`\r\n- Full test suite passes (14/14)","reactions":{"url":"https://api.github.com/repos/stlab/stlab/issues/593/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/stlab/stlab/issues/593/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/stlab/stlab/issues/comments/4008157879","html_url":"https://github.com/stlab/stlab/pull/593#issuecomment-4008157879","issue_url":"https://api.github.com/repos/stlab/stlab/issues/593","id":4008157879,"node_id":"IC_kwDOAiB0YM7u56K3","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-03-05T22:14:44Z","updated_at":"2026-03-05T22:14:44Z","body":"The general rule in C++ is that you have to construct in your constructor what you use in the destructor, so the LIFO order works. The issue pre_exit() addresses is that code running in the tasking system operates in an unstructured or partially structured fashion, so there isn't a way to keep a destructor from running after the structured order. It sounds like the client code is trying to use pre_exit() instead of naming the dependency to impose a lifo order. If the dependency is directly on the tasking system, accessing it would solve this (and I'd be open to an optional initialize() API to force initialization without actually enqueueing a task (but a workaround would be `default_executor([]() noexcept {});` ).\r\n\r\nI had considered using a priority queue for pre_exit, and clients could tag their dependencies explicitly, but there really isn't any difference between that and imposing the structured order above.\r\n\r\nIf I'm missing something and the client code can be adapted to this model, let me know why, and we'll seek a solution.","reactions":{"url":"https://api.github.com/repos/stlab/stlab/issues/comments/4008157879/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2026-03-05T22:14:44Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9040518136","type":"DeleteEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"ref":"sean-parent/algorithms","ref_type":"branch","full_ref":"refs/heads/sean-parent/algorithms","pusher_type":"user"},"public":true,"created_at":"2026-03-04T19:36:36Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7086867097","type":"PullRequestEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"action":"merged","number":44,"pull_request":{"url":"https://api.github.com/repos/stlab/better-code/pulls/44","id":3305635356,"number":44,"head":{"ref":"sean-parent/algorithms","sha":"e99e3212b5e344657992a23941ee67bc4c7f6328","repo":{"id":399925664,"url":"https://api.github.com/repos/stlab/better-code","name":"better-code"}},"base":{"ref":"main","sha":"ac444d61957a314f26311234daf330c87c76c938","repo":{"id":399925664,"url":"https://api.github.com/repos/stlab/better-code","name":"better-code"}}}},"public":true,"created_at":"2026-03-04T19:36:23Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9040512227","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"repository_id":399925664,"push_id":31334423633,"ref":"refs/heads/main","head":"c19ab8ced99dcc8a4fc0fb788659987e381c8fb4","before":"ac444d61957a314f26311234daf330c87c76c938"},"public":true,"created_at":"2026-03-04T19:36:25Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9040498044","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"repository_id":399925664,"push_id":31334409607,"ref":"refs/heads/sean-parent/algorithms","head":"e99e3212b5e344657992a23941ee67bc4c7f6328","before":"cd587146803207f7b14c7ea1d47ff8d45dffd913"},"public":true,"created_at":"2026-03-04T19:35:58Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9040337818","type":"DeleteEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"ref":"sean-parent/contracts-cleanup-2","ref_type":"branch","full_ref":"refs/heads/sean-parent/contracts-cleanup-2","pusher_type":"user"},"public":true,"created_at":"2026-03-04T19:30:42Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7086691971","type":"PullRequestEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"action":"merged","number":37,"pull_request":{"url":"https://api.github.com/repos/stlab/better-code/pulls/37","id":3150879640,"number":37,"head":{"ref":"sean-parent/contracts-cleanup-2","sha":"029d3f816ec5e658665cc0c2cb3be933c32e9533","repo":{"id":399925664,"url":"https://api.github.com/repos/stlab/better-code","name":"better-code"}},"base":{"ref":"main","sha":"0d00da7b1cbd1e8bd1873dee57aada2e59d8b454","repo":{"id":399925664,"url":"https://api.github.com/repos/stlab/better-code","name":"better-code"}}}},"public":true,"created_at":"2026-03-04T19:30:35Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9040335017","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"repository_id":399925664,"push_id":31334247098,"ref":"refs/heads/main","head":"ac444d61957a314f26311234daf330c87c76c938","before":"0d00da7b1cbd1e8bd1873dee57aada2e59d8b454"},"public":true,"created_at":"2026-03-04T19:30:36Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9039376473","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":399925664,"name":"stlab/better-code","url":"https://api.github.com/repos/stlab/better-code"},"payload":{"repository_id":399925664,"push_id":31333287941,"ref":"refs/heads/sean-parent/contracts-cleanup-2","head":"029d3f816ec5e658665cc0c2cb3be933c32e9533","before":"a0368e36dc3f6ca5acf3bbd2f59f9367f67f9161"},"public":true,"created_at":"2026-03-04T18:59:57Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7084890426","type":"PullRequestReviewEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"review":{"id":3891202686,"node_id":"PRR_kwDOAGTX8M7n7wp-","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":null,"commit_id":"7df4927339dac0c414bb798dc6e62a778cf8e56f","submitted_at":"2026-03-04T18:28:58Z","state":"commented","html_url":"https://github.com/stlab/adobe_source_libraries/pull/153#pullrequestreview-3891202686","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153","_links":{"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/153#pullrequestreview-3891202686"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153"}},"updated_at":"2026-03-04T18:28:58Z"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153","id":3352397183,"number":153,"head":{"ref":"main","sha":"7df4927339dac0c414bb798dc6e62a778cf8e56f","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"26b88ed49d6ebf4bae1a100233b60796d0f90ac5","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}},"action":"created"},"public":true,"created_at":"2026-03-04T18:29:00Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7084889745","type":"PullRequestReviewCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2885388733","pull_request_review_id":3891202686,"id":2885388733,"node_id":"PRRC_kwDOAGTX8M6r-4m9","diff_hunk":"@@ -231,7 +216,7 @@ template <typename F,\n struct invoker {\n     // add an argument to a Fusion cons-list for each parameter type\n     template <typename Args, typename ArgStream>\n-    static inline typename result_type<F>::type apply(F func, ArgStream& astream,\n+    static inline auto apply(F func, ArgStream& astream,","path":"adobe/arg_stream.hpp","commit_id":"7df4927339dac0c414bb798dc6e62a778cf8e56f","original_commit_id":"7df4927339dac0c414bb798dc6e62a778cf8e56f","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"To match the prior semantics, it should be `decltype(auto)`.","created_at":"2026-03-04T18:28:58Z","updated_at":"2026-03-04T18:28:58Z","html_url":"https://github.com/stlab/adobe_source_libraries/pull/153#discussion_r2885388733","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2885388733"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/153#discussion_r2885388733"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153"}},"reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2885388733/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"in_reply_to_id":2885098059,"original_position":45,"position":45,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/153","id":3352397183,"number":153,"head":{"ref":"main","sha":"7df4927339dac0c414bb798dc6e62a778cf8e56f","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"26b88ed49d6ebf4bae1a100233b60796d0f90ac5","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}}},"public":true,"created_at":"2026-03-04T18:28:58Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"9007605433","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6621399,"name":"sean-parent/sean-parent.github.io","url":"https://api.github.com/repos/sean-parent/sean-parent.github.io"},"payload":{"repository_id":6621399,"push_id":31301575917,"ref":"refs/heads/main","head":"b8e50fa21fbea58f2f8249aec2981bd63c8afdde","before":"07881da0c9f2be9d8d71c425cea4de4c0ea2e02b"},"public":true,"created_at":"2026-03-03T23:44:37Z"},{"id":"9003330805","type":"PushEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"repository_id":6608880,"push_id":31297300763,"ref":"refs/heads/main","head":"26b88ed49d6ebf4bae1a100233b60796d0f90ac5","before":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de"},"public":true,"created_at":"2026-03-03T20:54:58Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7053509836","type":"IssueCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","issue":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152","repository_url":"https://api.github.com/repos/stlab/adobe_source_libraries","labels_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152/comments","events_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152/events","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152","id":4017493087,"node_id":"PR_kwDOAGTX8M7Hpmrx","number":152,"title":"Get rid of nested std::bind, and some boost removal","user":{"login":"venik","id":54374,"node_id":"MDQ6VXNlcjU0Mzc0","avatar_url":"https://avatars.githubusercontent.com/u/54374?v=4","gravatar_id":"","url":"https://api.github.com/users/venik","html_url":"https://github.com/venik","followers_url":"https://api.github.com/users/venik/followers","following_url":"https://api.github.com/users/venik/following{/other_user}","gists_url":"https://api.github.com/users/venik/gists{/gist_id}","starred_url":"https://api.github.com/users/venik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venik/subscriptions","organizations_url":"https://api.github.com/users/venik/orgs","repos_url":"https://api.github.com/users/venik/repos","events_url":"https://api.github.com/users/venik/events{/privacy}","received_events_url":"https://api.github.com/users/venik/received_events","type":"User","user_view_type":"public","site_admin":false},"labels":[],"state":"closed","locked":false,"assignees":[],"milestone":null,"comments":1,"created_at":"2026-03-03T16:07:44Z","updated_at":"2026-03-03T20:54:57Z","closed_at":"2026-03-03T20:54:56Z","assignee":null,"type":null,"active_lock_reason":null,"draft":false,"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152","diff_url":"https://github.com/stlab/adobe_source_libraries/pull/152.diff","patch_url":"https://github.com/stlab/adobe_source_libraries/pull/152.patch","merged_at":"2026-03-03T20:54:56Z"},"body":"std::bind in MSVC can generate deeply nested template instantiations when you chain or nest binds, especially with lambdas or other std::bind calls inside. The complexity can grow exponentially with the number of bound arguments and placeholders, leading to very slow compilation and large binaries.  Also replaced some boost type_traits with std counterparts.\r\n\r\ncan be compiled with c++17\r\n```\r\ncmake -DCMAKE_CXX_STANDARD=17 -B build -S .\r\n...\r\ncmake --build build\r\n...\r\n[100%] Linking CXX executable zuidgen\r\n[100%] Built target zuidgen\r\n```","reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"timeline_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152/timeline","performed_via_github_app":null,"state_reason":null},"comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/comments/3993483239","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#issuecomment-3993483239","issue_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/152","id":3993483239,"node_id":"IC_kwDOAGTX8M7uB7fn","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"created_at":"2026-03-03T20:54:41Z","updated_at":"2026-03-03T20:54:41Z","body":"LGTM","reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/comments/3993483239/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"performed_via_github_app":null}},"public":true,"created_at":"2026-03-03T20:54:41Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7049807435","type":"PullRequestReviewEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"review":{"id":3884261384,"node_id":"PRR_kwDOAGTX8M7nhSAI","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Some issues noted in comments. Generally, I approve of the transformation, but care must be taken to not escape items captured by reference unless the prior implementation was capturing by reference.","commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","submitted_at":"2026-03-03T18:22:40Z","state":"changes_requested","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#pullrequestreview-3884261384","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","_links":{"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/152#pullrequestreview-3884261384"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152"}},"updated_at":"2026-03-03T18:22:40Z"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","id":3349572337,"number":152,"head":{"ref":"velo/no-nested-bind","sha":"0e9af8bee63e6ce2dc4b4b887b5a444a5f01ac64","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}},"action":"created"},"public":true,"created_at":"2026-03-03T18:22:43Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7049807409","type":"PullRequestReviewEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"review":{"id":3884261384,"node_id":"PRR_kwDOAGTX8M7nhSAI","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"Some issues noted in comments. Generally, I approve of the transformation, but care must be taken to not escape items captured by reference unless the prior implementation was capturing by reference.","commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","submitted_at":"2026-03-03T18:22:40Z","state":"changes_requested","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#pullrequestreview-3884261384","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","_links":{"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/152#pullrequestreview-3884261384"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152"}},"updated_at":"2026-03-03T18:22:40Z"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","id":3349572337,"number":152,"head":{"ref":"velo/no-nested-bind","sha":"0e9af8bee63e6ce2dc4b4b887b5a444a5f01ac64","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}},"action":"updated"},"public":true,"created_at":"2026-03-03T18:22:43Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7049709014","type":"PullRequestReviewCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879826942","pull_request_review_id":3884261384,"id":2879826942,"node_id":"PRRC_kwDOAGTX8M6rpqv-","diff_hunk":"@@ -200,17 +200,37 @@ eve_callback_suite_t bind_layout(const bind_layout_proc_t& proc, sheet_t& sheet,\n     eve_callback_suite_t suite;\n \n     suite.add_view_proc_m =\n-        std::bind(proc, _1, _3, std::bind(&evaluate_named_arguments, std::ref(evaluator), _4));\n-    suite.add_cell_proc_m = std::bind(&add_cell, std::ref(sheet), _1, _2, _3, _4);\n-    suite.add_relation_proc_m = std::bind(&add_relation, std::ref(sheet), _1, _2, _3, _4);\n+        [&evaluator, &proc](const eve_callback_suite_t::position_t& parent, const line_position_t& /* parse_location */,","path":"source/eve_evaluate.cpp","commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","original_commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The prior call captured `proc` by value; you have changed it to by reference.","created_at":"2026-03-03T18:19:12Z","updated_at":"2026-03-03T18:22:40Z","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879826942","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879826942"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879826942"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152"}},"reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879826942/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":7,"position":1,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","id":3349572337,"number":152,"head":{"ref":"velo/no-nested-bind","sha":"0e9af8bee63e6ce2dc4b4b887b5a444a5f01ac64","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}}},"public":true,"created_at":"2026-03-03T18:19:12Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7049381299","type":"PullRequestReviewCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879775792","pull_request_review_id":3884261384,"id":2879775792,"node_id":"PRRC_kwDOAGTX8M6rpeQw","diff_hunk":"@@ -81,8 +82,10 @@ std::pair<Iter, Iter> gather(Iter first, Iter last, Iter pivot, Pred pred) {\n     return std::make_pair(\n         std::stable_partition(\n             first, pivot,\n-            std::bind(std::logical_not<bool>(), std::bind(pred, std::placeholders::_1))),\n-        std::stable_partition(pivot, last, std::bind(pred, std::placeholders::_1)));\n+            [&](auto&& v) -> bool { return !pred(std::forward<decltype(v)>(v)); }),\n+        std::stable_partition(pivot, last, [&](auto&& v) -> bool {\n+            return pred(std::forward<decltype(v)>(v));","path":"adobe/algorithm/gather.hpp","commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","original_commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"`pred()` needs to be called with `std::invoke` to match the prior implementation and support. `v` should be passed as `const&`","created_at":"2026-03-03T18:07:18Z","updated_at":"2026-03-03T18:22:40Z","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879775792","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879775792"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879775792"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152"}},"reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879775792/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":16,"position":1,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","id":3349572337,"number":152,"head":{"ref":"velo/no-nested-bind","sha":"0e9af8bee63e6ce2dc4b4b887b5a444a5f01ac64","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}}},"public":true,"created_at":"2026-03-03T18:07:18Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}},{"id":"7049261216","type":"PullRequestReviewCommentEvent","actor":{"id":2279724,"login":"sean-parent","display_login":"sean-parent","gravatar_id":"","url":"https://api.github.com/users/sean-parent","avatar_url":"https://avatars.githubusercontent.com/u/2279724?"},"repo":{"id":6608880,"name":"stlab/adobe_source_libraries","url":"https://api.github.com/repos/stlab/adobe_source_libraries"},"payload":{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879757213","pull_request_review_id":3884261384,"id":2879757213,"node_id":"PRRC_kwDOAGTX8M6rpZud","diff_hunk":"@@ -739,7 +739,7 @@ void sheet_t::implementation_t::add_output(name_t name, const line_position_t& p\n     // REVISIT (sparent) : Non-transactional on failure.\n     cell_set_m.push_back(cell_t(\n         access_output, name,\n-        std::bind(&implementation_t::calculate_expression, std::ref(*this), position, expression),\n+        [&, this]() { return calculate_expression(position, expression); },","path":"source/adam.cpp","commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","original_commit_id":"4545e685d885ff3c47c8a4d75438054fc1cd1fec","user":{"login":"sean-parent","id":2279724,"node_id":"MDQ6VXNlcjIyNzk3MjQ=","avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","user_view_type":"public","site_admin":false},"body":"The expression is escaping. In the original bind position and expression are captured by value - capturing them by reference is dangerous and may be escaping a temporary. I believe this should be `[=, this]`. I also prefer being explicit about the captures so `[_position = position, _expression = expression, this]` would be preferred.","created_at":"2026-03-03T18:03:05Z","updated_at":"2026-03-03T18:22:40Z","html_url":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879757213","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879757213"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/152#discussion_r2879757213"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152"}},"reactions":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/2879757213/reactions","total_count":0,"+1":0,"-1":0,"laugh":0,"hooray":0,"confused":0,"heart":0,"rocket":0,"eyes":0},"original_position":5,"position":1,"subject_type":"line"},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/152","id":3349572337,"number":152,"head":{"ref":"velo/no-nested-bind","sha":"0e9af8bee63e6ce2dc4b4b887b5a444a5f01ac64","repo":{"id":1025842438,"url":"https://api.github.com/repos/venik/adobe_source_libraries","name":"adobe_source_libraries"}},"base":{"ref":"main","sha":"fbb1362c10f29bb56bf6a4ebd5679f38cbdae8de","repo":{"id":6608880,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","name":"adobe_source_libraries"}}}},"public":true,"created_at":"2026-03-03T18:03:05Z","org":{"id":2448845,"login":"stlab","gravatar_id":"","url":"https://api.github.com/orgs/stlab","avatar_url":"https://avatars.githubusercontent.com/u/2448845?"}}]